From: Nick Burch <nick@apache.org>
Date: Wed, 12 Dec 2007 10:30:22 +0000 (+0000)
Subject: Add comments on which formula related things should go in which of the two test suites
X-Git-Tag: REL_3_0_3_BETA1~252
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e4937b63b2afedd7b203f4484ea06fc2b558f254;p=poi.git

Add comments on which formula related things should go in which of the two test suites

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@603538 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java b/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java
index 9f65aabf26..ac3ca2eb29 100644
--- a/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java
+++ b/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java
@@ -23,8 +23,13 @@ package org.apache.poi.hssf.record.formula.eval;
 import junit.framework.TestSuite;
 
 /**
- * @author Amol S. Deshmukh &lt; amolweb at ya hoo dot com &gt;
+ * This is a test of all the Eval functions we have implemented.
+ * Add newly implemented Eval functions in here to have them
+ *  tested.
+ * For newly implemented functions, 
+ *  @see org.apache.poi.hssf.record.formula.functions.TestEverything
  *
+ * @author Amol S. Deshmukh &lt; amolweb at ya hoo dot com &gt;
  */
 public class TestEverything extends TestSuite {
 
@@ -45,12 +50,9 @@ public class TestEverything extends TestSuite {
         suite.addTest(new GenericFormulaTestCase("D71")); // UnaryMinusEval
         suite.addTest(new GenericFormulaTestCase("D75")); // UnaryPlusEval
         
-        suite.addTest(new GenericFormulaTestCase("D249")); // Concatenate
-        suite.addTest(new GenericFormulaTestCase("D741")); // Int
-        suite.addTest(new GenericFormulaTestCase("D1393")); // Trim
-        suite.addTest(new GenericFormulaTestCase("D1421")); // Upper
-        
-        // Add newly implemented formula functions here 
+		// Add newly implemented Eval functions here
+		// (Formula functions go in 
+ 		//  @see org.apache.poi.hssf.record.formula.functions.TestEverything )
         
         return suite;
     }
diff --git a/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java b/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java
index ad93996339..8337810216 100644
--- a/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java
+++ b/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java
@@ -25,11 +25,16 @@ import org.apache.poi.hssf.record.formula.eval.GenericFormulaTestCase;
 import junit.framework.TestSuite;
 
 /**
- * @author Amol S. Deshmukh &lt; amolweb at ya hoo dot com &gt;
+ * This is a test of all the normal formula functions we have implemented.
+ * It should pick up newly implemented functions which are correctly added
+ *  to the test formula excel file, but tweak the rows below if you
+ *  add any past the end of what's currently checked.
+ * For newly implemented eval functions, 
+ *  @see org.apache.poi.hssf.record.formula.eval.TestEverything
  *
+ * @author Amol S. Deshmukh &lt; amolweb at ya hoo dot com &gt;
  */
 public class TestEverything extends TestSuite {
-
     public static TestSuite suite() throws Exception {
         TestSuite suite = new TestSuite("Tests for individual function classes");
         String s;