From: Thomas Müller <thomas.mueller@tmit.eu>
Date: Mon, 23 Sep 2013 20:04:37 +0000 (+0200)
Subject: handle error situation of rename proper
X-Git-Tag: v6.0.0alpha2~126^2~2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e55f25b64df09a3ba6535274eaf738e82910e1f6;p=nextcloud-server.git

handle error situation of rename proper
---

diff --git a/lib/connector/sabre/directory.php b/lib/connector/sabre/directory.php
index 3181a4b310f..9e0fe5e64e7 100644
--- a/lib/connector/sabre/directory.php
+++ b/lib/connector/sabre/directory.php
@@ -88,7 +88,12 @@ class OC_Connector_Sabre_Directory extends OC_Connector_Sabre_Node implements Sa
 			}
 
 			// rename to correct path
-			\OC\Files\Filesystem::rename($partpath, $newPath);
+			$renameOkay = \OC\Files\Filesystem::rename($partpath, $newPath);
+			if (!$renameOkay) {
+				\OC_Log::write('webdav', '\OC\Files\Filesystem::rename() failed', \OC_Log::ERROR);
+				\OC\Files\Filesystem::unlink($partpath);
+				throw new Sabre_DAV_Exception();
+			}
 
 			// allow sync clients to send the mtime along in a header
 			$mtime = OC_Request::hasModificationTime();