From: Go MAEDA <maeda@farend.jp>
Date: Thu, 6 Dec 2018 00:40:39 +0000 (+0000)
Subject: Discourage search engines from indexing old versions of wiki pages (#29503).
X-Git-Tag: 4.0.0~14
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e6e02e5e45e989f56329b920aa277a5c387a6f90;p=redmine.git

Discourage search engines from indexing old versions of wiki pages (#29503).

Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17690 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/views/wiki/show.html.erb b/app/views/wiki/show.html.erb
index 5fffba259..93a358346 100644
--- a/app/views/wiki/show.html.erb
+++ b/app/views/wiki/show.html.erb
@@ -99,4 +99,8 @@
   <%= render :partial => 'sidebar' %>
 <% end %>
 
+<% content_for :header_tags do %>
+  <%= robot_exclusion_tag unless @content.current_version? %>
+<% end %>
+
 <% html_title @page.pretty_title %>
diff --git a/test/functional/wiki_controller_test.rb b/test/functional/wiki_controller_test.rb
index 7f658be0b..bf81cb73e 100644
--- a/test/functional/wiki_controller_test.rb
+++ b/test/functional/wiki_controller_test.rb
@@ -1182,4 +1182,17 @@ class WikiControllerTest < Redmine::ControllerTest
     attachment = Attachment.order('id DESC').first
     assert_equal Wiki.find(1).find_page('CookBook_documentation'), attachment.container
   end
+
+  def test_old_version_should_have_robot_exclusion_tag
+    @request.session[:user_id] = 2
+    # Discourage search engines from indexing old versions
+    get :show, :params => {:project_id => 'ecookbook', :id => 'CookBook_documentation', :version => '2'}
+    assert_response :success
+    assert_select 'head>meta[name="robots"][content=?]', 'noindex,follow,noarchive'
+
+    # No robots meta tag in the current page
+    get :show, :params => {:project_id => 'ecookbook', :id => 'CookBook_documentation'}
+    assert_response :success
+    assert_select 'head>meta[name="robots"]', false
+  end
 end