From: Roeland Jago Douma <roeland@famdouma.nl>
Date: Fri, 22 Mar 2019 15:54:35 +0000 (+0100)
Subject: Check if elements are set in installer
X-Git-Tag: v16.0.0beta2~21^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f021db956c1e0c9da4a9829dce0d27d1ba45ecef;p=nextcloud-server.git

Check if elements are set in installer

Since we now have all the apps from the appstore we need to do a bit
more checking.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
---

diff --git a/lib/private/Installer.php b/lib/private/Installer.php
index dc1110c0496..a410c6a011f 100644
--- a/lib/private/Installer.php
+++ b/lib/private/Installer.php
@@ -391,6 +391,10 @@ class Installer {
 		foreach($this->apps as $app) {
 			if($app['id'] === $appId) {
 				$currentVersion = OC_App::getAppVersion($appId);
+
+				if (!isset($app['releases'][0]['version'])) {
+					return false;
+				}
 				$newestVersion = $app['releases'][0]['version'];
 				if ($currentVersion !== '0' && version_compare($newestVersion, $currentVersion, '>')) {
 					return $newestVersion;