From: Jean-Philippe Lang Date: Sun, 30 Nov 2014 14:31:53 +0000 (+0000) Subject: Drop shoulda. X-Git-Tag: 3.0.0~311 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f04148695a4a2de305945b00433aa1462d5c901c;p=redmine.git Drop shoulda. git-svn-id: http://svn.redmine.org/redmine/trunk@13676 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- diff --git a/Gemfile b/Gemfile index fce09bee5..75d4f70bf 100644 --- a/Gemfile +++ b/Gemfile @@ -86,7 +86,6 @@ end group :test do gem "minitest" - gem "shoulda-context" gem "mocha", "~> 1.0.0", :require => 'mocha/api' # For running UI tests gem "capybara", "~> 2.1.0" diff --git a/test/test_helper.rb b/test/test_helper.rb index c66fd60f5..b374a1422 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -15,7 +15,6 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -#require 'shoulda' ENV["RAILS_ENV"] = "test" require File.expand_path(File.dirname(__FILE__) + "/../config/environment") require 'rails/test_help' @@ -34,9 +33,6 @@ end class ActiveSupport::TestCase include ActionDispatch::TestProcess - include Shoulda::Context::Assertions - include Shoulda::Context::InstanceMethods - extend Shoulda::Context::ClassMethods self.use_transactional_fixtures = true self.use_instantiated_fixtures = false diff --git a/test/unit/mail_handler_test.rb b/test/unit/mail_handler_test.rb index d774eeedd..d18da5fab 100644 --- a/test/unit/mail_handler_test.rb +++ b/test/unit/mail_handler_test.rb @@ -328,7 +328,7 @@ class MailHandlerTest < ActiveSupport::TestCase ) end user = User.order('id DESC').first - assert_same_elements [group1, group2], user.groups + assert_equal [group1, group2].sort, user.groups.sort end def test_created_user_should_not_receive_account_information_with_no_account_info_option diff --git a/test/unit/project_test.rb b/test/unit/project_test.rb index 62ecf5293..4723b4638 100644 --- a/test/unit/project_test.rb +++ b/test/unit/project_test.rb @@ -481,7 +481,8 @@ class ProjectTest < ActiveSupport::TestCase project = Project.generate! parent_version_1 = Version.generate!(:project => project) parent_version_2 = Version.generate!(:project => project) - assert_same_elements [parent_version_1, parent_version_2], project.rolled_up_versions + assert_equal [parent_version_1, parent_version_2].sort, + project.rolled_up_versions.sort end test "#rolled_up_versions should include versions for a subproject" do @@ -491,11 +492,8 @@ class ProjectTest < ActiveSupport::TestCase subproject = Project.generate_with_parent!(project) subproject_version = Version.generate!(:project => subproject) - assert_same_elements [ - parent_version_1, - parent_version_2, - subproject_version - ], project.rolled_up_versions + assert_equal [parent_version_1, parent_version_2, subproject_version].sort, + project.rolled_up_versions.sort end test "#rolled_up_versions should include versions for a sub-subproject" do @@ -507,11 +505,8 @@ class ProjectTest < ActiveSupport::TestCase sub_subproject_version = Version.generate!(:project => sub_subproject) project.reload - assert_same_elements [ - parent_version_1, - parent_version_2, - sub_subproject_version - ], project.rolled_up_versions + assert_equal [parent_version_1, parent_version_2, sub_subproject_version].sort, + project.rolled_up_versions.sort end test "#rolled_up_versions should only check active projects" do @@ -524,7 +519,8 @@ class ProjectTest < ActiveSupport::TestCase project.reload assert !subproject.active? - assert_same_elements [parent_version_1, parent_version_2], project.rolled_up_versions + assert_equal [parent_version_1, parent_version_2].sort, + project.rolled_up_versions.sort end def test_shared_versions_none_sharing