From: Artur Signell <artur@vaadin.com>
Date: Thu, 5 Apr 2012 08:12:13 +0000 (+0300)
Subject: Removed unneeded code (TextField uses border box sizing)
X-Git-Tag: 7.0.0.alpha2~114
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f3306f62fcd09b6fe3969d13f98c45163c1b4d21;p=vaadin-framework.git

Removed unneeded code (TextField uses border box sizing)

Also as % are not converted to px anymore the code is not run for
relative sizes, which in the comment is said to be the reason for the
method.
---

diff --git a/src/com/vaadin/terminal/gwt/client/ui/VTextField.java b/src/com/vaadin/terminal/gwt/client/ui/VTextField.java
index cb7c53f216..5936a96565 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VTextField.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VTextField.java
@@ -60,8 +60,6 @@ public class VTextField extends TextBoxBase implements Field, ChangeHandler,
     private boolean valueBeforeEditIsSynced = true;
 
     protected boolean immediate = false;
-    private int extraHorizontalPixels = -1;
-    private int extraVerticalPixels = -1;
     private int maxLength = -1;
 
     private static final String CLASSNAME_PROMPT = "prompt";
@@ -411,75 +409,6 @@ public class VTextField extends TextBoxBase implements Field, ChangeHandler,
     } catch (e) {}
     }-*/;
 
-    /**
-     * @return space used by components paddings and borders
-     */
-    private int getExtraHorizontalPixels() {
-        if (extraHorizontalPixels < 0) {
-            detectExtraSizes();
-        }
-        return extraHorizontalPixels;
-    }
-
-    /**
-     * @return space used by components paddings and borders
-     */
-    private int getExtraVerticalPixels() {
-        if (extraVerticalPixels < 0) {
-            detectExtraSizes();
-        }
-        return extraVerticalPixels;
-    }
-
-    /**
-     * Detects space used by components paddings and borders. Used when
-     * relational size are used.
-     */
-    private void detectExtraSizes() {
-        Element clone = Util.cloneNode(getElement(), false);
-        DOM.setElementAttribute(clone, "id", "");
-        DOM.setStyleAttribute(clone, "visibility", "hidden");
-        DOM.setStyleAttribute(clone, "position", "absolute");
-        // due FF3 bug set size to 10px and later subtract it from extra pixels
-        DOM.setStyleAttribute(clone, "width", "10px");
-        DOM.setStyleAttribute(clone, "height", "10px");
-        DOM.appendChild(DOM.getParent(getElement()), clone);
-        extraHorizontalPixels = DOM.getElementPropertyInt(clone, "offsetWidth") - 10;
-        extraVerticalPixels = DOM.getElementPropertyInt(clone, "offsetHeight") - 10;
-
-        DOM.removeChild(DOM.getParent(getElement()), clone);
-    }
-
-    @Override
-    public void setHeight(String height) {
-        if (height.endsWith("px")) {
-            int h = Integer.parseInt(height.substring(0, height.length() - 2));
-            h -= getExtraVerticalPixels();
-            if (h < 0) {
-                h = 0;
-            }
-
-            super.setHeight(h + "px");
-        } else {
-            super.setHeight(height);
-        }
-    }
-
-    @Override
-    public void setWidth(String width) {
-        if (width.endsWith("px")) {
-            int w = Integer.parseInt(width.substring(0, width.length() - 2));
-            w -= getExtraHorizontalPixels();
-            if (w < 0) {
-                w = 0;
-            }
-
-            super.setWidth(w + "px");
-        } else {
-            super.setWidth(width);
-        }
-    }
-
     // Here for backward compatibility; to be moved to TextArea
     public void setWordwrap(boolean enabled) {
         if (enabled == wordwrap) {