From: Jörn Zaefferer Date: Sat, 17 Nov 2012 17:04:10 +0000 (+0100) Subject: Dialog: Update focus-tabbable test with a timer workaround to get IE8 to pass. X-Git-Tag: 1.10.0-beta.1~94 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f3525afe0ec8d6599e2c54571b005b4c3d754352;p=jquery-ui.git Dialog: Update focus-tabbable test with a timer workaround to get IE8 to pass. --- diff --git a/tests/unit/dialog/dialog_core.js b/tests/unit/dialog/dialog_core.js index b5566255c..404e81770 100644 --- a/tests/unit/dialog/dialog_core.js +++ b/tests/unit/dialog/dialog_core.js @@ -48,34 +48,36 @@ test( "focus tabbable", function() { }] }; - // 1. first element inside the dialog matching [autofocus] el = $( "

" ).dialog( options ); - equal( document.activeElement, el.find( "input" )[ 1 ] ); + equal( document.activeElement, el.find( "input" )[ 1 ], "1. first element inside the dialog matching [autofocus]" ); el.remove(); - // 2. tabbable element inside the content element - el = $( "

" ).dialog( options ); - equal( document.activeElement, el.find( "input" )[ 0 ] ); - el.remove(); - - // 3. tabbable element inside the buttonpane - el = $( "

text

" ).dialog( options ); - equal( document.activeElement, el.dialog( "widget" ).find( ".ui-dialog-buttonpane button" )[ 0 ] ); - el.remove(); - - // 4. the close button - el = $( "

text

" ).dialog(); - equal( document.activeElement, el.dialog( "widget" ).find( ".ui-dialog-titlebar .ui-dialog-titlebar-close" )[ 0 ] ); - el.remove(); - - // 5. the dialog itself - el = $( "

text

" ).dialog({ - autoOpen: false - }); - el.dialog( "widget" ).find( ".ui-dialog-titlebar-close" ).hide(); - el.dialog( "open" ); - equal( document.activeElement, el.parent()[ 0 ] ); - el.remove(); + // IE8 fails to focus the input, ends up being the activeElement + // so wait for that stupid browser + stop(); + setTimeout(function() { + el = $( "

" ).dialog( options ); + equal( document.activeElement, el.find( "input" )[ 0 ], "2. tabbable element inside the content element" ); + el.remove(); + + el = $( "

text

" ).dialog( options ); + equal( document.activeElement, el.dialog( "widget" ).find( ".ui-dialog-buttonpane button" )[ 0 ], "3. tabbable element inside the buttonpane" ); + el.remove(); + + el = $( "

text

" ).dialog(); + equal( document.activeElement, el.dialog( "widget" ).find( ".ui-dialog-titlebar .ui-dialog-titlebar-close" )[ 0 ], "4. the close button" ); + el.remove(); + + el = $( "

text

" ).dialog({ + autoOpen: false + }); + el.dialog( "widget" ).find( ".ui-dialog-titlebar-close" ).hide(); + el.dialog( "open" ); + equal( document.activeElement, el.parent()[ 0 ], "5. the dialog itself" ); + el.remove(); + + start(); + }, 13); }); })(jQuery);