From: Nick Burch <nick@apache.org>
Date: Wed, 12 Aug 2015 18:38:30 +0000 (+0000)
Subject: Note on arguments
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f3a33fcead4228aa3871a96eecdc686ea1e0cb25;p=poi.git

Note on arguments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695595 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/java/org/apache/poi/ss/formula/functions/IfFunc.java b/src/java/org/apache/poi/ss/formula/functions/IfFunc.java
index 2af174f9df..d410350b7c 100644
--- a/src/java/org/apache/poi/ss/formula/functions/IfFunc.java
+++ b/src/java/org/apache/poi/ss/formula/functions/IfFunc.java
@@ -23,11 +23,18 @@ import org.apache.poi.ss.formula.eval.EvaluationException;
 import org.apache.poi.ss.formula.eval.MissingArgEval;
 import org.apache.poi.ss.formula.eval.OperandResolver;
 import org.apache.poi.ss.formula.eval.ValueEval;
+import org.apache.poi.ss.formula.ptg.Ptg;
+import org.apache.poi.ss.formula.ptg.RefPtg;
 
 /**
  * Implementation for the Excel function IF
- *
- * @author Amol S. Deshmukh &lt; amolweb at ya hoo dot com &gt;
+ * <p>
+ * Note that Excel is a bit picky about the arguments to this function,
+ *  when serialised into {@link Ptg}s in a HSSF file. While most cases are
+ *  pretty chilled about the R vs V state of {@link RefPtg} arguments,
+ *  for IF special care is needed to avoid Excel showing #VALUE.
+ * See bug numbers #55324 and #55747 for the full details on this.
+ * TODO Fix this...
  */
 public final class IfFunc extends Var2or3ArgFunction {