From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Wed, 20 May 2015 21:31:18 +0000 (+0200)
Subject: Remove useless methods from MeasuresDao
X-Git-Tag: 5.2-RC1~1888
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f6c0a0b5308a21fb62c36b2bcc8608e84276d8a1;p=sonarqube.git

Remove useless methods from MeasuresDao
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/startup/RegisterMetrics.java b/server/sonar-server/src/main/java/org/sonar/server/startup/RegisterMetrics.java
index 5c15b01414a..23636e51133 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/startup/RegisterMetrics.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/startup/RegisterMetrics.java
@@ -88,7 +88,7 @@ public class RegisterMetrics {
       @Override
       public boolean apply(Metric metric) {
         // It should be better to use the template mechanism (as it's done in #RegisterDashboards to register provided user manager metrics
-        return !metric.getUserManaged() || measuresDao.getMetric(metric) == null;
+        return !metric.getUserManaged() || measuresDao.getMetric(metric.getKey()) == null;
       }
     }));
   }
diff --git a/server/sonar-server/src/test/java/org/sonar/server/startup/RegisterMetricsTest.java b/server/sonar-server/src/test/java/org/sonar/server/startup/RegisterMetricsTest.java
index 4cb2153786f..af536fab964 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/startup/RegisterMetricsTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/startup/RegisterMetricsTest.java
@@ -125,7 +125,7 @@ public class RegisterMetricsTest extends AbstractDbUnitTestCase {
     loader.start();
 
     assertThat(measuresDao.getMetric("deprecated").getEnabled()).isFalse();
-    assertThat(measuresDao.getMetric(CoreMetrics.COMPLEXITY).getEnabled()).isTrue();
+    assertThat(measuresDao.getMetric(CoreMetrics.COMPLEXITY_KEY).getEnabled()).isTrue();
   }
 
   @Test
diff --git a/sonar-core/src/main/java/org/sonar/jpa/dao/MeasuresDao.java b/sonar-core/src/main/java/org/sonar/jpa/dao/MeasuresDao.java
index 1ed2f16042a..372674b94c4 100644
--- a/sonar-core/src/main/java/org/sonar/jpa/dao/MeasuresDao.java
+++ b/sonar-core/src/main/java/org/sonar/jpa/dao/MeasuresDao.java
@@ -19,17 +19,14 @@
  */
 package org.sonar.jpa.dao;
 
-import org.apache.commons.collections.CollectionUtils;
-import org.apache.commons.collections.Predicate;
-import org.sonar.api.database.DatabaseSession;
-import org.sonar.api.measures.Metric;
-
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-
-import static com.google.common.collect.Lists.newArrayList;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.collections.Predicate;
+import org.sonar.api.database.DatabaseSession;
+import org.sonar.api.measures.Metric;
 
 public class MeasuresDao {
 
@@ -40,18 +37,6 @@ public class MeasuresDao {
     this.session = session;
   }
 
-  public Metric getMetric(Metric metric) {
-    return getMetricsByName().get(metric.getKey());
-  }
-
-  public List<Metric> getMetrics(List<Metric> metrics) {
-    List<Metric> result = newArrayList();
-    for (Metric metric : metrics) {
-      result.add(getMetric(metric));
-    }
-    return result;
-  }
-
   public Metric getMetric(String metricName) {
     return getMetricsByName().get(metricName);
   }
@@ -69,16 +54,6 @@ public class MeasuresDao {
     });
   }
 
-  public Collection<Metric> getUserDefinedMetrics() {
-    return CollectionUtils.select(getMetricsByName().values(), new Predicate() {
-      @Override
-      public boolean evaluate(Object o) {
-        Metric m = (Metric) o;
-        return m.getEnabled() && m.getOrigin() != Metric.Origin.JAV;
-      }
-    });
-  }
-
   public void disableAutomaticMetrics() {
     session.createQuery("update " + Metric.class.getSimpleName() + " m set m.enabled=false where m.userManaged=false").executeUpdate();
     session.commit();
@@ -97,7 +72,7 @@ public class MeasuresDao {
   }
 
   private void persistMetricWithoutClear(Metric metric) {
-    Metric dbMetric = getMetric(metric);
+    Metric dbMetric = getMetric(metric.getKey());
     if (dbMetric != null) {
       dbMetric.merge(metric);
       session.getEntityManager().merge(dbMetric);
@@ -107,19 +82,6 @@ public class MeasuresDao {
     }
   }
 
-  public void persistMetric(Metric metric) {
-    persistMetricWithoutClear(metric);
-    metricsByName.clear();
-  }
-
-  public void disabledMetrics(Collection<Metric> metrics) {
-    for (Metric metric : metrics) {
-      metric.setEnabled(Boolean.FALSE);
-      session.getEntityManager().persist(metric);
-      metricsByName.put(metric.getName(), metric);
-    }
-  }
-
   private Map<String, Metric> getMetricsByName() {
     if (metricsByName.isEmpty()) {
       List<Metric> metrics = session.getResults(Metric.class);
diff --git a/sonar-core/src/test/java/org/sonar/jpa/dao/MeasuresDaoTest.java b/sonar-core/src/test/java/org/sonar/jpa/dao/MeasuresDaoTest.java
index d525fe3c7c6..bab9bcd488d 100644
--- a/sonar-core/src/test/java/org/sonar/jpa/dao/MeasuresDaoTest.java
+++ b/sonar-core/src/test/java/org/sonar/jpa/dao/MeasuresDaoTest.java
@@ -45,19 +45,6 @@ public class MeasuresDaoTest extends AbstractDbUnitTestCase {
     getSession().save(project);
   }
 
-  @Test
-  public void shouldReturnUserDefinedMetrics() {
-    for (Metric metric : createMetrics()) {
-      getSession().save(metric);
-    }
-
-    Collection<Metric> metrics = service.getUserDefinedMetrics();
-    assertThat(metrics.size(), is(2));
-    for (Metric metric : metrics) {
-      assertThat(metric.getOrigin(), not(Metric.Origin.JAV));
-    }
-  }
-
   @Test
   public void shouldRegisterMetrics() {
     Collection<Metric> newMetrics = createMetrics();
@@ -67,20 +54,6 @@ public class MeasuresDaoTest extends AbstractDbUnitTestCase {
     assertThat(metrics.size(), is(newMetrics.size()));
   }
 
-  @Test
-  public void shouldDisabledMetrics() {
-    Collection<Metric> newMetrics = createMetrics();
-
-    service.disabledMetrics(newMetrics);
-
-    Collection<Metric> allMetrics = service.getMetrics();
-    assertThat(allMetrics.size(), is(newMetrics.size()));
-
-    Collection<Metric> disabledMetrics = service.getEnabledMetrics();
-    assertThat(disabledMetrics.size(), is(0));
-  }
-
-
   private Collection<Metric> createMetrics() {
     Metric m1 = new Metric("metric1");
     m1.setEnabled(false);