From: Pierre Ossman <ossman@cendio.se>
Date: Mon, 8 Oct 2018 14:03:43 +0000 (+0200)
Subject: Remove comments about self-deleting connections
X-Git-Tag: v1.9.90~66^2~4
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=f858682c36cbae39f056a51c0e025826a77e9cbc;p=tigervnc.git

Remove comments about self-deleting connections

It isn't true so remove those comments.
---

diff --git a/common/rfb/VNCSConnectionST.h b/common/rfb/VNCSConnectionST.h
index 4fe92b00..76e78a9b 100644
--- a/common/rfb/VNCSConnectionST.h
+++ b/common/rfb/VNCSConnectionST.h
@@ -51,10 +51,6 @@ namespace rfb {
     // Methods called from VNCServerST.  None of these methods ever knowingly
     // throw an exception.
 
-    // Unless otherwise stated, the SConnectionST may not be valid after any of
-    // these methods are called, since they catch exceptions and may have
-    // called close() which deletes the object.
-
     // init() must be called to initialise the protocol.  If it fails it
     // returns false, and close() will have been called.
     bool init();
@@ -86,8 +82,7 @@ namespace rfb {
     // zero is returned.  Zero is also returned if there is no idle timeout.
     int checkIdleTimeout();
 
-    // The following methods never throw exceptions nor do they ever delete the
-    // SConnectionST object.
+    // The following methods never throw exceptions
 
     // getComparerState() returns if this client would like the framebuffer
     // comparer to be enabled.
@@ -115,9 +110,7 @@ namespace rfb {
   private:
     // SConnection callbacks
 
-    // These methods are invoked as callbacks from processMsg().  Note that
-    // none of these methods should call any of the above methods which may
-    // delete the SConnectionST object.
+    // These methods are invoked as callbacks from processMsg()
 
     virtual void authSuccess();
     virtual void queryConnection(const char* userName);