From: David Gageot <david@gageot.net>
Date: Tue, 6 Nov 2012 12:01:00 +0000 (+0100)
Subject: SONAR-3885 Don't exclude files anymore in cobertura's
X-Git-Tag: 3.4~392
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=fb40abf3d287a85738eeceeff7d4d6c4b5b138bb;p=sonarqube.git

SONAR-3885 Don't exclude files anymore in cobertura's
---

diff --git a/plugins/sonar-cobertura-plugin/src/main/java/org/sonar/plugins/cobertura/CoberturaMavenPluginHandler.java b/plugins/sonar-cobertura-plugin/src/main/java/org/sonar/plugins/cobertura/CoberturaMavenPluginHandler.java
index 90628197be7..20a2aa9fcd0 100644
--- a/plugins/sonar-cobertura-plugin/src/main/java/org/sonar/plugins/cobertura/CoberturaMavenPluginHandler.java
+++ b/plugins/sonar-cobertura-plugin/src/main/java/org/sonar/plugins/cobertura/CoberturaMavenPluginHandler.java
@@ -19,7 +19,6 @@
  */
 package org.sonar.plugins.cobertura;
 
-import org.apache.commons.lang.StringUtils;
 import org.sonar.api.batch.maven.MavenPlugin;
 import org.sonar.api.batch.maven.MavenPluginHandler;
 import org.sonar.api.batch.maven.MavenSurefireUtils;
@@ -28,7 +27,7 @@ import org.sonar.plugins.cobertura.api.CoberturaUtils;
 
 public class CoberturaMavenPluginHandler implements MavenPluginHandler {
 
-  private CoberturaSettings settings;
+  private final CoberturaSettings settings;
 
   public CoberturaMavenPluginHandler(CoberturaSettings settings) {
     this.settings = settings;
@@ -51,25 +50,16 @@ public class CoberturaMavenPluginHandler implements MavenPluginHandler {
   }
 
   public String[] getGoals() {
-    return new String[] { "cobertura" };
+    return new String[] {"cobertura"};
   }
 
   public void configure(Project project, MavenPlugin coberturaPlugin) {
-    configureCobertura(project, coberturaPlugin);
+    configureCobertura(coberturaPlugin);
     MavenSurefireUtils.configure(project);
   }
 
-  private void configureCobertura(Project project, MavenPlugin coberturaPlugin) {
+  private void configureCobertura(MavenPlugin coberturaPlugin) {
     coberturaPlugin.setParameter("formats/format", "xml");
-    for (String pattern : project.getExclusionPatterns()) {
-      if (pattern.endsWith(".java")) {
-        pattern = StringUtils.substringBeforeLast(pattern, ".") + ".class";
-
-      } else if (StringUtils.substringAfterLast(pattern, "/").indexOf(".") < 0) {
-        pattern = pattern + ".class";
-      }
-      coberturaPlugin.addParameter("instrumentation/excludes/exclude", pattern);
-    }
     coberturaPlugin.setParameter("maxmem", settings.getMaxMemory());
   }
 }
diff --git a/plugins/sonar-cobertura-plugin/src/test/java/org/sonar/plugins/cobertura/CoberturaMavenPluginHandlerTest.java b/plugins/sonar-cobertura-plugin/src/test/java/org/sonar/plugins/cobertura/CoberturaMavenPluginHandlerTest.java
index 756fc211bda..037bb749193 100644
--- a/plugins/sonar-cobertura-plugin/src/test/java/org/sonar/plugins/cobertura/CoberturaMavenPluginHandlerTest.java
+++ b/plugins/sonar-cobertura-plugin/src/test/java/org/sonar/plugins/cobertura/CoberturaMavenPluginHandlerTest.java
@@ -61,7 +61,6 @@ public class CoberturaMavenPluginHandlerTest {
   public void should_enable_xml_format() {
     Project project = mock(Project.class);
     when(project.getPom()).thenReturn(new MavenProject());
-    when(project.getExclusionPatterns()).thenReturn(new String[0]);
 
     MavenPlugin coberturaPlugin = new MavenPlugin(CoberturaUtils.COBERTURA_GROUP_ID, CoberturaUtils.COBERTURA_ARTIFACT_ID, null);
     handler.configure(project, coberturaPlugin);
@@ -69,20 +68,6 @@ public class CoberturaMavenPluginHandlerTest {
     assertThat(coberturaPlugin.getParameter("formats/format")).isEqualTo("xml");
   }
 
-  @Test
-  public void should_set_cobertura_exclusions() {
-    Project project = mock(Project.class);
-    when(project.getPom()).thenReturn(new MavenProject());
-    when(project.getExclusionPatterns()).thenReturn(new String[]{"**/Foo.java", "com/*Test.*", "com/*"});
-
-    MavenPlugin coberturaPlugin = new MavenPlugin(CoberturaUtils.COBERTURA_GROUP_ID, CoberturaUtils.COBERTURA_ARTIFACT_ID, null);
-    handler.configure(project, coberturaPlugin);
-
-    assertThat(coberturaPlugin.getParameters("instrumentation/excludes/exclude")).isEqualTo(new String[]{
-      "**/Foo.class", "com/*Test.*", "com/*.class"
-    });
-  }
-
   @Test
   public void should_set_max_memory() {
     when(settings.getMaxMemory()).thenReturn("128m");