From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Wed, 10 Jun 2015 11:41:25 +0000 (+0200)
Subject: Refactor the SQL request to select notif properties
X-Git-Tag: 5.2-RC1~1552
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=fb4a58afd8f1857ce4fd115c2ee31f653f7897d1;p=sonarqube.git

Refactor the SQL request to select notif properties

It should restore the compatibility with all supported dbs.
---

diff --git a/sonar-core/src/main/resources/org/sonar/core/properties/PropertiesMapper.xml b/sonar-core/src/main/resources/org/sonar/core/properties/PropertiesMapper.xml
index 1a15db272d4..18297848cd6 100644
--- a/sonar-core/src/main/resources/org/sonar/core/properties/PropertiesMapper.xml
+++ b/sonar-core/src/main/resources/org/sonar/core/properties/PropertiesMapper.xml
@@ -4,16 +4,16 @@
 <mapper namespace="org.sonar.core.properties.PropertiesMapper">
 
   <select id="findUsersForNotification" parameterType="map" resultType="String">
-    SELECT U.login
-    FROM properties P, users U
+    select u.login
+    from users u
+    inner join properties p on p.user_id=u.id
     <if test="projectUuid == null">
-      WHERE P.user_id = U.id AND P.prop_key = #{notifKey} AND P.text_value LIKE 'true'
-      AND P.resource_id is null
+      where p.prop_key = #{notifKey} and p.text_value LIKE 'true' and p.resource_id is null
     </if>
     <if test="projectUuid != null">
-      inner join projects c on c.id=P.resource_id
-      WHERE P.user_id = U.id AND P.prop_key = #{notifKey} AND P.text_value LIKE 'true'
-      AND c.uuid = #{projectUuid}
+      inner join projects c on c.id=p.resource_id
+      where p.prop_key = #{notifKey} AND p.text_value LIKE 'true'
+      and c.uuid = #{projectUuid} and p.resource_id is not null
     </if>
   </select>