From: Scott González <scott.gonzalez@gmail.com>
Date: Mon, 23 Mar 2015 22:37:47 +0000 (-0400)
Subject: Dialog: Properly handle empty title with jQuery git
X-Git-Tag: 1.12.0-beta.1~351
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=fdbb85be397b1d1e632ead53a53c57d30739e70c;p=jquery-ui.git

Dialog: Properly handle empty title with jQuery git

jQuery now returns `null` for empty attributes instead of `undefined`.

Ref gh-1516
---

diff --git a/ui/dialog.js b/ui/dialog.js
index 2f322aa86..c7ffbd9ef 100644
--- a/ui/dialog.js
+++ b/ui/dialog.js
@@ -118,7 +118,9 @@ $.widget( "ui.dialog", {
 			index: this.element.parent().children().index( this.element )
 		};
 		this.originalTitle = this.element.attr( "title" );
-		this.options.title = this.options.title || this.originalTitle;
+		if ( this.options.title == null && this.originalTitle != null ) {
+			this.options.title = this.originalTitle;
+		}
 
 		this._createWrapper();
 
@@ -433,10 +435,11 @@ $.widget( "ui.dialog", {
 	},
 
 	_title: function( title ) {
-		if ( !this.options.title ) {
+		if ( this.options.title ) {
+			title.text( this.options.title );
+		} else {
 			title.html( "&#160;" );
 		}
-		title.text( this.options.title );
 	},
 
 	_createButtonPane: function() {