From: Alexander Kriegisch Date: Fri, 9 Apr 2021 06:55:33 +0000 (+0700) Subject: Replace JDT Core system dependency by deployed one X-Git-Tag: V1_9_7_M2~21^2~38 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=fe91fe26245d1f20b9ee1b4bb163969a89993a3f;p=aspectj.git Replace JDT Core system dependency by deployed one Get rid of system paths. Instead, rely on JDT Core Shadows to deploy both binary and source JARs to GitHub Packages. The former module directory was deleted completely. Instead, the JARs are redundantly copied into 'libs/jdtcore-aj' in order to be found there by tests and other Ant scripts. Signed-off-by: Alexander Kriegisch --- diff --git a/ajde.core/pom.xml b/ajde.core/pom.xml index d15533915..8ed061954 100644 --- a/ajde.core/pom.xml +++ b/ajde.core/pom.xml @@ -34,22 +34,9 @@ org.aspectj.ajdt.core ${project.version} - - - - - org.aspectj - org.eclipse.jdt.core - 1.0 - system - ${project.basedir}/../org.eclipse.jdt.core/jdtcore-for-aspectj.jar - - diff --git a/ajde/pom.xml b/ajde/pom.xml index 3a42b7e80..42c9e10c4 100644 --- a/ajde/pom.xml +++ b/ajde/pom.xml @@ -41,22 +41,10 @@ test-jar test - - org.aspectj org.eclipse.jdt.core - 1.0 - system - ${project.basedir}/../org.eclipse.jdt.core/jdtcore-for-aspectj.jar - - org.aspectj ajde.core diff --git a/ajdoc/pom.xml b/ajdoc/pom.xml index 780dcb8e3..3b1b64f5d 100644 --- a/ajdoc/pom.xml +++ b/ajdoc/pom.xml @@ -52,9 +52,6 @@ org.aspectj org.eclipse.jdt.core - 1.0 - system - ${project.basedir}/../org.eclipse.jdt.core/jdtcore-for-aspectj.jar org.aspectj diff --git a/aspectjtools/pom.xml b/aspectjtools/pom.xml index c566c3f73..9073483a0 100644 --- a/aspectjtools/pom.xml +++ b/aspectjtools/pom.xml @@ -66,7 +66,7 @@ @@ -82,7 +82,7 @@ diff --git a/build/build.xml b/build/build.xml index 013f32610..68405e117 100644 --- a/build/build.xml +++ b/build/build.xml @@ -20,7 +20,7 @@ - + @@ -38,11 +38,11 @@ - + - + - + @@ -66,7 +66,7 @@ version="${build.version}" versionSourceFile="${aspectj.modules.dir}/bridge/src/org/aspectj/bridge/Version.java" versionTagFile="${aj.temp.dir}/versionUptodate"/> - + @@ -87,21 +87,21 @@ - + - + - + - + @@ -117,40 +117,40 @@ - + - + - - + - - + + + failonerror="true"/> @@ -159,11 +159,11 @@ distDir="${aj.dist.dir}" jarDir="${aj.jar.dir}" trimTesting="${trim.testing}" - buildConfig="${build.config}" + buildConfig="${build.config}" version="${build.version.long}" verbose="${build.verbose}" assembleall="${assemble}" - failonerror="true"/> + failonerror="true"/> @@ -189,7 +189,7 @@ - + @@ -197,11 +197,11 @@ - + - + - + @@ -226,16 +226,16 @@ - - + - - @@ -243,7 +243,7 @@ - @@ -294,7 +294,7 @@ - + @@ -309,9 +309,9 @@ - - @@ -327,24 +327,24 @@ else=""> - - - + - @@ -353,13 +353,13 @@ - + - + @@ -369,7 +369,7 @@ - + @@ -379,7 +379,7 @@ -To use testing client jar in tests, +To use testing client jar in tests, mv ../aj-build/jars/testing-client-all.jar ../lib/tests/testing-client.jar @@ -391,23 +391,23 @@ To use testing client jar in tests, - + - + - + - + @@ -423,12 +423,12 @@ To use testing client jar in tests, - + - + @@ -451,7 +451,7 @@ To use testing client jar in tests, /> - + @@ -497,12 +497,12 @@ To use testing client jar in tests, + description="create the Eclipse distribution plugins"> - + - + @@ -564,9 +564,9 @@ To use testing client jar in tests, - + - + @@ -644,7 +644,7 @@ To use testing client jar in tests, - + @@ -721,28 +721,28 @@ To use testing client jar in tests, --> - + - - + + - - - - - + + + + + - + - + @@ -752,45 +752,45 @@ To use testing client jar in tests, - + - - + + - + - + - - + + - + - + - - - - + + + + @@ -857,7 +857,7 @@ ant -propertyfile XXX publishtomaven - + @@ -889,7 +889,7 @@ ant -propertyfile XXX publishtomaven - + @@ -938,13 +938,13 @@ ant -propertyfile XXX publishtomaven - + - @@ -957,15 +957,15 @@ ant -propertyfile XXX publishtomaven - - + + - + - @@ -979,10 +979,10 @@ ant -propertyfile XXX publishtomaven - - + + - + diff --git a/build/scripts/compileTest.sh b/build/scripts/compileTest.sh index 42d9281da..f6a5b3a17 100644 --- a/build/scripts/compileTest.sh +++ b/build/scripts/compileTest.sh @@ -22,7 +22,7 @@ ajdir=`echo "$ajdir" | sed 's|/cygdrive/\([a-zA-Z]\)/|\1:/|'` allfiles="$ajdir/allfiles.lst" onefile="$ajdir/onefile.lst" srcdirs="ajbrowser ajde asm bridge org.aspectj.ajdt.core runtime taskdefs util weaver" -libs="lib/ant/lib/ant.jar lib/bcel/bcel.jar org.eclipse.jdt.core/jdtcore-for-aspectj.jar" +libs="lib/ant/lib/ant.jar lib/bcel/bcel.jar libx/jdtcore-aj/jdtcore-for-aspectj.jar" classesDir="$ajdir/classes" ajc110=$aj110/bin/ajc @@ -63,9 +63,9 @@ for compiler in "$jdk14"/bin/javac "$jdk13"/bin/javac "$ajc110" "$ajc111" "$jike cp="$aj110/lib/aspectjrt.jar$classpath" fi echo "##################################### $compiler $cp" - start=`date +%s` + start=`date +%s` $compiler \ - -d "$classesDir" -classpath "$cp" @"$argfile" + -d "$classesDir" -classpath "$cp" @"$argfile" end=`date +%s` duration=`expr $end - $start` echo "$duration ($start - $end) # $compiler" diff --git a/build/scripts/jikesInc.sh b/build/scripts/jikesInc.sh index db3ef00a2..209aeadfc 100644 --- a/build/scripts/jikesInc.sh +++ b/build/scripts/jikesInc.sh @@ -14,7 +14,7 @@ ajdir=`cd "$ajdir"; pwd` ajdir=`echo "$ajdir" | sed 's|/cygdrive/\([a-zA-Z]\)/|\1:/|'` allfiles="$ajdir/allfiles.lst" srcdirs="ajbrowser ajde asm bridge org.aspectj.ajdt.core runtime taskdefs util weaver" -libs="lib/ant/lib/ant.jar lib/bcel/bcel.jar org.eclipse.jdt.core/jdtcore-for-aspectj.jar" +libs="lib/ant/lib/ant.jar lib/bcel/bcel.jar libx/jdtcore-aj/jdtcore-for-aspectj.jar" classesDir="$ajdir/classes" diff --git a/build/scripts/makeAspectjtoolsLstFile.sh b/build/scripts/makeAspectjtoolsLstFile.sh index 50a705db0..9ed7d8ad3 100644 --- a/build/scripts/makeAspectjtoolsLstFile.sh +++ b/build/scripts/makeAspectjtoolsLstFile.sh @@ -1,180 +1,180 @@ -#!/bin/bash -# generate .lst file for aspectjtools.jar -# by compile all non-testing src dirs -# todo: copy ajbrowser manifest -[ -n "$DEBUG" ] && set -vx - -usage() { - name=`basename "$0"` - cat< aspectjtools-sources.lst; - # head aspectjtools-sources.lst -} - -genResourceJar() { # slow, but hey - [ -n "$DEBUG" ] && set -vx - jarFile=`canonicalPath "$1"` - [ -n "$jarFile" ] || exit 43 - - "${JAVA_HOME:-c:/home/apps/jdk14}/bin/"jar \ - cfM "$jarFile" build.xml - - curDir=`pwd`; - for i in `listSourceDirs` ; do - cd "$i" - "${JAVA_HOME:-c:/home/apps/jdk14}/bin/"jar \ - ufM "$jarFile" `find . -type f | sed '/CVS/d;/\.java/d'` - cd "$curDir" - done - cd "$curDir" - -# mf=`canonicalPath "grj_manifest.txt"` -# sed 's|@build.version.short@|1.1.1|;s|@company.name@|na|' \ -# ../ajbrowser/ajbrowser.mf.txt > "$mf" -# "${JAVA_HOME:-c:/home/apps/jdk14}/bin/"jar \ -# ufm "$jarFile" "$mf" build.xml -# rm "$mf" -} - -addManifest() { - outjar="$1" - mf=`canonicalPath "grj_manifest.txt"` - sed 's|@build.version.short@|1.1.1|;s|@company.name@|na|' \ - ../ajbrowser/ajbrowser.mf.txt > "$mf" - echo "nothing" > am_nothing - "${JAVA_HOME:-c:/home/apps/jdk14}/bin/"jar \ - ufm "$outjar" "$mf" am_nothing - rm "$mf" am_nothing -} - -getClasspath() { - [ -n "$DEBUG" ] && set -vx - ajrt=`canonicalPath "${ASPECTJ_HOME:-c:/home/apps/aspectj-1.1.1}/lib/aspectjrt.jar"` - echo "${ajrt};`cygpath -ma ../lib/ant/lib/ant.jar`" -} - -getInjars() { - [ -n "$DEBUG" ] && set -vx - cp="" - sep="" - for i in "$1" ../lib/bcel/bcel.jar \ - ../org.eclipse.jdt.core/jdtcore-for-aspectj.jar \ - ; do - cp="${cp}${sep}`canonicalPath "$i"`" - [ -z "${sep}" ] && sep=";" - done - echo "$cp" -} - -setupManifest() { - [ -n "$DEBUG" ] && set -vx - midir="../ajbrowser/src/META-INF" - [ -d "$midir" ] || mkdir ../ajbrowser/src/META-INF - sed 's|@build.version.short@|1.1.1|;s|@company.name@|na|' \ - ../ajbrowser/ajbrowser.mf.txt > "$1" -} - -generateFile() { - resourceJar="$1" - outputJar="$2" - [ -n "$DEBUG" ] && set -vx - [ -f "$resourceJar" ] || exit 98 - [ -n "$outputJar" ] || exit 98 - rm -f "$outputJar" - PS=";" - #sourceroots=`getSourceroots` - classpath=`getClasspath` - injars=`getInjars "$resourceJar"` - cat< aspectjtools.lst - ls -ald "$resourceJar" aspectjtools.lst -fi +#!/bin/bash +# generate .lst file for aspectjtools.jar +# by compile all non-testing src dirs +# todo: copy ajbrowser manifest +[ -n "$DEBUG" ] && set -vx + +usage() { + name=`basename "$0"` + cat< aspectjtools-sources.lst; + # head aspectjtools-sources.lst +} + +genResourceJar() { # slow, but hey + [ -n "$DEBUG" ] && set -vx + jarFile=`canonicalPath "$1"` + [ -n "$jarFile" ] || exit 43 + + "${JAVA_HOME:-c:/home/apps/jdk14}/bin/"jar \ + cfM "$jarFile" build.xml + + curDir=`pwd`; + for i in `listSourceDirs` ; do + cd "$i" + "${JAVA_HOME:-c:/home/apps/jdk14}/bin/"jar \ + ufM "$jarFile" `find . -type f | sed '/CVS/d;/\.java/d'` + cd "$curDir" + done + cd "$curDir" + +# mf=`canonicalPath "grj_manifest.txt"` +# sed 's|@build.version.short@|1.1.1|;s|@company.name@|na|' \ +# ../ajbrowser/ajbrowser.mf.txt > "$mf" +# "${JAVA_HOME:-c:/home/apps/jdk14}/bin/"jar \ +# ufm "$jarFile" "$mf" build.xml +# rm "$mf" +} + +addManifest() { + outjar="$1" + mf=`canonicalPath "grj_manifest.txt"` + sed 's|@build.version.short@|1.1.1|;s|@company.name@|na|' \ + ../ajbrowser/ajbrowser.mf.txt > "$mf" + echo "nothing" > am_nothing + "${JAVA_HOME:-c:/home/apps/jdk14}/bin/"jar \ + ufm "$outjar" "$mf" am_nothing + rm "$mf" am_nothing +} + +getClasspath() { + [ -n "$DEBUG" ] && set -vx + ajrt=`canonicalPath "${ASPECTJ_HOME:-c:/home/apps/aspectj-1.1.1}/lib/aspectjrt.jar"` + echo "${ajrt};`cygpath -ma ../lib/ant/lib/ant.jar`" +} + +getInjars() { + [ -n "$DEBUG" ] && set -vx + cp="" + sep="" + for i in "$1" ../lib/bcel/bcel.jar \ + ../libx/jdtcore-aj/jdtcore-for-aspectj.jar \ + ; do + cp="${cp}${sep}`canonicalPath "$i"`" + [ -z "${sep}" ] && sep=";" + done + echo "$cp" +} + +setupManifest() { + [ -n "$DEBUG" ] && set -vx + midir="../ajbrowser/src/META-INF" + [ -d "$midir" ] || mkdir ../ajbrowser/src/META-INF + sed 's|@build.version.short@|1.1.1|;s|@company.name@|na|' \ + ../ajbrowser/ajbrowser.mf.txt > "$1" +} + +generateFile() { + resourceJar="$1" + outputJar="$2" + [ -n "$DEBUG" ] && set -vx + [ -f "$resourceJar" ] || exit 98 + [ -n "$outputJar" ] || exit 98 + rm -f "$outputJar" + PS=";" + #sourceroots=`getSourceroots` + classpath=`getClasspath` + injars=`getInjars "$resourceJar"` + cat< aspectjtools.lst + ls -ald "$resourceJar" aspectjtools.lst +fi diff --git a/libx/pom.xml b/libx/pom.xml index 1dd0e8239..c30de98e0 100644 --- a/libx/pom.xml +++ b/libx/pom.xml @@ -153,6 +153,28 @@ + + + org.aspectj + org.eclipse.jdt.core + ${jdt.core.version} + jar + false + jdtcore-aj + jdtcore-for-aspectj.jar + + + + org.aspectj + org.eclipse.jdt.core + ${jdt.core.version} + java-source + sources + false + jdtcore-aj + jdtcore-for-aspectj-src.zip + + org.aspectj loadtime diff --git a/org.eclipse.jdt.core/README.html b/org.eclipse.jdt.core/README.html deleted file mode 100644 index b47a42e65..000000000 --- a/org.eclipse.jdt.core/README.html +++ /dev/null @@ -1,16 +0,0 @@ - - - - The Eclipse JDT compiler - - - -

The Eclipse JDT Compiler

- -

This module exports jdtcore.jar to anyone who depends on it. That .jar - contains a lightly modified version of the eclipse JDT compiler and all of its - dependencies. The .jar is built from shadows/org.eclipse.jdt.core. See - shadows/README.html for more information. -

- - diff --git a/org.eclipse.jdt.core/jdtcore-for-aspectj-src.zip b/org.eclipse.jdt.core/jdtcore-for-aspectj-src.zip deleted file mode 100644 index 37f003c8d..000000000 Binary files a/org.eclipse.jdt.core/jdtcore-for-aspectj-src.zip and /dev/null differ diff --git a/org.eclipse.jdt.core/jdtcore-for-aspectj.jar b/org.eclipse.jdt.core/jdtcore-for-aspectj.jar deleted file mode 100644 index 4275229c0..000000000 Binary files a/org.eclipse.jdt.core/jdtcore-for-aspectj.jar and /dev/null differ diff --git a/org.eclipse.jdt.core/pom.xml b/org.eclipse.jdt.core/pom.xml deleted file mode 100644 index 08f8196fa..000000000 --- a/org.eclipse.jdt.core/pom.xml +++ /dev/null @@ -1,63 +0,0 @@ - - 4.0.0 - - - org.aspectj - aspectj-parent - 1.9.7.BUILD-SNAPSHOT - - - org.eclipse.jdt.core - jar - org.eclipse.jdt.core - - - - - org.apache.maven.plugins - maven-install-plugin - - - default-install - none - - - org.aspectj:org.eclipse.jdt.core - install - - install-file - - - org.aspectj - org.eclipse.jdt.core - 1.9.7.BUILD-SNAPSHOT - jar - ${basedir}/jdtcore-for-aspectj.jar - true - true - - - - org.aspectj:org.eclipse.jdt.core:sources - install - - install-file - - - org.aspectj - org.eclipse.jdt.core - 1.9.7.BUILD-SNAPSHOT - jar - ${basedir}/jdtcore-for-aspectj-src.zip - true - sources - true - - - - - - - - diff --git a/pom.xml b/pom.xml index 7c6788f1b..09acc2be6 100644 --- a/pom.xml +++ b/pom.xml @@ -13,6 +13,7 @@ 1.9.7.BUILD-SNAPSHOT UTF-8 + 3.25.0-SNAPSHOT 1.6.3 2.6.2 1.2 @@ -28,6 +29,22 @@ ${maven.multiModuleProjectDirectory}/libx + + + + github + GitHub Packages + https://maven.pkg.github.com/kriegaex/aspectj-packages + + true + + + + util bridge @@ -218,6 +235,7 @@ ${lib.directory}/ant/lib/junit.jar ${lib.directory}/commons/commons.jar ${lib.directory}/jarjar/jarjar-1.3.jar + ${lib.directory}/jdtcore-aj/jdtcore-for-aspectj.jar ${lib.directory}/junit/junit.jar ${lib.directory}/regexp/jakarta-regexp-1.2.jar ${lib.directory}/saxon/saxon.jar @@ -243,6 +261,11 @@ pom import
+ + org.aspectj + org.eclipse.jdt.core + ${jdt.core.version} + commons-beanutils diff --git a/run-all-junit-tests/pom.xml b/run-all-junit-tests/pom.xml index a4d186e26..6abd8610b 100644 --- a/run-all-junit-tests/pom.xml +++ b/run-all-junit-tests/pom.xml @@ -183,13 +183,10 @@ ${project.version} test-jar - org.aspectj ajdoc @@ -243,13 +240,6 @@ ${lib.ant.version} - org.aspectj - org.eclipse.jdt.core - 1.0 - system - ${project.basedir}/../org.eclipse.jdt.core/jdtcore-for-aspectj.jar - - jrockit jrockit 1.0 diff --git a/testing/pom.xml b/testing/pom.xml index 68badf0ff..660dec41f 100644 --- a/testing/pom.xml +++ b/testing/pom.xml @@ -140,9 +140,6 @@ org.aspectj org.eclipse.jdt.core - 1.0 - system - ${project.basedir}/../org.eclipse.jdt.core/jdtcore-for-aspectj.jar diff --git a/tests/pom.xml b/tests/pom.xml index 97ea6c30c..11f91a216 100644 --- a/tests/pom.xml +++ b/tests/pom.xml @@ -64,9 +64,6 @@ org.aspectj org.eclipse.jdt.core - 1.0 - system - ${project.basedir}/../org.eclipse.jdt.core/jdtcore-for-aspectj.jar org.aspectj diff --git a/tests/product/build-aspectj/build.xml b/tests/product/build-aspectj/build.xml index de7e7ba99..394f10ff7 100644 --- a/tests/product/build-aspectj/build.xml +++ b/tests/product/build-aspectj/build.xml @@ -27,21 +27,21 @@ Setup: - Variables ASPECTJ_HOME and ASPECTJ_MODULES refer to the - base of an AspectJ install and the modules directory + Variables ASPECTJ_HOME and ASPECTJ_MODULES refer to the + base of an AspectJ install and the modules directory of the AspectJ source tree. By default they are - + ASPECTJ_MODULES: $${basedir}/../.. ASPECTJ_HOME: $${basedir}/../../aj-build/dist/tools - + which assumes the tools dist is built and this runs from modules/tests/product/build-aspectj. - + To disable verbose mode, set iajc.verbose to false. - + You can also define the properties to run on any distribution from anywhere: - + ant -DASPECTJ_HOME=dev/tools/aj -DASPECTJ_MODULES=ec @@ -59,9 +59,9 @@ - - + @@ -70,23 +70,23 @@ + location="${basedir}/../../.."/> + location="${basedir}/../../../aj-build/dist/tools"/> + location="${ASPECTJ_HOME}/lib"/> + location="${aspectj.lib.dir}/aspectjrt.jar"/> + location="${aspectj.lib.dir}/aspectjtools.jar"/> + location="${basedir}/output"/> @@ -100,17 +100,17 @@ - + - + - + @@ -121,22 +121,22 @@ - + - + - - - + + @@ -144,32 +144,32 @@ - - - - + - + - + @@ -181,11 +181,11 @@ verbose="${iajc.verbose}" sourcerootsref="runtime.roots"/> - + - + - + @@ -203,7 +203,7 @@ failonerror="true"> - + @@ -217,9 +217,9 @@ - + - + diff --git a/tests/profiling/build.xml b/tests/profiling/build.xml index ccb4d8f82..e6e9509b7 100644 --- a/tests/profiling/build.xml +++ b/tests/profiling/build.xml @@ -73,7 +73,7 @@ - +