From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Mon, 10 Jul 2017 21:19:19 +0000 (+0000)
Subject: Fix thumbnail rendering for images with height >> width.
X-Git-Tag: 4.0.0~630
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=ffea3d5ba3cea6a5f6b1d500ae5417fe158a4546;p=redmine.git

Fix thumbnail rendering for images with height >> width.

git-svn-id: http://svn.redmine.org/redmine/trunk@16813 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 52a405211..3409bb7be 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -220,11 +220,12 @@ module ApplicationHelper
   end
 
   def thumbnail_tag(attachment)
+    thumbnail_size = Setting.thumbnails_size.to_i
     link_to(
       image_tag(
         thumbnail_path(attachment),
-        :srcset => "#{thumbnail_path(attachment, :size => Setting.thumbnails_size.to_i * 2)} 2x",
-        :width => Setting.thumbnails_size
+        :srcset => "#{thumbnail_path(attachment, :size => thumbnail_size * 2)} 2x",
+        :style => "max-width: #{thumbnail_size}px; max-height: #{thumbnail_size}px;"
       ),
       named_attachment_path(
         attachment,