From: wisberg <wisberg>
Date: Sun, 25 May 2003 20:12:40 +0000 (+0000)
Subject: PR-based queries were dominating - now do union correctly
X-Git-Tag: V1_1_0~57
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=fffed25e1966af8b5ea57fcc7aab7ff012f4af76;p=aspectj.git

PR-based queries were dominating - now do union correctly
---

diff --git a/testing/src/org/aspectj/testing/harness/bridge/AjcTest.java b/testing/src/org/aspectj/testing/harness/bridge/AjcTest.java
index 55ec35258..e67eb8b9e 100644
--- a/testing/src/org/aspectj/testing/harness/bridge/AjcTest.java
+++ b/testing/src/org/aspectj/testing/harness/bridge/AjcTest.java
@@ -343,6 +343,7 @@ public class AjcTest extends RunSpecIterator {
          * <li>the spec does not have a required title (description)n</li>
          * </ul>
          * When skipping, this issues a messages as to why skipped.
+         * Skip combinations are not guaranteed to work correctly. XXX
          * @return false if this wants to be skipped, true otherwise
          * @throws Error if selected option is not of the form
          *          <pre>-ajctest[Require|Skip]Keywords=keyword{,keyword}..</pre>.
@@ -425,7 +426,7 @@ public class AjcTest extends RunSpecIterator {
                         String spec = (String) iter.next();
                         if (null != havePr) {
                             if (havePr.equals(spec)) { // String.equals()
-                                return true;
+                                havePr = null;
                             }
                         } else if (keywordMustExist != keywords.contains(spec)) {
                             String reason = "keyword " + spec