From: Matthias Sohn <matthias.sohn@sap.com>
Date: Fri, 30 Aug 2024 14:32:30 +0000 (+0200)
Subject: Remove deprecated LocalDiskRepositoryTestCase#create(boolean,boolean)
X-Git-Tag: v7.0.0.202409031743-r~42
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=refs%2Fchanges%2F39%2F1200239%2F2;p=jgit.git

Remove deprecated LocalDiskRepositoryTestCase#create(boolean,boolean)

Change-Id: I9eff2d405b5302753ff2ec1d0eab431bdba69fe0
---

diff --git a/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java b/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java
index 407290a399..98f69ed31c 100644
--- a/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java
+++ b/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java
@@ -422,32 +422,11 @@ public abstract class LocalDiskRepositoryTestCase {
 	 */
 	protected FileRepository createRepository(boolean bare)
 			throws IOException {
-		return createRepository(bare, false /* auto close */);
-	}
-
-	/**
-	 * Creates a new empty repository.
-	 *
-	 * @param bare
-	 *            true to create a bare repository; false to make a repository
-	 *            within its working directory
-	 * @param autoClose
-	 *            auto close the repository in {@link #tearDown()}
-	 * @return the newly created repository, opened for access
-	 * @throws IOException
-	 *             the repository could not be created in the temporary area
-	 * @deprecated use {@link #createRepository(boolean)} instead
-	 */
-	@Deprecated
-	public FileRepository createRepository(boolean bare, boolean autoClose)
-			throws IOException {
 		File gitdir = createUniqueTestGitDir(bare);
 		FileRepository db = new FileRepository(gitdir);
 		assertFalse(gitdir.exists());
 		db.create(bare);
-		if (autoClose) {
-			addRepoToClose(db);
-		}
+		addRepoToClose(db);
 		return db;
 	}
 
diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/RepositoryCacheTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/RepositoryCacheTest.java
index cec69c4998..2a6551787f 100644
--- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/RepositoryCacheTest.java
+++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/RepositoryCacheTest.java
@@ -159,8 +159,8 @@ public class RepositoryCacheTest extends RepositoryTestCase {
 	@Test
 	public void testRepositoryUsageCountWithRegisteredRepository()
 			throws IOException {
-		@SuppressWarnings({"resource", "deprecation"}) // We are testing the close() method
-		Repository repo = createRepository(false, false);
+		@SuppressWarnings("resource") // We are testing the close() method
+		Repository repo = createRepository(false);
 		assertEquals(1, repo.useCnt.get());
 		RepositoryCache.register(repo);
 		assertEquals(1, repo.useCnt.get());
@@ -207,10 +207,8 @@ public class RepositoryCacheTest extends RepositoryTestCase {
 
 	@Test
 	public void testRepositoryUnregisteringWhenExpired() throws Exception {
-		@SuppressWarnings({"resource", "deprecation"}) // We are testing the close() method
-		Repository repoA = createRepository(true, false);
-		@SuppressWarnings({"resource", "deprecation"}) // We are testing the close() method
-		Repository repoB = createRepository(true, false);
+		Repository repoA = createRepository(true);
+		Repository repoB = createRepository(true);
 		Repository repoC = createBareRepository();
 		RepositoryCache.register(repoA);
 		RepositoryCache.register(repoB);
@@ -243,8 +241,7 @@ public class RepositoryCacheTest extends RepositoryTestCase {
 
 	@Test
 	public void testReconfigure() throws InterruptedException, IOException {
-		@SuppressWarnings({"resource", "deprecation"}) // We are testing the close() method
-		Repository repo = createRepository(false, false);
+		Repository repo = createRepository(false);
 		RepositoryCache.register(repo);
 		assertTrue(RepositoryCache.isCached(repo));
 		repo.close();