From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Wed, 28 Sep 2016 14:28:51 +0000 (+0200)
Subject: Fix Quality flaws
X-Git-Tag: 6.2-RC1~551
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=refs%2Fpull%2F1275%2Fhead;p=sonarqube.git

Fix Quality flaws
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/permission/PermissionUpdater.java b/server/sonar-server/src/main/java/org/sonar/server/permission/PermissionUpdater.java
index a6d92e1cd7c..5c10a26fead 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/permission/PermissionUpdater.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/permission/PermissionUpdater.java
@@ -191,10 +191,8 @@ public class PermissionUpdater {
   private ComponentDto getComponent(DbSession session, @Nullable String componentKey) {
     if (componentKey == null) {
       return null;
-    } else {
-      ComponentDto component = componentFinder.getByKey(session, componentKey);
-      return component;
     }
+    return componentFinder.getByKey(session, componentKey);
   }
 
   private static Object badRequestIfNullResult(@Nullable Object component, String objectType, String objectKey) {
diff --git a/sonar-db/src/main/java/org/sonar/db/permission/CountByProjectAndPermissionDto.java b/sonar-db/src/main/java/org/sonar/db/permission/CountByProjectAndPermissionDto.java
index b366d9dfb85..8f98728ac32 100644
--- a/sonar-db/src/main/java/org/sonar/db/permission/CountByProjectAndPermissionDto.java
+++ b/sonar-db/src/main/java/org/sonar/db/permission/CountByProjectAndPermissionDto.java
@@ -19,8 +19,6 @@
  */
 package org.sonar.db.permission;
 
-import com.google.common.annotations.VisibleForTesting;
-
 public class CountByProjectAndPermissionDto {
   private long componentId;
   private String permission;
@@ -30,13 +28,6 @@ public class CountByProjectAndPermissionDto {
     // used by MyBatis
   }
 
-  @VisibleForTesting
-  public CountByProjectAndPermissionDto(long componentId, String permission, int count) {
-    this.componentId = componentId;
-    this.permission = permission;
-    this.count = count;
-  }
-
   public long getComponentId() {
     return componentId;
   }
diff --git a/sonar-db/src/main/java/org/sonar/db/permission/UserPermissionDao.java b/sonar-db/src/main/java/org/sonar/db/permission/UserPermissionDao.java
index 9a873d89959..ac0978cc745 100644
--- a/sonar-db/src/main/java/org/sonar/db/permission/UserPermissionDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/permission/UserPermissionDao.java
@@ -57,7 +57,7 @@ public class UserPermissionDao implements Dao {
    */
   public List<String> selectLogins(DbSession dbSession, PermissionQuery query) {
     return select(dbSession, query, null).stream()
-      .map(p -> p.getUserLogin())
+      .map(ExtendedUserPermissionDto::getUserLogin)
       .distinct()
       .collect(Collectors.toList());
   }
@@ -73,7 +73,7 @@ public class UserPermissionDao implements Dao {
       .setComponentUuid(projectUuid)
       .build();
     return select(dbSession, query, asList(userLogin)).stream()
-      .map(p -> p.getPermission())
+      .map(ExtendedUserPermissionDto::getPermission)
       .collect(Collectors.toSet());
   }
 
diff --git a/sonar-db/src/main/java/org/sonar/db/permission/UserPermissionMapper.java b/sonar-db/src/main/java/org/sonar/db/permission/UserPermissionMapper.java
index e43b6c64fdb..c7773bd4684 100644
--- a/sonar-db/src/main/java/org/sonar/db/permission/UserPermissionMapper.java
+++ b/sonar-db/src/main/java/org/sonar/db/permission/UserPermissionMapper.java
@@ -32,7 +32,7 @@ public interface UserPermissionMapper {
    *
    * @param query non-null query including optional filters.
    * @param userLogins if null, then filter on all active users. If not null, then filter on logins, including disabled users.
-   *                   Must not be empty. If not null then maximum size is 1'000.
+   *                   Must not be empty. If not null then maximum size is {@link org.sonar.db.DatabaseUtils#PARTITION_SIZE_FOR_ORACLE}.
    */
   List<ExtendedUserPermissionDto> selectByQuery(@Param("query") PermissionQuery query, @Nullable @Param("userLogins") Collection<String> userLogins, RowBounds rowBounds);
 
diff --git a/sonar-db/src/main/java/org/sonar/db/user/RoleDao.java b/sonar-db/src/main/java/org/sonar/db/user/RoleDao.java
index aede227c655..ff41c4d6867 100644
--- a/sonar-db/src/main/java/org/sonar/db/user/RoleDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/user/RoleDao.java
@@ -48,11 +48,11 @@ public class RoleDao implements Dao {
     mapper(session).deleteGroupRolesByResourceId(projectId);
   }
 
-  private int countResourceGroupRoles(DbSession session, Long resourceId) {
+  private static int countResourceGroupRoles(DbSession session, Long resourceId) {
     return mapper(session).countResourceGroupRoles(resourceId);
   }
 
-  private int countResourceUserRoles(DbSession session, Long resourceId) {
+  private static int countResourceUserRoles(DbSession session, Long resourceId) {
     return mapper(session).countResourceUserRoles(resourceId);
   }
 
diff --git a/sonar-db/src/test/java/org/sonar/db/permission/template/PermissionTemplateDaoTest.java b/sonar-db/src/test/java/org/sonar/db/permission/template/PermissionTemplateDaoTest.java
index d834fa4e6d1..b65ad38ef85 100644
--- a/sonar-db/src/test/java/org/sonar/db/permission/template/PermissionTemplateDaoTest.java
+++ b/sonar-db/src/test/java/org/sonar/db/permission/template/PermissionTemplateDaoTest.java
@@ -141,11 +141,11 @@ public class PermissionTemplateDaoTest {
   public void should_update_permission_template() {
     db.prepareDbUnit(getClass(), "updatePermissionTemplate.xml");
 
-    PermissionTemplateDto dto = new PermissionTemplateDto();
-    dto.setId(1L);
-    dto.setName("new_name");
-    dto.setDescription("new_description");
-    dto.setKeyPattern("new_regexp");
+    PermissionTemplateDto dto = new PermissionTemplateDto()
+      .setId(1L)
+      .setName("new_name")
+      .setDescription("new_description")
+      .setKeyPattern("new_regexp");
     underTest.update(dbSession, dto);
 
     db.assertDbUnitTable(getClass(), "updatePermissionTemplate-result.xml", "permission_templates", "id", "name", "kee", "description");