From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Tue, 31 May 2022 06:31:38 +0000 (+0200)
Subject: Check background job type
X-Git-Tag: v25.0.0beta1~321^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=refs%2Fpull%2F32666%2Fhead;p=nextcloud-server.git

Check background job type

It is assumed that a job class loaded from the jobs table is an IJob,
but due to programming error the job might be of another type. Then the
setters will most likely fail.

This patch adds an interface type check so only correct jobs are used,
anything else is ignored.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---

diff --git a/lib/private/BackgroundJob/JobList.php b/lib/private/BackgroundJob/JobList.php
index fe65a1879bc..7ab86df8455 100644
--- a/lib/private/BackgroundJob/JobList.php
+++ b/lib/private/BackgroundJob/JobList.php
@@ -311,6 +311,10 @@ class JobList implements IJobList {
 				}
 			}
 
+			if (!($job instanceof IJob)) {
+				// This most likely means an invalid job was enqueued. We can ignore it.
+				return null;
+			}
 			$job->setId((int) $row['id']);
 			$job->setLastRun((int) $row['last_run']);
 			$job->setArgument(json_decode($row['argument'], true));