Merge pull request #33174 from nextcloud/fix/redirect-css-not-found

Do not redirect if requested font, style or script can not be found

Merge pull request #33465 from nextcloud/bugfix/noid/fix-more-icon-color

Fix "More" app icon in dark mode

Merge pull request #33415 from nextcloud/fix/integration-test-notif

Fix integration tests

Merge pull request #32363 from nextcloud/cleanup/remove-long-deprecated-classes

Remove OCP\App and OCP\BackgroundJob

Do not redirect if requested CSS can not be found

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #33357 from nextcloud/external_storage_buttons_a11y

Fix accessibility of buttons in the external storage configuration

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #33398 from nextcloud/enh/noid/sensitive-methods-apps

allow apps to specify methods carrying sensitive parameters

Fix "More" app icon

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #33411 from nextcloud/dependabot/npm_and_yarn/puppeteer-15.5.0

Merge pull request #33448 from nextcloud/bugfix/allow-download-label

Merge pull request #33269 from nextcloud/dependabot/npm_and_yarn/jquery-ui-1.13.2

Fix label for allow download share permission

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #33447 from nextcloud/bugfix/noid/detect-leading-spaces-in-config

Detect leading spaces in config files

Merge pull request #33435 from nextcloud/fix/remove-at-matchers-in-tests

Remove at matchers from tests in oauth2 and tests/Test

Merge pull request #32615 from sleiner/feature/ipv6-cidr-for-trusted-proxies

Support specifying IPv6 proxies in CIDR notation

Merge pull request #32852 from nextcloud/revert-revert-federation-performance-issues

Revert "Revert "Remove inefficient fed share scanner""

Fix accessibility of buttons in the external storage configuration

Note that there is no keyboard only way to close the dropdown

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #33451 from nextcloud/update-node-workflow-better-error-messages

Update node workflow for better error messages

fix external share scanner not propagating locking-opt-out

Signed-off-by: Robin Appelman <robin@icewind.nl>

Update node workflow for better error messages

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Disable locking on federated shares

The old inneficiant code didn't do locking and adding locking is
creating issues

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Revert "Revert "Remove inefficient fed share scanner""

This reverts commit 6667007bf235b90a7dd105c881cf5802b2a3f83e.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Detect leading spaces in config files

Because those will cause PHP to output to stdout and will cause
unrelated error messages.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Support specifying IPv6 proxies in CIDR notation

Previously, it was not possible to use CIDR notation for IPv6 proxies
in the trusted_proxies parameter of config.php [1]. This patch adds
support for that.

[1]: https://docs.nextcloud.com/server/24/admin_manual/configuration_server/reverse_proxy_configuration.html#defining-trusted-proxies

Signed-off-by: Simon Leiner <simon@leiner.me>

Merge pull request #32958 from nextcloud/fix/noid/permission-update-allow-public-uploads

Merge pull request #33425 from nextcloud/fix/fix-dynamic-properties-in-tests

Fix dynamic property creations in test files

Merge pull request #33428 from nextcloud/improve-accessibility-device

Improve Devices & sessions settings

Remove at matchers from tests in:

* apps/oauth2
* tests/Test/Repair/Owncloud

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #33432 from nextcloud/nickvergessen-patch-1

Remove "needs info" label when the issue is not stale anymore

Document all getIncomplete implementations as returning string|false

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Remove "needs info" label when the issue is not stale anymore

Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>

fix share manager tests

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

Improve Devices & sessions settings

- Add label for better accessibility
- Only allow to add app token with a name
- Align in rows

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #33405 from nextcloud/perf/new-index-mounts-class

Fix dynamic property creations in test files

This fixes warnings in PHP 8.2

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

don't reduce file public link permissions if public upload is not enabled

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

DB mounts table: Add index for mount_provider_class

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Fix integration tests

The html tags changed in the notification apps, adapt selector to the
new state

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Remove OCP\App and OCP\BackgroundJob

Both deprecated since NC 23

IAppManager is the replacement for OCP\App unfortunately it can't be
dependency injected in classes used by the installed otherwise the
database connection is initialised too early

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #32482 from nextcloud/enh/noid/share-attributes

Add share attributes + prevent download permission

Multiple fixes

- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Bump puppeteer from 14.1.0 to 15.5.0

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 14.1.0 to 15.5.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/puppeteer/puppeteer/compare/v14.1.0...v15.5.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #33225 from nextcloud/fix/handle-one-time-passwords

Handle one time password better

add unit test for ExceptionSerializer

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

allow apps to specify methods carrying sensitive parameters

… in order to remove them from logging.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Bump jquery-ui from 1.13.1 to 1.13.2

Bumps [jquery-ui](https://github.com/jquery/jquery-ui) from 1.13.1 to 1.13.2.
- [Release notes](https://github.com/jquery/jquery-ui/releases)
- [Commits](https://github.com/jquery/jquery-ui/compare/1.13.1...1.13.2)

---
updated-dependencies:
- dependency-name: jquery-ui
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Enforcing permission during resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Inherit hide download from share attributes

When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Block download when needed on direct download endpoint

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix view-only code after code review comments

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix adding to empty attributes and duplicate request

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Add share attrs + download permission support in frontend

Added download permission checkbox in frontend
Added share attributes parsing and setting in frontend.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Add nc:share-attributes Webdav property

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Don't reset share attributes when not specified

When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Attempt to fix sqlite json issue

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix share attribute related tests + code style

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Fix share controller to accept share attributes alone

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Add share attributes + prevent download permission

Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #33394 from nextcloud/fix/fix-370-Label_not_connected_to_form-element_in_file_listing

Connect ```input``` checkbox with corresponding file name via ```aria-describedby```

Handle one time password better

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Connect ```input``` checkbox with corresponding file name via ```aria-describedby```

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

Merge pull request #33385 from nextcloud/fix/transfer-aria-label-from-nav-settings-to-settings-icon

Transfer `aria-label` from nav settings menu to settings menu icon-button

Merge pull request #33081 from nextcloud/techdebt/noid/ocp-security-bruteforce-ithrottler

Add a public interface for the bruteforce throttler and register for …

Merge pull request #33280 from nextcloud/externalStorageWithoutVersioning

handle AccessDenied error when checking if external s3 support versions

Transfer `aria-label` from nav settings menu to settings menu icon-button

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

handle AccessDenied error when checking if external s3 support versions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #33299 from nextcloud/fix/files-dark-color-theme

[files app]: Fix dark color mode detection for filelist

Add a public interface for the bruteforce throttler and register for injection

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #33380 from luzpaz/fix/lib-private-typos

Fix typos in lib/private subdirectory

Merge pull request #32244 from nextcloud/dependabot/npm_and_yarn/core-js-3.22.3

Bump core-js from 3.22.0 to 3.22.3

Bumps [core-js](https://github.com/zloirock/core-js) from 3.22.0 to 3.22.3.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.22.0...v3.22.3)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #33386 from nextcloud/fix/noid/delete-user-value

Merge pull request #33379 from nextcloud/techdebt/noid/goodbye-legacy-ids

Remove more legacy ids

Merge pull request #32956 from nextcloud/fix/upload-folder-wrong-content

Handle file contained inside the uploads folder

fix mistake in db query to delete a user config value

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>

Merge pull request #33378 from nextcloud/s3-no-null-bundle

don't set `null` as a bundle path

Fix typos in lib/private subdirectory

Found via `codespell -q 3 -S l10n -L jus ./lib/private`

Signed-off-by: luz paz <luzpaz@github.com>

Merge pull request #33316 from nextcloud/bugfix/noid/aria-label-share-link-buttons

Accessible names for share panel buttons

Remove more legacy ids

Remove more unused legacy ids from early ownCloud times.

This reduces the number of duplicate ids in the DOM.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #33373 from nextcloud/techdebt/noid/remove-legacy-dir

Remove legacy #dir element in files list

Merge pull request #33368 from luzpaz/fix/apps-dav-typos

Fix typos in apps/dav subdirectory

don't set `null` as a bundle path

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #33265 from nextcloud/fix/carl/login-boxes

Redesign guest pages for better accessibility

Merge pull request #33300 from nextcloud/fix/dashboard-dark-color-theme

dashboard: Fix dark theme detection

Fix login flow

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Fix caldav invitation related public pages

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Redesign guest pages for better accessibility

- Use white box and put content on it
- Improve focus indicator

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Remove legacy #dir element in files list

Removed legacy "#dir" input element in the DOM.

Apps should use OCA.Files.App.currentFileList or
OCA.Sharing.PublicApp.fileList and call getCurrentDirectory() to
retrieve the current directory and changeDirectory() to change it.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #33307 from nextcloud/bump/nextcloud-dialogs-3.1.2-to-3.1.4

Bump nextcloud-dialogs from 3.1.2 to 3.1.4

Merge pull request #33271 from nextcloud/enh/a11y-new-file-menu

Use explicit name for new file/folder menu

Fix typos in apps/dav subdirectory

Found via `codespell -q 3 -S l10n -L jus ./apps/dav`

Signed-off-by: luz paz <luzpaz@github.com>

Bump nextcloud-dialogs from 3.1.2 to 3.1.4

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #30030 from nextcloud/fexists

Fix disabled `php_uname`

Merge pull request #30510 from nextcloud/user-cleanup-storage-before-cache

delete files before cleaning cache when cleaning user files

Accessible names for share panel buttons

Added aria-label for the buttons on the share panel.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #33361 from nextcloud/techdebt/noid/further-cleanup

Further markup cleanup