source.dussan.org Git

Javen O'Neal [Mon, 15 Aug 2016 16:05:32 +0000 (16:05 +0000)]

bug 60005: fix NPE in XSLFTextParagraph.getDefaultFontSize()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756397 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 15 Aug 2016 08:09:32 +0000 (08:09 +0000)]

make member variables final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756361 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 15 Aug 2016 07:36:22 +0000 (07:36 +0000)]

extract string constant out of code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756358 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 15 Aug 2016 07:31:43 +0000 (07:31 +0000)]

simplify unit test using assertContainsIgnoreCase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756357 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 15 Aug 2016 07:27:03 +0000 (07:27 +0000)]

add (meta) unit test for POITestCase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756356 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 15 Aug 2016 05:23:34 +0000 (05:23 +0000)]

whitespace, remove unused variable, expose Set interface for seenNotes, append \n character instead of String

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756348 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 15 Aug 2016 04:42:31 +0000 (04:42 +0000)]

bug 59773: move loop invariants out of for-loop for performance, use for-each instead of for loop when possible

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756345 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 11 Aug 2016 15:27:33 +0000 (15:27 +0000)]

Slightly simplify HWPF writing code, and add in-place write tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756003 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 11 Aug 2016 15:14:04 +0000 (15:14 +0000)]

HWPF in-place write support

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756001 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 11 Aug 2016 12:00:53 +0000 (12:00 +0000)]

Fix detecting Java 6 versus Java 7 or higher for Findbugs-version, this did not really work for some reason.
Use real Java version, not ant.java.version as this is not correctly set sometimes .
Also print out some more Ant-version-information

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755962 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Wed, 10 Aug 2016 21:45:12 +0000 (21:45 +0000)]

prepare for 3.15-beta4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755880 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Wed, 10 Aug 2016 21:44:15 +0000 (21:44 +0000)]

release prepare for 3.15-beta3 - pin documentation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755878 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Wed, 10 Aug 2016 21:40:39 +0000 (21:40 +0000)]

release prepare for 3.15-beta3 - pin documentation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755876 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Wed, 10 Aug 2016 20:32:20 +0000 (20:32 +0000)]

Remove incorrectly set svn:executable flags

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755847 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 4 Aug 2016 17:50:42 +0000 (17:50 +0000)]

Print out version of findbugs/java to research why we chose the wrong one in CI

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755222 13f79535-47bb-0310-9956-ffa450edef68

Whitespace, javadocs and @Overrides for the Logger classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755192 13f79535-47bb-0310-9956-ffa450edef68

Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68

Refactor out some of the common FormulaEvaluator logic from HSSF to a base class (XSSF coming shortly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755070 13f79535-47bb-0310-9956-ffa450edef68

Whitespace / indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755068 13f79535-47bb-0310-9956-ffa450edef68

Whitespace / indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755066 13f79535-47bb-0310-9956-ffa450edef68

Fix eclipse classpath - collections is in core lib

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755062 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Tue, 2 Aug 2016 08:38:17 +0000 (08:38 +0000)]

Tweak

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754849 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Tue, 2 Aug 2016 08:36:12 +0000 (08:36 +0000)]

Test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754848 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Tue, 2 Aug 2016 08:35:25 +0000 (08:35 +0000)]

Test commit

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754847 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Tue, 2 Aug 2016 08:31:52 +0000 (08:31 +0000)]

Tweak

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754846 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Tue, 2 Aug 2016 08:29:37 +0000 (08:29 +0000)]

Trivial change to test SVN is working again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754845 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 1 Aug 2016 18:20:43 +0000 (18:20 +0000)]

bug 59922: rename XSSFPaswordHelper to XSSFPasswordHelper

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754786 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 1 Aug 2016 18:03:36 +0000 (18:03 +0000)]

bug 59922: make XSSFPasswordHelper internal because it works on XmlObject objects, which are generally an internal implementation detail of POI-OOXML

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754785 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 1 Aug 2016 18:01:24 +0000 (18:01 +0000)]

whitespace; +svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754784 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 1 Aug 2016 17:36:06 +0000 (17:36 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754782 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Mon, 1 Aug 2016 12:51:24 +0000 (12:51 +0000)]

Fix zero-padding and handling of empty passwords (meaning protection on, but no password to remove it) for XSSF workbook protection.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59920

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754744 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 1 Aug 2016 06:23:36 +0000 (06:23 +0000)]

Rename and add missing license header

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754705 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 1 Aug 2016 05:32:41 +0000 (05:32 +0000)]

javadoc fix: incorrect deprecated replacement

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754702 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Murphy [Mon, 1 Aug 2016 04:21:14 +0000 (04:21 +0000)]

revert changes made in r1754691

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754700 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Murphy [Mon, 1 Aug 2016 02:53:55 +0000 (02:53 +0000)]

correction to junit bugs in r1754691

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754698 13f79535-47bb-0310-9956-ffa450edef68

Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Murphy [Sun, 31 Jul 2016 23:59:02 +0000 (23:59 +0000)]

Add new class Cell Style Template and supporting enum for drawing borders

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 31 Jul 2016 21:24:13 +0000 (21:24 +0000)]

Add coverage of function WEEKDAY

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754689 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 31 Jul 2016 21:23:34 +0000 (21:23 +0000)]

Fix download-location of commons-logging4 jar and add it to FindBugs and bin-files target correctly
Add ant-jar to findbugs target as it is needed for excelant-code-check now
Fail on error when running Findbugs (still not on found warnings!)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754688 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 31 Jul 2016 21:23:25 +0000 (21:23 +0000)]

Allow to specify -addmods for Java 9 support, update to JaCoCo 0.7.7 for initial Java 9 support and add target to create a combined JUnit report

Conflicts:
build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754687 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 31 Jul 2016 17:19:37 +0000 (17:19 +0000)]

Exclude package sl.draw.binding from coverage-counting as this is generated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754676 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 31 Jul 2016 17:19:33 +0000 (17:19 +0000)]

Test a few more cases of function INDIRECT()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754675 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 31 Jul 2016 17:19:27 +0000 (17:19 +0000)]

Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 31 Jul 2016 17:19:17 +0000 (17:19 +0000)]

IDE warnings and fix a few places where we do not close resources in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754673 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 31 Jul 2016 17:19:05 +0000 (17:19 +0000)]

Adjust build:
* Use "skipexisting" in Get from Ant 1.8
* Do not always re-run ooxml-lite
* Findbugs does not require src- and javadocs-jars, so depend on "jar" instead of "assemble"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754672 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sat, 30 Jul 2016 12:39:16 +0000 (12:39 +0000)]

Sonar wants to know about the new commons collections dependency too!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754620 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Sat, 30 Jul 2016 08:54:50 +0000 (08:54 +0000)]

Move commons collections 4 dependency to main

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754602 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Fri, 29 Jul 2016 18:48:07 +0000 (18:48 +0000)]

As Nick suspected, the dependency is actually from HSSF too so commons collections 4 needs adding to the main POM

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754563 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 29 Jul 2016 14:03:28 +0000 (14:03 +0000)]

Javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754530 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Fri, 29 Jul 2016 13:24:00 +0000 (13:24 +0000)]

Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods.

Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 27 Jul 2016 18:15:54 +0000 (18:15 +0000)]

Bug 55384: Handle setting pre-evaluation string correctly in SXSSF as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754328 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 26 Jul 2016 10:58:08 +0000 (10:58 +0000)]

HWPFDocument.write(File) support and tests #57919

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754108 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 24 Jul 2016 11:38:50 +0000 (11:38 +0000)]

Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 21 Jul 2016 23:25:02 +0000 (23:25 +0000)]

In-place write for HSLF #57919

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753741 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 21 Jul 2016 23:09:07 +0000 (23:09 +0000)]

Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 21 Jul 2016 10:27:27 +0000 (10:27 +0000)]

Javadoc updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 21 Jul 2016 02:17:37 +0000 (02:17 +0000)]

test Cell.setCellValue(false)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753634 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 23:31:57 +0000 (23:31 +0000)]

If doing an in-place write, update the properties too

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 23:20:02 +0000 (23:20 +0000)]

#57919 HSLF writing to new File

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753622 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 23:09:33 +0000 (23:09 +0000)]

#57919 HPSF writing better error handling, and start prep for HSLF more write methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 22:39:12 +0000 (22:39 +0000)]

Whitespace / indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753620 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 22:35:51 +0000 (22:35 +0000)]

#57919 Add in-place and new-File write methods to POIDocument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 22:18:25 +0000 (22:18 +0000)]

Mark some more scratchpad document types as currently being read-only

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753618 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 22:13:03 +0000 (22:13 +0000)]

Helper class for implementing extra write methods (#57919) for Scratchpad classes which are read-only

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753617 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 18:41:27 +0000 (18:41 +0000)]

Prepare for pushing write() and write(File) to POIDocument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 12:01:36 +0000 (12:01 +0000)]

Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 11:14:05 +0000 (11:14 +0000)]

Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 20 Jul 2016 11:07:29 +0000 (11:07 +0000)]

#57919 Start on support for writing to a new File (faster than OutputStream)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753486 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 19 Jul 2016 10:08:50 +0000 (10:08 +0000)]

add test case for bug 53564

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753359 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 19 Jul 2016 08:43:30 +0000 (08:43 +0000)]

svn propset svn:mime-type application/vnd.openxmlformats-officedocument.spreadsheetml.sheet *.xlsx

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753351 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 19 Jul 2016 08:39:38 +0000 (08:39 +0000)]

+svn:auto-props for common Microsoft Office files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753350 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 19 Jul 2016 08:02:41 +0000 (08:02 +0000)]

bug 59881: fix D* functions for blank cells in headers in database; patch from Patrick Zimmermann

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753346 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 18 Jul 2016 18:26:18 +0000 (18:26 +0000)]

+svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753299 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 18 Jul 2016 18:25:28 +0000 (18:25 +0000)]

bug 59881: fix spelling; patch from Patrick Zimmermann

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753298 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 18 Jul 2016 10:32:55 +0000 (10:32 +0000)]

52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 18 Jul 2016 09:34:59 +0000 (09:34 +0000)]

Some warnings/improvements suggested by IntelliJ

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 17 Jul 2016 21:18:27 +0000 (21:18 +0000)]

59106: WorkdayFunction does not read the area with holidays correctly to calculate work days

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 17 Jul 2016 21:18:19 +0000 (21:18 +0000)]

Adjust unused local variables to also make FindBugs happy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753124 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 17 Jul 2016 21:18:12 +0000 (21:18 +0000)]

Fix one more place where stream were left open when an exception is thrown

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 17 Jul 2016 21:18:07 +0000 (21:18 +0000)]

Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 17 Jul 2016 21:17:51 +0000 (21:17 +0000)]

Enable reproducer test for bug 56880 after it was fixed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753121 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 17 Jul 2016 21:17:45 +0000 (21:17 +0000)]

Add commented reproducer for bug 57603

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753120 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 20:33:32 +0000 (20:33 +0000)]

only calculate getTextHeight if it will be used

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 20:29:34 +0000 (20:29 +0000)]

reduce statement complexity in drawContent, also has fewer FLOPS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 20:27:57 +0000 (20:27 +0000)]

if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 20:25:37 +0000 (20:25 +0000)]

bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 20:24:14 +0000 (20:24 +0000)]

make instance variables final where possible

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753111 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 17 Jul 2016 19:02:58 +0000 (19:02 +0000)]

#57919 Provide an initial in-place write method for HSSFWorkbook

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 13:25:02 +0000 (13:25 +0000)]

bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 13:12:27 +0000 (13:12 +0000)]

bug 59170: remove deprecated TableSprmUncompressor#uncompressTAP(byte[] grpprl, int offset) method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753070 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 13:11:18 +0000 (13:11 +0000)]

bug 59170: fix compile error from r1753052 when removing deprecated TAP_TYPE constant

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753069 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 12:16:58 +0000 (12:16 +0000)]

bug 58190: add unit tests for XMLSlideShow#addPicture and XMLSlideShow#findPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753065 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 11:56:13 +0000 (11:56 +0000)]

bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 11:45:40 +0000 (11:45 +0000)]

bug 59264,59833,59837: upgrade deprecated methods in examples and testcases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753061 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 11:43:50 +0000 (11:43 +0000)]

bug 59264,59833,59837: upgrade deprecated methods in examples and testcases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753060 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 10:27:44 +0000 (10:27 +0000)]

close workbook to avoid resource leak

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753053 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 10:27:18 +0000 (10:27 +0000)]

bug 59170: remove deprecated constants, make private variables final, whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753052 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 10:22:43 +0000 (10:22 +0000)]

HexDump.writeHex is similar to Long#toHexString. Consider consolidating.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753050 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 10:10:21 +0000 (10:10 +0000)]

log on unsupported Sprm operation, save operand to variable to reduce duplicated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753048 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 17 Jul 2016 10:08:06 +0000 (10:08 +0000)]

whitespace (tabs to spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753047 13f79535-47bb-0310-9956-ffa450edef68