Merge pull request #21825 from nextcloud/fix/appframework/services

Fix AppFramework services

Merge pull request #21812 from nextcloud/feature/noid/app-bootstrap-without-app.php

Do not load app.php if Application implements IBootstrap

Merge pull request #21833 from nextcloud/docfix/noid/irequest_getHeader

Fix PHPDoc of IRequest::getHeader

Merge pull request #21828 from nextcloud/enhancement/lazy-bootstrap-registration-delegation

Delegate bootstrap registration lazily

Fix AppFramework services

* We can't just register an alias as the services need the appId to be
  injected. if we just register an alias this blows up since the main
  container doesn't have the appId.
* Moved the Authtokens over to show the PoC works

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Do not load app.php if Application implements IBootstrap

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Delegate bootstrap registration lazily

* Keep the registration context
* Expose the context object for other components
* Ensure registration is only run once

Search providers are migrated for demonstration.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #21832 from nextcloud/bugfix/noid/source-maps-prod

Build source maps on production build again

Merge pull request #21827 from nextcloud/fix/psr3-logger-exception

Make the PSR-3 adapter exception-aware

Compile assets

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Fix PHPDoc of IRequest::getHeader

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Build source maps on production build again

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Make the PSR-3 adapter exception-aware

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #21824 from nextcloud/techdebt/noid/bootstrap-user_ldap

Use IBootstrap for the app user_ldap

Merge pull request #21357 from nextcloud/feature/21265/personal-share-notes

Add Editing for Link Share Labels

Merge pull request #21791 from nextcloud/bug/21790/update-guzzle

Add Guzzle's InvalidArgumentException

Use IBootstrap for the app user_ldap

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

[tx-robot] updated from transifex

Add user input for link share labels

Signed-off-by: Gary Kim <gary@garykim.dev>

Add Guzzle's InvalidArgumentException

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #21813 from nextcloud/enh/noid/report-code-style-to-github

Report php-cs-fixer errors to GitHub

Merge pull request #21820 from nextcloud/techdebt/noid/ldap-do-not-use-custom-DI-names

Do not use custom DI object names for user_ldap

Merge pull request #21819 from nextcloud/techdebt/noid/updatenotification-bootstrap

Use IBootstrap for the app updatenotification

Do not use custom DI object names for user_ldap

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Use IBootstrap for the app updatenotification

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21785 from nextcloud/techdebt/noid/remove-classmap-in-files_external

Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH us…

Report php-cs-fixer errors to GitHub

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #21792 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.19

Bump lodash from 4.17.15 to 4.17.19

Merge pull request #21748 from nextcloud/bugfix/noid/improve-error-reporting-with-sharing

Improve error reporting on sharing errors

Merge pull request #21800 from nextcloud/bug/noid/key_export_call

Call openssl_pkey_export with $config and log errors.

Merge pull request #21789 from nextcloud/ftp-filter-hash

filter files containing a hash in the path for ftp storages

Bump lodash from 4.17.15 to 4.17.19

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #21794 from nextcloud/dependabot/npm_and_yarn/jsdom-16.3.0

Bump jsdom from 16.2.2 to 16.3.0

[tx-robot] updated from transifex

Call openssl_pkey_export with $config and log errors.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

[tx-robot] updated from transifex

Bump jsdom from 16.2.2 to 16.3.0

Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.2.2 to 16.3.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](https://github.com/jsdom/jsdom/compare/16.2.2...16.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #21796 from nextcloud/dependabot/npm_and_yarn/mochapack-2.0.3

Bump mochapack from 2.0.2 to 2.0.3

[tx-robot] updated from transifex

Bump mochapack from 2.0.2 to 2.0.3

Bumps [mochapack](https://github.com/sysgears/mochapack) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/sysgears/mochapack/releases)
- [Commits](https://github.com/sysgears/mochapack/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

filter files containing a hash in the path for ftp storages

the php ftp streamwrapper doesn't handle hashes correctly and will break when it tries to enter a path containing a hash.

By filtering out paths containing a hash we can at least stop the external storage from breaking completely

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #21684 from nextcloud/dependabot/npm_and_yarn/sass-loader-9.0.1

Bump sass-loader from 8.0.2 to 9.0.1

Merge pull request #21730 from nextcloud/design/app-limit

Up the limit for the header app menu

Up the limit for the header app menu, fix #21635

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

[tx-robot] updated from transifex

Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH usage in files_external

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21760 from nextcloud/fix/20453/get-plural

Fix parsing of language code

Compile assets

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix parsing of language code

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #21777 from nextcloud/search-min-length

lower minimum search length to 2 characters

Merge pull request #21771 from nextcloud/techdebt/noid/clarify-scopes-for-profile-data

Clarify the scopes for profile data federation

Merge pull request #21750 from nextcloud/techdebt/noid/files_versions-bootstrap

Move files_versions to bootstrap mechanism

Merge pull request #21778 from nextcloud/fix/moment-locale-early

Set the moment locale even earlier

Merge pull request #21759 from nextcloud/enh/lazy_subscription

Make the subscription registry lazy

Set the moment locale even earlier

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

lower minimum search length to 2 characters

Signed-off-by: Robin Appelman <robin@icewind.nl>

Add DummySubscription for tests

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Move files_versions to bootstrap mechanism

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21733 from nextcloud/fix/noid/cache-system-card-etag-during-request

Update system addressbook card only when there was a change based on a cached etag

Clarify the scropes for profile data federation

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #21489 from nextcloud/fix/share/use_correct_mount

Use the correct mountpoint to calculate

Merge pull request #21736 from nextcloud/bugfix/21433

Fix placeholder issues with multiplace spaces in the name

Make the subscription registry lazy

This will allow to do lazy registration here which should allow for
loading less (or at least only when needed!).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Update system addressbook card only when there was a change based on a cached etag

Due to our old and new hook system the card dav backend listens to old and new hooks. This triggers this code multiple times and always causes an update. With this change we cache the etag during a request and only trigger the update if the etag has changed. This does not catches all not needed updates, but it does not need another round trip to the database and still covers most cases where multiple attributes are updated during one single request.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

better cleanup in share tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

ensure home storage is initialized on first setup

Signed-off-by: Robin Appelman <robin@icewind.nl>

ensure mounts are scanned during tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

Add more integration tests for resharing permissions

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Use the correct mountpoint to calculate

If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21767 from nextcloud/enh/lazy_register_navigation

Lazy register the navigation

Lazy register the navigation

This makes sure that we do not translate unneeded strings on for example
webdav requests.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21746 from nextcloud/techdebt/noid/cloud_federation_api-bootstrap

Move cloud_federation_api to bootstrap mechanism

Merge pull request #21766 from nextcloud/fix/21761/regression-in-return-value

Fix regression in return value of OC_Util::checkDataDirectoryPermissi…

Fix regression in return value of OC_Util::checkDataDirectoryPermissions due to #21761

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Fix placeholder issues with multiplace spaces in the name

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #21761 from nextcloud/fix/permission_check_translation

Kill another unneeded translation

[tx-robot] updated from transifex

Kill another unneeded translation

We should only translate things when we actually need them.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21758 from nextcloud/fix/routes/defaults

Fix supporting defaults for routes

Fix supporting defaults for routes

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21754 from nextcloud/td/no_translation_on_each_request

Only translate if we need the string

Only translate if we need the string

This translation was done in each call. Over and over and over again.
All while it was probably not used in 99.99999% of the cases. A small
gain. But still.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21729 from nextcloud/enh/noid/orphaned-mounts

Add removal of mounts without storages to files:cleanup command

Merge pull request #21745 from nextcloud/techdebt/noid/lookup_server_connector-bootstrap

Move lookup server connector to bootstrap mechanism

Merge pull request #21749 from nextcloud/techdebt/noid/contactsinteraction-bootstrap

Move contactsinteraction and comments to bootstrap mechanism

Move contactsinteraction to bootstrap mechanism

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Improve error reporting on sharing errors

Signed-off-by: Joas Schilling <coding@schilljs.com>

Test for proper removal of mount entries

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Move cloud_federation_api to bootstrap mechanism

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Move lookup server connector to bootstrap mechanism

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21643 from nextcloud/enh/no_routeactionhadler_inits

Do not create a RouteActionHandler object for each route

Merge pull request #21741 from nextcloud/debt/noid/url-generator-does-not-implement-i-user-session

Fix type for $urlGenerator

Fix type for $urlGenerator

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #21739 from nextcloud/techdebt/14552/migrate-OC-initSession

Remove hook for initSession

[tx-robot] updated from transifex

Remove hook for initSession

It's not used anyways and allowed to manipulate the state of the session. Also removed the code handling this.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add removal of mounts without storages to files:cleanup command

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Do not create a RouteActionHandler object for each route

This is not required and doesn't allow us to be properly lazy. On top of
it this doesnt allow us to cache the routes (since closures/objects
can't be cached).

This is the first small step into cleaning up the routing we have

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21676 from J0WI/fix-chmod-on-fd

Fix chmod on file descriptor

Merge pull request #21725 from nextcloud/bugfix/21316/ie11-quoted-props

Fix main bundle on IE11