Alfred Schmid [Thu, 9 Jan 2014 12:42:54 +0000 (13:42 +0100)]
Issue 356 - function updateUserModels also updates the stored teams in
the UserModel. Now all Teammembers are shown when
realm.ldap.synchronizeUsers.enable is turned on.
Alex Lewis [Mon, 23 Dec 2013 15:02:18 +0000 (15:02 +0000)]
Fixed test.
testRevlog was expecting 12 commits but getting 19. Looking at the
hello-world repository on github (on which the test executes) the 19
commit count appears to be correct.
James Moger [Thu, 12 Dec 2013 04:12:12 +0000 (23:12 -0500)]
Rollback to Servlet 2.5
Combining Dagger and Servlet 3 works really well on stock Tomcat and
Jetty but it is a troublesome combination on JEE containers with their
own ideas on how to instantiate classes. JBoss AS 7 has been
particularly nasty and it is just simpler to scaleback and stay with
Servlet 2.5 than it is to fight all permuations of containers.
Instead of using constructor DI, the servlets and filters each have an
inject(ObjectGaph) method which is automatically called during
initialization. Each servlet or filter is responsible for retrieving
the required dependency from the graph. The Dagger object graph is
created in the context listener and stuffed into the context as an
attribute.
James Moger [Mon, 25 Nov 2013 18:02:20 +0000 (13:02 -0500)]
Add support for per-repository bugtraq configuration
Imported the reference implementation contributed by syntevo which
is used in their SmartGit product. You may create a bugtraq config
section inf your .git/config file OR you may add a .gitbugtraq file
to the root of your repository.
Alex Lewis [Wed, 20 Nov 2013 17:32:27 +0000 (17:32 +0000)]
Add coloring modes to the blame page (issue-2, pull request #125)
Blame output is now colored according to Commit (default), Author or
Age. Both Commit and Author output uses random colors whereas Age uses a
single color with varying tints applied to indicate the age. White
indicates the eldest commit with the tint darkening as the commits get
younger.
James Moger [Sun, 17 Nov 2013 21:15:24 +0000 (16:15 -0500)]
Define manager interfaces and update all of Gitblit to use managers
These manager interfaces define how the GitBlit singleton will
eventually be split into smaller component managers. The Wicket app and
all servlets have been updated to request the needed managers. There
are _very_ few method signature changes - although there are a handful.
This is a surgical sharding of responsibility based on a proof of
concept refactor. Instead of random references to GittBlit.self()
there are now precise references to the manager interface required to
accomplish some task. Some tasks may require references to multiple
managers.
The code is now littered with calls to GitBlit.getManager(class) and
those familiar with the code-base will no doubt notice the duplication
of methods from IUserService in IUserManager and the addition of
implementation methods in the GitBlit context class. When the
GitBlit class is broken apart and the existing external authentication
user service classes are refactored to AuthenticationService classes,
this will again simplify and flatten. But in order to safely and
cleanly modularize the stable code-base we will have to live with a
little duplication for a short while.
James Moger [Sat, 16 Nov 2013 16:42:06 +0000 (11:42 -0500)]
Eliminate nearly all direct GitBlit singleton references in Wicket
This is the first step towards modularization and injection. All
direct references to the GitBlit singleton within the Wicket pages
and panels have been replaced to proxy methods in the GitBlitWebApp
singleton. There are still two Wicket classes which rely on the
GitBlit singleton; those require manual instantiation (servlet 3).
James Moger [Sat, 16 Nov 2013 14:12:10 +0000 (09:12 -0500)]
Automatically adjust web.forwardSlash on Tomcat containers
One issue that frequently arises in the discussion group and the bug
tracker is how Tomcat automatically re-encodes %2f as '/' which breaks
url parameters with %2f. After documenting this in half a dozen places
it still comes up. Clearly I haven't done enough.
Gitblit will now act on, instead of just report, an improperly configured
web.forwardSlash character on Tomcat containers. This will make Gitblit
"just work" for more users and will make the world a better place.
Florian Zschocke [Fri, 22 Nov 2013 15:09:05 +0000 (10:09 -0500)]
Merge pull request #122 from fzs/ldap-deref-alias
Currently the LDAP user service will not dereference aliases when
searching for groups. This patch enables dereferencing aliases for the
group search. This is benefitial if groups are defined in the DIT in a
common place but only certain ones shall play a role in Gitblit. These
can now be linked under a group that can be provided as search base for
groups, without having to recreate the existing groups under the search
base.
In addition, the new doSearch() method implemented in this patch also
limits the attributes returned for the group search to the "cn"
attribute, which is the only one used. That prevents returning all the
members of the result groups, which can be a lot.
projects / gitblit.git / log