aclement [Thu, 26 Feb 2004 10:00:31 +0000 (10:00 +0000)]
Fix for preventing the use of if/target/this/args/cflow/cflowbelow in DeclareSofts.
(Reordered flow in creating declare soft munger and concretizing the pointcut)
aclement [Thu, 26 Feb 2004 09:58:14 +0000 (09:58 +0000)]
Fix for preventing the use of if/target/this/args/cflow/cflowbelow in DeclareSofts.
(I hope putting this utility method in the Pointcut class is ok ...)
aclement [Wed, 25 Feb 2004 11:14:32 +0000 (11:14 +0000)]
Fix for Bugzilla Bug 51320
ClasscastException on concretization of if(false)
(i.e. you can't use if/target/args/cflow/cflowbelow/this in deow - you get an error if you try)
jhugunin [Thu, 19 Feb 2004 22:09:16 +0000 (22:09 +0000)]
fix for Bugzilla Bug 51929
Advice calling protected super method causing java.lang.VerifyError 'Bad access to protected data'
Also expanded test to cover protected field access as well as methods
Fix required getting the correct receiver type for both field access and method
calls to correspond to Java's complicated rules for accessing protected
members (JLSv2 6.6.2 and mentioned in passing in JVMv2 5.4.4)
aclement [Mon, 9 Feb 2004 15:07:37 +0000 (15:07 +0000)]
Fix for Bugzilla Bug 50641
Better binary compatibility for advice method names
- I've run the tests a thousand times and they all pass, I'm still nervous about this first big commit though *gulp*
aclement [Fri, 30 Jan 2004 11:24:21 +0000 (11:24 +0000)]
Following yesterdays discussion, I'm temporarily adding a folder containing one file to see if it makes the build happy (we had to do this for adrians new module). If it fails then I'll delete it and wait for George to return who knows the right cruise control incantations to locate the problem.
jhugunin [Tue, 27 Jan 2004 19:47:12 +0000 (19:47 +0000)]
generates accurate max stack height information for aspectOf method
this is a long-standing bug that was masked by the weaver which
would always recompute this field. optimizations to the weaver made
this bug appear again.
aclement [Tue, 27 Jan 2004 10:20:28 +0000 (10:20 +0000)]
Adrian made me put these in. We seem to need a directory containing one file in order to satisfy the build script when it builds shadows.org.eclipse.jdt.core.
acolyer [Mon, 26 Jan 2004 16:23:41 +0000 (16:23 +0000)]
Bugzilla Bug 50458
Make a full implementation of org.eclipse.jdt.core for use in AJDT
Pushdown of AjParser and AjScanner into shadows/org.eclipse.jdt.core.
New class DeclarationFactory handles creation of AJDT-specific types
on behalf of Parser.
acolyer [Mon, 26 Jan 2004 16:18:36 +0000 (16:18 +0000)]
Bugzilla Bug 50458
Make a full implementation of org.eclipse.jdt.core for use in AJDT
Updated jdtcore jars, and an external builder configured in build
chain to refresh them from the shadows...
acolyer [Mon, 26 Jan 2004 15:17:22 +0000 (15:17 +0000)]
When not working with the branch version of
shadows/org.eclipse.jdt.core in your workspace (which will be
most of the time), this dummy project will satisfy the
build dependency of the HEAD org.eclipse.jdt.core project.
jhugunin [Sat, 24 Jan 2004 02:28:54 +0000 (02:28 +0000)]
Implemented feature for Bugzilla Bug 48091
Lazy instantiation of thisJoinPoint
Speed-ups of 10-100X are measured even when running a small test case with minimal GC issues.
The actual feature implemented is that thisJoinPoint objects are only created just before calling the method for advice that requires them. To take advantage of this feature you must use an if PCD or some other dynamic test that occurs in the PCD not the advice body to guard the expensive creation of the thisJoinPoint object.
-XlazyTjp flag must be passed to compiler to enable this feature.
If any around advice is present on the joinpoint then lazy instantiation
will be disabled. An Xlint warning will be displayed in this case.
As a related optimization, several helper methods were added to
Factory.makeJP to reduce the code size when thisJoinPoint is used.
acolyer [Fri, 23 Jan 2004 19:06:25 +0000 (19:06 +0000)]
eliminated a dependency on org.eclipse.core.runtime that had crept
into this source - only the org.eclipse.jdt.core project should
contain links to other portions of eclipse source.
wisberg [Thu, 15 Jan 2004 02:52:01 +0000 (02:52 +0000)]
Gregor's mailing list fixes to BoundPoint (two advice), plus (a) properties miscapitalized; (b) execution rather than call.
Could also skip proceed and event notification if input value not different, but that's a different example, eh?
jhugunin [Wed, 14 Jan 2004 15:24:06 +0000 (15:24 +0000)]
Fix for Bugzilla Bug 44587
Erroneous exception conversion
and Bugzilla Bug 34206
before():execution(new(..)) does not throw NoAspectBoundException
All exceptions that occur during the static intialization of a persingleton
aspect will be swallowed. When using that aspect (via aspectOf())
a NoAspectBoundException will be thrown with the original exception
from the staitc initializer as the cause.
acolyer [Wed, 14 Jan 2004 11:12:27 +0000 (11:12 +0000)]
Fix for Bugzilla Bug 49784
declaring interface methods should work as it does in interface
and Bugzilla Bug 45676
AspectJ enhanced code can not be used with plain old java anymo
and Bugzilla Bug 43972
Static crosscutting makes interfaces unusable for javac