]> source.dussan.org Git - redmine.git/log
redmine.git
5 years agorubocop: add Style/AsciiComments to .rubocop_todo.yml
Toshi MARUYAMA [Wed, 9 Oct 2019 02:05:49 +0000 (02:05 +0000)]
rubocop: add Style/AsciiComments to .rubocop_todo.yml

git-svn-id: http://svn.redmine.org/redmine/trunk@18632 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/AsciiComments in lib/redmine/search.rb
Toshi MARUYAMA [Wed, 9 Oct 2019 02:05:37 +0000 (02:05 +0000)]
code cleanup: rubocop: fix Style/AsciiComments in lib/redmine/search.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18631 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb
Toshi MARUYAMA [Wed, 9 Oct 2019 02:05:25 +0000 (02:05 +0000)]
code cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18630 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError...
Go MAEDA [Wed, 9 Oct 2019 02:02:16 +0000 (02:02 +0000)]
Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError (#32223).

git-svn-id: http://svn.redmine.org/redmine/trunk@18629 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up test/unit/issue_status_test.rb
Toshi MARUYAMA [Tue, 8 Oct 2019 14:10:02 +0000 (14:10 +0000)]
code layout clean up test/unit/issue_status_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18628 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up test/functional/issue_statuses_controller_test.rb
Toshi MARUYAMA [Tue, 8 Oct 2019 14:09:51 +0000 (14:09 +0000)]
code layout clean up test/functional/issue_statuses_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18627 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/RedundantBegin in lib/redmine/scm/adapters/git_adapt...
Toshi MARUYAMA [Tue, 8 Oct 2019 14:09:40 +0000 (14:09 +0000)]
code cleanup: rubocop: fix Style/RedundantBegin in lib/redmine/scm/adapters/git_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18626 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix wong link destinations in wiki_syntax_markdown.html (#32169).
Go MAEDA [Tue, 8 Oct 2019 12:54:10 +0000 (12:54 +0000)]
Fix wong link destinations in wiki_syntax_markdown.html (#32169).

git-svn-id: http://svn.redmine.org/redmine/trunk@18625 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoadd additional assert to Issue system "test_update_issue_with_form_update"
Toshi MARUYAMA [Tue, 8 Oct 2019 12:18:01 +0000 (12:18 +0000)]
add additional assert to Issue system "test_update_issue_with_form_update"

git-svn-id: http://svn.redmine.org/redmine/trunk@18624 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoreduce sleep seconds of Issue system "test_update_journal_notes_with_preview"
Toshi MARUYAMA [Tue, 8 Oct 2019 12:17:51 +0000 (12:17 +0000)]
reduce sleep seconds of Issue system "test_update_journal_notes_with_preview"

git-svn-id: http://svn.redmine.org/redmine/trunk@18623 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/views/issues/_action_menu.html.erb
Toshi MARUYAMA [Tue, 8 Oct 2019 07:39:23 +0000 (07:39 +0000)]
code layout clean up app/views/issues/_action_menu.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@18622 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode layout clean up app/views/issues/_attributes.html.erb
Toshi MARUYAMA [Tue, 8 Oct 2019 05:29:40 +0000 (05:29 +0000)]
code layout clean up app/views/issues/_attributes.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@18621 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode clean up test/integration/issues_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 13:07:12 +0000 (13:07 +0000)]
code clean up test/integration/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18620 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/issues_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 13:07:00 +0000 (13:07 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18619 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/HashSyntax in test/functional/issues_controller_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 13:06:47 +0000 (13:06 +0000)]
code cleanup: rubocop: fix Style/HashSyntax in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18618 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids
Toshi MARUYAMA [Mon, 7 Oct 2019 11:45:22 +0000 (11:45 +0000)]
use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids

WikiPage#deleted_attachment_ids is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18617 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "attr_writer" instead of "attr_accessor" for QueryColumn#sortable
Toshi MARUYAMA [Mon, 7 Oct 2019 11:45:11 +0000 (11:45 +0000)]
use "attr_writer" instead of "attr_accessor" for QueryColumn#sortable

QueryColumn#sortable is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18616 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "attr_reader" instead of "attr_accessor" for CustomFieldValue#value
Toshi MARUYAMA [Mon, 7 Oct 2019 11:44:54 +0000 (11:44 +0000)]
use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value

CustomFieldValue#value= is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc...
Toshi MARUYAMA [Mon, 7 Oct 2019 11:44:42 +0000 (11:44 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc in test/unit/setting_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18614 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: fix source code comment in r18607
Toshi MARUYAMA [Mon, 7 Oct 2019 07:34:22 +0000 (07:34 +0000)]
code cleanup: fix source code comment in r18607

git-svn-id: http://svn.redmine.org/redmine/trunk@18613 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/AlignArray in test/functional/issues_controller_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 07:21:27 +0000 (07:21 +0000)]
code cleanup: rubocop: fix Layout/AlignArray in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18612 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAfterColon in test/integration/wiki_test.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 07:21:14 +0000 (07:21 +0000)]
code cleanup: rubocop: fix Layout/SpaceAfterColon in test/integration/wiki_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18611 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in test/functional...
Toshi MARUYAMA [Mon, 7 Oct 2019 07:21:03 +0000 (07:21 +0000)]
code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18610 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceAfterColon in test/functional/issues_controlle...
Toshi MARUYAMA [Mon, 7 Oct 2019 07:20:50 +0000 (07:20 +0000)]
code cleanup: rubocop: fix Layout/SpaceAfterColon in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18609 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/functional/issues...
Toshi MARUYAMA [Mon, 7 Oct 2019 07:20:38 +0000 (07:20 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/functional/issues_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18608 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb
Toshi MARUYAMA [Mon, 7 Oct 2019 07:20:26 +0000 (07:20 +0000)]
code cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18607 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentHeredoc in test/functional/documents_controll...
Toshi MARUYAMA [Mon, 7 Oct 2019 07:20:13 +0000 (07:20 +0000)]
code cleanup: rubocop: fix Layout/IndentHeredoc in test/functional/documents_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18606 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTraditional Chinese translation update (#32210).
Go MAEDA [Mon, 7 Oct 2019 04:08:08 +0000 (04:08 +0000)]
Traditional Chinese translation update (#32210).

Patch by ChunChang Lo.

git-svn-id: http://svn.redmine.org/redmine/trunk@18605 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/integration/attachments_test.rb from Layout/EmptyLinesAroundExce...
Toshi MARUYAMA [Mon, 7 Oct 2019 02:32:36 +0000 (02:32 +0000)]
rubocop: remove test/integration/attachments_test.rb from Layout/EmptyLinesAroundExceptionHandling fixed by r18593

git-svn-id: http://svn.redmine.org/redmine/trunk@18604 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/functional/issues_controller_test.rb from Layout/IndentHeredoc...
Toshi MARUYAMA [Mon, 7 Oct 2019 02:02:40 +0000 (02:02 +0000)]
rubocop: remove test/functional/issues_controller_test.rb from Layout/IndentHeredoc and Layout/IndentationConsistency fixed by r18593

git-svn-id: http://svn.redmine.org/redmine/trunk@18603 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoOptions in a drop-down overlap the down arrow when Alternate theme is used (#32206...
Go MAEDA [Mon, 7 Oct 2019 00:40:03 +0000 (00:40 +0000)]
Options in a drop-down overlap the down arrow when Alternate theme is used (#32206, #31147).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18602 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoJapanese wiki help translation update (#32207).
Go MAEDA [Sun, 6 Oct 2019 10:53:09 +0000 (10:53 +0000)]
Japanese wiki help translation update (#32207).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18601 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix that "Associated revisions" tab has no content when the user displays comments...
Go MAEDA [Sat, 5 Oct 2019 23:57:33 +0000 (23:57 +0000)]
Fix that "Associated revisions" tab has no content when the user displays comments in reverse chronological order (#32198, #3058).

Patch by José Esteves.

git-svn-id: http://svn.redmine.org/redmine/trunk@18598 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoJapanese translation update (#32202).
Go MAEDA [Sat, 5 Oct 2019 10:02:00 +0000 (10:02 +0000)]
Japanese translation update (#32202).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18597 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate locales (#17840).
Go MAEDA [Sat, 5 Oct 2019 09:48:15 +0000 (09:48 +0000)]
Update locales (#17840).

git-svn-id: http://svn.redmine.org/redmine/trunk@18596 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoOption to send email notification on "Target version updated" (#17840).
Go MAEDA [Sat, 5 Oct 2019 09:46:05 +0000 (09:46 +0000)]
Option to send email notification on "Target version updated" (#17840).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRedmine::VERSION::revision may return wrong value (#29601).
Go MAEDA [Sat, 5 Oct 2019 05:46:39 +0000 (05:46 +0000)]
Redmine::VERSION::revision may return wrong value (#29601).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18594 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix test failure due to missing call to set_tmp_attachments_directory (#32122).
Go MAEDA [Fri, 4 Oct 2019 11:17:33 +0000 (11:17 +0000)]
Fix test failure due to missing call to set_tmp_attachments_directory (#32122).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18593 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix incorrect headings example in Textile help (#32184).
Go MAEDA [Fri, 4 Oct 2019 00:18:30 +0000 (00:18 +0000)]
Fix incorrect headings example in Textile help (#32184).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18592 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN...
Go MAEDA [Thu, 3 Oct 2019 13:40:55 +0000 (13:40 +0000)]
Fix "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks (#32110).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18589 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRemove unnecessary requiring of "rexml/document" (#32189).
Go MAEDA [Thu, 3 Oct 2019 13:36:18 +0000 (13:36 +0000)]
Remove unnecessary requiring of "rexml/document" (#32189).

git-svn-id: http://svn.redmine.org/redmine/trunk@18588 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRounded corners on table.cal (#32165).
Go MAEDA [Thu, 3 Oct 2019 12:09:25 +0000 (12:09 +0000)]
Rounded corners on table.cal (#32165).

Patch by Antonio McDeal.

git-svn-id: http://svn.redmine.org/redmine/trunk@18587 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUse Redmine::MimeType.of instead of regexp to check if the attachment is Textile...
Go MAEDA [Thu, 3 Oct 2019 09:30:43 +0000 (09:30 +0000)]
Use Redmine::MimeType.of instead of regexp to check if the attachment is Textile (#29752).

git-svn-id: http://svn.redmine.org/redmine/trunk@18586 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd styles for Textile/Markdown attachments preview (#29752).
Go MAEDA [Thu, 3 Oct 2019 00:32:33 +0000 (00:32 +0000)]
Add styles for Textile/Markdown attachments preview (#29752).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18585 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRender Textile and Markdown attachments on the preview page (#29752).
Go MAEDA [Thu, 3 Oct 2019 00:09:28 +0000 (00:09 +0000)]
Render Textile and Markdown attachments on the preview page (#29752).

Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@18584 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRuboCop: Disable Layout/SpaceInsideHashLiteralBraces
Go MAEDA [Thu, 3 Oct 2019 00:08:02 +0000 (00:08 +0000)]
RuboCop: Disable Layout/SpaceInsideHashLiteralBraces

git-svn-id: http://svn.redmine.org/redmine/trunk@18583 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoCode cleanup: RuboCop: Fix Performance/Count and Performance/Detect.
Go MAEDA [Wed, 2 Oct 2019 00:53:11 +0000 (00:53 +0000)]
Code cleanup: RuboCop: Fix Performance/Count and Performance/Detect.

This change corrects newly detected offenses after updating rubocop-performance to 1.5.0 in r18579.

git-svn-id: http://svn.redmine.org/redmine/trunk@18580 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate rubocop-performance to 1.5.0 (#31509).
Go MAEDA [Wed, 2 Oct 2019 00:27:19 +0000 (00:27 +0000)]
Update rubocop-performance to 1.5.0 (#31509).

git-svn-id: http://svn.redmine.org/redmine/trunk@18579 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix Redmine::Themes#scan_themes is not private
Toshi MARUYAMA [Tue, 1 Oct 2019 05:07:27 +0000 (05:07 +0000)]
fix Redmine::Themes#scan_themes is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18578 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix Watcher#prune_single_user is not private
Toshi MARUYAMA [Tue, 1 Oct 2019 05:07:16 +0000 (05:07 +0000)]
fix Watcher#prune_single_user is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18577 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate RuboCop to 0.75.0 (#31509).
Go MAEDA [Tue, 1 Oct 2019 03:18:39 +0000 (03:18 +0000)]
Update RuboCop to 0.75.0 (#31509).

git-svn-id: http://svn.redmine.org/redmine/trunk@18576 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix wrong markup in public/help/ja/wiki_syntax_detailed_(markdown|textile).html ...
Go MAEDA [Mon, 30 Sep 2019 13:31:26 +0000 (13:31 +0000)]
Fix wrong markup in public/help/ja/wiki_syntax_detailed_(markdown|textile).html (#32169).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18572 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd links to the detailed Wiki formatting help in Quick Reference (#32169).
Go MAEDA [Mon, 30 Sep 2019 13:28:50 +0000 (13:28 +0000)]
Add links to the detailed Wiki formatting help in Quick Reference (#32169).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18571 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd support for "start with" and "end with" operators to "Files" filter (#31879).
Go MAEDA [Mon, 30 Sep 2019 13:15:45 +0000 (13:15 +0000)]
Add support for "start with" and "end with" operators to "Files" filter (#31879).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18570 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_su...
Toshi MARUYAMA [Mon, 30 Sep 2019 12:47:52 +0000 (12:47 +0000)]
fix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_subtasks

git-svn-id: http://svn.redmine.org/redmine/trunk@18569 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/models/issue.rb from Layout/ElseAlignment fixed by previous revisions
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:59 +0000 (11:42 +0000)]
rubocop: remove app/models/issue.rb from Layout/ElseAlignment fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18568 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:48 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours method

git-svn-id: http://svn.redmine.org/redmine/trunk@18567 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:36 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method

git-svn-id: http://svn.redmine.org/redmine/trunk@18566 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:26 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition method

git-svn-id: http://svn.redmine.org/redmine/trunk@18565 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_hel...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:15 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18564 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/integration/api_test/issues_test.rb from Layout/IndentationConsi...
Toshi MARUYAMA [Mon, 30 Sep 2019 10:59:13 +0000 (10:59 +0000)]
rubocop: remove test/integration/api_test/issues_test.rb from Layout/IndentationConsistency fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18563 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/issues_t...
Toshi MARUYAMA [Mon, 30 Sep 2019 10:59:01 +0000 (10:59 +0000)]
code cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18562 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_t...
Toshi MARUYAMA [Mon, 30 Sep 2019 10:58:50 +0000 (10:58 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18561 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/models/attachment.rb from Layout/EmptyLineBetweenDefs fixed by...
Toshi MARUYAMA [Mon, 30 Sep 2019 10:58:39 +0000 (10:58 +0000)]
rubocop: remove app/models/attachment.rb from Layout/EmptyLineBetweenDefs fixed by r18558

git-svn-id: http://svn.redmine.org/redmine/trunk@18560 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb
Toshi MARUYAMA [Mon, 30 Sep 2019 09:00:06 +0000 (09:00 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18559 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/attachment.rb
Toshi MARUYAMA [Mon, 30 Sep 2019 08:59:54 +0000 (08:59 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/attachment.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18558 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/helpers/applicatio...
Toshi MARUYAMA [Mon, 30 Sep 2019 08:59:43 +0000 (08:59 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/helpers/application_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18557 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb
Toshi MARUYAMA [Mon, 30 Sep 2019 08:59:26 +0000 (08:59 +0000)]
code cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18556 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/unit/changeset_te...
Toshi MARUYAMA [Mon, 30 Sep 2019 08:59:14 +0000 (08:59 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/unit/changeset_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18555 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/issue_test.rb
Toshi MARUYAMA [Mon, 30 Sep 2019 02:44:32 +0000 (02:44 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18554 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/api_test...
Toshi MARUYAMA [Mon, 30 Sep 2019 02:44:21 +0000 (02:44 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/api_test/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18553 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoadd test "removing issue shows confirm dialog"
Toshi MARUYAMA [Mon, 30 Sep 2019 02:23:14 +0000 (02:23 +0000)]
add test "removing issue shows confirm dialog"

git-svn-id: http://svn.redmine.org/redmine/trunk@18552 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoremove extra space from app/views/issues/_edit.html.erb
Toshi MARUYAMA [Mon, 30 Sep 2019 02:23:03 +0000 (02:23 +0000)]
remove extra space from app/views/issues/_edit.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@18551 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoText enclosed in pre tag in Wiki formatting reference is not displayed in a monospace...
Go MAEDA [Mon, 30 Sep 2019 00:28:47 +0000 (00:28 +0000)]
Text enclosed in pre tag in Wiki formatting reference is not displayed in a monospaced font in Chrome (#32170).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18550 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUnify fields of subtasks and related issues on issue page (#25540).
Go MAEDA [Sun, 29 Sep 2019 00:03:34 +0000 (00:03 +0000)]
Unify fields of subtasks and related issues on issue page (#25540).

Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@18549 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoMake the disabled fields more obvious (#31147).
Go MAEDA [Sat, 28 Sep 2019 23:50:10 +0000 (23:50 +0000)]
Make the disabled fields more obvious (#31147).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18548 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRounded corners on table.list elements (#32014).
Go MAEDA [Sat, 28 Sep 2019 00:06:52 +0000 (00:06 +0000)]
Rounded corners on table.list elements (#32014).

Patch by Antonio McDeal.

git-svn-id: http://svn.redmine.org/redmine/trunk@18547 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoMove the links (All time entries, Import) from Spent time section of the spent time...
Go MAEDA [Fri, 27 Sep 2019 09:38:33 +0000 (09:38 +0000)]
Move the links (All time entries, Import) from Spent time section of the spent time list sidebar under a dropdown (#31598).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18546 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd "Highlighted code" section in Wiki Syntax Quick Reference (#32123).
Go MAEDA [Fri, 27 Sep 2019 01:30:56 +0000 (01:30 +0000)]
Add "Highlighted code" section in Wiki Syntax Quick Reference (#32123).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18545 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoIncoming emails may cause "invalid byte sequence" error depending on the default...
Go MAEDA [Thu, 26 Sep 2019 13:01:01 +0000 (13:01 +0000)]
Incoming emails may cause "invalid byte sequence" error depending on the default external encoding, due to r18317 (#31549).

git-svn-id: http://svn.redmine.org/redmine/trunk@18544 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't set border-radius for the items in the dropdown menu (#32013).
Go MAEDA [Thu, 26 Sep 2019 09:37:05 +0000 (09:37 +0000)]
Don't set border-radius for the items in the dropdown menu (#32013).

Patch by Bernhard Rohloff.

git-svn-id: http://svn.redmine.org/redmine/trunk@18543 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoBulgarian translation update (#32147).
Go MAEDA [Thu, 26 Sep 2019 06:53:46 +0000 (06:53 +0000)]
Bulgarian translation update (#32147).

Patch by Ivan Cenov.

git-svn-id: http://svn.redmine.org/redmine/trunk@18542 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoJapanese translation update (#32144).
Go MAEDA [Thu, 26 Sep 2019 03:44:24 +0000 (03:44 +0000)]
Japanese translation update (#32144).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18541 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTraditional Chinese translation update (#32143).
Go MAEDA [Thu, 26 Sep 2019 03:20:15 +0000 (03:20 +0000)]
Traditional Chinese translation update (#32143).

Patch by ChunChang Lo.

git-svn-id: http://svn.redmine.org/redmine/trunk@18540 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agosvn propdel svn:executable app/models/mail_handler.rb
Toshi MARUYAMA [Thu, 26 Sep 2019 02:38:50 +0000 (02:38 +0000)]
svn propdel svn:executable app/models/mail_handler.rb

It was added by r16609 accidentally.

git-svn-id: http://svn.redmine.org/redmine/trunk@18539 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in test/integration/api_t...
Toshi MARUYAMA [Wed, 25 Sep 2019 17:55:26 +0000 (17:55 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in test/integration/api_test/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18538 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/unit/issue_test.rb
Toshi MARUYAMA [Wed, 25 Sep 2019 17:55:14 +0000 (17:55 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18537 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agodetect Chrome downloaded file more strictly
Toshi MARUYAMA [Wed, 25 Sep 2019 17:30:07 +0000 (17:30 +0000)]
detect Chrome downloaded file more strictly

git-svn-id: http://svn.redmine.org/redmine/trunk@18536 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate locales (#31879).
Go MAEDA [Wed, 25 Sep 2019 16:31:06 +0000 (16:31 +0000)]
Update locales (#31879).

git-svn-id: http://svn.redmine.org/redmine/trunk@18535 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years ago"starts with" and "ends with" filter operators for string values (#31879).
Go MAEDA [Wed, 25 Sep 2019 16:24:08 +0000 (16:24 +0000)]
"starts with" and "ends with" filter operators for string values (#31879).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18534 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in test/application_system_test_c...
Toshi MARUYAMA [Wed, 25 Sep 2019 14:12:18 +0000 (14:12 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in test/application_system_test_case.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18533 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agodetect strictly Chrome downloaded file
Toshi MARUYAMA [Wed, 25 Sep 2019 13:24:20 +0000 (13:24 +0000)]
detect strictly Chrome downloaded file

git-svn-id: http://svn.redmine.org/redmine/trunk@18532 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agodo not delete Chrome downloaded files on Linux
Toshi MARUYAMA [Wed, 25 Sep 2019 13:14:05 +0000 (13:14 +0000)]
do not delete Chrome downloaded files on Linux

https://github.com/SeleniumHQ/selenium/issues/5292

git-svn-id: http://svn.redmine.org/redmine/trunk@18531 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoworkaround Chrome default_directory ignored on Linux
Toshi MARUYAMA [Wed, 25 Sep 2019 12:31:40 +0000 (12:31 +0000)]
workaround Chrome default_directory ignored on Linux

https://github.com/SeleniumHQ/selenium/issues/5292

git-svn-id: http://svn.redmine.org/redmine/trunk@18530 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/TrailingCommaInArguments in test/unit/issue_test.rb
Toshi MARUYAMA [Wed, 25 Sep 2019 11:18:59 +0000 (11:18 +0000)]
code cleanup: rubocop: fix Style/TrailingCommaInArguments in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18529 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove config/initializers/30-redmine.rb from Style/MultilineTernaryOperator...
Toshi MARUYAMA [Wed, 25 Sep 2019 11:18:48 +0000 (11:18 +0000)]
rubocop: remove config/initializers/30-redmine.rb from Style/MultilineTernaryOperator fixed by r18521

git-svn-id: http://svn.redmine.org/redmine/trunk@18528 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoinput[type="number"] should be highlighted as well when it has focus (#31971).
Go MAEDA [Wed, 25 Sep 2019 07:36:34 +0000 (07:36 +0000)]
input[type="number"] should be highlighted as well when it has focus (#31971).

git-svn-id: http://svn.redmine.org/redmine/trunk@18527 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Naming/AccessorMethodName
Toshi MARUYAMA [Wed, 25 Sep 2019 04:35:40 +0000 (04:35 +0000)]
rubocop: disable Naming/AccessorMethodName

git-svn-id: http://svn.redmine.org/redmine/trunk@18526 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Lint/IneffectiveAccessModifier
Toshi MARUYAMA [Wed, 25 Sep 2019 04:35:29 +0000 (04:35 +0000)]
rubocop: disable Lint/IneffectiveAccessModifier

git-svn-id: http://svn.redmine.org/redmine/trunk@18525 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoHighlight the input field that has focus by setting border-color (#31971).
Go MAEDA [Wed, 25 Sep 2019 01:48:20 +0000 (01:48 +0000)]
Highlight the input field that has focus by setting border-color (#31971).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18524 e93f8b46-1217-0410-a6f0-8f06a7374b81