]> source.dussan.org Git - vaadin-framework.git/log
vaadin-framework.git
8 years agoFix ListDataSource implementation firing empty remove events
Teemu Suo-Anttila [Fri, 5 Feb 2016 15:44:19 +0000 (17:44 +0200)]
Fix ListDataSource implementation firing empty remove events

Change-Id: I43e0149ddc11aa05b33b299465eb4dbce83ec534

8 years agoRemove unnecessary size parameter from data reset in simple mode
Teemu Suo-Anttila [Fri, 5 Feb 2016 15:43:24 +0000 (17:43 +0200)]
Remove unnecessary size parameter from data reset in simple mode

Change-Id: I861cf9ed99637cd74ecb2f65705a2c7717afbd08

8 years agoRefactor DataSource from SimpleDataProvider to super class
Teemu Suo-Anttila [Fri, 5 Feb 2016 15:40:39 +0000 (17:40 +0200)]
Refactor DataSource from SimpleDataProvider to super class

Change-Id: I4fcb1dcb2a7d4369e68bc2abc0c1168ad21c8201

8 years agoFix TypedDataGenerator removal from DataProvider
Teemu Suo-Anttila [Fri, 5 Feb 2016 15:30:56 +0000 (17:30 +0200)]
Fix TypedDataGenerator removal from DataProvider

Change-Id: Iadc8d58d790a6b42ab96bded68009191736705d7

8 years agoFix key and active data mapping when adding a data object
Teemu Suo-Anttila [Thu, 4 Feb 2016 13:45:40 +0000 (15:45 +0200)]
Fix key and active data mapping when adding a data object

Change-Id: Ibfaf4b62673c008b94e039deb77f6f6d73d83753

8 years agoIntroduce DataSource API and DataChangeHandler for it
Teemu Suo-Anttila [Thu, 4 Feb 2016 13:30:31 +0000 (15:30 +0200)]
Introduce DataSource API and DataChangeHandler for it

Change-Id: I3b24bca46ffc136884e163c94f3f4c304c1e12b2

8 years agoFix SimpleDataProvider clean up and client-side data tracking on edit
Teemu Suo-Anttila [Wed, 3 Feb 2016 11:55:00 +0000 (13:55 +0200)]
Fix SimpleDataProvider clean up and client-side data tracking on edit

Change-Id: I9807717df9cbae47c6532e43a58dd6bb693eaa85

8 years agoSplit SimpleDataProvider from DataProvider super class
Teemu Suo-Anttila [Tue, 2 Feb 2016 16:55:36 +0000 (18:55 +0200)]
Split SimpleDataProvider from DataProvider super class

Change-Id: Ib486553fa2f0f9d17de9012413b2647b73c07822

8 years agoAdd simple data update support to DataProvider
Teemu Suo-Anttila [Tue, 2 Feb 2016 10:46:56 +0000 (12:46 +0200)]
Add simple data update support to DataProvider

This patch adds the option of updating an existing data object. Update
is done on the next client response to catch any possible changes before
and after the update is initiated.

Change-Id: I30ca4803dd7c47befcb8e5ae761860c09cbdb8bd

8 years agoAdd simple support for generic reset for data to DataProvider
Teemu Suo-Anttila [Tue, 2 Feb 2016 09:23:58 +0000 (11:23 +0200)]
Add simple support for generic reset for data to DataProvider

Adds a simple test that sorts the data and verifies that the content
does not actually change with just sorting.

Change-Id: I0d8889694a98da1d55e0335714f63abaedb5684a

8 years agoUse key mapping to keep track of data on the client-side
Teemu Suo-Anttila [Mon, 1 Feb 2016 15:44:56 +0000 (17:44 +0200)]
Use key mapping to keep track of data on the client-side

This method fixes data removing to be based on the key mapping instead
of data content. Also the data clean up is now properly called when
dropping data objects.

Change-Id: I76a917968026f6c3b2693b52848448de92145fb1

8 years agoAdd DataKeyMapper to correctly keep track of active data
Teemu Suo-Anttila [Mon, 1 Feb 2016 15:34:18 +0000 (17:34 +0200)]
Add DataKeyMapper to correctly keep track of active data

Added a simple test that checks transported data correctness. Also
provides clean up method to TypedDataGenerator, even though it's not
called actually yet.

Change-Id: Icef69790732922b63a9874c9b1a6b44d4d682887

8 years agoAdd simple data add/remove support to DataProvider
Teemu Suo-Anttila [Fri, 29 Jan 2016 13:51:33 +0000 (15:51 +0200)]
Add simple data add/remove support to DataProvider

Removal is currently based on the content of the object. Multiple
objects with same content will cause problems. This should be fixed by
adding a simple key mapping for objects.

Change-Id: Ie6fd1c6bcb7e8eaa73469f8f794f5365b1590fe2

8 years agoImplement TypedDataGenerator support and clean up client-side code
Teemu Suo-Anttila [Fri, 29 Jan 2016 13:06:48 +0000 (15:06 +0200)]
Implement TypedDataGenerator support and clean up client-side code

Change-Id: I96080e2344ca0626940635dde77f2715c9d62c7b

8 years agoAdd data communication for DataProvider for Collections
Teemu Suo-Anttila [Fri, 29 Jan 2016 12:49:20 +0000 (14:49 +0200)]
Add data communication for DataProvider for Collections

After this patch, the object is passed to the client-side as a
JsonObject containing a key "k" with value from object.toString()

Change-Id: I3f83144a6c84dda9812739ff2f2cb74cb5577d5c

8 years agoAdd a dummy DataProvider for Collections
Teemu Suo-Anttila [Fri, 29 Jan 2016 12:20:01 +0000 (14:20 +0200)]
Add a dummy DataProvider for Collections

Change-Id: I190e807094d8e235797e618ea80cb4b7136d1111

8 years agoSupport non-indexed containers in RpcDataProvider (#19266)
Teemu Suo-Anttila [Wed, 18 Nov 2015 11:53:03 +0000 (12:53 +0100)]
Support non-indexed containers in RpcDataProvider (#19266)

Any other type of container is supported by getting all the item ids and
finding out the part we need to send to the client. This is not optimal,
but should work.

Change-Id: I02f05f31beddf506fc47a64bc21c98d142e809e0

8 years agoMake RpcDataProviderExtension more generic (#19266)
Teemu Suo-Anttila [Wed, 18 Nov 2015 11:35:05 +0000 (12:35 +0100)]
Make RpcDataProviderExtension more generic (#19266)

Change-Id: I3099f2568b70670248983f735aa6cbac46238b34

8 years agoMinor ComboBox client side cleanup (#19929)
Henri Sara [Thu, 12 Nov 2015 10:46:11 +0000 (12:46 +0200)]
Minor ComboBox client side cleanup (#19929)

Remove unused references to immediate flags.

Change-Id: I780fcf44f9824a132acb35d37d40d8c969d4f0f3

8 years agoMove combo box selection update logic to handler (#19929)
Henri Sara [Wed, 11 Nov 2015 10:27:03 +0000 (12:27 +0200)]
Move combo box selection update logic to handler (#19929)

Move logic related to updating the selection to the handler and
VFilterSelect.

Change-Id: I537d3cd23a3e990de1be578a506029c930c55da7

8 years agoMove more combo logic to handler (#19929)
Henri Sara [Wed, 11 Nov 2015 09:17:57 +0000 (11:17 +0200)]
Move more combo logic to handler (#19929)

- Move waitingForFilteringResponse etc. to the data received
handler.
- Change some setters to parameterless methods that trigger a
state transition.

Change-Id: Ifb92207853d4ec76db846945f69a426c885562ed

8 years agoUse a separate data received handler in VFilterSelect (#19929)
Henri Sara [Wed, 11 Nov 2015 08:50:11 +0000 (10:50 +0200)]
Use a separate data received handler in VFilterSelect (#19929)

Move parts of the request handling to a separate handler
class that keeps track of the current communication state etc.

This is an intermediate change. Later changes should move
waitingForFilteringResponse etc. to the handler.

Change-Id: I762d15cc4b54ead3003e6d9d913e2a975256644c

8 years agoMove combo popup opener clicked flag to connector (#19929)
Henri Sara [Tue, 10 Nov 2015 12:42:41 +0000 (14:42 +0200)]
Move combo popup opener clicked flag to connector (#19929)

The flag is only used by the connector to temporarily block
certain operations.

Change-Id: I90cabcb26d938a6db342ff549ac2e4b8d8998aeb

8 years agoRefactor ComboBox pending selection handling (#19929)
Henri Sara [Tue, 10 Nov 2015 12:28:12 +0000 (14:28 +0200)]
Refactor ComboBox pending selection handling (#19929)

Move the handling of selection when a navigation operation
pends on server reply to the connector, with a callback
that actually performs the selection.

Change-Id: I3fa95cda6d7e02ce5aa4140ed341b2d1ba74abfc

8 years agoUse accessors for combo internal state (#19929)
Henri Sara [Tue, 10 Nov 2015 11:44:33 +0000 (13:44 +0200)]
Use accessors for combo internal state (#19929)

This is an intermediate step towards refactoring the
communication related client side internal state management.

Change-Id: I31ba382fb195b7b7c80de35f464db2510ecd9515

8 years agoRemove obsolete code (#19929)
Henri Sara [Tue, 10 Nov 2015 08:31:12 +0000 (10:31 +0200)]
Remove obsolete code (#19929)

A previous change left a few obsolete lines related to
pageLength in ComboBoxConnector.updateFromUIDL().
Those are removed here.

Change-Id: I4c2d151afbb1acf604e4c24ed320b12ce5632b1f

8 years agoRemove UIDL references in VFilterSelect (#19929)
Henri Sara [Mon, 9 Nov 2015 13:00:50 +0000 (15:00 +0200)]
Remove UIDL references in VFilterSelect (#19929)

Change-Id: I403ca3a62e04c03594608fd5d75a97991f7dda3d

8 years agoRefactor ComboBox item painting (#19929)
Henri Sara [Mon, 9 Nov 2015 12:52:46 +0000 (14:52 +0200)]
Refactor ComboBox item painting (#19929)

This is an intermediate step towards a different approach
to sending items from server to client.

An unused null selection item attribute was removed, as the
information is currently communicated outside the item.

Change-Id: I9c08d627bcf48fd42793595795aeb3ac49c2fef6

8 years agoRequest ComboBox pages with RPC (#19929)
Henri Sara [Mon, 9 Nov 2015 10:58:52 +0000 (12:58 +0200)]
Request ComboBox pages with RPC (#19929)

All client to server communication of ComboBox is now done
with RPC.

There is still an empty changeVariables() methods to
override the default behavior in AbstractSelect.

Change-Id: Ic11ea48cac1846272609f6e4107bb0006d18494c

8 years agoMove ComboBox filtering mode to state (#19929)
Henri Sara [Mon, 9 Nov 2015 10:42:25 +0000 (12:42 +0200)]
Move ComboBox filtering mode to state (#19929)

Change-Id: Ida38de55e1fc06aa6ec5e693f34cd5bc14ac4fc5

8 years agoMove ComboBox pageLength to state (#19929)
Henri Sara [Mon, 9 Nov 2015 10:33:07 +0000 (12:33 +0200)]
Move ComboBox pageLength to state (#19929)

Use shared state for the page length and update related tests.
This change also removes an unused widget field.

Change-Id: Id8719661121a9570be40028da09e32f27bec82b5

8 years agoSend ComboBox selection with RPC (#19929)
Henri Sara [Fri, 6 Nov 2015 08:54:10 +0000 (10:54 +0200)]
Send ComboBox selection with RPC (#19929)

Send the selection from the client to the server with RPC.

Change-Id: Ic32d869c3dc2a8806f9c7cfd1f3db8263a5379a9

8 years agoSend ComboBox focus/blur with RPC (#19929)
Henri Sara [Thu, 5 Nov 2015 11:29:15 +0000 (13:29 +0200)]
Send ComboBox focus/blur with RPC (#19929)

Send focus and blur events using RPC instead of in UIDL.
This change does not use ConnectorFocusAndBlurHandler to preserve
old timings.

Change-Id: I1d58756e3955a11864b1ef00abcd27525a4db593

8 years agoCreate new items with RPC (#19929)
Henri Sara [Thu, 5 Nov 2015 11:06:20 +0000 (13:06 +0200)]
Create new items with RPC (#19929)

When the user creates a new item, send it with client to
server RPC.

Change-Id: I1b92073dc2791911e4916d17f749dc1f35e54bca

8 years agoMove ComboBox communication to connector (#19929)
Henri Sara [Thu, 5 Nov 2015 10:49:44 +0000 (12:49 +0200)]
Move ComboBox communication to connector (#19929)

This change extracts the client to server communication
methods of VFilterSelect and moves them to the connector.

Change-Id: I07f61abeda503de5d63e332d8ead10cf312115ba

8 years agoCreate ComboBoxServerRpc stub (#19229)
Henri Sara [Thu, 5 Nov 2015 09:16:55 +0000 (11:16 +0200)]
Create ComboBoxServerRpc stub (#19229)

Create an empty client to server RPC implementation for ComboBox.

Change-Id: I348208fefb267765814383559e55866bc0933e4b

8 years agoUse shared state in ComboBox (#19229)
Henri Sara [Thu, 5 Nov 2015 08:51:56 +0000 (10:51 +0200)]
Use shared state in ComboBox (#19229)

This change uses shared state for the read-only flag, text
input allowed flag and input prompt.

Change-Id: I3bdc6843288c5309311461a3d036293d79004e22

8 years agoClean up SingleSelectionModel client-side on data source change (#19469)
Teemu Suo-Anttila [Wed, 13 Jan 2016 15:26:50 +0000 (17:26 +0200)]
Clean up SingleSelectionModel client-side on data source change (#19469)

Change-Id: Ie0044341725b858e5cbae150da757aba878fc9ed

8 years agoFix demo and archetype build scripts to deploy all wars at once
Teemu Suo-Anttila [Wed, 13 Jan 2016 10:01:40 +0000 (12:01 +0200)]
Fix demo and archetype build scripts to deploy all wars at once

Change-Id: I5ddf43d0c895404abf2139c847ac805ef08452c8

8 years agoAdd clarifying comment to CustomDetailsGenerator
Teemu Suo-Anttila [Tue, 12 Jan 2016 15:29:44 +0000 (17:29 +0200)]
Add clarifying comment to CustomDetailsGenerator

Change-Id: I9e6668b1fbc0a956bf34b48b75df59279005d097

8 years agoAdd missing @since for 7.6.1
Teemu Suo-Anttila [Tue, 12 Jan 2016 15:27:49 +0000 (17:27 +0200)]
Add missing @since for 7.6.1

Change-Id: Ic28598e561f0fc325b6f74ace3398d46ba996fb5

8 years agoUse LayoutManager for details rows (#18821, #18619)
Leif Åstrand [Mon, 30 Nov 2015 12:38:25 +0000 (14:38 +0200)]
Use LayoutManager for details rows (#18821, #18619)

Change-Id: I430e55db8a3e2860f68f5351e06d8d069a657d6e

8 years agoAdd a simple waitForApplication for servlet integration tests
Teemu Suo-Anttila [Tue, 12 Jan 2016 11:36:02 +0000 (13:36 +0200)]
Add a simple waitForApplication for servlet integration tests

This waitForApplication checks if an UI element exists on the page. If
not, then it will wait 10 seconds in order for it to appear. This should
reduce the amount of false negatives in server tests.

Change-Id: I37a398e60c247920fd56fc05b747e0f93f3f2dd2

8 years agoSplit VOverlay functionality to a new base class (#19347)
Teemu Suo-Anttila [Thu, 7 Jan 2016 15:20:13 +0000 (17:20 +0200)]
Split VOverlay functionality to a new base class (#19347)

This fixes the missing z-index for the Grid popup.

Change-Id: I5474fe653ad4ece38e9bc3cb2331a1d2190ea898

8 years agocheckstyle configuration contains invalid module RedundantThrows (#18941)
Andreas Höhmann [Sun, 20 Sep 2015 15:39:53 +0000 (17:39 +0200)]
checkstyle configuration contains invalid module RedundantThrows (#18941)

just removed module "RedundantThrows" from vaadin-checkstyle.xml
Change-Id: Id12fbf5b052c9b08aaf834f5bbdfbc9d24f287a7

8 years agoUse simple date format for BasicCrudGridEditorRow test UI
Teemu Suo-Anttila [Fri, 8 Jan 2016 14:23:32 +0000 (16:23 +0200)]
Use simple date format for BasicCrudGridEditorRow test UI

This patch also forces locales to US for all the date formats to avoid
issues on different default locales.

Change-Id: I7445f4ff1a25d83ab9dbb0633caefcea56d50acc

8 years agoConvert ComboBoxItemIcon test to TB4
Henri Sara [Fri, 8 Jan 2016 12:03:37 +0000 (14:03 +0200)]
Convert ComboBoxItemIcon test to TB4

Change-Id: I939fe7e5c5b57c007a543f5f7c491c8c9f11e773

8 years agoConvert TableContextMenuAndIcons test to TB4
Henri Sara [Fri, 8 Jan 2016 12:48:03 +0000 (14:48 +0200)]
Convert TableContextMenuAndIcons test to TB4

Change-Id: I510617c5cd728a3bf0b27d706e11c6c3f12ee19e

8 years agoFix ScrollbarBundle to not round down pixel values (#19421)
Teemu Suo-Anttila [Thu, 7 Jan 2016 13:45:26 +0000 (15:45 +0200)]
Fix ScrollbarBundle to not round down pixel values (#19421)

Since Escalator now uses subpixels in most cases, scrollbar calculation
fails when ScrollbarBundle calls Math.floor for the offset size. Removed
rounding, added a pixel epsilon check that we don't make a scrollbar
when it's not really needed.

Change-Id: I228fd7dd48d4506e5b2b7bb799291c9a122ea3fe

8 years agoFix DateFormat for Editor tests as well
Teemu Suo-Anttila [Thu, 7 Jan 2016 15:46:56 +0000 (17:46 +0200)]
Fix DateFormat for Editor tests as well

Change-Id: Ice7b77ab1bcb1cdecd50fc8e480c1ca2f8dae26c

8 years agoFix GridThemeUI to use more stable date format
Teemu Suo-Anttila [Thu, 7 Jan 2016 12:47:56 +0000 (14:47 +0200)]
Fix GridThemeUI to use more stable date format

Change-Id: I94099919f68d3ffeb340bed30d9066e0911d53cf

8 years agoAlways stick Grid column resize handle to the right edge (#19409)
Johannes Dahlström [Mon, 4 Jan 2016 13:05:59 +0000 (15:05 +0200)]
Always stick Grid column resize handle to the right edge (#19409)

Change-Id: I329bc5ae8138be731770211e995225cb3ca4fc76

8 years agoSupport non-AbstractFieldConnector fields with Grid Editor (#19440)
Teemu Suo-Anttila [Tue, 5 Jan 2016 14:26:22 +0000 (16:26 +0200)]
Support non-AbstractFieldConnector fields with Grid Editor (#19440)

Change-Id: Ib3eaf0b35cfe88391c8ab3b5fcbe668d67c2dd3c

8 years agoAlways set header/footer style name to TH (#19209)
Artur Signell [Wed, 30 Dec 2015 08:51:38 +0000 (10:51 +0200)]
Always set header/footer style name to TH (#19209)

Change-Id: I8d0240fb76b9841e7290bf13588975da20c78b62

8 years agoConnectorHierarchyChangeEvent.getParent() should return the connector (#18525)
Artur Signell [Mon, 3 Aug 2015 11:09:24 +0000 (14:09 +0300)]
ConnectorHierarchyChangeEvent.getParent() should return the connector (#18525)

Change-Id: Ifd2151a76ff77127170f2d95a800dfb7d601a7d3

8 years agoFixes exception when enter is pressed and there is nothing to select (#19149)
Artur Signell [Fri, 1 Jan 2016 10:02:06 +0000 (12:02 +0200)]
Fixes exception when enter is pressed and there is nothing to select (#19149)

Change-Id: I8ff11e98bb4ec999d369ff5bcde0cb95290ed037

8 years agoAdd a client-side connector for DetailsComponentManager (#19412)
Teemu Suo-Anttila [Tue, 22 Dec 2015 12:30:11 +0000 (14:30 +0200)]
Add a client-side connector for DetailsComponentManager (#19412)

Change-Id: Ibc4d35a8f729b670d8712743c9da8d608a0ba952

8 years agoFix NPE in Label.writeDesign with NULL values #19434
John Ahlroos [Mon, 4 Jan 2016 12:42:05 +0000 (14:42 +0200)]
Fix NPE in Label.writeDesign with NULL values #19434

Change-Id: If3628bc655d6cd58ab51b7400af808bdbca3dc91

8 years agoMake GeneratedPropertyItem addItem return null when appropriate (#18685)
Artur Signell [Wed, 30 Dec 2015 06:13:26 +0000 (08:13 +0200)]
Make GeneratedPropertyItem addItem return null when appropriate (#18685)

Change-Id: I08f05bee9bf0c82f5767c63654046285c85f233a

8 years agoEnsure no unknown attribute warnings are logged in design tests (#19429)
Artur Signell [Sat, 2 Jan 2016 12:48:55 +0000 (14:48 +0200)]
Ensure no unknown attribute warnings are logged in design tests (#19429)

* Adds missing custom attributes to Slider/AbstractEmbedded

Change-Id: I574caf3499ab0681a7c829f89164062eb725013f

8 years agoListen to body for shortcut actions for standalone apps (#19392)
Artur Signell [Fri, 1 Jan 2016 09:53:42 +0000 (11:53 +0200)]
Listen to body for shortcut actions for standalone apps (#19392)

Change-Id: I48cc4884fce984354dafa2096e488c3c6dec141c

8 years agoFix custom attributes of Link component (#19107)
maxschuster [Sun, 11 Oct 2015 18:48:52 +0000 (20:48 +0200)]
Fix custom attributes of Link component (#19107)

Added the custom attributes href and target to the Link component to
match the attribute names used by Link.readDesign() and
Link.writeDesign()
Change-Id: I7f257fcf89cb78d14d9632aa1be548e92f3010c3

8 years agoInclude correct type and parameter info in exception (#19064)
Artur Signell [Sat, 10 Oct 2015 16:48:42 +0000 (19:48 +0300)]
Include correct type and parameter info in exception (#19064)

Change-Id: Ic08bfa69bc0c4cb42ecbb1d53ab712e75075ee10

8 years agoMake GeneratedPropertyItem equals self (#19426)
Artur Signell [Wed, 30 Dec 2015 05:56:33 +0000 (07:56 +0200)]
Make GeneratedPropertyItem equals self (#19426)

Change-Id: Ieccb53a402dd6669fb684b0ef8e18e4c8778c58e

8 years agoMake GeneratedPropertyContainer.getItem(nonExistant) return null (#19425)
Artur Signell [Wed, 30 Dec 2015 05:49:10 +0000 (07:49 +0200)]
Make GeneratedPropertyContainer.getItem(nonExistant) return null (#19425)

Change-Id: I41e40b87b64aec046428c1294aa1d488b6daf693

8 years agoMake test succeed in Eclipse
Artur Signell [Sat, 2 Jan 2016 12:54:33 +0000 (14:54 +0200)]
Make test succeed in Eclipse

Change-Id: I1f8afb25e40c4c963092730b479303e345a732a2

8 years agoRevert changes which were previously reverted from only 7.5 (#19424)
Teemu Suo-Anttila [Tue, 21 Jul 2015 11:00:03 +0000 (14:00 +0300)]
Revert changes which were previously reverted from only 7.5 (#19424)

Revert "Take Window special case into account for invalid layouts (#17598)"

This reverts commit abc1c5dff6438d65e53473b69ae9a3ca2b8e60e1.

Revert "Render nested invalid layouts correctly (#17598)"

This reverts commit ac4e85f4e35a57d1ba6e6f3448744cbb0c2df60f.

Added test to ensure a similar problem is not reintroduced later

Change-Id: I892896e953637d793d0c0a788f28f3b61494d441

8 years agoUpdate to Font Awesome 4.5.0
Artur Signell [Thu, 3 Dec 2015 11:55:23 +0000 (13:55 +0200)]
Update to Font Awesome 4.5.0

Change-Id: Ied7437e43dee81671c6b36dd7f860cf9bdf7fb68

8 years agoAdd keyboard shortcut to save grid editor in buffered mode (#16842)
Teemu Suo-Anttila [Mon, 28 Dec 2015 12:15:50 +0000 (14:15 +0200)]
Add keyboard shortcut to save grid editor in buffered mode (#16842)

Change-Id: I4f542d166e15a63f12f8033aec4ef7b95578df71

8 years agoFix typo in release notes
Henri Sara [Wed, 23 Dec 2015 11:22:43 +0000 (13:22 +0200)]
Fix typo in release notes

Change-Id: I4c49cf6d744fdc7792a5448f94df58eab3847343

8 years agoFix WidgetRenderer column cells not correctly init on change (#19086)
Teemu Suo-Anttila [Tue, 1 Dec 2015 11:54:29 +0000 (13:54 +0200)]
Fix WidgetRenderer column cells not correctly init on change (#19086)

When changing to a widget renderer with an existing column, the widget
renderer expects that the cells would be initialized to have a correct
widget for it. Because of original design where you could not change
renderers, this was not taken into account and cells did not get
reinitialized when changing the renderer.

This patch showed another underlying detach problem from removing a
widget renderer and destroying complex renderers. These both are also
addressed to make this bug possible to test correctly.

Patch includes a client-side test that verifies the integrity of the
renderer state in different stages of its lifecycle.

Change-Id: I67330e5d07c95047cb69040e8355a17dc8a96f08

8 years agoUpdate supported versions in release notes
Henri Sara [Tue, 22 Dec 2015 08:30:42 +0000 (10:30 +0200)]
Update supported versions in release notes

Change-Id: I9376019c353f511ea799866587512ccbf1a7a584

8 years agoFix Grid sorting tests (#16838)
Henri Sara [Mon, 21 Dec 2015 14:33:44 +0000 (16:33 +0200)]
Fix Grid sorting tests (#16838)

Increase click X offset to account for wider resize handle.

Change-Id: Id638214f4a98d2476f298014c1bae0bbca6dea16

8 years agoFix GridColumnReorderTest for IE8 (#16838)
Henri Sara [Mon, 21 Dec 2015 14:24:20 +0000 (16:24 +0200)]
Fix GridColumnReorderTest for IE8 (#16838)

Use a different X offset not to hit a resize handle.

Change-Id: I6e7d4cb0ae0e9c941cb3dd2ba3e29256d6643fde

8 years agoFix GridEditorBufferedTest for (#16838)
Henri Sara [Sun, 20 Dec 2015 10:20:28 +0000 (12:20 +0200)]
Fix GridEditorBufferedTest for (#16838)

Changed cell padding affected the location of the cursor after
a click.

Change-Id: I950496eb43b8c9be1fc37f558ddd80511eb1c0c3

8 years agoDisable long tap support on iOS (#19367)
Henri Sara [Mon, 21 Dec 2015 07:48:35 +0000 (09:48 +0200)]
Disable long tap support on iOS (#19367)

Long tap causes problems in embedded browsers on iOS (text
selection is performed and/or the OS native context menu is shown).

The support should be re-enabled in the future (see #19406).

Change-Id: I842df12675482c8e529e8bb061958414cc8c0b90

8 years agoIgnore context click on resize handle (#19408)
Henri Sara [Mon, 21 Dec 2015 09:44:23 +0000 (11:44 +0200)]
Ignore context click on resize handle (#19408)

Otherwise, context clicks in the left edge of a header cell get
handled by the wrong cell.

Change-Id: I08e0c6bb62c90cc871fde7ec1d0f0a8602e5631f

8 years agoFix left padding for ComboBox inside Grid editor (#16838)
Marlon Richert [Mon, 21 Dec 2015 09:41:00 +0000 (11:41 +0200)]
Fix left padding for ComboBox inside Grid editor (#16838)

This fix applies especially to the themes Base, Chameleon and Runo.
Reindeer and Valo were already covered by earlier changes.

Filed #19407 for fixing incorrect positioning of DateField button in
Base theme.

Change-Id: Iefda0d23b93c74274ad83c60907c0198e5c2f237

8 years agoFix javadoc typo in ItemClickEvent
Henri Sara [Mon, 21 Dec 2015 09:46:37 +0000 (11:46 +0200)]
Fix javadoc typo in ItemClickEvent

Change-Id: I759999ab2e39202b4dda7eafa2cc30a64524939d

8 years agoAdd a UI for reviewing new reference screenshots
Leif Åstrand [Tue, 22 Sep 2015 11:24:58 +0000 (14:24 +0300)]
Add a UI for reviewing new reference screenshots

Change-Id: I79b953cd4620331e3892a8bd070db8f9bd076e0f

8 years agoIncrease grid column resize handle width (#16838)
Marlon Richert [Wed, 9 Dec 2015 12:33:43 +0000 (14:33 +0200)]
Increase grid column resize handle width (#16838)

Change-Id: Ic7768d9023d48b04458376765596059d3a81d8c6

8 years agoFix IE8 focus handling in Grid editor in unbuffered state (#19389)
Teemu Suo-Anttila [Wed, 16 Dec 2015 12:57:58 +0000 (14:57 +0200)]
Fix IE8 focus handling in Grid editor in unbuffered state (#19389)

Change-Id: Ia77c246239cae7b0add3c4975dfa5ffaa42d08b6

8 years agoFix empty @since tags
Henri Sara [Fri, 18 Dec 2015 11:40:38 +0000 (13:40 +0200)]
Fix empty @since tags

Change-Id: I68dd71f65091a6c5979b67c2faea9050feac2b02

8 years agoVerify Column width after all sort related cell changes (#16597)
Teemu Suo-Anttila [Thu, 17 Dec 2015 13:56:43 +0000 (15:56 +0200)]
Verify Column width after all sort related cell changes (#16597)

This fixes an IE8 issue where multisorting is not shown correctly.

Change-Id: Id68103f06baf9e3ae20cb2714407b467829ef1a0

8 years agoDisable Atmosphere online/offline handling (#19391)
Artur Signell [Thu, 17 Dec 2015 06:25:10 +0000 (08:25 +0200)]
Disable Atmosphere online/offline handling (#19391)

Atmosphere will disconnect the push connection when going offline and reconnect it
when going online again. There are no events sent when this happens, which means the
reconnect logic cannot take this into account.

Having it enabled leads to something like:

1. Browser goes offline, push is disconnected
2. Framework sees it as a normal close and does not show the reconnect dialog
3. The user does something, the framework tries to send a websocket request
4. A new Atmosphere request is created and enters a try-to-reconnect loop as expected
5. The browser goes online, and the online event re-initializes the old connection
although a try-to-reconnect loop is already running

Change-Id: I5dcef768783142e2c7b4e7c821353addb0ec3d28

8 years agoUpdate to Atmosphere 2.2.13.vaadin3 (#19391)
Artur Signell [Thu, 17 Dec 2015 06:07:09 +0000 (08:07 +0200)]
Update to Atmosphere 2.2.13.vaadin3 (#19391)

Change-Id: I80a594092d5f662120b83148cb992a9457859248

8 years agoParse true/false as boolean values for push configuration (#19394)
Artur Signell [Thu, 17 Dec 2015 06:24:22 +0000 (08:24 +0200)]
Parse true/false as boolean values for push configuration (#19394)

Change-Id: I89e99ebd552b00a1bdc79801a8236aff72b6a290

8 years agoFix Grid column resize to take account min width for cells (#16597)
Johannes Dahlström [Tue, 15 Dec 2015 13:59:55 +0000 (15:59 +0200)]
Fix Grid column resize to take account min width for cells (#16597)

Use Escalator cell size calculation without content to determine the
absolute minimum size for cells. This is used in Grid when drag resizing
or sorting columns to prevent cells from overflowing to the next row.

Change-Id: I2d598232d7d2b8729b11fe190b68ca3e42ee3652

8 years agoUpdate to Atmosphere 2.2.13.vaadin2 (#19388)
Artur Signell [Wed, 16 Dec 2015 12:35:21 +0000 (14:35 +0200)]
Update to Atmosphere 2.2.13.vaadin2 (#19388)

The new Atmosphere fixes a JS typo in "ononline" handling

Change-Id: If0a9a1b6756212d5a0232f6aaa2f4314ba1dc052

8 years agoMake it possible to only show collapsible columns in menu (#9811)
Leif Åstrand [Fri, 18 Sep 2015 11:26:50 +0000 (14:26 +0300)]
Make it possible to only show collapsible columns in menu (#9811)

Change-Id: I52cd2648d305f44d5688e7a2fcd222e6b167b97b

8 years agoFix LegacyComponentThemeChangeTest on Chrome 47
Henri Sara [Tue, 15 Dec 2015 13:41:53 +0000 (15:41 +0200)]
Fix LegacyComponentThemeChangeTest on Chrome 47

The test uses an Embedded component with non-existent Flash content.
This does not work on Chrome 47 so this change disables that part
of the test on Chrome like it was already disabled on IE8.

Change-Id: Ie60123247ec45b2138202fccd73d794bf98e533e

8 years agoFix text selection and context click events for Android devices (#19367)
Teemu Suo-Anttila [Tue, 15 Dec 2015 11:39:12 +0000 (13:39 +0200)]
Fix text selection and context click events for Android devices (#19367)

Text and element selection needs to be disabled on touch start for
Android as well. Other touch event handling used by iOS devices is not
used on Android.

Change-Id: I7f17af437ddf4f7b747232fbd19b2cd5c825c0e2

8 years agoIgnore empty style names from Grid Row and CellStyleGenerators (#19364)
Teemu Suo-Anttila [Mon, 14 Dec 2015 12:14:18 +0000 (14:14 +0200)]
Ignore empty style names from Grid Row and CellStyleGenerators (#19364)

Change-Id: I07b241f40bcb20b92f9eea48036724dd91ecc985

8 years agoPrevent text selection on iOS devices with long tap (#19367)
Teemu Suo-Anttila [Tue, 15 Dec 2015 11:19:16 +0000 (13:19 +0200)]
Prevent text selection on iOS devices with long tap (#19367)

Text or elements should not get selected when there's a context click
listener. Pre-emptively prevent text selection for the whole widget when
that happens.

Change-Id: I3c09d8b2c25d383d6abe079f0fee3809cf5838c7

8 years agoAdd a method to clear selected text on context click (#19367)
Teemu Suo-Anttila [Fri, 11 Dec 2015 12:39:56 +0000 (14:39 +0200)]
Add a method to clear selected text on context click (#19367)

Change-Id: Id7ec7013bcff446cdf3ce0f2088cb20b0708a56b

8 years agoFix mouse wheel scrolling of ComboBox in IE11 (#16918)
Anna Koskinen [Wed, 25 Feb 2015 11:43:39 +0000 (13:43 +0200)]
Fix mouse wheel scrolling of ComboBox in IE11 (#16918)

IE11 is broken so that the simple implementation always moves up on any
mouse wheel event. Therefore, this change borrows the approach taken by
Escalator for low-level handling of mouse wheel events in a way compatible
with all supported browsers.

Change-Id: I98c89d3ccfeea38d6a454ef708f0eb7d1d3f480c

8 years agoFix RpcDataProvider listener handling on ItemSetChange (#19371)
Teemu Suo-Anttila [Mon, 14 Dec 2015 08:40:06 +0000 (10:40 +0200)]
Fix RpcDataProvider listener handling on ItemSetChange (#19371)

Old ValueChangeListeners are discarded and new ones created when an
ItemSetChange occurs. This is done to reapply the listeners to possibly
recreated Items.

Change-Id: I9956af8950e241005574c597c49c5efb43afc1c7

8 years agoFix and extend Javadoc for setFirstDayOfWeek (#19227)
Leonid Rozenblyum [Sat, 5 Dec 2015 17:30:41 +0000 (19:30 +0200)]
Fix and extend Javadoc for setFirstDayOfWeek (#19227)

The Javadoc was incorrect saying the method goal was to set the first
day of week depending on locale. Actual main goal - to set it in
independent way.
Also extended the doc to look more complete.
Change-Id: I2c82c774f4e245437b03c0bd0246a0361584d949

8 years agoFix selecting a row that was deselected on the server (#19360)
Teemu Suo-Anttila [Fri, 11 Dec 2015 09:39:16 +0000 (11:39 +0200)]
Fix selecting a row that was deselected on the server (#19360)

Client-side connector of the SingleSelectionModel attempts to keep track
of currently selected row. This tracking gets lost when the row get
deselected on the server-side. Special case is now correctly handled.

Change-Id: I1c45548bd11536bc85cddbc2ba8b6225965c1194

8 years agoReapply DataGenerators when container changes (#19357, #19359)
Teemu Suo-Anttila [Fri, 11 Dec 2015 08:58:06 +0000 (10:58 +0200)]
Reapply DataGenerators when container changes (#19357, #19359)

Previously on container change Grid applied only its internal
DataGenerators to the new RpcDataProviderExtension. Now it goes through
all existing Extensions and adds all DataGenerators to the data
provider.

Change-Id: Idbd48e5152867b1d2b7a770741e3ea08aa4299b6