add tests for oauth2 authorization code expiration

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

make oauth2 authorization code expire after 10 minutes

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Merge pull request #40764 from nextcloud/chore/eslint-no-external-apps

chore: Do not lint external apps

Merge pull request #40745 from nextcloud/fix/noid/ocm-provider-rewrite-rules

fix ocm-provider rewrite rules

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #40771 from nextcloud/fix/37098/migrate-to-nc-icon-svg-wrapper

Merge pull request #40768 from nextcloud/fix/37098/dashboard-duplicated-ids

fix(dashboard): remove duplicated IDs on the dashboard page

chore(assets): Recompile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(files): migrate from CustomSvgIconrenderer to NcIconSvgWrapper

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Merge pull request #40662 from nextcloud/fix-37080_correct_aria_label_text_on_action_inputs

Correct `aria-label` on action input and text field

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #40515 from nextcloud/fix/redirect-if-wrong-dir

chore: build assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(dashboard): remove duplicated IDs

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Correct `aria-label` on action input and text field

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

fix: redirect to proper directory if file not found

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Merge pull request #40585 from nextcloud/fix/illegal-characters

fix(files): disallow illegal characters

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Merge pull request #40660 from nextcloud/bugfix/noid/fix-missing-user-status-on-autocomplete-api

fix(autocomplete): Fix missing user status on autocomplete endpoint

Merge pull request #40439 from Koc/feature/clickable-logo

Merge pull request #40756 from nextcloud/fix/encoded-source

fix(files): legacy humanFileSize tests

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

chore: Do not lint external apps

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Make logo in header clickable in the shared file view

Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>

fix(files): encoded source path on actions requests

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

Update .htaccess

Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #40752 from nextcloud/enh/40654/share-creation-loading-feedback

Show loading icon in 'save share' button when creating a share

compile assets

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

show loading icon in 'save share' button when creating a share

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Merge pull request #39114 from fsamapoor/refactor_lib_private_collaboration_part2

[2/2] Refactors lib/private/Collaboration

Merge pull request #40751 from nextcloud/dependabot/npm_and_yarn/core-js-3.33.0

chore(deps): Bump core-js from 3.32.0 to 3.33.0

chore(deps): Bump core-js from 3.32.0 to 3.33.0

Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.32.0 to 3.33.0.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.33.0/packages/core-js)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #40748 from nextcloud/chore/remove-nextcloud-vue-dashboard

Refactors lib/private/Collaboration.

Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #40629 from nextcloud/40438-sharing-cleanup

Updates to new sharing flow

chore(deps): remove @nextcloud/vue-dashboard

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix ocm-provider rewrite rules

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #40678 from nextcloud/chore/phpunit-vendor-bin

chore: Install phpunit via vendor bin

Correct check for enabled expiration date

The default expiration date cannot be enforced if it is not enabled
in the first place. Hence, the check for whether a share has an expiration date
should not consider enforcements but only where the share expiry type is enabled.

For example : Using `this.config.isDefaultExpireDateEnabled` instead of
`this.config.isDefaultExpireDateEnforced` which can be verified by checking `isExpiryDateEnforced`.

Resolves : https://github.com/nextcloud/server/issues/40612

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Updates to sharing flow

- Show enforced expiry date for new shares.
- Improve quick share dropdown visibility in dark mode.
- Prevent expiry date from showing expire for incoming shares.
by updating the check for `share.passwordExpirationTime` to equally
check for `undefined`.
- Move "Download permission/attribute" from custom setting (as it is just
another advanced setting and not an actual permission).
- Show correct text for upload/editing when "allow public uploads" is enabled
or disabled by admin.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Merge pull request #40736 from nextcloud/test/cypress-record-in-prs-only

test(cypress): only use the cypress cloud on pull requests

Merge pull request #40738 from nextcloud/fix/remove-uneeded-class_app_navigation_caption

Remove unneeded class

chore: Install phpunit via vendor bin

This means we can all run the same version. And when switching to
stableX it can pull the corresponding version too. Also local dev envs
and CI run the same phpunit.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #40656 from nextcloud/feat/backgroundjob/schedule-job-after

feat(backgroundjob): Schedule job after <timestamp>

test(cypress): only use the cypress cloud on pull requests

* Disable recording on integration branches.
* No parallelization on integration branches.

This will still run the cypress tests - but a bit slower and without recordings.

The matrix syntax to enable this is somewhat hard to parse.
In case of a PR the matrix will contain one entry for use-cypress-cloud
with the value `true`. Otherwise it will have one entry `false`.

This way we can exclude containers for the case without the cypress cloud.

Signed-off-by: Max <max@nextcloud.com>

Remove unneeded class

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

Merge pull request #37201 from AaronDewes/fix/ldap-filter-generation

Fix: Escape group names for LDAP

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #40734 from nextcloud/debt/noid/align-param-name

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #40630 from nextcloud/enh/enable-php-8.3

ci: clear disable_functions to enable pcntl_signal

When using ini-file development then disable_functions forbids pcntl_signal by default.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Use latest shivammathur/setup-php in phpunit-32bits.yml

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add 8.3 to lint CI and 32bits test suite

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Adding ini-file:development to 32bit CI

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Allow PHP 8.3 in version check

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: rename serializedClosure to argument to align with parent class

To make psalm happy ;)

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #40709 from nextcloud/fix/ldap-profile-pic-resolution-master

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #40564 from nextcloud/fix/userstatus/message-timestamp

fix(userstatus): Track message timestamp too

Merge pull request #40714 from nextcloud/bugfix/noid/sensitive-onlyoffice

fix(systemreport): Mask onlyoffice secret as sensitive

fix(systemreport): Mask onlyoffice secret as sensitive

Signed-off-by: Joas Schilling <coding@schilljs.com>

Update apps/user_ldap/lib/User/User.php

Co-authored-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

LDAP: Increase profile picture limit to 512

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat(backgroundjob): Schedule job after <timestamp>

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

fix(userstatus): Track message timestamp too

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #40576 from nextcloud/fix/36915-_The_page_only_has_one_h1_heading

Split list to navigation for the left sidebar

Merge pull request #40644 from nextcloud/fix/noid/encode-uri-trashbin-restore-files-delete-favorite

fix: encode uri for delete, restore and favorite

Merge pull request #39224 from shdehnavi/null_coalescing_conversion_lib_private

Convert isset ternary to null coalescing operator

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: encode uri for delete, restore and favorite

To encode # and other characters properly

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Split list to navigation for the left sidebar

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

Merge pull request #40675 from nextcloud/fix/unifiedsearch/search-0

fix(unifiedsearch): Allow searching for "0"

Merge pull request #40677 from nextcloud/fix/wcag-files

Convert isset ternary to null coalescing operator

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

fix(files): pass WCAG AA for hover rows

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #39131 from fsamapoor/refactor_lib_files_external_commands

Refactors files_external app commands

fix(autocomplete): Fix missing user status on autocomplete endpoint

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #40430 from nextcloud/enh/a11y/share-note-label

enh(a11y): Add label to share note textbox

Merge pull request #39225 from shdehnavi/null_coalescing_conversion_apps

Convert isset ternary to null coalescing operator

Merge pull request #40583 from nextcloud/feat/button-mtime

Merge pull request #40617 from nextcloud/enh/allow-user-to-set-apporder

Read apporder from configuration value

fix(unifiedsearch): Allow searching for "0"

empty("0") evaluates to true

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Convert isset ternary to null coalescing operator

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Merge pull request #39011 from fsamapoor/refactor_lib_private_security_part1

[1/3] Refactors lib/private/Security

Merge pull request #39236 from shdehnavi/refactor_comments_app

Fix behavior when defaultapp is empty

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Make adjustments based on the review

Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Refactor comments app

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Adds parameter type hints.

Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

Refactors files_external app commands.

To improve code readability.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>

chore: compile assets

Signed-off-by: Christopher Ng <chrng8@gmail.com>

enh(a11y): Add label to share note textbox

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #39213 from shdehnavi/replace_strpos_and_substr_calls_in_federatedfilesharing_app

Refactor "strpos" and "substr" calls in federatedfilesharing app to improve code readability

Merge pull request #39175 from shdehnavi/settings_app_users_controller_square_bracket_syntax

use square bracket syntax to modify array

Refactors "strpos" and "substr" calls to improve code readability

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

Merge pull request #40651 from nextcloud/refactor/dbal-connection-query-execute-query

refactor: Use DBAL's executeQuery instead of query (deprecated)