]> source.dussan.org Git - redmine.git/log
redmine.git
5 years agofix Redmine::Themes#scan_themes is not private
Toshi MARUYAMA [Tue, 1 Oct 2019 05:07:27 +0000 (05:07 +0000)]
fix Redmine::Themes#scan_themes is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18578 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix Watcher#prune_single_user is not private
Toshi MARUYAMA [Tue, 1 Oct 2019 05:07:16 +0000 (05:07 +0000)]
fix Watcher#prune_single_user is not private

git-svn-id: http://svn.redmine.org/redmine/trunk@18577 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate RuboCop to 0.75.0 (#31509).
Go MAEDA [Tue, 1 Oct 2019 03:18:39 +0000 (03:18 +0000)]
Update RuboCop to 0.75.0 (#31509).

git-svn-id: http://svn.redmine.org/redmine/trunk@18576 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFix wrong markup in public/help/ja/wiki_syntax_detailed_(markdown|textile).html ...
Go MAEDA [Mon, 30 Sep 2019 13:31:26 +0000 (13:31 +0000)]
Fix wrong markup in public/help/ja/wiki_syntax_detailed_(markdown|textile).html (#32169).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18572 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd links to the detailed Wiki formatting help in Quick Reference (#32169).
Go MAEDA [Mon, 30 Sep 2019 13:28:50 +0000 (13:28 +0000)]
Add links to the detailed Wiki formatting help in Quick Reference (#32169).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18571 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd support for "start with" and "end with" operators to "Files" filter (#31879).
Go MAEDA [Mon, 30 Sep 2019 13:15:45 +0000 (13:15 +0000)]
Add support for "start with" and "end with" operators to "Files" filter (#31879).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18570 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agofix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_su...
Toshi MARUYAMA [Mon, 30 Sep 2019 12:47:52 +0000 (12:47 +0000)]
fix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_subtasks

git-svn-id: http://svn.redmine.org/redmine/trunk@18569 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/models/issue.rb from Layout/ElseAlignment fixed by previous revisions
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:59 +0000 (11:42 +0000)]
rubocop: remove app/models/issue.rb from Layout/ElseAlignment fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18568 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:48 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours method

git-svn-id: http://svn.redmine.org/redmine/trunk@18567 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:36 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method

git-svn-id: http://svn.redmine.org/redmine/trunk@18566 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:26 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition method

git-svn-id: http://svn.redmine.org/redmine/trunk@18565 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_hel...
Toshi MARUYAMA [Mon, 30 Sep 2019 11:42:15 +0000 (11:42 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18564 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove test/integration/api_test/issues_test.rb from Layout/IndentationConsi...
Toshi MARUYAMA [Mon, 30 Sep 2019 10:59:13 +0000 (10:59 +0000)]
rubocop: remove test/integration/api_test/issues_test.rb from Layout/IndentationConsistency fixed by previous revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18563 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/issues_t...
Toshi MARUYAMA [Mon, 30 Sep 2019 10:59:01 +0000 (10:59 +0000)]
code cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18562 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_t...
Toshi MARUYAMA [Mon, 30 Sep 2019 10:58:50 +0000 (10:58 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18561 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/models/attachment.rb from Layout/EmptyLineBetweenDefs fixed by...
Toshi MARUYAMA [Mon, 30 Sep 2019 10:58:39 +0000 (10:58 +0000)]
rubocop: remove app/models/attachment.rb from Layout/EmptyLineBetweenDefs fixed by r18558

git-svn-id: http://svn.redmine.org/redmine/trunk@18560 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb
Toshi MARUYAMA [Mon, 30 Sep 2019 09:00:06 +0000 (09:00 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18559 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/attachment.rb
Toshi MARUYAMA [Mon, 30 Sep 2019 08:59:54 +0000 (08:59 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/attachment.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18558 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/helpers/applicatio...
Toshi MARUYAMA [Mon, 30 Sep 2019 08:59:43 +0000 (08:59 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/helpers/application_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18557 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb
Toshi MARUYAMA [Mon, 30 Sep 2019 08:59:26 +0000 (08:59 +0000)]
code cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18556 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/unit/changeset_te...
Toshi MARUYAMA [Mon, 30 Sep 2019 08:59:14 +0000 (08:59 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/unit/changeset_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18555 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/issue_test.rb
Toshi MARUYAMA [Mon, 30 Sep 2019 02:44:32 +0000 (02:44 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18554 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/api_test...
Toshi MARUYAMA [Mon, 30 Sep 2019 02:44:21 +0000 (02:44 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/api_test/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18553 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoadd test "removing issue shows confirm dialog"
Toshi MARUYAMA [Mon, 30 Sep 2019 02:23:14 +0000 (02:23 +0000)]
add test "removing issue shows confirm dialog"

git-svn-id: http://svn.redmine.org/redmine/trunk@18552 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoremove extra space from app/views/issues/_edit.html.erb
Toshi MARUYAMA [Mon, 30 Sep 2019 02:23:03 +0000 (02:23 +0000)]
remove extra space from app/views/issues/_edit.html.erb

git-svn-id: http://svn.redmine.org/redmine/trunk@18551 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoText enclosed in pre tag in Wiki formatting reference is not displayed in a monospace...
Go MAEDA [Mon, 30 Sep 2019 00:28:47 +0000 (00:28 +0000)]
Text enclosed in pre tag in Wiki formatting reference is not displayed in a monospaced font in Chrome (#32170).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18550 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUnify fields of subtasks and related issues on issue page (#25540).
Go MAEDA [Sun, 29 Sep 2019 00:03:34 +0000 (00:03 +0000)]
Unify fields of subtasks and related issues on issue page (#25540).

Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@18549 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoMake the disabled fields more obvious (#31147).
Go MAEDA [Sat, 28 Sep 2019 23:50:10 +0000 (23:50 +0000)]
Make the disabled fields more obvious (#31147).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18548 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRounded corners on table.list elements (#32014).
Go MAEDA [Sat, 28 Sep 2019 00:06:52 +0000 (00:06 +0000)]
Rounded corners on table.list elements (#32014).

Patch by Antonio McDeal.

git-svn-id: http://svn.redmine.org/redmine/trunk@18547 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoMove the links (All time entries, Import) from Spent time section of the spent time...
Go MAEDA [Fri, 27 Sep 2019 09:38:33 +0000 (09:38 +0000)]
Move the links (All time entries, Import) from Spent time section of the spent time list sidebar under a dropdown (#31598).

Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18546 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAdd "Highlighted code" section in Wiki Syntax Quick Reference (#32123).
Go MAEDA [Fri, 27 Sep 2019 01:30:56 +0000 (01:30 +0000)]
Add "Highlighted code" section in Wiki Syntax Quick Reference (#32123).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18545 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoIncoming emails may cause "invalid byte sequence" error depending on the default...
Go MAEDA [Thu, 26 Sep 2019 13:01:01 +0000 (13:01 +0000)]
Incoming emails may cause "invalid byte sequence" error depending on the default external encoding, due to r18317 (#31549).

git-svn-id: http://svn.redmine.org/redmine/trunk@18544 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't set border-radius for the items in the dropdown menu (#32013).
Go MAEDA [Thu, 26 Sep 2019 09:37:05 +0000 (09:37 +0000)]
Don't set border-radius for the items in the dropdown menu (#32013).

Patch by Bernhard Rohloff.

git-svn-id: http://svn.redmine.org/redmine/trunk@18543 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoBulgarian translation update (#32147).
Go MAEDA [Thu, 26 Sep 2019 06:53:46 +0000 (06:53 +0000)]
Bulgarian translation update (#32147).

Patch by Ivan Cenov.

git-svn-id: http://svn.redmine.org/redmine/trunk@18542 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoJapanese translation update (#32144).
Go MAEDA [Thu, 26 Sep 2019 03:44:24 +0000 (03:44 +0000)]
Japanese translation update (#32144).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18541 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoTraditional Chinese translation update (#32143).
Go MAEDA [Thu, 26 Sep 2019 03:20:15 +0000 (03:20 +0000)]
Traditional Chinese translation update (#32143).

Patch by ChunChang Lo.

git-svn-id: http://svn.redmine.org/redmine/trunk@18540 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agosvn propdel svn:executable app/models/mail_handler.rb
Toshi MARUYAMA [Thu, 26 Sep 2019 02:38:50 +0000 (02:38 +0000)]
svn propdel svn:executable app/models/mail_handler.rb

It was added by r16609 accidentally.

git-svn-id: http://svn.redmine.org/redmine/trunk@18539 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/ClosingHeredocIndentation in test/integration/api_t...
Toshi MARUYAMA [Wed, 25 Sep 2019 17:55:26 +0000 (17:55 +0000)]
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in test/integration/api_test/issues_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18538 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/unit/issue_test.rb
Toshi MARUYAMA [Wed, 25 Sep 2019 17:55:14 +0000 (17:55 +0000)]
code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18537 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agodetect Chrome downloaded file more strictly
Toshi MARUYAMA [Wed, 25 Sep 2019 17:30:07 +0000 (17:30 +0000)]
detect Chrome downloaded file more strictly

git-svn-id: http://svn.redmine.org/redmine/trunk@18536 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate locales (#31879).
Go MAEDA [Wed, 25 Sep 2019 16:31:06 +0000 (16:31 +0000)]
Update locales (#31879).

git-svn-id: http://svn.redmine.org/redmine/trunk@18535 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years ago"starts with" and "ends with" filter operators for string values (#31879).
Go MAEDA [Wed, 25 Sep 2019 16:24:08 +0000 (16:24 +0000)]
"starts with" and "ends with" filter operators for string values (#31879).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18534 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in test/application_system_test_c...
Toshi MARUYAMA [Wed, 25 Sep 2019 14:12:18 +0000 (14:12 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in test/application_system_test_case.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18533 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agodetect strictly Chrome downloaded file
Toshi MARUYAMA [Wed, 25 Sep 2019 13:24:20 +0000 (13:24 +0000)]
detect strictly Chrome downloaded file

git-svn-id: http://svn.redmine.org/redmine/trunk@18532 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agodo not delete Chrome downloaded files on Linux
Toshi MARUYAMA [Wed, 25 Sep 2019 13:14:05 +0000 (13:14 +0000)]
do not delete Chrome downloaded files on Linux

https://github.com/SeleniumHQ/selenium/issues/5292

git-svn-id: http://svn.redmine.org/redmine/trunk@18531 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoworkaround Chrome default_directory ignored on Linux
Toshi MARUYAMA [Wed, 25 Sep 2019 12:31:40 +0000 (12:31 +0000)]
workaround Chrome default_directory ignored on Linux

https://github.com/SeleniumHQ/selenium/issues/5292

git-svn-id: http://svn.redmine.org/redmine/trunk@18530 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/TrailingCommaInArguments in test/unit/issue_test.rb
Toshi MARUYAMA [Wed, 25 Sep 2019 11:18:59 +0000 (11:18 +0000)]
code cleanup: rubocop: fix Style/TrailingCommaInArguments in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18529 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove config/initializers/30-redmine.rb from Style/MultilineTernaryOperator...
Toshi MARUYAMA [Wed, 25 Sep 2019 11:18:48 +0000 (11:18 +0000)]
rubocop: remove config/initializers/30-redmine.rb from Style/MultilineTernaryOperator fixed by r18521

git-svn-id: http://svn.redmine.org/redmine/trunk@18528 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoinput[type="number"] should be highlighted as well when it has focus (#31971).
Go MAEDA [Wed, 25 Sep 2019 07:36:34 +0000 (07:36 +0000)]
input[type="number"] should be highlighted as well when it has focus (#31971).

git-svn-id: http://svn.redmine.org/redmine/trunk@18527 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Naming/AccessorMethodName
Toshi MARUYAMA [Wed, 25 Sep 2019 04:35:40 +0000 (04:35 +0000)]
rubocop: disable Naming/AccessorMethodName

git-svn-id: http://svn.redmine.org/redmine/trunk@18526 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Lint/IneffectiveAccessModifier
Toshi MARUYAMA [Wed, 25 Sep 2019 04:35:29 +0000 (04:35 +0000)]
rubocop: disable Lint/IneffectiveAccessModifier

git-svn-id: http://svn.redmine.org/redmine/trunk@18525 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoHighlight the input field that has focus by setting border-color (#31971).
Go MAEDA [Wed, 25 Sep 2019 01:48:20 +0000 (01:48 +0000)]
Highlight the input field that has focus by setting border-color (#31971).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18524 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 15:56:51 +0000 (15:56 +0000)]
code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/issue_test.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 15:43:56 +0000 (15:43 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18522 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Rails/Presence in config/initializers/30-redmine.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 15:42:13 +0000 (15:42 +0000)]
code cleanup: rubocop: fix Rails/Presence in config/initializers/30-redmine.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18521 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Rails/Presence in config/initializers/10-patches.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 15:42:02 +0000 (15:42 +0000)]
code cleanup: rubocop: fix Rails/Presence in config/initializers/10-patches.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18520 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Rails/Presence in db/migrate/20110228000100_copy_repositor...
Toshi MARUYAMA [Tue, 24 Sep 2019 15:41:50 +0000 (15:41 +0000)]
code cleanup: rubocop: fix Rails/Presence in db/migrate/20110228000100_copy_repositories_log_encoding.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18519 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Rails/Presence in lib/redmine/scm/adapters/cvs_adapter.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 15:41:39 +0000 (15:41 +0000)]
code cleanup: rubocop: fix Rails/Presence in lib/redmine/scm/adapters/cvs_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18518 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/BlockEndNewline in app/models/issue.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 05:54:53 +0000 (05:54 +0000)]
code cleanup: rubocop: fix Layout/BlockEndNewline in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18517 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in app/helpers/issue...
Toshi MARUYAMA [Tue, 24 Sep 2019 05:54:42 +0000 (05:54 +0000)]
code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18516 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in db/migrate/20170302015225_c...
Toshi MARUYAMA [Tue, 24 Sep 2019 05:21:20 +0000 (05:21 +0000)]
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in db/migrate/20170302015225_change_attachments_digest_limit_to_64.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18515 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/issues_helper.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 05:21:09 +0000 (05:21 +0000)]
code cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18514 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/issues_hel...
Toshi MARUYAMA [Tue, 24 Sep 2019 05:20:58 +0000 (05:20 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18513 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/repository...
Toshi MARUYAMA [Tue, 24 Sep 2019 05:13:46 +0000 (05:13 +0000)]
code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/repository/bazaar.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18512 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/NegatedIf in lib/redmine/scm/adapters/bazaar_adapter.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 05:13:35 +0000 (05:13 +0000)]
code cleanup: rubocop: fix Style/NegatedIf in lib/redmine/scm/adapters/bazaar_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18511 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ColonMethodCall in lib/redmine/scm/adapters/bazaar_a...
Toshi MARUYAMA [Tue, 24 Sep 2019 05:13:24 +0000 (05:13 +0000)]
code cleanup: rubocop: fix Style/ColonMethodCall in lib/redmine/scm/adapters/bazaar_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18510 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoadd missing fixtures to MailHandlerTest (#31946)
Toshi MARUYAMA [Tue, 24 Sep 2019 04:48:14 +0000 (04:48 +0000)]
add missing fixtures to MailHandlerTest (#31946)

git-svn-id: http://svn.redmine.org/redmine/trunk@18509 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoDon't show unsettable permissions in the tracker permissions table (#30431).
Go MAEDA [Tue, 24 Sep 2019 04:18:44 +0000 (04:18 +0000)]
Don't show unsettable permissions in the tracker permissions table (#30431).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18508 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/SpaceInsideRangeLiteral in app/models/repository...
Toshi MARUYAMA [Tue, 24 Sep 2019 02:34:43 +0000 (02:34 +0000)]
code cleanup: rubocop: fix Layout/SpaceInsideRangeLiteral in app/models/repository/cvs.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18507 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/EmptyLiteral in lib/redmine/scm/adapters/cvs_adapter.rb
Toshi MARUYAMA [Tue, 24 Sep 2019 02:34:32 +0000 (02:34 +0000)]
code cleanup: rubocop: fix Style/EmptyLiteral in lib/redmine/scm/adapters/cvs_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18506 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRounded corners of "my page" blocks (#32015).
Go MAEDA [Mon, 23 Sep 2019 02:35:20 +0000 (02:35 +0000)]
Rounded corners of "my page" blocks (#32015).

Patch by Antonio McDeal.

git-svn-id: http://svn.redmine.org/redmine/trunk@18505 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/Casecmp in lib/redmine/scm/adapters/bazaar_ada...
Toshi MARUYAMA [Sat, 21 Sep 2019 15:54:38 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Performance/Casecmp in lib/redmine/scm/adapters/bazaar_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18504 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Performance/Casecmp in lib/redmine/codeset_util.rb
Toshi MARUYAMA [Sat, 21 Sep 2019 15:54:25 +0000 (15:54 +0000)]
code cleanup: rubocop: fix Performance/Casecmp in lib/redmine/codeset_util.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18503 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/RedundantConditional in app/helpers/issues_helper.rb
Toshi MARUYAMA [Sat, 21 Sep 2019 14:14:28 +0000 (14:14 +0000)]
code cleanup: rubocop: fix Style/RedundantConditional in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18502 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Naming/BinaryOperatorParameterName
Toshi MARUYAMA [Sat, 21 Sep 2019 14:11:19 +0000 (14:11 +0000)]
rubocop: disable Naming/BinaryOperatorParameterName

git-svn-id: http://svn.redmine.org/redmine/trunk@18501 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: disable Rails/HelperInstanceVariable
Toshi MARUYAMA [Sat, 21 Sep 2019 14:11:07 +0000 (14:11 +0000)]
rubocop: disable Rails/HelperInstanceVariable

git-svn-id: http://svn.redmine.org/redmine/trunk@18500 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/helpers/issues_helper.rb from Style/NestedTernaryOperator fixed...
Toshi MARUYAMA [Sat, 21 Sep 2019 14:10:56 +0000 (14:10 +0000)]
rubocop: remove app/helpers/issues_helper.rb from Style/NestedTernaryOperator fixed by r18496

git-svn-id: http://svn.redmine.org/redmine/trunk@18499 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoAuto-complete issues #id in the search form (#32052).
Go MAEDA [Sat, 21 Sep 2019 07:52:16 +0000 (07:52 +0000)]
Auto-complete issues #id in the search form (#32052).

Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18498 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Rails/Blank in app/helpers/issues_helper.rb
Toshi MARUYAMA [Sat, 21 Sep 2019 06:39:36 +0000 (06:39 +0000)]
code cleanup: rubocop: fix Rails/Blank in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18497 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/MultilineTernaryOperator in app/helpers/issues_helper.rb
Toshi MARUYAMA [Sat, 21 Sep 2019 06:39:24 +0000 (06:39 +0000)]
code cleanup: rubocop: fix Style/MultilineTernaryOperator in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18496 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in test/unit/repository_b...
Toshi MARUYAMA [Sat, 21 Sep 2019 06:32:29 +0000 (06:32 +0000)]
code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in test/unit/repository_bazaar_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18495 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/ScriptPermission of Rakefile fixed by r18493
Toshi MARUYAMA [Fri, 20 Sep 2019 18:12:59 +0000 (18:12 +0000)]
code cleanup: rubocop: fix Lint/ScriptPermission of Rakefile fixed by r18493

git-svn-id: http://svn.redmine.org/redmine/trunk@18494 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agosvn propset svn:executable on Rakefile
Toshi MARUYAMA [Fri, 20 Sep 2019 18:08:14 +0000 (18:08 +0000)]
svn propset svn:executable on Rakefile

git-svn-id: http://svn.redmine.org/redmine/trunk@18493 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/CommentedKeyword in app/models/repository/cvs.rb
Toshi MARUYAMA [Fri, 20 Sep 2019 17:54:54 +0000 (17:54 +0000)]
code cleanup: rubocop: fix Style/CommentedKeyword in app/models/repository/cvs.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18492 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/CommentAnnotation in lib/redmine/scm/adapters/cvs_ad...
Toshi MARUYAMA [Fri, 20 Sep 2019 17:54:42 +0000 (17:54 +0000)]
code cleanup: rubocop: fix Style/CommentAnnotation in lib/redmine/scm/adapters/cvs_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18491 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/ClassCheck in lib/redmine/scm/adapters/cvs_adapter.rb
Toshi MARUYAMA [Fri, 20 Sep 2019 17:54:30 +0000 (17:54 +0000)]
code cleanup: rubocop: fix Style/ClassCheck in lib/redmine/scm/adapters/cvs_adapter.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18490 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agorubocop: remove app/models/issue.rb from Lint/DuplicateMethods fixed by previous...
Toshi MARUYAMA [Fri, 20 Sep 2019 15:03:58 +0000 (15:03 +0000)]
rubocop: remove app/models/issue.rb from Lint/DuplicateMethods fixed by previous two revisions

git-svn-id: http://svn.redmine.org/redmine/trunk@18489 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoremove "attr_reader :current_journal" from Issue class
Toshi MARUYAMA [Fri, 20 Sep 2019 15:03:48 +0000 (15:03 +0000)]
remove "attr_reader :current_journal" from Issue class

Issue#current_journal is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18488 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agouse "attr_writer" instead of "attr_accessor" for Issue#deleted_attachment_ids
Toshi MARUYAMA [Fri, 20 Sep 2019 15:03:37 +0000 (15:03 +0000)]
use "attr_writer" instead of "attr_accessor" for Issue#deleted_attachment_ids

Issue#deleted_attachment_ids is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18487 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode clean up app/models/repository.rb
Toshi MARUYAMA [Fri, 20 Sep 2019 13:58:41 +0000 (13:58 +0000)]
code clean up app/models/repository.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18486 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/LeadingCommentSpace in app/models/repository.rb
Toshi MARUYAMA [Fri, 20 Sep 2019 13:58:30 +0000 (13:58 +0000)]
code cleanup: rubocop: fix Layout/LeadingCommentSpace in app/models/repository.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18485 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoFixes not to call set_tmp_attachments_directory twice after each test (#32094).
Go MAEDA [Fri, 20 Sep 2019 01:31:13 +0000 (01:31 +0000)]
Fixes not to call set_tmp_attachments_directory twice after each test (#32094).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18484 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoRounded corners of the main menu (#32013).
Go MAEDA [Fri, 20 Sep 2019 00:57:02 +0000 (00:57 +0000)]
Rounded corners of the main menu (#32013).

Patch by Antonio McDeal.

git-svn-id: http://svn.redmine.org/redmine/trunk@18483 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoUpdate Rouge to 3.11.0 (#31556).
Go MAEDA [Thu, 19 Sep 2019 16:07:42 +0000 (16:07 +0000)]
Update Rouge to 3.11.0 (#31556).

git-svn-id: http://svn.redmine.org/redmine/trunk@18482 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Style/StringLiteralsInInterpolation in app/helpers/issues_...
Toshi MARUYAMA [Thu, 19 Sep 2019 12:59:24 +0000 (12:59 +0000)]
code cleanup: rubocop: fix Style/StringLiteralsInInterpolation in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18481 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoLog info messages when MailHandler ignored a reply to a nonexistent issue, journal...
Go MAEDA [Thu, 19 Sep 2019 09:38:39 +0000 (09:38 +0000)]
Log info messages when MailHandler ignored a reply to a nonexistent issue, journal, or message (#31946).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18480 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/issues_helper.rb
Toshi MARUYAMA [Thu, 19 Sep 2019 06:11:15 +0000 (06:11 +0000)]
code cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18479 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agobackout r13743
Toshi MARUYAMA [Thu, 19 Sep 2019 05:49:21 +0000 (05:49 +0000)]
backout r13743

git-svn-id: http://svn.redmine.org/redmine/trunk@18478 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agocode cleanup: rubocop: fix Lint/UselessSetterCall in test/unit/issue_test.rb
Toshi MARUYAMA [Wed, 18 Sep 2019 01:56:43 +0000 (01:56 +0000)]
code cleanup: rubocop: fix Lint/UselessSetterCall in test/unit/issue_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18477 e93f8b46-1217-0410-a6f0-8f06a7374b81

5 years agoChange textfield to textarea for "Exclude attachments by name" (#19903).
Go MAEDA [Wed, 18 Sep 2019 01:25:47 +0000 (01:25 +0000)]
Change textfield to textarea for "Exclude attachments by name" (#19903).

Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18476 e93f8b46-1217-0410-a6f0-8f06a7374b81