source.dussan.org Git

Javen O'Neal [Sun, 9 Oct 2016 19:09:26 +0000 (19:09 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763999 13f79535-47bb-0310-9956-ffa450edef68

Javen O'Neal [Sun, 9 Oct 2016 19:03:49 +0000 (19:03 +0000)]

bug 60230: add disabled unit test from PJ Fanning for a roundtrip write/read of an encrypted XSSFWorkbook

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763998 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 18:06:46 +0000 (18:06 +0000)]

bug 60153: java.nio.charset.StandardCharsets is not available until Java 7. Use Charset.forName for Java 6 compatibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763997 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 12:58:46 +0000 (12:58 +0000)]

bug 60153: patch from PJ Fanning to demonstrate that SXSSFWorkbook SheetDataWriter can write encrypted temporary files to disk and the workbook can be AES encrypted when written to disk for a fully secure disk environment

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763969 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 12:15:39 +0000 (12:15 +0000)]

fix findbugs warning BC_VACUOUS_INSTANCEOF from bug 55075

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763965 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 10:59:34 +0000 (10:59 +0000)]

bug 60228: getCellTypeEnum should not be deprecated until after getCellType returns a CellType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763960 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 10:51:13 +0000 (10:51 +0000)]

bug 60153: findbugs OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE close opened streams if an exception is raised while decorating the stream

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763959 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 10:26:49 +0000 (10:26 +0000)]

bug 55075: add missing import

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763955 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 10:13:06 +0000 (10:13 +0000)]

bug 55075: remove wildcard import; previous commit contributed by Frank Ploessel

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763951 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 10:02:36 +0000 (10:02 +0000)]

bug 55075,51233: create drawings with correct height when rows are custom height

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763950 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 05:40:38 +0000 (05:40 +0000)]

bug 60021: add note that EncryptionInfo may require poi-ooxml.jar to run EncryptionModes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763944 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 04:43:14 +0000 (04:43 +0000)]

bug 60153: encrypt SXSSF temporary files; patch from PJ Fanning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763943 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 9 Oct 2016 03:02:13 +0000 (03:02 +0000)]

bug 60197: Workbook#setSheetOrder should update named range sheet indices

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763939 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 8 Oct 2016 23:41:08 +0000 (23:41 +0000)]

bug 60219: add disabled unit test for parsing formulas containing external workbook references with a quoted sheet name

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763937 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 8 Oct 2016 18:08:25 +0000 (18:08 +0000)]

Bug 60003 - Regression: HSLF Powerpoint text extractor from footer of master slide

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763927 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 8 Oct 2016 17:07:15 +0000 (17:07 +0000)]

Bug 60226 - ClassLoader workaround for OSGI when processing OOXML files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763922 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 7 Oct 2016 19:33:11 +0000 (19:33 +0000)]

Add initial compile steps with a simple multi-project setup to build.gradle
Adjust some tests to make them run fine in the Gradle build as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763816 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 7 Oct 2016 12:39:15 +0000 (12:39 +0000)]

bug 60216: javadocx fix for Comment#isVisible and Comment#setVisible; patch from Daniel Kueppers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763757 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 5 Oct 2016 20:13:38 +0000 (20:13 +0000)]

Bug 59958: Add simple test-case

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763487 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 5 Oct 2016 20:00:07 +0000 (20:00 +0000)]

Use IOUtils.closeQuietly() in more places
Avoid two possible file-handle leaks when opening files fails with an exception
Make tests close resources properly to not spam the output when running with file-leak-detector

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763485 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 5 Oct 2016 19:59:56 +0000 (19:59 +0000)]

Bug 53028: Broken auto fit row height in the cells with word wrap

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763484 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 5 Oct 2016 19:59:50 +0000 (19:59 +0000)]

Print out size of extracted text in CommandLineExtractor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763483 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 5 Oct 2016 19:59:44 +0000 (19:59 +0000)]

Some IDE warning fixes and unit test adjustments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763482 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 5 Oct 2016 10:39:03 +0000 (10:39 +0000)]

Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763399 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Murphy [Wed, 5 Oct 2016 02:23:52 +0000 (02:23 +0000)]

Add PropertyTemplate for drawing Borders (58787)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763338 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 30 Sep 2016 10:22:27 +0000 (10:22 +0000)]

Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762875 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 30 Sep 2016 07:02:02 +0000 (07:02 +0000)]

bug 60187: set BorderStyle directly instead of through short code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762859 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 30 Sep 2016 06:39:29 +0000 (06:39 +0000)]

bug 60187: replace methods operating on BorderStyle codes with BorderStyle enums

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762856 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 28 Sep 2016 23:36:09 +0000 (23:36 +0000)]

Bug 59857 - Password protected files with "Microsoft Enhanced Cryptographic Provider v1.0"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762726 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 28 Sep 2016 21:22:13 +0000 (21:22 +0000)]

merge trunk to branch

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762715 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 28 Sep 2016 21:01:40 +0000 (21:01 +0000)]

merge trunk to branch

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762709 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 28 Sep 2016 08:44:14 +0000 (08:44 +0000)]

Adjust some JavaDoc and remove some unnecessary String.valueOf() calls and fix some other compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762617 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 25 Sep 2016 02:21:41 +0000 (02:21 +0000)]

add onealj@apache.org 8BABDD6C to KEYS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762154 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 09:30:24 +0000 (09:30 +0000)]

ignore .gradle directory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761875 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 09:24:48 +0000 (09:24 +0000)]

bug 57843: add failing unit test: Word 6.0 (1993) fails with ArrayIndexOutOfBoundsException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761873 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 09:21:56 +0000 (09:21 +0000)]

add gradle build script for building POI with gradle

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761871 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 07:50:33 +0000 (07:50 +0000)]

bug 59687: correctly delete comments from rows when removing a row and the workbook contains empty rows above the deleted row; patch from Greg Woolsey

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761861 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 07:36:52 +0000 (07:36 +0000)]

bug 59687: add failing unit test showing that comments when the row that contains the comment is deleted; patch and file contributed by Greg Woolsey

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761860 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 04:37:04 +0000 (04:37 +0000)]

check column outline level for bug 55076

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761847 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 04:24:22 +0000 (04:24 +0000)]

add failing unit test for bug 55076: collapsing column groups only hides the first column

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761846 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 04:02:56 +0000 (04:02 +0000)]

fix NPE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761844 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 03:48:49 +0000 (03:48 +0000)]

use equalsIgnoreCase for case-insensitive string comparisons

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761843 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 03:37:09 +0000 (03:37 +0000)]

add comment for purpose of test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761842 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 22 Sep 2016 03:29:00 +0000 (03:29 +0000)]

bug 45565: add failing unit test for bug 45565

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761841 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Wed, 21 Sep 2016 22:03:57 +0000 (22:03 +0000)]

Add 3,15 to DOAP file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761823 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 21 Sep 2016 05:45:57 +0000 (05:45 +0000)]

Compiler/IDE warnings, unnecessary keywords,

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761675 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 05:32:26 +0000 (05:32 +0000)]

replace @Ignore with POITestCase.skipTest/testPassesNow

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761674 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 05:20:36 +0000 (05:20 +0000)]

bug 59983: add failing unit test demonstrating formula shifting is apply twice to shared formulas; patch from Luca Martini

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761673 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 05:03:57 +0000 (05:03 +0000)]

add fixturing for notifying us when a previously failing unit test passes (better than @Ignore)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761672 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 03:57:22 +0000 (03:57 +0000)]

bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761669 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 03:31:15 +0000 (03:31 +0000)]

bug 60153: move flushSheets out to its own method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761668 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 03:19:31 +0000 (03:19 +0000)]

bug 57200,59788: be more specific why a temporary directory could not be created

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761667 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 02:45:39 +0000 (02:45 +0000)]

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 02:43:55 +0000 (02:43 +0000)]

javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761664 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 02:12:54 +0000 (02:12 +0000)]

bug 59933: demote accessibility of NullLogger methods to the same level as POILogger

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761662 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 02:05:58 +0000 (02:05 +0000)]

make POILogFactory _loggers cache final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761660 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 01:41:54 +0000 (01:41 +0000)]

bug 59933: override POILogger#log(int, Object...) in NullLogger

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761657 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 01:15:39 +0000 (01:15 +0000)]

fix copy-paste error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761655 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 01:14:26 +0000 (01:14 +0000)]

include class of caught exception

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761654 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 21 Sep 2016 01:03:12 +0000 (01:03 +0000)]

bug 60158: add failing test cases for AIOOBE on VBAMacroReader

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761652 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 20 Sep 2016 20:24:54 +0000 (20:24 +0000)]

Adjust handling of ByteBuffer some more

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761636 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 20 Sep 2016 09:59:01 +0000 (09:59 +0000)]

bug 59853: exclude BaseTestXSSFPivotTable from ooxml-lite

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761545 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 20 Sep 2016 07:55:13 +0000 (07:55 +0000)]

bug 59853: support PivotTables with named structured references; patch from Greg Woolsey

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761537 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 19 Sep 2016 00:20:44 +0000 (00:20 +0000)]

merge trunk to branch

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1761376 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Sat, 17 Sep 2016 09:33:43 +0000 (09:33 +0000)]

prepare for 3.16-beta1

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761167 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Sat, 17 Sep 2016 08:50:18 +0000 (08:50 +0000)]

release prepare for 3.15 - updating build.xml and status.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761161 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Sat, 17 Sep 2016 07:49:52 +0000 (07:49 +0000)]

prepare for 3.16-beta1

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761144 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David North [Sat, 17 Sep 2016 07:49:02 +0000 (07:49 +0000)]

release prepare for 3.15 - updating build.xml and status.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761142 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 16 Sep 2016 00:41:25 +0000 (00:41 +0000)]

+svnprops eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760987 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 16 Sep 2016 00:32:40 +0000 (00:32 +0000)]

bug 59705: consolidate bounds checking of column index into a helper method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760986 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Thu, 15 Sep 2016 00:19:52 +0000 (00:19 +0000)]

POI 60140 Prevent unnecessary memory usage -- no need to cache HeapByteBuffer in FileBackedDataSource, thanks to Luis Filipe Nassif for diagnosing this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760816 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 22:43:08 +0000 (22:43 +0000)]

sheet names are case insensitive

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760814 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 22:11:14 +0000 (22:11 +0000)]

make sure workbook can be written out and read back for all TestXSSFPivotTable tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760811 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 22:01:11 +0000 (22:01 +0000)]

convert TestXSSFPivotTable to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760806 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 21:44:06 +0000 (21:44 +0000)]

declare methods throw runtime exceptions for IDE hints

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760798 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 21:32:34 +0000 (21:32 +0000)]

declare methods throw runtime exceptions for IDE hints

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760784 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 19:24:49 +0000 (19:24 +0000)]

bug 60128: remove forbidden-api Exception.printStackTrace()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760744 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 18:41:21 +0000 (18:41 +0000)]

bug 60128: exclude openxml4j/invalid.xlsx from additional integration (stress) tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760743 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 17:55:51 +0000 (17:55 +0000)]

add compile-examples dependency to compile-integration. o.a.p.xssf.eventusermodel.XLSX2CSV and o.a.p.xssf.eventusermodel.examples.FromHowTo are needed for o.a.p.stress.XSSFFileHandler.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760736 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 17:48:00 +0000 (17:48 +0000)]

bug 60128: add test-data/openxml4j/invalid.xlsx to expected failures for integration test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760735 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 17:25:03 +0000 (17:25 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760733 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 17:21:31 +0000 (17:21 +0000)]

bug 60128: make code Java 6 compatible. Throwable#addSuppressed not available until Java 7

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760732 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 14 Sep 2016 15:01:57 +0000 (15:01 +0000)]

Javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760719 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 14 Sep 2016 14:59:00 +0000 (14:59 +0000)]

Patches from Patrick Zimmermann from bugs #60130 and #60131 - DGET fix for empty cells and D* coding improvements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760717 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 13:56:03 +0000 (13:56 +0000)]

make logger final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760711 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 13:55:39 +0000 (13:55 +0000)]

bug 60128: close opened resources to avoid leaks; add exception as cause where available for more context for raised exceptions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760710 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 13:28:27 +0000 (13:28 +0000)]

give more helpful exceptions rather than returning null when zip file cannot be opened

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760708 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 12:57:39 +0000 (12:57 +0000)]

bug 60128: close open file descriptors when exceptions are thrown from OPCPackage.open

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760702 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 14 Sep 2016 12:35:34 +0000 (12:35 +0000)]

Unit test for bug #60128, showing that calling close on a broken package cleans up file or stream

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760693 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 07:53:58 +0000 (07:53 +0000)]

move HSSFFormulaEvaluator#evaluateInCell and BaseXSSFFormulaEvaluator#evaluateInCell(Cell) up to BaseFormulaEvaluator to reduce duplicated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760651 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 07:33:20 +0000 (07:33 +0000)]

move BaseXSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) and HSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) up to BaseFormulaEvaluator class to reduce duplicated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760647 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 06:42:20 +0000 (06:42 +0000)]

bug 59791: add deprecation and removal annotations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760641 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 06:22:38 +0000 (06:22 +0000)]

bug 59791: add deprecation warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760639 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 05:51:52 +0000 (05:51 +0000)]

bug 59791: add deprecation and removal annotations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760634 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 05:41:40 +0000 (05:41 +0000)]

bug 58190: add @since annotations to SlideShow.addPicture and findPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760633 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 05:31:48 +0000 (05:31 +0000)]

bug 58671: add @Removal annotation to deprecated fields

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760632 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 05:22:23 +0000 (05:22 +0000)]

bug 59264: revert CellStyle#getBorder[Top|Bottom|Left|Right]() to return short and add getBorder[Top|Bottom|Left|Right]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760630 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 04:35:45 +0000 (04:35 +0000)]

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 03:51:45 +0000 (03:51 +0000)]

bug 59790: add @Removal annotations to deprecated methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760624 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 14 Sep 2016 03:33:52 +0000 (03:33 +0000)]

bug 59833: add @Removal annotation to deprecated methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760623 13f79535-47bb-0310-9956-ffa450edef68