]> source.dussan.org Git - vaadin-framework.git/log
vaadin-framework.git
3 years agoApplied save actions to compatibility Grid client-side classes. (#12389) 8.14.0.beta1
Anna Koskinen [Fri, 27 Aug 2021 11:01:08 +0000 (14:01 +0300)]
Applied save actions to compatibility Grid client-side classes. (#12389)

3 years agochore: Update liferay kernel version (#12387)
Tatu Lund [Thu, 26 Aug 2021 14:59:38 +0000 (17:59 +0300)]
chore: Update liferay kernel version (#12387)

Enables to use Liferay 7.4.x

3 years agoFix compatibility Grid column reorder with partially hidden joined cells (#12385)
Anna Koskinen [Thu, 26 Aug 2021 09:49:22 +0000 (12:49 +0300)]
Fix compatibility Grid column reorder with partially hidden joined cells (#12385)

Fixes #12377

3 years agoCleaned out old references to removed buildhelpers and widgets modules. (#12383)
Anna Koskinen [Wed, 25 Aug 2021 14:08:07 +0000 (17:08 +0300)]
Cleaned out old references to removed buildhelpers and widgets modules. (#12383)

3 years agoUpdate to Jsoup 1.14.2 (#12381)
Tatu Lund [Tue, 24 Aug 2021 10:53:34 +0000 (13:53 +0300)]
Update to Jsoup 1.14.2 (#12381)

3 years agoSome Checkstyle fixes. (#12379)
Anna Koskinen [Tue, 24 Aug 2021 09:48:45 +0000 (12:48 +0300)]
Some Checkstyle fixes. (#12379)

- Added and updated JavaDocs.
- Deprecated unused fields and methods that update them.
- Suppressed unavoidable deprecated calls.
- Switched other deprecated calls to use currently recommended calls.

3 years agoCheckstyle fixes for SplitPanel widgets. (#12378)
Anna Koskinen [Mon, 23 Aug 2021 14:09:01 +0000 (17:09 +0300)]
Checkstyle fixes for SplitPanel widgets. (#12378)

- Added and updated JavaDocs.
- Added default cases to Switch statements.
- Deprecated unused fields.
- Switched to use non-deprecated calls where possible.

3 years agoSome Checkstyle tweaks. (#12376)
Anna Koskinen [Mon, 23 Aug 2021 05:49:41 +0000 (08:49 +0300)]
Some Checkstyle tweaks. (#12376)

- Added and updated JavaDocs.
- Formatting fixes.
- Suppressed deprecation warnings.

3 years agoUpdates to TreeGrid's ensureAvailability handling. (#12374)
Anna Koskinen [Fri, 20 Aug 2021 11:27:18 +0000 (14:27 +0300)]
Updates to TreeGrid's ensureAvailability handling. (#12374)

- Always update the availability request range when more or less data
becomes available. Otherwise e.g. programmatically expanding a TreeGrid
row can lead to discarding a lot of the new data right after receiving
it.

Fixes #12372

3 years agoEnsure visible tab search only covers existing tabs. (#12373)
Anna Koskinen [Wed, 18 Aug 2021 08:23:25 +0000 (11:23 +0300)]
Ensure visible tab search only covers existing tabs. (#12373)

Fixes #11673

3 years agoUpdate release note template for 8.14 (#12371) 8.14.0.alpha1
Zhe Sun [Tue, 17 Aug 2021 10:18:37 +0000 (13:18 +0300)]
Update release note template for 8.14 (#12371)

3 years agoUpdated screenshots (#12370)
Anna Koskinen [Mon, 16 Aug 2021 07:23:38 +0000 (10:23 +0300)]
Updated screenshots (#12370)

3 years agoReworked and cleaned up client-side TabSheet and Accordion. (#12357)
Anna Koskinen [Fri, 13 Aug 2021 14:05:50 +0000 (17:05 +0300)]
Reworked and cleaned up client-side TabSheet and Accordion. (#12357)

- Added and corrected JavaDocs.
- Deprecated unused public methods.
- Fixed first tab style logic in TabSheet.
- Fixed navigation focus logic in TabSheet.
- Fixed tab width bookkeeping for scrolling TabSheet tabs.
- Renamed private methods and variables for clarity.
- Removed unnecessary or duplicated private methods.
- Reworked some logic to clarify it and to better match my understanding
of what's supposed to happen within those methods.
- Updated some deprecated method calls to use currently recommended
solutions.
- Added and updated regression tests.

3 years agoAdd detection of HCL Digital Experience rebranding (#12242)
Marcello Barnaba [Mon, 9 Aug 2021 13:55:48 +0000 (15:55 +0200)]
Add detection of HCL Digital Experience rebranding (#12242)

On HCL Digital Experience 8.5.5 CF19, the `getPortalInfo()` method returns
"hcl digital experience/8.5", breaking detection of the servlet engine.

This ultimately leads to methods such as `getHeader()` to return NULL, as
the upstream HTTP request is not retrieved.

3 years agoUpdated the version of vaadin-context-menu (#12363)
CodeMonkeyLab [Mon, 9 Aug 2021 11:49:35 +0000 (12:49 +0100)]
Updated the version of vaadin-context-menu (#12363)

Moving to new version removes the warning
com.vaadin.event.EventRouter addListener WARNING: Adding listeners with type Object is deprecated, event listener should extend SerializableEventListener

3 years agofix: Prevent deadlock in findOrCreateVaadinSession (#12355)
Tatu Lund [Mon, 9 Aug 2021 10:36:39 +0000 (13:36 +0300)]
fix: Prevent deadlock in findOrCreateVaadinSession (#12355)

It is possible findOrCreateVaadinSession leaves session locked if HTTP session is invalidated in an another thread between lockSession and unlockSession calls. This PR changes the implementation so that this can no longer happen.

fixes: #12352

3 years agofix: Avoid processing value change event due writing back of converted value (#12360)
Tatu Lund [Fri, 6 Aug 2021 15:30:53 +0000 (18:30 +0300)]
fix: Avoid processing value change event due writing back of converted value (#12360)

This is both a optimization by skipping duplicate validation round and avoids ConcurrentModificationExpectation being thrown certain corner cases.

3 years agoChrome updated to version 92 (#12358)
Anna Koskinen [Fri, 6 Aug 2021 08:30:10 +0000 (11:30 +0300)]
Chrome updated to version 92 (#12358)

3 years agoSplit too long method in two. (#12351)
Anna Koskinen [Tue, 27 Jul 2021 13:44:56 +0000 (16:44 +0300)]
Split too long method in two. (#12351)

3 years agoImproved error login in GridColumnResizeModeTest. (#12350)
Anna Koskinen [Tue, 27 Jul 2021 11:31:23 +0000 (14:31 +0300)]
Improved error login in GridColumnResizeModeTest. (#12350)

3 years agoCheckstyle fixes. (#12349)
Anna Koskinen [Tue, 27 Jul 2021 08:41:25 +0000 (11:41 +0300)]
Checkstyle fixes. (#12349)

- Added and completed JavaDocs.
- Fixed a typo in logging.
- Removed an unused parameter in a private method.

3 years agoDeprecating Flash component. (#12348)
Anna Koskinen [Mon, 26 Jul 2021 08:04:05 +0000 (11:04 +0300)]
Deprecating Flash component. (#12348)

Also added missing JavaDocs.

3 years agoDivide too long Grid and Escalator methods into smaller units. (#12340)
Anna Koskinen [Fri, 23 Jul 2021 15:56:52 +0000 (18:56 +0300)]
Divide too long Grid and Escalator methods into smaller units. (#12340)

3 years agoCheckstyle fixes (#12347)
Anna Koskinen [Fri, 23 Jul 2021 12:41:25 +0000 (15:41 +0300)]
Checkstyle fixes (#12347)

- Added, completed, and corrected JavaDocs.
- Added an assert to enforce a condition that has always been required.
- Added default sections to switch blocks.
- Added wildcards.
- Deprecated unused methods and variables.
- Removed inner assignments.
- Removed unused private variables and calls that do nothing.
- Updated deprecated calls to use currently recommended versions.
- Updated warning suppressions.
- ...and some auto-formatting.

3 years agoBump jetty-webapp from 9.4.41.v20210516 to 9.4.43.v20210629 (#12344)
dependabot[bot] [Thu, 22 Jul 2021 11:01:32 +0000 (14:01 +0300)]
Bump jetty-webapp from 9.4.41.v20210516 to 9.4.43.v20210629 (#12344)

Bumps [jetty-webapp](https://github.com/eclipse/jetty.project) from 9.4.41.v20210516 to 9.4.43.v20210629.
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.41.v20210516...jetty-9.4.43.v20210629)

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-webapp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 years agofix: Reuse existing filesystem (#12346)
Anna Koskinen [Thu, 22 Jul 2021 10:01:10 +0000 (13:01 +0300)]
fix: Reuse existing filesystem (#12346)

Modified cherry-pick of https://github.com/vaadin/flow/pull/11428

3 years agoEnsure Grid details rows get a full refresh when a column is sorted. (#12342)
Anna Koskinen [Wed, 21 Jul 2021 09:44:51 +0000 (12:44 +0300)]
Ensure Grid details rows get a full refresh when a column is sorted. (#12342)

Fixes #12341

3 years agoCheckstyle fixes (#12339)
Anna Koskinen [Thu, 15 Jul 2021 13:21:10 +0000 (16:21 +0300)]
Checkstyle fixes (#12339)

- Added missing default sections to switch blocks.
- Added missing JavaDocs and JavaDoc parameters.
- Added wildcards where possible.
- Deprecated unused method.
- Fixed JavaDoc formatting.
- Removed inner assignments.
- Removed unused imports.
- Removed unused variables.
- Removed warning suppressions that were unnecessary or about boxing
(not tracked by coding conventions).
- Suppressed warnings about rawtypes, deprecation, and unchecked where
couldn't be avoided.

3 years agoCode cleanup (#12333)
Anna Koskinen [Thu, 8 Jul 2021 09:04:58 +0000 (12:04 +0300)]
Code cleanup (#12333)

- removed unused private methods
- removed unused private variables
- removed unnecessary initializations
- removed unnecessary substring(0)
- removed inner assignments
- renamed private methods that started with upper case
- renamed static final variables to use upper case
- converted to use non-deprecated options
- suppressed unavoidable warnings
- divided long Strings to multiple lines
- added missing types
- added missing JavaDoc parameters
- formatting
- updated comments & JavaDocs

3 years agoEnsure removing a row does not cause exceptions in detail row handling. (#12330)
Anna Koskinen [Wed, 30 Jun 2021 08:53:18 +0000 (11:53 +0300)]
Ensure removing a row does not cause exceptions in detail row handling. (#12330)

Fixes: #12328
3 years agofix: don't serve directories as static files (#12325)
Anna Koskinen [Wed, 23 Jun 2021 12:29:23 +0000 (15:29 +0300)]
fix: don't serve directories as static files (#12325)

Also prevents opening FileSystem for unknown schemes.

Modified cherry-picks of https://github.com/vaadin/flow/pull/11072 ,
https://github.com/vaadin/flow/pull/11147 , and
https://github.com/vaadin/flow/pull/11235

3 years agofix: add JavaDoc warning to avoid using ResponseWriter for directories (#12324)
Anna Koskinen [Tue, 15 Jun 2021 13:28:13 +0000 (16:28 +0300)]
fix: add JavaDoc warning to avoid using ResponseWriter for directories (#12324)

* fix: add JavaDoc warning to avoid using ResponseWriter for directories

Cherry-picked from: https://github.com/vaadin/flow/pull/11112

3 years agoBump jetty-servlets from 9.4.38.v20210224 to 9.4.41.v20210516 (#12322)
dependabot[bot] [Mon, 14 Jun 2021 08:14:47 +0000 (11:14 +0300)]
Bump jetty-servlets from 9.4.38.v20210224 to 9.4.41.v20210516 (#12322)

- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.38.v20210224...jetty-9.4.41.v20210516)

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-servlets
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
3 years agoChrome 91 test fixes (#12323)
Anna Koskinen [Mon, 14 Jun 2021 05:56:15 +0000 (08:56 +0300)]
Chrome 91 test fixes (#12323)

3 years agoSmall updates to servlet container test setup. (#12318)
Zhe Sun [Mon, 31 May 2021 07:15:11 +0000 (10:15 +0300)]
Small updates to servlet container test setup. (#12318)

* Small updates to servlet container test setup.

- Upgraded to use cargo-maven3-plugin since cargo-maven2-plugin is now
EOL.
- Defined supported packagings as the current jetty-maven-plugin default
only covers war.
- Changed a test pojo to implement Serializable in order to prevent an
error in cargo-maven3-plugin stop-container phase.

3 years agoTrigger repositioning after full refresh of current details. (#12312)
Anna Koskinen [Thu, 20 May 2021 08:18:16 +0000 (11:18 +0300)]
Trigger repositioning after full refresh of current details. (#12312)

Fixes #12310

3 years agoinclude @font-face definition in mixin so -icons variable has effect (#12295)
Raffael [Tue, 18 May 2021 08:38:03 +0000 (10:38 +0200)]
include @font-face definition in mixin so -icons variable has effect (#12295)

3 years agoUpdate Atmosphere (#12293)
Tatu Lund [Mon, 17 May 2021 09:33:17 +0000 (12:33 +0300)]
Update Atmosphere (#12293)

Fixes concurrency issue with UUIDBroadcasterCache that may lead to loss of packets and thus repeated resynchronizations when using Push.

3 years agoRemoved outdated readme.txt (#12296)
Anna Koskinen [Wed, 12 May 2021 16:17:54 +0000 (19:17 +0300)]
Removed outdated readme.txt (#12296)

3 years agoUpdated comparison screenshots for servlet containers module. (#12294)
Anna Koskinen [Wed, 12 May 2021 09:56:05 +0000 (12:56 +0300)]
Updated comparison screenshots for servlet containers module. (#12294)

* Updated comparison screenshots for servlet containers module.

3 years agoFix TabSheetElement clicks for IE, test tweaks. (#12291)
Anna Koskinen [Fri, 7 May 2021 08:32:07 +0000 (11:32 +0300)]
Fix TabSheetElement clicks for IE, test tweaks. (#12291)

- Backspace navigation hasn't worked in years thanks to new browser
standards, removed related tests. Left a test for regular backspace use
within a modal window.
- Enabled a modal window test for Chrome since it seems to be working
now, removed extending of another test class to avoid running the tests
twice without any configuration changes.
- Adjusted browser width limitation.
- Added screenshots.

3 years agoUpdate Liferay kernel dependency range to [7.0.0,12.0.0) (#12290)
Tatu Lund [Tue, 4 May 2021 12:35:10 +0000 (15:35 +0300)]
Update Liferay kernel dependency range to [7.0.0,12.0.0) (#12290)

Fixes: https://github.com/vaadin/framework/issues/12285
3 years agoTest screenshots for Firefox (#12288)
Anna Koskinen [Tue, 4 May 2021 10:41:16 +0000 (13:41 +0300)]
Test screenshots for Firefox (#12288)

* Test screenshots for Firefox

3 years agoTest tweaks (#12287)
Anna Koskinen [Tue, 4 May 2021 07:47:11 +0000 (10:47 +0300)]
Test tweaks (#12287)

3 years agoBump commons-io from 2.4 to 2.7 (#12278)
dependabot[bot] [Mon, 3 May 2021 11:23:41 +0000 (14:23 +0300)]
Bump commons-io from 2.4 to 2.7 (#12278)

Bumps commons-io from 2.4 to 2.7.

Signed-off-by: dependabot[bot] <support@github.com>
3 years agoAttempts to reduce test flakiness (#12283)
Anna Koskinen [Mon, 3 May 2021 07:31:31 +0000 (10:31 +0300)]
Attempts to reduce test flakiness (#12283)

* Attempts to reduce test flakiness

3 years agoEnsure large tooltips can be closed on touch devices. (#12282)
Anna Koskinen [Fri, 30 Apr 2021 11:34:16 +0000 (14:34 +0300)]
Ensure large tooltips can be closed on touch devices. (#12282)

Fixes #10435

3 years agoFix validation in non-buffered Grid editor (#12281)
Tarek Oraby [Wed, 28 Apr 2021 14:47:32 +0000 (17:47 +0300)]
Fix validation in non-buffered Grid editor (#12281)

Handle possible race condition by disabling the editor's widget while awaiting validation from the server.

Fixes #12270

3 years agoUpdated browser versions and screenshots, test tweaks for stability. (#12271)
Anna Koskinen [Tue, 27 Apr 2021 10:32:16 +0000 (13:32 +0300)]
Updated browser versions and screenshots, test tweaks for stability. (#12271)

3 years agoTest tweak: repeat selection for stability (#12267)
Anna Koskinen [Tue, 20 Apr 2021 08:54:22 +0000 (11:54 +0300)]
Test tweak: repeat selection for stability (#12267)

3 years agoAdd browser specific handling in setRows (#12141)
Tatu Lund [Mon, 19 Apr 2021 07:52:08 +0000 (10:52 +0300)]
Add browser specific handling in setRows (#12141)

* Add browser specific handling in setRows

Fixes: https://github.com/vaadin/framework/issues/10138
Fixes: https://github.com/vaadin/framework/issues/7878
* Enforced minimum height to 1 rows and added a test.

Co-authored-by: Anna Koskinen <anna@vaadin.com>
3 years agoUpdated IE screenshots, added some test delays for stability (#12266)
Anna Koskinen [Thu, 15 Apr 2021 12:21:30 +0000 (15:21 +0300)]
Updated IE screenshots, added some test delays for stability (#12266)

3 years agoUpdated Firefox screenshots (#12265)
Anna Koskinen [Wed, 14 Apr 2021 14:03:44 +0000 (17:03 +0300)]
Updated Firefox screenshots (#12265)

3 years agoUpdate 8.14-SNAPSHOT and release note (#12261)
Zhe Sun [Wed, 14 Apr 2021 09:02:35 +0000 (12:02 +0300)]
Update 8.14-SNAPSHOT and release note (#12261)

3 years agoFix Window dragging on touch screen. (#12260)
Anna Koskinen [Wed, 31 Mar 2021 05:34:29 +0000 (08:34 +0300)]
Fix Window dragging on touch screen. (#12260)

- Added check for touch move event in order to allow the same flow for
both mouse and touch events when dragging a Window by its header.
- Can be tested with SubwindowDraggability class.

Fixes #12257

Co-authored-by: Jakub Antoniak <j.antoniak8@gmail.com>
3 years agoAdd ErrorHandler to AbstractTestUI (#12256)
Anna Koskinen [Mon, 29 Mar 2021 12:52:45 +0000 (15:52 +0300)]
Add ErrorHandler to AbstractTestUI (#12256)

* Add ErrorHandler to AbstractTestUI

3 years agoRevert "Add logging to uitest module TB test fails. (#12249)" (#12255)
Anna Koskinen [Fri, 26 Mar 2021 15:42:12 +0000 (17:42 +0200)]
Revert "Add logging to uitest module TB test fails. (#12249)" (#12255)

This reverts commit 8c39731123b56ef5fa08a614b9aa1b55bd53e5cc.

3 years agoInclude compatibility tests in validation builds (#12250)
Anna Koskinen [Fri, 26 Mar 2021 14:37:44 +0000 (16:37 +0200)]
Include compatibility tests in validation builds (#12250)

3 years agochore: Change Jetty version to 9.4.38.v20210224 (#12248)
Tatu Lund [Tue, 23 Mar 2021 08:58:16 +0000 (10:58 +0200)]
chore: Change Jetty version to 9.4.38.v20210224 (#12248)

Avoids dependency security alert

3 years agoAdd logging to uitest module TB test fails. (#12249)
Anna Koskinen [Fri, 19 Mar 2021 13:38:10 +0000 (15:38 +0200)]
Add logging to uitest module TB test fails. (#12249)

- Override ParallelRunner of TestBench 5.2.0 for uitest module in order
to intercept and log uncaught exceptions in
TBMethod.invokeExplosively(...).

3 years agoRename comparison screenshot (#12247)
Anna Koskinen [Fri, 19 Mar 2021 08:45:58 +0000 (10:45 +0200)]
Rename comparison screenshot (#12247)

3 years agofeat: Add API to control whether Binder converts back to presentation (#12246)
Tatu Lund [Thu, 18 Mar 2021 16:12:37 +0000 (18:12 +0200)]
feat: Add API to control whether Binder converts back to presentation (#12246)

#12132 fixed an old bug, conversion was not done back, which was a regression from Vaadin 7. However since the bug has been present long time, it has become established behavior, thus there may be need to disable conversion back to presentation sometimes, thus this API as added.

3 years agoTest fixes (#12244)
Anna Koskinen [Thu, 18 Mar 2021 12:35:55 +0000 (14:35 +0200)]
Test fixes (#12244)

3 years agofix: Update regexp pattern of legacy EmailValidator (#12241)
Tatu Lund [Fri, 12 Mar 2021 16:45:25 +0000 (18:45 +0200)]
fix: Update regexp pattern of legacy EmailValidator (#12241)

Fixes: https://github.com/vaadin/framework/issues/12240
3 years agoAdd delay to a flaky test. (#12238)
Anna Koskinen [Fri, 12 Mar 2021 08:47:21 +0000 (10:47 +0200)]
Add delay to a flaky test. (#12238)

3 years agoUpdated release notes (#12237) 8.13.0.alpha1
Tatu Lund [Thu, 11 Mar 2021 16:49:25 +0000 (18:49 +0200)]
Updated release notes (#12237)

3 years agoAdd missing 8.13 since tag (#12236)
Zhe Sun [Thu, 11 Mar 2021 14:42:18 +0000 (16:42 +0200)]
Add missing 8.13 since tag (#12236)

3 years agoOptimized #12211 fix. (#12234)
Anna Koskinen [Wed, 10 Mar 2021 12:59:27 +0000 (14:59 +0200)]
Optimized #12211 fix. (#12234)

3 years agoRemove outdated comment (#12233)
Anna Koskinen [Tue, 9 Mar 2021 12:00:00 +0000 (14:00 +0200)]
Remove outdated comment (#12233)

3 years agoFix updating Escalator's physical row index. (#12232)
Anna Koskinen [Mon, 8 Mar 2021 13:38:40 +0000 (15:38 +0200)]
Fix updating Escalator's physical row index. (#12232)

* Fix updating Escalator's physical row index.

- Physical index should take into account that more than one row can
have a spacer. Physical index has no practical effect on how Grid looks
like or behaves, since Escalator by design operates independently of it
and the visual positioning of elements is based on the logical and
visual indices. Physical index only affects the order of elements
within the DOM tree, where a mismatch can cause confusion during
debugging.

3 years agoFix updating Grid's item set when details rows are open. (#12231)
Anna Koskinen [Mon, 8 Mar 2021 11:18:11 +0000 (13:18 +0200)]
Fix updating Grid's item set when details rows are open. (#12231)

- Old details should close.
- New details should open.
- If some row has details in both old and new item set, the details row
contents should get updated.
- Updating details row contents should not break the positioning of the
rows and details below.

Fixes #12211

3 years agoPrevent NPE in comparison (#12218)
Tatu Lund [Fri, 5 Mar 2021 12:03:39 +0000 (14:03 +0200)]
Prevent NPE in comparison (#12218)

Fixes: https://github.com/vaadin/framework/issues/12207
3 years agoAdd a delay to a flaky test. (#12216)
Anna Koskinen [Thu, 4 Mar 2021 11:00:04 +0000 (13:00 +0200)]
Add a delay to a flaky test. (#12216)

3 years agoUpdate copyright year range. (#12215)
Anna Koskinen [Thu, 4 Mar 2021 05:46:51 +0000 (07:46 +0200)]
Update copyright year range. (#12215)

* Update copyright year range.

3 years agoupdate to Atmosphere runtime 2.4.30.vaadin3 (#12214)
Olli Tietäväinen [Wed, 3 Mar 2021 17:37:21 +0000 (19:37 +0200)]
update to Atmosphere runtime 2.4.30.vaadin3 (#12214)

3 years agoRemove whitespace-maven-plugin and formatter-maven-plugin. (#12213)
Anna Koskinen [Wed, 3 Mar 2021 11:59:50 +0000 (13:59 +0200)]
Remove whitespace-maven-plugin and formatter-maven-plugin. (#12213)

- These plugins cause significant problems for many Windows developers,
and since most active maintainers are currently included in that group,
the plugins have been deemed more trouble than they are worth.

3 years agoFix displaying checkboxes within Grid editor row. (#12212)
Anna Koskinen [Wed, 3 Mar 2021 10:08:38 +0000 (12:08 +0200)]
Fix displaying checkboxes within Grid editor row. (#12212)

* Fix displaying checkboxes within Grid editor row.

- Checkbox margins should match regular row content margins.
- Multiselect checkbox label should only be visible for assistive
devices.

3 years agoAdd delays to a flaky test class. (#12209)
Anna Koskinen [Mon, 1 Mar 2021 09:08:36 +0000 (11:08 +0200)]
Add delays to a flaky test class. (#12209)

3 years agoFixed input to ensureAvailabilty (#12208)
Oliver Buchien [Fri, 26 Feb 2021 15:16:52 +0000 (16:16 +0100)]
Fixed input to ensureAvailabilty (#12208)

3 years agoMerged column headers should work within declarative Grid. (#12206)
Anna Koskinen [Fri, 26 Feb 2021 13:49:47 +0000 (15:49 +0200)]
Merged column headers should work within declarative Grid. (#12206)

- null check to prevent NPE from the merged column headers
- convert to internal columnIds for merge handling
- use correct cell in merge handling
- switch away from streams in merge handling for easier readability
- regression test

Fixes: #10464
3 years agoAdd API to prevent invalid input when integrated range validator is used (#12168)
Tatu Lund [Fri, 19 Feb 2021 09:11:49 +0000 (11:11 +0200)]
Add API to prevent invalid input when integrated range validator is used (#12168)

Do not fire DateField's value change event if the new date is not within the range.

Fixes: #12163
3 years agoAdded missing file ending (#12202)
Anna Koskinen [Tue, 16 Feb 2021 12:19:16 +0000 (14:19 +0200)]
Added missing file ending (#12202)

3 years agofix: Focus-activated shortcut listener in compatibility TextField (#12203)
Tatu Lund [Tue, 16 Feb 2021 11:16:49 +0000 (13:16 +0200)]
fix: Focus-activated shortcut listener in compatibility TextField (#12203)

3 years agoClear out ClientCache when UI is detached to prevent a minor memory leak (#12199)
Anna Koskinen [Thu, 11 Feb 2021 13:55:21 +0000 (15:55 +0200)]
Clear out ClientCache when UI is detached to prevent a minor memory leak (#12199)

* Clear out ClientCache when UI is detached to prevent a minor memory leak

Implemented with a listener rather than direct call from UI.detach() in
order to avoid new public API, since the whole feature has been marked
for removal. This doesn't yet prevent the cache or the type map from
getting slightly bloated during the UI's lifetime.

See: #3705

3 years agoRe-use ComputedStyles in Escalator when possible. (#12186)
Anna Koskinen [Fri, 5 Feb 2021 12:55:00 +0000 (14:55 +0200)]
Re-use ComputedStyles in Escalator when possible. (#12186)

3 years agoDead code removal (#12187)
Tatu Lund [Thu, 4 Feb 2021 15:30:41 +0000 (17:30 +0200)]
Dead code removal (#12187)

3 years agoRemove outdated IE10 compatibility class (#12193)
Anna Koskinen [Tue, 2 Feb 2021 09:14:27 +0000 (11:14 +0200)]
Remove outdated IE10 compatibility class (#12193)

Leftover from https://github.com/vaadin/framework/commit/0081286c8d05c3751803181230092bd4b1e769f7

3 years agofix: use time-constant comparison for CSRF tokens (#12188)
Tatu Lund [Mon, 1 Feb 2021 15:51:22 +0000 (17:51 +0200)]
fix: use time-constant comparison for CSRF tokens (#12188)

This hardens the framework against a theoretical timing attack based on
comparing how quickly a request with an invalid CSRF token is rejected.

Cherry-picked from: https://github.com/vaadin/flow/pull/9875

3 years agofix: use time-constant comparison for security tokens (#12189)
Tatu Lund [Fri, 29 Jan 2021 11:32:09 +0000 (13:32 +0200)]
fix: use time-constant comparison for security tokens (#12189)

This is the same as https://github.com/vaadin/framework/pull/12188,
but also applied for the upload security key
and the push id since both of those are also used to protect against
cross-site attacks. In addition, documentation for the push id is
clarified to point out its role.

Cherry-picked from: https://github.com/vaadin/flow/pull/9896

3 years agoDateField value should actively adjust to the set resolution. (#12183) 7.7.23
Anna Koskinen [Fri, 22 Jan 2021 11:08:02 +0000 (13:08 +0200)]
DateField value should actively adjust to the set resolution. (#12183)

3 years agoUpdate Atmosphere vaadin2 patch (#12181)
Tatu Lund [Mon, 18 Jan 2021 13:05:04 +0000 (15:05 +0200)]
Update Atmosphere vaadin2 patch (#12181)

3 years agoMove call to getMessageHandler().onResynchronize(); to right place (#12178)
Tatu Lund [Thu, 7 Jan 2021 11:21:46 +0000 (13:21 +0200)]
Move call to getMessageHandler().onResynchronize(); to right place (#12178)

https://github.com/vaadin/framework/pull/12043 changed resync message sending to be deferred to queue. Now also the setting of the semaphor in message handler needs to be deferred to its right place. Otherwise there is possibility for a timing glitch. I.e. MessageHandler is set to resync handling mode before message is actually send.

Fixes: https://github.com/vaadin/framework/issues/12151
3 years agoAdd getter for presentationProvider in Grid.Column (#10323) (#12060)
jdewaen [Fri, 18 Dec 2020 20:40:13 +0000 (21:40 +0100)]
Add getter for presentationProvider in Grid.Column (#10323) (#12060)

Without access to the presentation provider used for a column, it is often not possible to reconstruct the data as shown on the end-user's screen

This commit adds a getter method to Grid.Column to allow access to this provider

3 years agoFix to LayoutManager size calculations during transform. (#12138)
Anna Koskinen [Fri, 18 Dec 2020 11:16:26 +0000 (13:16 +0200)]
Fix to LayoutManager size calculations during transform. (#12138)

* Fix to LayoutManager size calculations during transform.

- ComputedStyle is slower but more reliable than using
getBoundingClientRect, which does not work as expected if a transform
has been applied to the element or one of its parents. This is a problem
e.g. with PopupView, where getBoundingClientRect will return too small
size (or even zero size) for all the popup contents while the opening
animation is active. ComputedStyle ignores the transform and returns the
expected value.
- The presence of the element in DOM must be checked before the size is
requested from ComputedStyle, if the element has disappeared from DOM
without a warning and calculation is attempted anyway, the browser gets
stuck.
- Possibility to configure LayoutManager to use the less reliable
calculations for applications where the slight performance difference is
more important than layout issues within elements that have transform
animations.
- Manual test, problem isn't reproducible by TestBench.

Fixes: #11187
3 years agoBetter error handling trying to enable HTML5 DnD for mobile from thread (#12170)
Anna Koskinen [Mon, 7 Dec 2020 14:40:15 +0000 (16:40 +0200)]
Better error handling trying to enable HTML5 DnD for mobile from thread (#12170)

- Informative error message
- Reset back to disabled state when enabling fails
- Incorrect usage also detectable using non-mobile devices

Fixes #12152

3 years agoTest tweaks (#12169)
Anna Koskinen [Mon, 7 Dec 2020 07:34:04 +0000 (09:34 +0200)]
Test tweaks (#12169)

* Test tweaks

- Divided HeaderFooterClickLeftRightMiddleTest tests to separate methods
based on click type
- Updated screenshot

3 years agoBump jetty.version from 9.4.34.v20201102 to 9.4.35.v20201120 (#12164)
dependabot[bot] [Thu, 3 Dec 2020 07:29:42 +0000 (09:29 +0200)]
Bump jetty.version from 9.4.34.v20201102 to 9.4.35.v20201120 (#12164)

Bumps `jetty.version` from 9.4.34.v20201102 to 9.4.35.v20201120.

Updates `jetty-server` from 9.4.34.v20201102 to 9.4.35.v20201120
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.34.v20201102...jetty-9.4.35.v20201120)

Updates `jetty-servlets` from 9.4.34.v20201102 to 9.4.35.v20201120
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.34.v20201102...jetty-9.4.35.v20201120)

Updates `websocket-server` from 9.4.34.v20201102 to 9.4.35.v20201120

Updates `jetty-webapp` from 9.4.34.v20201102 to 9.4.35.v20201120
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.34.v20201102...jetty-9.4.35.v20201120)

Updates `jetty-util` from 9.4.34.v20201102 to 9.4.35.v20201120
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.34.v20201102...jetty-9.4.35.v20201120)

Updates `jetty-proxy` from 9.4.34.v20201102 to 9.4.35.v20201120
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.34.v20201102...jetty-9.4.35.v20201120)

Updates `jetty-maven-plugin` from 9.4.34.v20201102 to 9.4.35.v20201120
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.34.v20201102...jetty-9.4.35.v20201120)

Signed-off-by: dependabot[bot] <support@github.com>
3 years agoMenuBar: Don't set openRootOnHover when on Android or IOS. (#12135)
Martin Vysny [Thu, 3 Dec 2020 04:16:58 +0000 (06:16 +0200)]
MenuBar: Don't set openRootOnHover when on Android or IOS. (#12135)

Fixes #5873

3 years agoBinder: Also use converter for user-changed values (#12132)
Tatu Lund [Thu, 3 Dec 2020 03:27:30 +0000 (05:27 +0200)]
Binder: Also use converter for user-changed values (#12132)

See: https://vaadin.com/forum/thread/15931682

3 years agoEnsure Composite's contents gets re-measured on resize. (#12154)
Anna Koskinen [Tue, 1 Dec 2020 09:34:32 +0000 (11:34 +0200)]
Ensure Composite's contents gets re-measured on resize. (#12154)

Fixes: #12153