]>
source.dussan.org Git - nextcloud-server.git/log
Julien Veyssier [Fri, 30 Sep 2022 22:43:23 +0000 (00:43 +0200)]
Merge pull request #34353 from nextcloud/fix/noid/reference-url-fallback
Reference url can always fallback to the link itself
Simon L [Fri, 30 Sep 2022 18:33:10 +0000 (20:33 +0200)]
Merge pull request #34333 from nextcloud/enh/33851/fix-tertiary-button
fix the tertiary button text
Vincent Petry [Fri, 30 Sep 2022 17:52:32 +0000 (19:52 +0200)]
Merge pull request #34348 from nextcloud/bugfix/34156/fix-rename-within-sharedwithyou
Fix renaming in shared with you file list
Julien Veyssier [Fri, 30 Sep 2022 17:12:39 +0000 (19:12 +0200)]
reference url can always fallback to the link itself
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
szaimen [Fri, 30 Sep 2022 17:01:51 +0000 (19:01 +0200)]
fix test
Signed-off-by: szaimen <szaimen@e.mail.de>
szaimen [Thu, 29 Sep 2022 17:18:08 +0000 (19:18 +0200)]
fix the tertiary button text
Signed-off-by: szaimen <szaimen@e.mail.de>
Christoph Wurst [Fri, 30 Sep 2022 14:46:42 +0000 (16:46 +0200)]
Merge pull request #34038 from nextcloud/fix/migrate-TagMapper-to-QBMapper
Migrate TagMapper to QBMapper instead of deprecated Mapper
Vincent Petry [Fri, 30 Sep 2022 13:39:30 +0000 (15:39 +0200)]
Fix renaming in shared with you file list
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Côme Chilliet [Fri, 30 Sep 2022 13:15:13 +0000 (15:15 +0200)]
Merge pull request #34346 from nextcloud/fix/add-pre-commit-to-expected-files
Add .pre-commit-config.yaml to expected files in checker
Côme Chilliet [Fri, 30 Sep 2022 13:06:04 +0000 (15:06 +0200)]
Merge pull request #34344 from nextcloud/fix/gitignore-files-modified-by-tests
Ignore files which are modified by our tests
Côme Chilliet [Fri, 30 Sep 2022 12:27:36 +0000 (14:27 +0200)]
add .pre-commit-config.yaml to expected files in checker
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Côme Chilliet [Fri, 30 Sep 2022 10:52:28 +0000 (12:52 +0200)]
Ignore files which are modified by our tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Joas Schilling [Fri, 30 Sep 2022 08:15:01 +0000 (10:15 +0200)]
Merge pull request #34328 from nextcloud/fix/fix-redis-type-error
Correctly handle Redis::keys returning false
Julius Härtl [Fri, 30 Sep 2022 06:07:47 +0000 (08:07 +0200)]
Merge pull request #34322 from nextcloud/bugfix/noid/limit-url-matching-to-https
Only match http(s) URLs for references
Nextcloud bot [Fri, 30 Sep 2022 02:55:26 +0000 (02:55 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Simon L [Thu, 29 Sep 2022 21:06:10 +0000 (23:06 +0200)]
Merge pull request #34321 from nextcloud/fix/invisible-status
Fix invisible status
nextcloud-command [Thu, 29 Sep 2022 18:07:53 +0000 (18:07 +0000)]
Compile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
John Molakvoæ (skjnldsv) [Thu, 29 Sep 2022 08:52:54 +0000 (10:52 +0200)]
Fix invisible status
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Côme Chilliet [Thu, 29 Sep 2022 16:56:39 +0000 (18:56 +0200)]
Merge pull request #32012 from nextcloud/cleanup/tags
Cleanup tags and share component
blizzz [Thu, 29 Sep 2022 16:41:23 +0000 (18:41 +0200)]
Merge pull request #33984 from nextcloud/enh/add-pre-commit-config-for-cs-fixer
Add pre commit config for cs fixer, EOF checks, etc
Carl Schwan [Tue, 19 Apr 2022 11:05:38 +0000 (13:05 +0200)]
Cleanup tags and Share component
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Joas Schilling [Thu, 29 Sep 2022 14:38:50 +0000 (16:38 +0200)]
Adjust tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
Simon L [Thu, 29 Sep 2022 14:16:53 +0000 (16:16 +0200)]
Merge pull request #34327 from nextcloud/fix/favourite
Fix starred favourite icon
Côme Chilliet [Thu, 29 Sep 2022 12:41:53 +0000 (14:41 +0200)]
Correctly handle Redis::keys returning false
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
John Molakvoæ (skjnldsv) [Thu, 29 Sep 2022 11:51:45 +0000 (13:51 +0200)]
Fix starred favourite icon
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Simon L [Thu, 29 Sep 2022 11:23:51 +0000 (13:23 +0200)]
Merge pull request #34313 from nextcloud/fix/34203/rm_videoplayer
unbundle files_videoplayer and clean up a little
Arthur Schiwon [Wed, 28 Sep 2022 16:13:53 +0000 (18:13 +0200)]
unbundle files_videoplayer and clean up a little
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Joas Schilling [Thu, 29 Sep 2022 09:13:18 +0000 (11:13 +0200)]
Only match http(s) URLs for references
Signed-off-by: Joas Schilling <coding@schilljs.com>
Nextcloud bot [Thu, 29 Sep 2022 02:33:10 +0000 (02:33 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Simon L [Wed, 28 Sep 2022 23:22:41 +0000 (01:22 +0200)]
Merge pull request #34308 from nextcloud/fix/user-status
Fix user status emoji picking
Simon L [Wed, 28 Sep 2022 22:32:07 +0000 (00:32 +0200)]
Merge pull request #34311 from nextcloud/fix/settings-bg
Remove unwanted settings button background
John Molakvoæ (skjnldsv) [Wed, 28 Sep 2022 14:39:27 +0000 (16:39 +0200)]
Remove unwanted settings button background
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command [Wed, 28 Sep 2022 18:58:43 +0000 (18:58 +0000)]
Compile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
John Molakvoæ (skjnldsv) [Wed, 28 Sep 2022 13:03:42 +0000 (15:03 +0200)]
Fix user status emoji picking
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Simon L [Wed, 28 Sep 2022 18:35:07 +0000 (20:35 +0200)]
Merge pull request #34287 from nextcloud/enh/33836/fix-theme
fix highcontrast theme
Julius Härtl [Wed, 28 Sep 2022 18:25:15 +0000 (20:25 +0200)]
Merge pull request #34215 from nextcloud/bugfix/cache-headers-reference
Add cache header for image endpoint if link previews
Pytal [Wed, 28 Sep 2022 17:57:41 +0000 (10:57 -0700)]
Merge pull request #34204 from nextcloud/fix/flashing-background-color
Fix various theming bugs
Christopher Ng [Sat, 24 Sep 2022 00:02:50 +0000 (00:02 +0000)]
Fix various theming bugs
Signed-off-by: Christopher Ng <chrng8@gmail.com>
blizzz [Wed, 28 Sep 2022 13:51:37 +0000 (15:51 +0200)]
Merge pull request #34306 from nextcloud/fix/noid/step-file-not-moved
fix default value for updatedirectory setting
Julius Härtl [Fri, 23 Sep 2022 10:42:08 +0000 (12:42 +0200)]
Add cache header for image endpoint if link previews
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Vincent Petry [Wed, 28 Sep 2022 13:09:03 +0000 (15:09 +0200)]
Merge pull request #34152 from nextcloud/bugfix/noid/db-password-install
Do not store generated mysql password if it was not used
Vincent Petry [Wed, 28 Sep 2022 13:06:09 +0000 (15:06 +0200)]
Merge pull request #34248 from nextcloud/bugfix/noid/ignore-invalid-share-types
Ignore invalid share types
Arthur Schiwon [Wed, 28 Sep 2022 12:39:12 +0000 (14:39 +0200)]
fix default value for updatedirectory setting
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Nextcloud bot [Wed, 28 Sep 2022 02:32:41 +0000 (02:32 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Vincent Petry [Tue, 27 Sep 2022 17:05:00 +0000 (19:05 +0200)]
Merge pull request #34288 from nextcloud/bugfix/34281/fix-copy-internal-link-focus
Fix focussing to internal link after copy
Vincent Petry [Tue, 27 Sep 2022 17:03:26 +0000 (19:03 +0200)]
Merge pull request #34292 from nextcloud/bugfix/33847/fix-gridview-publicpage
Fix grid view button in public page
Pytal [Tue, 27 Sep 2022 16:20:41 +0000 (09:20 -0700)]
Merge pull request #34272 from nextcloud/enh/shipped-background-primary-colors
Add primary color presets for shipped backgrounds
Vincent Petry [Tue, 27 Sep 2022 13:18:58 +0000 (15:18 +0200)]
Update apps/files_sharing/src/components/SharingEntryInternal.vue
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Vincent Petry [Tue, 27 Sep 2022 13:51:15 +0000 (15:51 +0200)]
Fix grid view button in public page
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
szaimen [Tue, 27 Sep 2022 10:14:38 +0000 (12:14 +0200)]
fix highcontrast theme icons
Signed-off-by: szaimen <szaimen@e.mail.de>
Vincent Petry [Tue, 27 Sep 2022 10:25:22 +0000 (12:25 +0200)]
Fix focussing to internal link after copy
Since a recent change to NcActions it's not possible to add a "ref"
attribute on a NcAction* component.
As a workaround, a ref was added on the NcActions parent component
instead.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Julien Veyssier [Tue, 27 Sep 2022 09:26:20 +0000 (11:26 +0200)]
Merge pull request #34263 from nextcloud/bugfix/noid/resolve-get-cachable
Add endpoint to fetch a cachable reference data
Joas Schilling [Tue, 27 Sep 2022 09:25:11 +0000 (11:25 +0200)]
Merge pull request #34134 from nextcloud/Valdnet-patch-4
l10n: Fix text string
Joas Schilling [Tue, 27 Sep 2022 09:13:00 +0000 (11:13 +0200)]
Merge pull request #34142 from nextcloud/move-background-clearing
Move avatar clearing in the background
blizzz [Tue, 27 Sep 2022 07:19:50 +0000 (09:19 +0200)]
Merge pull request #34267 from nextcloud/bugfix/upgrade-from-26
Bump versions to upgrade from
Nextcloud bot [Tue, 27 Sep 2022 02:28:05 +0000 (02:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Christopher Ng [Tue, 27 Sep 2022 00:56:58 +0000 (00:56 +0000)]
Add preset primary colors for shipped backgrounds
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Vincent Petry [Mon, 26 Sep 2022 19:28:51 +0000 (21:28 +0200)]
Merge pull request #33162 from nextcloud/dependabot/npm_and_yarn/moment-2.29.4
Bump moment from 2.29.2 to 2.29.4
Simon L [Mon, 26 Sep 2022 19:27:06 +0000 (21:27 +0200)]
Merge pull request #34163 from Jerome-Herbinet/patch-6
User list : User name and Display name visibility improvement
Vincent Petry [Mon, 26 Sep 2022 19:25:11 +0000 (21:25 +0200)]
Merge pull request #34260 from nextcloud/remove-unneeded-vue-cli
Remove unneeded and problematic vue-cli-plugin-unit-test
Julius Härtl [Mon, 26 Sep 2022 17:17:25 +0000 (19:17 +0200)]
Bump versions to upgrade from
Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud-command [Mon, 26 Sep 2022 15:54:29 +0000 (15:54 +0000)]
Compile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Julius Härtl [Mon, 26 Sep 2022 15:23:11 +0000 (17:23 +0200)]
Add endpoint to fetch a cachable reference data
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Carl Schwan [Mon, 19 Sep 2022 17:03:27 +0000 (19:03 +0200)]
Move avatar clearing in the background
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Vincent Petry [Mon, 26 Sep 2022 13:24:15 +0000 (15:24 +0200)]
Remove unneeded and problematic vue-cli-plugin-unit-test
It was causing issues during dependency upgrades and wasn't really used
except for its preset definition.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
dependabot[bot] [Mon, 26 Sep 2022 12:58:39 +0000 (12:58 +0000)]
Bump moment from 2.29.2 to 2.29.4
Bumps [moment](https://github.com/moment/moment) from 2.29.2 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.2...2.29.4)
---
updated-dependencies:
- dependency-name: moment
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Joas Schilling [Mon, 26 Sep 2022 12:37:26 +0000 (14:37 +0200)]
Merge pull request #33887 from nextcloud/dependabot/npm_and_yarn/moment-timezone-0.5.37
Bump moment-timezone from 0.5.34 to 0.5.37
Vincent Petry [Mon, 26 Sep 2022 12:34:39 +0000 (14:34 +0200)]
Merge pull request #34247 from nextcloud/dependabot/npm_and_yarn/nth-check-and-vue/cli-service-2.1.1
Bump nth-check and @vue/cli-service
Simon L [Mon, 26 Sep 2022 10:40:59 +0000 (12:40 +0200)]
Merge pull request #34249 from nextcloud/bugfix/noid/reference-public
Move Reference class to public namespace
Joas Schilling [Mon, 26 Sep 2022 09:26:34 +0000 (11:26 +0200)]
Add since
Signed-off-by: Joas Schilling <coding@schilljs.com>
Carl Schwan [Mon, 26 Sep 2022 09:16:09 +0000 (11:16 +0200)]
Merge pull request #34222 from nextcloud/fix/install-page
Fix install page
Julius Härtl [Mon, 26 Sep 2022 08:04:28 +0000 (10:04 +0200)]
Move Reference class to public namespace
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Joas Schilling [Mon, 26 Sep 2022 07:40:53 +0000 (09:40 +0200)]
Ignore invalid share types
Signed-off-by: Joas Schilling <coding@schilljs.com>
dependabot[bot] [Mon, 26 Sep 2022 07:22:14 +0000 (07:22 +0000)]
Bump nth-check and @vue/cli-service
Bumps [nth-check](https://github.com/fb55/nth-check) and [@vue/cli-service](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-service). These dependencies needed to be updated together.
Updates `nth-check` from 1.0.2 to 2.1.1
- [Release notes](https://github.com/fb55/nth-check/releases)
- [Commits](https://github.com/fb55/nth-check/compare/v1.0.2...v2.1.1)
Updates `@vue/cli-service` from 4.5.17 to 5.0.8
- [Release notes](https://github.com/vuejs/vue-cli/releases)
- [Changelog](https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-cli/commits/v5.0.8/packages/@vue/cli-service)
---
updated-dependencies:
- dependency-name: nth-check
dependency-type: indirect
- dependency-name: "@vue/cli-service"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Joas Schilling [Mon, 26 Sep 2022 07:00:27 +0000 (09:00 +0200)]
Recompile
Signed-off-by: Joas Schilling <coding@schilljs.com>
Joas Schilling [Mon, 26 Sep 2022 06:54:09 +0000 (08:54 +0200)]
Bump moment-timezone from 0.5.34 to 0.5.37
Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.34 to 0.5.37.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](https://github.com/moment/moment-timezone/compare/0.5.34...0.5.37)
---
updated-dependencies:
- dependency-name: moment-timezone
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Nextcloud bot [Mon, 26 Sep 2022 02:33:45 +0000 (02:33 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 25 Sep 2022 02:32:58 +0000 (02:32 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Vincent Petry [Thu, 22 Sep 2022 18:31:38 +0000 (20:31 +0200)]
Fix install page
- Use normal labels instead of hiding them
- Fix position of the eye button (this is still very hacky)
- Define width on the box and not on the text fields
This really needs to be ported to vue
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
John Molakvoæ [Sat, 24 Sep 2022 05:35:34 +0000 (07:35 +0200)]
Merge pull request #34210 from nextcloud/fix/theming
Fixing missing theming variables
John Molakvoæ [Sat, 24 Sep 2022 05:33:30 +0000 (07:33 +0200)]
Merge pull request #34220 from nextcloud/fix-php-cs-setup
Make phpcs happy and remove unused setup thing
John Molakvoæ [Sat, 24 Sep 2022 05:32:30 +0000 (07:32 +0200)]
Merge pull request #34231 from nextcloud/fix/node-workflow-error
Fix node workflow error on master
Nextcloud bot [Sat, 24 Sep 2022 02:33:56 +0000 (02:33 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Christopher Ng [Fri, 23 Sep 2022 23:10:06 +0000 (23:10 +0000)]
Fix node workflow error on master
Signed-off-by: Christopher Ng <chrng8@gmail.com>
John Molakvoæ [Fri, 23 Sep 2022 13:29:47 +0000 (15:29 +0200)]
Refactor primary computation and fix a few missing theme parity variables
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Vincent Petry [Fri, 23 Sep 2022 13:07:28 +0000 (15:07 +0200)]
Make phpcs happy and remove unused setup thing
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Vincent Petry [Fri, 23 Sep 2022 13:05:47 +0000 (15:05 +0200)]
Merge pull request #34212 from nextcloud/bugfix/34211/fix-getbackground-route
Fix loading custom background
John Molakvoæ [Fri, 23 Sep 2022 13:01:38 +0000 (15:01 +0200)]
Disable background blur on highcontrast
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
John Molakvoæ [Fri, 23 Sep 2022 08:24:21 +0000 (10:24 +0200)]
Fixing dark primary element variables
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Joas Schilling [Fri, 23 Sep 2022 09:19:49 +0000 (11:19 +0200)]
Merge pull request #34191 from Jerome-Herbinet/patch-7
DashBoard : Allow up to 5 widgets side by side
Vincent Petry [Fri, 23 Sep 2022 09:19:38 +0000 (11:19 +0200)]
Fix loading custom background
Fix the route for loading the custom background.
Because the controller is UserThemeController, so the route path is
not "theming" but "userTheme".
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Nextcloud bot [Fri, 23 Sep 2022 02:28:39 +0000 (02:28 +0000)]
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
blizzz [Thu, 22 Sep 2022 15:34:30 +0000 (17:34 +0200)]
Merge pull request #34190 from nextcloud/fix/noid/remove-core-bundle
remove CoreBundle as we now ship the lat app that was referenced there
Jérôme Herbinet [Thu, 22 Sep 2022 13:23:03 +0000 (15:23 +0200)]
DashBoard : Allow up to 5 widgets side by side
Signed-off-by: Jérôme Herbinet <j.herbinet@protonmail.ch>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Arthur Schiwon [Thu, 22 Sep 2022 11:31:48 +0000 (13:31 +0200)]
update autoloader
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Arthur Schiwon [Thu, 22 Sep 2022 11:29:02 +0000 (13:29 +0200)]
remove getDefaultInstallationBundle
- because all apps are shipped now it was returning an empty result
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Arthur Schiwon [Thu, 22 Sep 2022 11:24:06 +0000 (13:24 +0200)]
remove InstallCoreBundle repair step
- core bundle was empty and thus removed
- all former apps installed this way are shipped
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Arthur Schiwon [Thu, 22 Sep 2022 11:20:37 +0000 (13:20 +0200)]
remove Core Bundle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Jérôme Herbinet [Thu, 22 Sep 2022 11:10:39 +0000 (13:10 +0200)]
Fix : strong end tag
<
33763786 +Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Jérôme Herbinet [Thu, 22 Sep 2022 11:06:12 +0000 (13:06 +0200)]
Fix : strong HTML end tag
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>