]> source.dussan.org Git - jquery-ui.git/log
jquery-ui.git
9 years agoResizable: Update demos to use AMD
Alexander Schmitz [Wed, 1 Jul 2015 02:14:51 +0000 (22:14 -0400)]
Resizable: Update demos to use AMD

Ref #10119

9 years agoProgressbar: Update demos to use AMD
Alexander Schmitz [Wed, 1 Jul 2015 02:11:05 +0000 (22:11 -0400)]
Progressbar: Update demos to use AMD

Ref #10119

9 years agoPosition: Update demos to use AMD
Alexander Schmitz [Tue, 30 Jun 2015 23:01:59 +0000 (19:01 -0400)]
Position: Update demos to use AMD

Ref #10119

9 years agoMenu: Update demos to use AMD
Alexander Schmitz [Tue, 30 Jun 2015 23:01:30 +0000 (19:01 -0400)]
Menu: Update demos to use AMD

Ref #10119

9 years agoEffects: Update demos to use AMD
Alexander Schmitz [Tue, 30 Jun 2015 22:57:51 +0000 (18:57 -0400)]
Effects: Update demos to use AMD

Ref #10119

9 years agoDroppable: Update demos to use AMD
Alexander Schmitz [Tue, 30 Jun 2015 21:18:16 +0000 (17:18 -0400)]
Droppable: Update demos to use AMD

Ref #10119

9 years agoDraggable: Update to demos to use AMD
Alexander Schmitz [Tue, 30 Jun 2015 21:12:39 +0000 (17:12 -0400)]
Draggable: Update to demos to use AMD

Ref #10119

9 years agoDialog: Switch demos to use AMD
Alexander Schmitz [Tue, 30 Jun 2015 21:00:57 +0000 (17:00 -0400)]
Dialog: Switch demos to use AMD

Ref #10119

9 years agoAutocomplete: Update demos to use AMD
Alexander Schmitz [Tue, 30 Jun 2015 19:22:59 +0000 (15:22 -0400)]
Autocomplete: Update demos to use AMD

Ref #10119

9 years agoDatepicker: Update localization demo to use i18n files from ui folder
Alexander Schmitz [Thu, 21 May 2015 20:59:18 +0000 (16:59 -0400)]
Datepicker: Update localization demo to use i18n files from ui folder

Ref #10119

9 years agoDatepicker: Use new demos infrastructure
Alexander Schmitz [Thu, 14 May 2015 13:51:52 +0000 (09:51 -0400)]
Datepicker: Use new demos infrastructure

Ref #10119

9 years agoAccordion: Use new demos infrastructure
Alexander Schmitz [Thu, 14 May 2015 13:58:57 +0000 (09:58 -0400)]
Accordion: Use new demos infrastructure

Ref #10119

9 years agoBuild: Add demos to jscs and jshint
Alexander Schmitz [Thu, 2 Jul 2015 13:55:12 +0000 (09:55 -0400)]
Build: Add demos to jscs and jshint

9 years agoDemos: Fixup correct name
Alexander Schmitz [Tue, 21 Jul 2015 14:55:41 +0000 (10:55 -0400)]
Demos: Fixup correct name

9 years agoDemos: Add new infrastructure using a require.js bootstrap
Alexander Schmitz [Thu, 14 May 2015 13:57:50 +0000 (09:57 -0400)]
Demos: Add new infrastructure using a require.js bootstrap

Fixes #10119
Closes gh-1557

9 years agoDialog: Fix removal of event listener for modal dialogs
Scott González [Fri, 17 Jul 2015 15:00:44 +0000 (11:00 -0400)]
Dialog: Fix removal of event listener for modal dialogs

Fixes #13649

9 years agoSortable: Optimize `_intersectsWithPointer()`
Victor Homyakov [Wed, 8 Jul 2015 10:53:13 +0000 (13:53 +0300)]
Sortable: Optimize `_intersectsWithPointer()`

Closes gh-1574

9 years agoPosition: Guard against passing window to offset
Alexander Schmitz [Wed, 17 Jun 2015 15:33:06 +0000 (11:33 -0400)]
Position: Guard against passing window to offset

Starting in jQuery 3.0 this will throw an error

Fixes #13493
Closes gh-1565

9 years agoREADME: Fix typo
Eric Lee Carraway [Fri, 3 Jul 2015 17:10:25 +0000 (12:10 -0500)]
README: Fix typo

Change "setup" (noun) to "set up" (verb).

Closes gh-1572

9 years agoAutocomplete: Revert mistaken event alias change 1568/head
Jörn Zaefferer [Wed, 1 Jul 2015 12:36:08 +0000 (14:36 +0200)]
Autocomplete: Revert mistaken event alias change

This is a call on the menu widget, not using an event alias.

Ref 8b4ce807cd97e3cb953995934d6c4f614de9fa03
Ref #12770

9 years agoSpinner: Deprecate _uiSpinnerHtml and _buttonHtml extension points 1560/head
Alexander Schmitz [Thu, 14 May 2015 12:37:53 +0000 (08:37 -0400)]
Spinner: Deprecate _uiSpinnerHtml and _buttonHtml extension points

Fixes #11097
Closes gh-1560

9 years agoTests: Stop testing against core 1.10.1 on testswarm
Alexander Schmitz [Wed, 20 May 2015 18:33:55 +0000 (14:33 -0400)]
Tests: Stop testing against core 1.10.1 on testswarm

Fixes #12745

9 years agoTests: Add custom build of core to tests
Alexander Schmitz [Thu, 14 May 2015 02:06:14 +0000 (22:06 -0400)]
Tests: Add custom build of core to tests

This adds a custom build which excludes the event/alias and deprecated modules

Fixes #12770
Closes gh-1556

9 years agoTests: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:05:32 +0000 (22:05 -0400)]
Tests: Remove core event/alias and deprecated module dependencies

9 years agoProgressbar: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:34:05 +0000 (22:34 -0400)]
Progressbar: Remove core event/alias and deprecated module dependencies

9 years agoPosition: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:05:07 +0000 (22:05 -0400)]
Position: Remove core event/alias and deprecated module dependencies

9 years agoResizable: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:04:02 +0000 (22:04 -0400)]
Resizable: Remove core event/alias and deprecated module dependencies

9 years agoMouse: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:11:56 +0000 (22:11 -0400)]
Mouse: Remove core event/alias and deprecated module dependencies

9 years agoCore: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:03:32 +0000 (22:03 -0400)]
Core: Remove core event/alias and deprecated module dependencies

9 years agoEffects: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:02:48 +0000 (22:02 -0400)]
Effects: Remove core event/alias and deprecated module dependencies

9 years agoWidget: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:02:32 +0000 (22:02 -0400)]
Widget: Remove core event/alias and deprecated module dependencies

9 years agoTooltip: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:02:14 +0000 (22:02 -0400)]
Tooltip: Remove core event/alias and deprecated module dependencies

9 years agoTabs: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:01:58 +0000 (22:01 -0400)]
Tabs: Remove core event/alias and deprecated module dependencies

9 years agoSpinner: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:01:44 +0000 (22:01 -0400)]
Spinner: Remove core event/alias and deprecated module dependencies

9 years agoSortable: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:01:25 +0000 (22:01 -0400)]
Sortable: Remove core event/alias and deprecated module dependencies

9 years agoSlider: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:01:09 +0000 (22:01 -0400)]
Slider: Remove core event/alias and deprecated module dependencies

9 years agoMenu: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:10:34 +0000 (22:10 -0400)]
Menu: Remove core event/alias and deprecated module dependencies

9 years agoSelectmenu: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 02:09:57 +0000 (22:09 -0400)]
Selectmenu: Remove core event/alias and deprecated module dependencies

9 years agoDroppable: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 01:58:16 +0000 (21:58 -0400)]
Droppable: Remove core event/alias and deprecated module dependencies

9 years agoDraggable: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 01:57:47 +0000 (21:57 -0400)]
Draggable: Remove core event/alias and deprecated module dependencies

9 years agoDialog: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 01:57:04 +0000 (21:57 -0400)]
Dialog: Remove core event/alias and deprecated module dependencies

9 years agoDatepicker: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 01:54:56 +0000 (21:54 -0400)]
Datepicker: Remove core event/alias and deprecated module dependencies

9 years agoButton: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 01:54:37 +0000 (21:54 -0400)]
Button: Remove core event/alias and deprecated module dependencies

9 years agoAutocomplete: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 01:54:08 +0000 (21:54 -0400)]
Autocomplete: Remove core event/alias and deprecated module dependencies

9 years agoAccordion: Remove core event/alias and deprecated module dependencies
Alexander Schmitz [Thu, 14 May 2015 01:52:09 +0000 (21:52 -0400)]
Accordion: Remove core event/alias and deprecated module dependencies

9 years agoForm Reset: Add form reset mixin
Scott González [Thu, 23 Apr 2015 19:11:41 +0000 (15:11 -0400)]
Form Reset: Add form reset mixin

Fixes #12638
Closes gh-1555

9 years agoWidget: Support mixins
Scott González [Wed, 13 May 2015 18:59:02 +0000 (14:59 -0400)]
Widget: Support mixins

Fixes #12601
Closes gh-1554

9 years agoBuild: Upgrade to jQuery 1.11.3
Scott González [Thu, 14 May 2015 12:25:16 +0000 (08:25 -0400)]
Build: Upgrade to jQuery 1.11.3

9 years agoTests: Use new jquery-compat-git and jquery-git files
Scott González [Thu, 14 May 2015 11:44:13 +0000 (07:44 -0400)]
Tests: Use new jquery-compat-git and jquery-git files

9 years agoWidget tests: Clean up $.fn methods
Scott González [Wed, 13 May 2015 18:58:39 +0000 (14:58 -0400)]
Widget tests: Clean up $.fn methods

9 years agoTabs: Use $.ui.escapeSelector to avoid invalid selectors
Alexander Schmitz [Mon, 27 Apr 2015 06:34:56 +0000 (02:34 -0400)]
Tabs: Use $.ui.escapeSelector to avoid invalid selectors

9 years agoSelectmenu: Use $.ui.escapeSelector
Alexander Schmitz [Mon, 27 Apr 2015 06:30:01 +0000 (02:30 -0400)]
Selectmenu: Use $.ui.escapeSelector

9 years agoCore: Add $.fn.labels, $.fn.form, and $.ui.escapeSelector methods
Alexander Schmitz [Mon, 27 Apr 2015 03:38:21 +0000 (23:38 -0400)]
Core: Add $.fn.labels, $.fn.form, and $.ui.escapeSelector methods

$.fn.labels and $.fn.form mimic the native labels and form properties
$.ui.escapeSelector is for escaping attributes and urls for use as selectors

Closes gh-1546

9 years agoBuild: Update to qunit-assert-classes to V 1.0.2
Alexander Schmitz [Wed, 29 Apr 2015 14:49:41 +0000 (10:49 -0400)]
Build: Update to qunit-assert-classes to V 1.0.2

Closes gh-1547

9 years agoEffect: Make .transfer() callback optional 1545/head
Jörn Zaefferer [Wed, 22 Apr 2015 13:50:43 +0000 (15:50 +0200)]
Effect: Make .transfer() callback optional

Adds two tests to at least check that no exception is thrown.

Fixes #12223
Closes gh-1545

9 years agoSlider: Range fills all space after changing orientation
Ablay Keldibek [Tue, 7 Apr 2015 14:10:27 +0000 (20:10 +0600)]
Slider: Range fills all space after changing orientation

Resets width/height of range

Fixes #12205
Closes gh-1533

9 years agoSlider: Remove scrollbar demo
Scott González [Wed, 22 Apr 2015 16:37:08 +0000 (12:37 -0400)]
Slider: Remove scrollbar demo

Custom scrollbars are often a bad idea and this was a particularly minimal,
and therefore terrible, implementation.

9 years agoTooltip: Remove name attribute from elements in the live region
Jiabao Wu [Wed, 22 Apr 2015 14:20:11 +0000 (10:20 -0400)]
Tooltip: Remove name attribute from elements in the live region

Fixes #11272
Closes gh-1544

9 years agoSlider: Pass 0 value if slider reaches it
Ablay Keldibek [Fri, 17 Apr 2015 08:34:33 +0000 (14:34 +0600)]
Slider: Pass 0 value if slider reaches it

Fixes #12196
Closes gh-1540

9 years agoPosition: Remove IE6 workarounds in tests
Scott González [Mon, 20 Apr 2015 18:21:36 +0000 (14:21 -0400)]
Position: Remove IE6 workarounds in tests

Closes gh-1543

9 years agoAutocomplete: Cleanup remote-jsonp demo 1542/head
Jörn Zaefferer [Mon, 20 Apr 2015 12:20:59 +0000 (14:20 +0200)]
Autocomplete: Cleanup remote-jsonp demo

Fix handling of empty response, remove silly open/close handlers,
fix select callback, fix demo description.

Closes gh-1542

9 years agoTabs: Rename ui-tab class to ui-tabs-tab for consistent prefixes 1538/head
Jörn Zaefferer [Wed, 15 Apr 2015 15:41:03 +0000 (17:41 +0200)]
Tabs: Rename ui-tab class to ui-tabs-tab for consistent prefixes

Fixes #12061
Closes gh-1538
Ref #7053
Ref jquery/api.jqueryui.com#256

9 years agoTests: Fix loading in TestSwarm
Scott González [Fri, 17 Apr 2015 14:47:23 +0000 (10:47 -0400)]
Tests: Fix loading in TestSwarm

9 years agoTests: Fix AMD loading in IE8
Scott González [Fri, 17 Apr 2015 16:13:38 +0000 (12:13 -0400)]
Tests: Fix AMD loading in IE8

It appears that we must load require.js via a standard script tag in order
for it to work properly in IE8.

9 years agoTests: Fix domEqual handling for invalid input
Scott González [Fri, 17 Apr 2015 16:10:36 +0000 (12:10 -0400)]
Tests: Fix domEqual handling for invalid input

9 years agoBuild: Upgrade to qunit-composite 1.1.0
Scott González [Thu, 9 Apr 2015 13:11:34 +0000 (09:11 -0400)]
Build: Upgrade to qunit-composite 1.1.0

Ref #10119
Closes gh-1528

9 years agoTests: Use the qunit-assert-close module
Scott González [Wed, 8 Apr 2015 13:15:23 +0000 (09:15 -0400)]
Tests: Use the qunit-assert-close module

Moved QUnit assertion dependencies from `lib/bootstrap` to `lib/qunit`.

Corrected bad draggable assertions.

Ref gh-1528

9 years agoTests: Rename files
Scott González [Tue, 7 Apr 2015 14:55:52 +0000 (10:55 -0400)]
Tests: Rename files

Ref gh-1528

9 years agoTests: Widget test helpers extend the main helper
Scott González [Tue, 7 Apr 2015 14:30:07 +0000 (10:30 -0400)]
Tests: Widget test helpers extend the main helper

Ref #10119
Ref gh-1528

9 years agoTests: Remove old test infrastructure
Scott González [Tue, 7 Apr 2015 00:41:24 +0000 (20:41 -0400)]
Tests: Remove old test infrastructure

Ref #10119
Ref gh-1528

9 years agoDroppable: Convert tests to new infrastructure
Scott González [Tue, 7 Apr 2015 00:35:27 +0000 (20:35 -0400)]
Droppable: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoTooltip: Convert tests to new infrastructure
Scott González [Tue, 7 Apr 2015 00:28:55 +0000 (20:28 -0400)]
Tooltip: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoDialog: Convert tests to new infrastructure
Scott González [Tue, 7 Apr 2015 00:23:50 +0000 (20:23 -0400)]
Dialog: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoTests: Support `$.uiBackCompat = false` via `data-no-back-compat`
Scott González [Tue, 7 Apr 2015 00:22:54 +0000 (20:22 -0400)]
Tests: Support `$.uiBackCompat = false` via `data-no-back-compat`

Ref #10119
Ref gh-1528

9 years agoDatepicker: Convert tests to new infrastructure
Scott González [Tue, 7 Apr 2015 00:06:31 +0000 (20:06 -0400)]
Datepicker: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoSpinner: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 23:46:15 +0000 (19:46 -0400)]
Spinner: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoWidget: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 19:07:04 +0000 (15:07 -0400)]
Widget: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoTabs: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 19:01:13 +0000 (15:01 -0400)]
Tabs: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoSortable: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 18:50:39 +0000 (14:50 -0400)]
Sortable: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoSlider: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 18:44:05 +0000 (14:44 -0400)]
Slider: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoSelectmenu: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 18:40:47 +0000 (14:40 -0400)]
Selectmenu: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoSelectable: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 18:38:11 +0000 (14:38 -0400)]
Selectable: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoResizable: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 18:33:25 +0000 (14:33 -0400)]
Resizable: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoProgressbar: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 18:27:05 +0000 (14:27 -0400)]
Progressbar: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoPosition: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 17:08:27 +0000 (13:08 -0400)]
Position: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoMenu: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 17:04:04 +0000 (13:04 -0400)]
Menu: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoEffects: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 16:56:07 +0000 (12:56 -0400)]
Effects: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoDraggable: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 16:42:49 +0000 (12:42 -0400)]
Draggable: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoCore: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 14:56:48 +0000 (10:56 -0400)]
Core: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoButton: Convert tests to new infrastructure
Scott González [Mon, 6 Apr 2015 14:13:15 +0000 (10:13 -0400)]
Button: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoAutocomplete: Convert tests to new infrastructure
Scott González [Fri, 3 Apr 2015 19:57:57 +0000 (15:57 -0400)]
Autocomplete: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoAccordion: Convert tests to new infrastructure
Scott González [Fri, 3 Apr 2015 19:24:09 +0000 (15:24 -0400)]
Accordion: Convert tests to new infrastructure

Ref #10119
Ref gh-1528

9 years agoTests: Convert closeEnough() to a proper QUnit assertion
Scott González [Tue, 31 Mar 2015 20:52:28 +0000 (16:52 -0400)]
Tests: Convert closeEnough() to a proper QUnit assertion

Should eventually replace with qunit-assert-close.

Ref #10119
Ref gh-1528

9 years agoTests: Change test infrastructure to use AMD and reduce boilerplate
Scott González [Fri, 3 Apr 2015 19:21:16 +0000 (15:21 -0400)]
Tests: Change test infrastructure to use AMD and reduce boilerplate

Ref #10119
Ref gh-1528

* Adds RequireJS and relies on AMD for loading dependencies.
* Updates to grunt-contrib-qunit 0.6.0.
* Convert `domEqual()` to a proper QUnit assertion.
* Introduces two bootstrap files (JS and CSS) which use `data-` attributes to
reduce the amount of boilerplate needed in each test

9 years agoRevert "Draggable: Set explicit width/height instead of right/bottom"
TJ VanToll [Sun, 5 Apr 2015 15:37:53 +0000 (11:37 -0400)]
Revert "Draggable: Set explicit width/height instead of right/bottom"

This reverts commit 8eca7b8f45885d20c13f1bf64cad8bee5fc1d5c5.

Fixes #10725

9 years agoMenu: Ignore bubbled mouseenter events on parent items
Jörn Zaefferer [Wed, 8 Apr 2015 14:09:17 +0000 (16:09 +0200)]
Menu: Ignore bubbled mouseenter events on parent items

Test uses QUnit 2.x API - inconsistent with the other tests, but also
a good reference.

Fixes #11641
Closes gh-1535

9 years agoSelectmenu: Add a disabled-default option example to default demo
Jörn Zaefferer [Wed, 8 Apr 2015 13:00:16 +0000 (15:00 +0200)]
Selectmenu: Add a disabled-default option example to default demo

Ref gh-1520

9 years agoMenu: Update default demo, use product categories
Jörn Zaefferer [Wed, 8 Apr 2015 12:33:35 +0000 (14:33 +0200)]
Menu: Update default demo, use product categories

Makes it look like a navigation menu that can't be navigated, at least
better than the random city names we had before.

Ref #11641

9 years agoTests: Switch to the new qunit-composite module
Scott González [Mon, 6 Apr 2015 13:51:10 +0000 (09:51 -0400)]
Tests: Switch to the new qunit-composite module

This module was created from our existing implementation.

Closes gh-1532

9 years agoSlider: Proper animation of range
Ablay Keldibek [Mon, 6 Apr 2015 20:58:55 +0000 (16:58 -0400)]
Slider: Proper animation of range

Fixes #9459
Closes gh-1530