]> source.dussan.org Git - poi.git/log
poi.git
6 years agouse StandardCharsets
PJ Fanning [Tue, 19 Dec 2017 00:33:16 +0000 (00:33 +0000)]
use StandardCharsets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818629 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse StandardCharsets
PJ Fanning [Tue, 19 Dec 2017 00:23:52 +0000 (00:23 +0000)]
use StandardCharsets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818628 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse non deprecated method for adding string to shared strings table
PJ Fanning [Mon, 18 Dec 2017 20:54:39 +0000 (20:54 +0000)]
use non deprecated method for adding string to shared strings table

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818623 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61859: support for evaluating comparison operators in array mode, detect array...
Yegor Kozlov [Mon, 18 Dec 2017 15:54:50 +0000 (15:54 +0000)]
Bug 61859: support for evaluating comparison operators in array mode, detect array mode from formula ptgs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818587 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61906 fix javadoc issue
PJ Fanning [Fri, 15 Dec 2017 09:13:16 +0000 (09:13 +0000)]
Bug-61906 fix javadoc issue

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818248 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61906 add API for working with RichStringText and deprecate API methods that...
PJ Fanning [Fri, 15 Dec 2017 09:09:50 +0000 (09:09 +0000)]
Bug-61906 add API for working with RichStringText and deprecate API methods that use CTRst

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818247 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug-61792 simplify sxssf code that writes chars
PJ Fanning [Fri, 15 Dec 2017 00:54:52 +0000 (00:54 +0000)]
Bug-61792 simplify sxssf code that writes chars

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818223 13f79535-47bb-0310-9956-ffa450edef68

6 years agodelete commented out code
Javen O'Neal [Wed, 13 Dec 2017 06:39:01 +0000 (06:39 +0000)]
delete commented out code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817976 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 57423: add unit test demonstrating corrupted workbook where CTRow xmlbeans are...
Javen O'Neal [Wed, 13 Dec 2017 06:21:19 +0000 (06:21 +0000)]
bug 57423: add unit test demonstrating corrupted workbook where CTRow xmlbeans are not in ascending order in the CTWorksheet; unit test adapted from Luca

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817975 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61765 Another HSSF Workbook name found from (unknown) third party software produced...
Nick Burch [Mon, 11 Dec 2017 19:52:53 +0000 (19:52 +0000)]
#61765 Another HSSF Workbook name found from (unknown) third party software produced files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817812 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
Greg Woolsey [Mon, 11 Dec 2017 17:33:00 +0000 (17:33 +0000)]
Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference

test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817797 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
Greg Woolsey [Mon, 11 Dec 2017 17:30:04 +0000 (17:30 +0000)]
Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference

Protect against this in the future by introducing a factory method to create XSSFColor instances from a CTColor instance and the associated workbook style indexed color map.

If the CTColor instance is null, the factory returns null.  All callers already are prepared for a null instance, but many had their own null check on the CTColor object.  This centralizes that.

This also further forces the requirement for the indexed color map.  Any time a color is created, the workbook or styleTable is available in the same context, so passing this is extra parameter is trivial and allows XSSFColor to properly reference custom/themed indexed colors.

Did not remove any methods yet, only deprecated them.  Changed the signature to one internal test-only constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817796 13f79535-47bb-0310-9956-ffa450edef68

6 years agoremove package name to ease the output
Andreas Beeker [Sat, 9 Dec 2017 12:06:59 +0000 (12:06 +0000)]
remove package name to ease the output

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817600 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61881 - handle invalid font names
Andreas Beeker [Sat, 9 Dec 2017 11:44:19 +0000 (11:44 +0000)]
#61881 - handle invalid font names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61841
Greg Woolsey [Thu, 7 Dec 2017 01:54:21 +0000 (01:54 +0000)]
#61841

Add @Override annotations, clean up imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817331 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61841 fix typo in method name
Greg Woolsey [Wed, 6 Dec 2017 23:53:25 +0000 (23:53 +0000)]
#61841 fix typo in method name

Fixing the typo pointed out by PJ Fanning, thanks for the proof read!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817325 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
Greg Woolsey [Wed, 6 Dec 2017 00:46:42 +0000 (00:46 +0000)]
Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference

always with the missing license...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817254 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
Greg Woolsey [Wed, 6 Dec 2017 00:15:51 +0000 (00:15 +0000)]
Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference

Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse try-with-resources in more places
PJ Fanning [Tue, 5 Dec 2017 22:31:59 +0000 (22:31 +0000)]
use try-with-resources in more places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817247 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse try-with-resources in more places
PJ Fanning [Tue, 5 Dec 2017 21:23:44 +0000 (21:23 +0000)]
use try-with-resources in more places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817238 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61840: close workbook to prevent resource leak in unit test
Javen O'Neal [Fri, 1 Dec 2017 17:51:19 +0000 (17:51 +0000)]
bug 61840: close workbook to prevent resource leak in unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816893 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61840: add unit test showing that shiftRows does not produce #REF! formula errors...
Javen O'Neal [Fri, 1 Dec 2017 17:47:29 +0000 (17:47 +0000)]
bug 61840: add unit test showing that shiftRows does not produce #REF! formula errors if cells are not shifted above the first row

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816892 13f79535-47bb-0310-9956-ffa450edef68

6 years agoJavadoc fixes
Nick Burch [Mon, 27 Nov 2017 14:05:17 +0000 (14:05 +0000)]
Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816453 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBump library version to match Ant defined version
Nick Burch [Mon, 27 Nov 2017 12:42:47 +0000 (12:42 +0000)]
Bump library version to match Ant defined version

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816445 13f79535-47bb-0310-9956-ffa450edef68

6 years agoXDDF usermodel for Charts closes #68 on GitHub
Alain Béarez [Sun, 26 Nov 2017 14:03:01 +0000 (14:03 +0000)]
XDDF usermodel for Charts closes #68 on GitHub

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61809 - Infinite loop in SectionIDMap.get() and .put()
Andreas Beeker [Fri, 24 Nov 2017 01:02:20 +0000 (01:02 +0000)]
#61809 - Infinite loop in SectionIDMap.get() and .put()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816205 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse try with resources in examples
PJ Fanning [Thu, 23 Nov 2017 20:03:25 +0000 (20:03 +0000)]
use try with resources in examples

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816189 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse try with resources in examples
PJ Fanning [Thu, 23 Nov 2017 19:28:36 +0000 (19:28 +0000)]
use try with resources in examples

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816187 13f79535-47bb-0310-9956-ffa450edef68

6 years agoDon't try to collect junit results for Maven when we only run Sonar-tasks and thus...
Dominik Stadler [Thu, 23 Nov 2017 18:54:17 +0000 (18:54 +0000)]
Don't try to collect junit results for Maven when we only run Sonar-tasks and thus skip unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816186 13f79535-47bb-0310-9956-ffa450edef68

6 years agoChange order of handling shape-types in copy() as FreeFormShape derives from AutoShap...
Dominik Stadler [Thu, 23 Nov 2017 18:54:11 +0000 (18:54 +0000)]
Change order of handling shape-types in copy() as FreeFormShape derives from AutoShape and thus would have not been copied correctly currently
Fix some Javadoc, some warnings and code duplications

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816185 13f79535-47bb-0310-9956-ffa450edef68

6 years agoEnsure that the tempdir exists when we use ImageIO in one of the tests
Dominik Stadler [Wed, 22 Nov 2017 12:25:11 +0000 (12:25 +0000)]
Ensure that the tempdir exists when we use ImageIO in one of the tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816046 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd TestStringCodepointsIterable
PJ Fanning [Wed, 22 Nov 2017 09:57:45 +0000 (09:57 +0000)]
add TestStringCodepointsIterable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816020 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse codepoint iterator in a few places
PJ Fanning [Wed, 22 Nov 2017 01:07:24 +0000 (01:07 +0000)]
use codepoint iterator in a few places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815998 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd forbidden api checks for non-Locale toLowerCase and toUpperCase
PJ Fanning [Tue, 21 Nov 2017 22:10:48 +0000 (22:10 +0000)]
add forbidden api checks for non-Locale toLowerCase and toUpperCase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd forbidden api checks for non-Locale toLowerCase and toUpperCase
PJ Fanning [Tue, 21 Nov 2017 21:33:51 +0000 (21:33 +0000)]
add forbidden api checks for non-Locale toLowerCase and toUpperCase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815989 13f79535-47bb-0310-9956-ffa450edef68

6 years agoremove more uses of Character.toUpperCase
PJ Fanning [Tue, 21 Nov 2017 21:11:07 +0000 (21:11 +0000)]
remove more uses of Character.toUpperCase

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815988 13f79535-47bb-0310-9956-ffa450edef68

6 years agoTry to set java.io.tmpdir for tests to avoid the strange permission errors that we...
Dominik Stadler [Tue, 21 Nov 2017 17:32:48 +0000 (17:32 +0000)]
Try to set java.io.tmpdir for tests to avoid the strange permission errors that we see in CI-builds

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815963 13f79535-47bb-0310-9956-ffa450edef68

6 years agoEnsure that no old version of commons-codec is lingering around and causes hard to...
Dominik Stadler [Tue, 21 Nov 2017 16:29:01 +0000 (16:29 +0000)]
Ensure that no old version of commons-codec is lingering around and causes hard to find build errors locally

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815952 13f79535-47bb-0310-9956-ffa450edef68

6 years agoTry if using a local temporary directory avoids the permission errors in unit tests...
Dominik Stadler [Tue, 21 Nov 2017 16:28:07 +0000 (16:28 +0000)]
Try if using a local temporary directory avoids the permission errors in unit tests in the Maven runs:
* Collect JUnit results
* Set java.io.tmpdir in Maven unit test runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815951 13f79535-47bb-0310-9956-ffa450edef68

6 years ago[bug-61792] basic test
PJ Fanning [Mon, 20 Nov 2017 23:58:13 +0000 (23:58 +0000)]
[bug-61792] basic test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815873 13f79535-47bb-0310-9956-ffa450edef68

6 years ago[bug-61792] some changes to avoid iterating over chars of Strings
PJ Fanning [Mon, 20 Nov 2017 23:35:36 +0000 (23:35 +0000)]
[bug-61792] some changes to avoid iterating over chars of Strings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815871 13f79535-47bb-0310-9956-ffa450edef68

6 years agoupgrade to commons-codec 1.11
PJ Fanning [Mon, 20 Nov 2017 20:46:16 +0000 (20:46 +0000)]
upgrade to commons-codec 1.11

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815852 13f79535-47bb-0310-9956-ffa450edef68

6 years agoHandle case where the JaCoCo zip file is available, but the extracted files are missi...
Dominik Stadler [Sun, 19 Nov 2017 19:53:44 +0000 (19:53 +0000)]
Handle case where the JaCoCo zip file is available, but the extracted files are missing, not sure how that happens, but we see it on some CI machines...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815755 13f79535-47bb-0310-9956-ffa450edef68

6 years agojavadocs and Quick page improvements for XSSF Header/Footer
Mark Murphy [Sun, 19 Nov 2017 01:35:07 +0000 (01:35 +0000)]
javadocs and Quick page improvements for XSSF Header/Footer

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815706 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd Locale awareness to case insensitive conditional comparisons in formatting rule...
Greg Woolsey [Thu, 16 Nov 2017 01:22:52 +0000 (01:22 +0000)]
add Locale awareness to case insensitive conditional comparisons in formatting rule logic.  Needed anyway, and removes forbidden API issues.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815404 13f79535-47bb-0310-9956-ffa450edef68

6 years agoignore a unit test that snuck in. It was created to investigate an open bug report...
Greg Woolsey [Wed, 15 Nov 2017 16:34:14 +0000 (16:34 +0000)]
ignore a unit test that snuck in.  It was created to investigate an open bug report.  It fails, as expected, which broke the build.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815336 13f79535-47bb-0310-9956-ffa450edef68

6 years agoFixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi...
Greg Woolsey [Wed, 15 Nov 2017 08:35:17 +0000 (08:35 +0000)]
Fixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions

Fixes Bug 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types

fixed, with unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298 13f79535-47bb-0310-9956-ffa450edef68

6 years agoFix setting a font-color if no previous color is defined for the font
Dominik Stadler [Mon, 13 Nov 2017 11:46:04 +0000 (11:46 +0000)]
Fix setting a font-color if no previous color is defined for the font
Add unit-test to verify this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815086 13f79535-47bb-0310-9956-ffa450edef68

6 years agoFix tests
Dominik Stadler [Mon, 13 Nov 2017 11:44:50 +0000 (11:44 +0000)]
Fix tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815085 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61745: remove String#toString() usage found by forbidden apis check
Javen O'Neal [Mon, 13 Nov 2017 00:51:41 +0000 (00:51 +0000)]
bug 61745: remove String#toString() usage found by forbidden apis check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815048 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari for the...
Javen O'Neal [Sun, 12 Nov 2017 21:48:41 +0000 (21:48 +0000)]
bug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari for the patch

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815047 13f79535-47bb-0310-9956-ffa450edef68

6 years ago+svn:eol-style native *.java
Javen O'Neal [Sun, 12 Nov 2017 06:52:38 +0000 (06:52 +0000)]
+svn:eol-style native *.java

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815002 13f79535-47bb-0310-9956-ffa450edef68

6 years agogithub #81: sheet names are case insensitive
Javen O'Neal [Sun, 12 Nov 2017 06:14:43 +0000 (06:14 +0000)]
github #81: sheet names are case insensitive

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815001 13f79535-47bb-0310-9956-ffa450edef68

6 years agoXWPFTable#getRows() should return an unmodifiable list unless the method can correctl...
Javen O'Neal [Sun, 12 Nov 2017 01:34:52 +0000 (01:34 +0000)]
XWPFTable#getRows() should return an unmodifiable list unless the method can correctly update xmlbeans in response to modifying the list

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814999 13f79535-47bb-0310-9956-ffa450edef68

6 years agomake tableRows final; initialize where defined rather than in constructor.
Javen O'Neal [Sun, 12 Nov 2017 01:32:43 +0000 (01:32 +0000)]
make tableRows final; initialize where defined rather than in constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814998 13f79535-47bb-0310-9956-ffa450edef68

6 years agodeprecate XWPFTable#addNewRowBetween(int,int), which has not been implemented since...
Javen O'Neal [Sun, 12 Nov 2017 01:30:42 +0000 (01:30 +0000)]
deprecate XWPFTable#addNewRowBetween(int,int), which has not been implemented since 2008 when this class was first authored. (Unrelated: This closes #82 on github).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814997 13f79535-47bb-0310-9956-ffa450edef68

6 years agoSurface XSSF Header/Footer Attributes (60887)
Mark Murphy [Sat, 11 Nov 2017 14:18:24 +0000 (14:18 +0000)]
Surface XSSF Header/Footer Attributes (60887)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814950 13f79535-47bb-0310-9956-ffa450edef68

6 years agoSome JavaDoc adjustments, typos, IntelliJ warnings
Dominik Stadler [Wed, 8 Nov 2017 14:59:08 +0000 (14:59 +0000)]
Some JavaDoc adjustments, typos, IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61730: remove asSet function from unit test
Javen O'Neal [Tue, 7 Nov 2017 07:26:48 +0000 (07:26 +0000)]
bug 61730: remove asSet function from unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814462 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is safer...
Javen O'Neal [Tue, 7 Nov 2017 07:21:24 +0000 (07:21 +0000)]
bug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is safer, less likely to cause an OOM/DoS.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814461 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61730: add javadoc
Javen O'Neal [Tue, 7 Nov 2017 01:54:25 +0000 (01:54 +0000)]
bug 61730: add javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814451 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61730: add iterator interface to CellRangeAddressBase for iterating over CellAddr...
Javen O'Neal [Tue, 7 Nov 2017 00:29:09 +0000 (00:29 +0000)]
bug 61730: add iterator interface to CellRangeAddressBase for iterating over CellAddresses

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814448 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61727: make TestCellRangeUtil unit tests more explicit
Javen O'Neal [Mon, 6 Nov 2017 22:19:06 +0000 (22:19 +0000)]
bug 61727: make TestCellRangeUtil unit tests more explicit

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814444 13f79535-47bb-0310-9956-ffa450edef68

6 years agoEnhance unit-test to Verify that bug 58785 is already via via some other change
Dominik Stadler [Mon, 6 Nov 2017 20:26:32 +0000 (20:26 +0000)]
Enhance unit-test to Verify that bug 58785 is already via via some other change

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814440 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61727: CellRangeUtil Merge cell ranges broken. Thanks for Sven Rieckhoff for...
Javen O'Neal [Mon, 6 Nov 2017 19:51:41 +0000 (19:51 +0000)]
bug 61727: CellRangeUtil Merge cell ranges broken. Thanks for Sven Rieckhoff for the patch

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814432 13f79535-47bb-0310-9956-ffa450edef68

6 years agoAdjust some tests to properly close resources
Dominik Stadler [Sun, 5 Nov 2017 20:33:35 +0000 (20:33 +0000)]
Adjust some tests to properly close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814374 13f79535-47bb-0310-9956-ffa450edef68

6 years agoBug #57517: Fix various things in HSSFOptimiser to make many more cases work fine...
Dominik Stadler [Sun, 5 Nov 2017 20:33:28 +0000 (20:33 +0000)]
Bug #57517: Fix various things in HSSFOptimiser to make many more cases work fine: Column styles, row styles, user defined styles, ...
Also call optimise in integration-tests and handle some cases of invalid content in files.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814373 13f79535-47bb-0310-9956-ffa450edef68

6 years agoAdd test-case which shows that bug 55814 is fixed already by other changes
Dominik Stadler [Sat, 4 Nov 2017 13:45:12 +0000 (13:45 +0000)]
Add test-case which shows that bug 55814 is fixed already by other changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814290 13f79535-47bb-0310-9956-ffa450edef68

6 years agoFix some IntelliJ and JavaDoc warnings and avoid code-duplication and duplicated...
Dominik Stadler [Sat, 4 Nov 2017 13:45:04 +0000 (13:45 +0000)]
Fix some IntelliJ and JavaDoc warnings and avoid code-duplication and duplicated test-methods
Adjust tests slighlty, close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814289 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: add ShiftMode#ColumnCopy for FormulaShifter
Javen O'Neal [Sat, 4 Nov 2017 10:11:20 +0000 (10:11 +0000)]
bug 61474, github #81: add ShiftMode#ColumnCopy for FormulaShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814268 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: add shiftMergedRegions to BaseRowColShifter interface
Javen O'Neal [Sat, 4 Nov 2017 09:32:05 +0000 (09:32 +0000)]
bug 61474, github #81: add shiftMergedRegions to BaseRowColShifter interface

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814264 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: bump visibility of abstract methods in BaseRowColShifter abstr...
Javen O'Neal [Sat, 4 Nov 2017 09:17:09 +0000 (09:17 +0000)]
bug 61474, github #81: bump visibility of abstract methods in BaseRowColShifter abstract class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814262 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: pull up methods from RowShifter to BaseRowColShifter, since...
Javen O'Neal [Sat, 4 Nov 2017 09:07:32 +0000 (09:07 +0000)]
bug 61474, github #81: pull up methods from RowShifter to BaseRowColShifter, since both row and column shifting should be able to shift formulas, comments, merged regions, conditional formatting, etc; add @since decorators for new *ColumnShifter and *RowColShifter classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814261 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: remove @Internal RowShifter#updateRowFormulas, move to XSSFRow...
Javen O'Neal [Sat, 4 Nov 2017 08:54:20 +0000 (08:54 +0000)]
bug 61474, github #81: remove @Internal RowShifter#updateRowFormulas, move to XSSFRowColShifter; implement ColumnShifter#updateFormulas; remove duplicated JavaDocs (better to inherit)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814260 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: implement updateConditionalFormatting for ColumnShifter
Javen O'Neal [Sat, 4 Nov 2017 07:58:41 +0000 (07:58 +0000)]
bug 61474, github #81: implement updateConditionalFormatting for ColumnShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814259 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: implement updateNamedRanges for ColumnShifter
Javen O'Neal [Sat, 4 Nov 2017 07:42:33 +0000 (07:42 +0000)]
bug 61474, github #81: implement updateNamedRanges for ColumnShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814258 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: fix ColumnShifter#removalNeeded to use columns instead of...
Javen O'Neal [Sat, 4 Nov 2017 07:29:53 +0000 (07:29 +0000)]
bug 61474, github #81: fix ColumnShifter#removalNeeded to use columns instead of rows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814257 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, github #81: add ColumnShifter interface; deduplicate some code in RowShift...
Javen O'Neal [Sat, 4 Nov 2017 07:17:44 +0000 (07:17 +0000)]
bug 61474, github #81: add ColumnShifter interface; deduplicate some code in RowShifter, CFRecordsAggregate

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814256 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474, #81 on github: add @Override annotation; rename FormulaShifter shifter...
Javen O'Neal [Sat, 4 Nov 2017 05:48:18 +0000 (05:48 +0000)]
bug 61474, #81 on github: add @Override annotation; rename FormulaShifter shifter to FormulaShifter formulaShifter to reduce confusion with the shifter variable referring to the RowShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814255 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61474,github-81: add FormulaShifter.createForColumnShift and ShiftMode.ColumnMove
Javen O'Neal [Sat, 4 Nov 2017 05:29:52 +0000 (05:29 +0000)]
bug 61474,github-81: add FormulaShifter.createForColumnShift and ShiftMode.ColumnMove

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814254 13f79535-47bb-0310-9956-ffa450edef68

6 years agogithub-81: extract routines in HSSFRow#shiftRows
Javen O'Neal [Sat, 4 Nov 2017 04:29:45 +0000 (04:29 +0000)]
github-81: extract routines in HSSFRow#shiftRows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814253 13f79535-47bb-0310-9956-ffa450edef68

6 years agorename ambiguous variable name shifter -> formulaShifter
Javen O'Neal [Sat, 4 Nov 2017 02:57:01 +0000 (02:57 +0000)]
rename ambiguous variable name shifter -> formulaShifter

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814247 13f79535-47bb-0310-9956-ffa450edef68

6 years agowhitespace
Javen O'Neal [Sat, 4 Nov 2017 02:49:52 +0000 (02:49 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814245 13f79535-47bb-0310-9956-ffa450edef68

6 years ago#61671 - XSLFSlide does not contain isHidden and setHidden like HSLFSlide does
Andreas Beeker [Thu, 2 Nov 2017 23:15:19 +0000 (23:15 +0000)]
#61671 - XSLFSlide does not contain isHidden and setHidden like HSLFSlide does

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814122 13f79535-47bb-0310-9956-ffa450edef68

6 years agoJavadoc fix
Nick Burch [Wed, 1 Nov 2017 11:21:25 +0000 (11:21 +0000)]
Javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813966 13f79535-47bb-0310-9956-ffa450edef68

6 years agoeventually we want to forbid StringBuffer usage
Javen O'Neal [Tue, 31 Oct 2017 11:10:08 +0000 (11:10 +0000)]
eventually we want to forbid StringBuffer usage

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813875 13f79535-47bb-0310-9956-ffa450edef68

6 years agouse StringBuilder in more places
PJ Fanning [Tue, 31 Oct 2017 10:24:47 +0000 (10:24 +0000)]
use StringBuilder in more places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813869 13f79535-47bb-0310-9956-ffa450edef68

6 years agogithub-68: add @Override to o.a.p.ss.usermodel.charts.DataSources. Thanks to Alain...
Javen O'Neal [Tue, 31 Oct 2017 10:17:38 +0000 (10:17 +0000)]
github-68: add @Override to o.a.p.ss.usermodel.charts.DataSources. Thanks to Alain-Bearez.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813868 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd test case for bug 61701
PJ Fanning [Tue, 31 Oct 2017 09:51:51 +0000 (09:51 +0000)]
add test case for bug 61701

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813864 13f79535-47bb-0310-9956-ffa450edef68

6 years agoadd test case for bug 61701 and use StringBuilder in more places
PJ Fanning [Tue, 31 Oct 2017 09:48:23 +0000 (09:48 +0000)]
add test case for bug 61701 and use StringBuilder in more places

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813863 13f79535-47bb-0310-9956-ffa450edef68

6 years agogithub-77: Remove the 'public' modifier to make fields package protected (findbugs...
Javen O'Neal [Tue, 31 Oct 2017 09:38:03 +0000 (09:38 +0000)]
github-77: Remove the 'public' modifier to make fields package protected (findbugs-MS_PKGPROTECT). Thanks to BruceKuiLiu for the PR. This closes #77 on github.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813859 13f79535-47bb-0310-9956-ffa450edef68

6 years agoconsolidate duplicated code: XSSFWorkbook#setBookViewsIfMissing()
Javen O'Neal [Tue, 31 Oct 2017 01:45:03 +0000 (01:45 +0000)]
consolidate duplicated code: XSSFWorkbook#setBookViewsIfMissing()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813841 13f79535-47bb-0310-9956-ffa450edef68

6 years agobump the Eclipse compile source to Java 1.8
Javen O'Neal [Tue, 31 Oct 2017 01:08:43 +0000 (01:08 +0000)]
bump the Eclipse compile source to Java 1.8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813840 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61630: Patch from Daniel to fix XSSFExportToXML IllegalArgumentException: Compari...
Javen O'Neal [Thu, 26 Oct 2017 18:10:09 +0000 (18:10 +0000)]
bug 61630: Patch from Daniel to fix XSSFExportToXML IllegalArgumentException: Comparison method violates its general contract! (bug 61630, comment 17, attachment 35468). Found during manual testing.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813443 13f79535-47bb-0310-9956-ffa450edef68

6 years agoremove test-hssf ant target
Javen O'Neal [Wed, 25 Oct 2017 20:19:23 +0000 (20:19 +0000)]
remove test-hssf ant target

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813351 13f79535-47bb-0310-9956-ffa450edef68

6 years agoremove test-ss and test-ooxml-ss ant targets, as these were causing problems with...
Javen O'Neal [Wed, 25 Oct 2017 18:59:54 +0000 (18:59 +0000)]
remove test-ss and test-ooxml-ss ant targets, as these were causing problems with the build/ooxml-testokfile.txt being written, requiring test-ooxml to be rerun on subsequent ant calls even if had previously completed successfully and not modifications to the ooxml source had been made.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813342 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61630: further XSSFExportToXML performance improvements from Daniel (bug 61630...
Javen O'Neal [Wed, 25 Oct 2017 18:19:12 +0000 (18:19 +0000)]
bug 61630: further XSSFExportToXML performance improvements from Daniel (bug 61630 comment 15, attachment 35450)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813332 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61630: revert r1813240, which failed the integration test with org.apache.poi...
Javen O'Neal [Tue, 24 Oct 2017 23:44:21 +0000 (23:44 +0000)]
bug 61630: revert r1813240, which failed the integration test with org.apache.poi.stress.XSSFFileHandler on test-data/spreadsheet/59025.xlsx

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813243 13f79535-47bb-0310-9956-ffa450edef68

6 years agobug 61630: further XSSFExportToXML performance improvements from Daniel (comment...
Javen O'Neal [Tue, 24 Oct 2017 23:00:12 +0000 (23:00 +0000)]
bug 61630: further XSSFExportToXML performance improvements from Daniel (comment 9, bug 61630 attachment 35450)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813240 13f79535-47bb-0310-9956-ffa450edef68

6 years agoRemove more deprecated code
PJ Fanning [Mon, 23 Oct 2017 21:17:49 +0000 (21:17 +0000)]
Remove more deprecated code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813102 13f79535-47bb-0310-9956-ffa450edef68