Fixed touch scrolling issue in Surface and WP devices (#18737)
Fixed by using pointerevents instead of touchevents when the browser is IE11,
or Edge. Also added touch-action: none; css rules into escalator.css to prevent
default touch behaviour on IE11 and Edge. Does not affect IE8 to IE10 browsers,
behaviour on those will stay the same as before the fix.
No new unit tests since we do not have automatic touch testing possibilities yet.
Please test manually with Surface: IE11 and Edge, use for example uitest:
com.vaadin.tests.components.grid.basics.GridBasicsomponents.grid.basics.GridBasics
Pekka Hyvönen [Tue, 22 Nov 2016 07:08:45 +0000 (09:08 +0200)]
Remove CustomFieldState (#20468)
Moves FocusDelegate to AbstractFieldState.
This change is done to revert backwards compatibiity breaking API
change in 7.7.4 when CustomFieldState was introduced.
adam [Sat, 12 Nov 2016 13:25:52 +0000 (15:25 +0200)]
Fixed drag and drop failure when message dragged from email client (#20451)
When dragging message form email client on Windows, item.webkitGetAsEntry()
might return null creating NPE on the client side. Added additional checks
for this situation.
adam [Tue, 18 Oct 2016 09:00:55 +0000 (12:00 +0300)]
Fix NPE in case some items don't contain all properties of Grid.
This could occur in when parent is a different entity than its children
in hierarchical data.
Artur Signell [Mon, 10 Oct 2016 19:58:04 +0000 (22:58 +0300)]
Make clicking outside a ComboBox add a pending new item (#18366)
It should not matter how you move from a field to the next. Tabbing
to the next field already previously caused the new item handler to
be invoked. This fixes the case when you click in the next field to
work the same way.
Fixed touch scrolling issue in Surface and WP devices (#18737)
Fixed by using mouse events instead of touchevents when the browser is
IE or Edge (added isIEOrEdge utility method in the BrowserInfo). Also
added touch-action: none; css rules into escalator.css to prevent
default touch behaviour on IE and Edge
No new unit tests since we do not have automatic touch testing
possibilities yet.
Please test manually with Surface: IE and Edge, use for example uitest:
com.vaadin.tests.components.grid.basics.GridBasics
Denis Anisimov [Mon, 31 Oct 2016 07:10:02 +0000 (09:10 +0200)]
Date/time issues are fixed in the tests.
- legacy DateField declarative format tests are fixed (day light saving
time is taken into account).
- CalendarMonthViewDndEvent UI because you are not supposed to work on
Sundays (when the test is broken).
Marc Englund [Mon, 28 Sep 2015 11:11:07 +0000 (14:11 +0300)]
Add valo-menu-hover stylename to make responsive menu appear w/o adding code (#19019)
Adding the optional "valo-menu-hover" style to the "valo-menu" element
will make the menu appear on hover - i.e when mousing over on desktop,
when tapping on touch devices (which also triggers hover).
Artur Signell [Sat, 24 Sep 2016 07:20:21 +0000 (10:20 +0300)]
Add tests for widgetset compilation in different modes
* Using the default widget set
* Using no add-ons but a custom widget set
* Using add-ons with a defined widget set
* Using add-ons with no defined widget set
* Using directories with special characters (space)
Artur Signell [Fri, 23 Sep 2016 19:08:39 +0000 (22:08 +0300)]
Fix widget set builder to create widget set in correct location (#20320)
The fix for #20285 generates URLs so that the end in a slash, where the old
version generated URLs without the trailing slash. The trailing slash was not
taken into account by the code which updates a widget set.
Artur Signell [Thu, 15 Sep 2016 07:43:27 +0000 (10:43 +0300)]
Use widget set specified by init parameter (#20276)
1. If a UI has @Widgetset, use that
2. If a "widgetset" init parameter has been specified, use that
3. If there is an AppWidgetset, use that
4. Use DefaultWidgetSet
This changes the default value of the @VaadinServletConfiguration widgetset
parameter to "", to avoid always setting the "widgetset" init parameter when
@VaadinServletConfiguration is used.
Artur Signell [Sun, 18 Sep 2016 20:00:58 +0000 (23:00 +0300)]
Use requestAnimationFrame when scrolling in Grid (#20294)
Chrome no longer (since version 5x) always fire deferred commands
immediately during scrolling but can delay them with several hundred
milliseconds, making grid really unresponsive.
So far, nobody has been able to provide a reliable test case.
Artur Signell [Sun, 18 Sep 2016 14:35:34 +0000 (17:35 +0300)]
Make initially disabled grid work when enabled (#20240)
Adds API to allow grid to ask its data source if it is waiting for data.
The previous tracking inside grid was not always correct as it relied
on dataAvailable being called.
Artur Signell [Thu, 15 Sep 2016 07:43:27 +0000 (10:43 +0300)]
Use widget set specified by init parameter (#20276)
1. If a UI has @Widgetset, use that
2. If a "widgetset" init parameter has been specified, use that
3. If there is an AppWidgetset, use that
4. Use DefaultWidgetSet
Artur Signell [Thu, 8 Sep 2016 19:22:53 +0000 (22:22 +0300)]
Ensure Firefox always updates the grid scrollbar (#19802)
When the scrollbar is scrolled a bit down and the number of items
in the grid is reduced so that no scrollbar is needed anymore, it seems
that Firefox refuses to send a scroll event even though the scroll position
is updated before the scrollbar is hidden.
Artur Signell [Fri, 2 Sep 2016 05:19:35 +0000 (08:19 +0300)]
Update DOM and update escalator row count in the correct order (#19442)
If you show a column when Grid has no horizontal scrollbar, and is scrolled
all the way down, and the number of visible rows is slightly more than N then
Escalator will adjust the row count when the scrollbar is shown so that N-1
rows are visible. During this operation, the DOM must be updated for the new
column.
Patrik Lindström [Thu, 23 Jun 2016 13:00:52 +0000 (16:00 +0300)]
Discard for DateField when the data source contains null (#8069)
Earlier discard did not work (#8069) if the data source
contained null and the user entered an invalid value for date fields.
The discard logic has been changed such that the error indicators and
internal state of the date field is cleared also if the value entered by
the user is invalid and the data source is null.
attach() updates the value from the data source in the same way as
discard. The old logic in attach is retained.
Artur Signell [Mon, 29 Aug 2016 19:11:23 +0000 (22:11 +0300)]
Fix animation end listeners so they are always removed (#17903)
Fixes ComboBox suggestion popup so that it will not automatically
close when clicking the popup button, if the user happened to
double click on the button earlier.
Matti Tahvonen [Mon, 22 Aug 2016 15:30:59 +0000 (18:30 +0300)]
Added a fallback value for useragent (#20172)
Without this change, some browsers, like GoogleBot, don't properly render the page.
Instead of weird JS exception (and hit to server with 404) we should at least try
to render the app with all browser. As webikit/chromium based browsers are
nowadays most popular, falling back to "safari" permutation.