]> source.dussan.org Git - gitea.git/log
gitea.git
3 years agoMigrations should not fail for comment reactions (#13352)
zeripath [Thu, 29 Oct 2020 21:41:49 +0000 (21:41 +0000)]
Migrations should not fail for comment reactions (#13352)

An extension to #13444 - where we now ensure that comment reaction failures do not cause migrations failure

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years agoIssue comment reactions should also check pull type (#13349)
zeripath [Thu, 29 Oct 2020 12:48:07 +0000 (12:48 +0000)]
Issue comment reactions should also check pull type (#13349)

* Migrating reactions is just not that important

A failure during migrating reactions should not cause failure of
migration.

Signed-off-by: Andrew Thornton <art27@cantab.net>
* When checking issue reactions check the correct permission

Signed-off-by: Andrew Thornton <art27@cantab.net>
* And there is another one ...

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years agoMigration failure during reaction migration from gitea (#13344)
zeripath [Thu, 29 Oct 2020 02:23:31 +0000 (02:23 +0000)]
Migration failure during reaction migration from gitea (#13344)

* Migrating reactions is just not that important

A failure during migrating reactions should not cause failure of
migration.

Signed-off-by: Andrew Thornton <art27@cantab.net>
* When checking issue reactions check the correct permission

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoRemove obsolete change of email on profile page (#13341)
zeripath [Wed, 28 Oct 2020 22:33:14 +0000 (22:33 +0000)]
Remove obsolete change of email on profile page (#13341)

* Remove obsolete change of email on profile page

The change email on the account profile page is out-of-date
and unnecessary.

Changing email should be done using the account page.

Fix #13336

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years agoFully remove fomantic-ui from frontend build dependencies (#13340)
silverwind [Wed, 28 Oct 2020 21:51:03 +0000 (22:51 +0100)]
Fully remove fomantic-ui from frontend build dependencies (#13340)

Followup to https://github.com/go-gitea/gitea/pull/13332. Turns out I
missed this dependency which resulted in fomantic-ui being uselessly
rebuild on CI. This fully removes it from the chain so it's not
attempted to be build as part of the main build process.

3 years agoFix command-line doc examples (#13337)
Shikaku [Wed, 28 Oct 2020 20:47:51 +0000 (05:47 +0900)]
Fix command-line doc examples (#13337)

3 years agoPrecompile fomantic-ui files (#13332)
silverwind [Tue, 27 Oct 2020 23:44:06 +0000 (00:44 +0100)]
Precompile fomantic-ui files (#13332)

We rarely change fomantic-ui or its configuration so it's kind of a
waste to have it rebuild on every CI run. These changes remove the
fomantic files from the build and instead add the relevant output files
to the git index, which should shave of 2-3 minutes on every CI run.

`make fomantic` should still work and should be ran whenever fomantic is
updated or its configuration is changed.

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoAdd migrated pulls to pull request task queue (#13331)
zeripath [Tue, 27 Oct 2020 21:34:56 +0000 (21:34 +0000)]
Add migrated pulls to pull request task queue (#13331)

* Add migrated pulls to pull request task queue

Fix #13321

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Improve error reports

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agofix quotation marks in launch.json (#13325)
Elena Neuschild [Tue, 27 Oct 2020 20:58:09 +0000 (21:58 +0100)]
fix quotation marks in launch.json (#13325)

Co-authored-by: zeripath <art27@cantab.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 27 Oct 2020 20:07:43 +0000 (20:07 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoAdd deprecation notice for webhook payload's secret field (#13330)
JustAnotherArchivist [Tue, 27 Oct 2020 20:06:35 +0000 (20:06 +0000)]
Add deprecation notice for webhook payload's secret field (#13330)

3 years ago[UI] Hide consecutive additions and removals of the same label (#13315)
Pedro Alves [Tue, 27 Oct 2020 07:12:01 +0000 (07:12 +0000)]
[UI] Hide consecutive additions and removals of the same label (#13315)

3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 26 Oct 2020 16:43:30 +0000 (16:43 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoFix send mail (#13312)
Lunny Xiao [Mon, 26 Oct 2020 16:42:27 +0000 (00:42 +0800)]
Fix send mail (#13312)

* Fix send mail

* Fix send mail

* Update modules/private/mail.go

Co-authored-by: techknowlogick <matti@mdranta.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 26 Oct 2020 09:06:29 +0000 (09:06 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoDeny wrong pull (#13308)
M4RKUS-11111 [Mon, 26 Oct 2020 09:05:27 +0000 (10:05 +0100)]
Deny wrong pull (#13308)

* Deny wrong pull

* Update routers/api/v1/repo/pull.go

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Markus <git+markus@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
3 years agoGroup Label Changed Comments in timeline (#13304)
Pedro Alves [Sun, 25 Oct 2020 21:49:48 +0000 (21:49 +0000)]
Group Label Changed Comments in timeline (#13304)

* Create function to group label comments

* Combine multiple label additions into one

* Group removed and added labels in the same comment

* Fix indentation on comments.tmpl

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: zeripath <art27@cantab.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sun, 25 Oct 2020 20:57:54 +0000 (20:57 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoAttempt to handle unready PR in tests (#13305)
zeripath [Sun, 25 Oct 2020 20:56:51 +0000 (20:56 +0000)]
Attempt to handle unready PR in tests (#13305)

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years ago#12897 - add mastodon provider (#13293)
Divyam Bhasin [Sun, 25 Oct 2020 18:21:49 +0000 (14:21 -0400)]
#12897 - add mastodon provider (#13293)

* added mastodon provider to oauth code

* changed go.mod and vendor/modules.txt to add updated goth

* vendored mastodon and new goth

* committing result of go mod tidy && go mod vendor

* added pic and mastodon to oauth models

* handled instance url

* applied lafriks suggestion

* Update web_src/js/index.js

Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <matti@mdranta.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sun, 25 Oct 2020 17:20:28 +0000 (17:20 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoFix Storage mapping (#13297)
zeripath [Sun, 25 Oct 2020 17:19:06 +0000 (17:19 +0000)]
Fix Storage mapping (#13297)

This PR fixes several bugs in setting storage

* The default STORAGE_TYPE should be the provided type.
* The Storage config should be passed in to NewStorage as a pointer - otherwise the Mappable interface function MapTo will not be found
* There was a bug in the MapTo function.

Fix #13286

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years agoUpdate Mirror IsEmpty status on synchronize (#13185)
zeripath [Sun, 25 Oct 2020 07:32:25 +0000 (07:32 +0000)]
Update Mirror IsEmpty status on synchronize (#13185)

Fix #9630
Fix #13183

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
3 years agoFix bug isEnd detection on getIssues/getPullRequests (#13299)
Lunny Xiao [Sun, 25 Oct 2020 05:11:03 +0000 (13:11 +0800)]
Fix bug isEnd detection on getIssues/getPullRequests (#13299)

3 years agosystemd service: Add commented PATH environment option for Git prefix (#13170)
Bagas Sanjaya [Sat, 24 Oct 2020 21:13:59 +0000 (04:13 +0700)]
systemd service: Add commented PATH environment option for Git prefix (#13170)

On some setups, Git is installed to directory prefix other than default
PATH (such as /opt/git/bin). For Gitea to know such Git installations,
PATH environment must be specified on service file.

Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoSendmail command (#13079)
Maxim Zhiburt [Sat, 24 Oct 2020 20:38:14 +0000 (23:38 +0300)]
Sendmail command (#13079)

* Add SendSync method

Usefull to have when you need to be confident that message was sent.

* Add sendmail command

* add checks that if either title or content is empty then error out

* Add a confirmation step

* Add --force option to bypass confirm step

* Move implementation of runSendMail to a different file

* Add copyrighting comment

* Make content optional

Print waring if it's empty or haven't been set up.
The warning will be skiped if there's a `--force` flag.

* Fix import style

Co-authored-by: 6543 <6543@obermui.de>
* Use batch when getting all users

IterateUsers uses batching by default.

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Send emails one by one instead of as one chunck

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Send messages concurantly

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Use SendAsync+Flush instead of SendSync

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Add timeout parameter to sendemail command

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Fix spelling mistake

Signed-off-by: Maxim Zhiburt <zhiburt@gmail.com>
* Update cmd/admin.go

Co-authored-by: 6543 <6543@obermui.de>
* Connect to a running Gitea instance

* Fix mispelling

* Add copyright comment

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoVarious UI and arc-green fixes (#13291)
silverwind [Sat, 24 Oct 2020 19:15:29 +0000 (21:15 +0200)]
Various UI and arc-green fixes (#13291)

- introduce variable for border-radius value
- fix some white borders in arc-green
- add text selection and placeholder in arc-green
- tweak branch list footer
- more things I forgot

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 24 Oct 2020 17:50:51 +0000 (17:50 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoRemove duplicated repository.upload on cheat-sheet docs (#13290)
Lunny Xiao [Sat, 24 Oct 2020 17:49:52 +0000 (01:49 +0800)]
Remove duplicated repository.upload on cheat-sheet docs (#13290)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 24 Oct 2020 16:49:12 +0000 (16:49 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoFix PR/Issue titles on mobile (#13292)
kolaente [Sat, 24 Oct 2020 16:48:08 +0000 (18:48 +0200)]
Fix PR/Issue titles on mobile (#13292)

* Start fixing Issue & PR title on mobile

Signed-off-by: kolaente <k@knt.li>
* Make sure the save & cancel buttons float right

Signed-off-by: kolaente <k@knt.li>
* Fix edit buttons and title input on mobile

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
3 years agoEnsure topics added using the API are added to the repository (#13285)
zeripath [Sat, 24 Oct 2020 14:11:30 +0000 (15:11 +0100)]
Ensure topics added using the API are added to the repository (#13285)

* Ensure topics added using the API are added to the repository

Fix #12426

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sat, 24 Oct 2020 11:55:43 +0000 (11:55 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoDon't show "0" labels on repo tabs (#13289)
silverwind [Sat, 24 Oct 2020 11:54:33 +0000 (13:54 +0200)]
Don't show "0" labels on repo tabs (#13289)

If count is zero, don't show the label, matching GH behavior.

3 years agoRearrange the order of the merged by etc. in locale (#13284)
zeripath [Sat, 24 Oct 2020 03:34:21 +0000 (04:34 +0100)]
Rearrange the order of the merged by etc. in locale (#13284)

Fix #13260

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years agoStore task errors following migrations and display them (#13246)
zeripath [Fri, 23 Oct 2020 23:46:35 +0000 (00:46 +0100)]
Store task errors following migrations and display them (#13246)

* Store task errors following migrations and display them

When migrate tasks fail store the error in the task table
and ensure that they show on the status page.

Fix #13242

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Update web_src/js/index.js

* Hide the failed first

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years ago#13091 - add new mirror button (#13105)
Divyam Bhasin [Fri, 23 Oct 2020 23:01:58 +0000 (19:01 -0400)]
#13091 - add new mirror button (#13105)

* added button

* got URL params to carry through to service specific migrate pages

* do not display add mirror button if mirroring turned off

* added corrections by reviewers

* Add silverwind's suggestion

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
3 years agoAvatar autogeneration fixed (#13233)
Paweł Bogusławski [Fri, 23 Oct 2020 17:55:10 +0000 (19:55 +0200)]
Avatar autogeneration fixed (#13233)

This mod fixes problem with initial avatar autogeneration and
avatar autogneration after deleting previous avatar.

Related: https://github.com/go-gitea/gitea/issues/13159
Fixes: 80a6b0f5bce15a641fc75f5f1ef6e42ef54424bc
Author-Change-Id: IB#1105243

3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Fri, 23 Oct 2020 16:00:48 +0000 (16:00 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoRefactor docs (#13275)
John Olheiser [Fri, 23 Oct 2020 15:59:45 +0000 (10:59 -0500)]
Refactor docs (#13275)

* First pass

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* More changes

Signed-off-by: jolheiser <john.olheiser@gmail.com>
* Redirects

Signed-off-by: jolheiser <john.olheiser@gmail.com>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Fri, 23 Oct 2020 10:12:50 +0000 (10:12 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoRemove PAM from auth dropdown when unavailable (#13276)
John Olheiser [Fri, 23 Oct 2020 10:10:29 +0000 (05:10 -0500)]
Remove PAM from auth dropdown when unavailable (#13276)

Signed-off-by: jolheiser <john.olheiser@gmail.com>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Thu, 22 Oct 2020 19:49:54 +0000 (19:49 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoFix arc theme label backgrounds (#13267)
Iván Valdés [Thu, 22 Oct 2020 19:48:48 +0000 (12:48 -0700)]
Fix arc theme label backgrounds (#13267)

* Fix arc theme label backgrounds

* Add specific style to yellow labels (background + border color)
* Remove !important from label's background rule to avoid breaking user
  defined labels. Make the rule more specific to override fomantic UI
  default white background

* Remove unnecesary selector

Co-authored-by: zeripath <art27@cantab.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Thu, 22 Oct 2020 18:03:41 +0000 (18:03 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoClarify app.example.ini documentation (#13256)
Mattias Persson [Thu, 22 Oct 2020 18:02:28 +0000 (20:02 +0200)]
Clarify app.example.ini documentation (#13256)

* Clarify app.example.ini documentation

Hard to understand if cron i needed to activate all other cron.

* Added missing "Extended cron tasks" to config-cheat-sheet.en-us.md

cron default is false - setting it true activates all cron. Changed the documentation accordingly

* Fixed spelling

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Thu, 22 Oct 2020 17:05:26 +0000 (17:05 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoadd sdk links to docs (#13266)
M4RKUS-11111 [Thu, 22 Oct 2020 17:04:23 +0000 (19:04 +0200)]
add sdk links to docs (#13266)

* add sdk links to docs

* Update docs/content/doc/advanced/api-usage.en-us.md

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: Markus <git+markus@obermui.de>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Thu, 22 Oct 2020 15:46:58 +0000 (15:46 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoKeep database transactions not too big (#13254)
Lunny Xiao [Thu, 22 Oct 2020 15:45:54 +0000 (23:45 +0800)]
Keep database transactions not too big (#13254)

* Keep database transactions not too big

* Fix #13255

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Only cache the last repo

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Andrew Thornton <art27@cantab.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Thu, 22 Oct 2020 05:47:21 +0000 (05:47 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoMigrations: Gitea should not fail just because of no apiConfig return (#13229)
6543 [Thu, 22 Oct 2020 05:46:18 +0000 (07:46 +0200)]
Migrations: Gitea should not fail just because of no apiConfig return (#13229)

* close #13227

* log it

:+1:

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoInform user of how disable SSH feature when installing using Docker (#13180)
Amoo Hesam [Thu, 22 Oct 2020 04:24:20 +0000 (07:54 +0330)]
Inform user of how disable SSH feature when installing using Docker (#13180)

3 years agoMore arc-green fixes (#13247)
silverwind [Thu, 22 Oct 2020 03:51:12 +0000 (05:51 +0200)]
More arc-green fixes (#13247)

- Fix various white borders
- Tweak basic button style to have more contrast
- Add more contrast to hover styles
- Invert Matrix webhook icon

May backport to 1.13.

Co-authored-by: zeripath <art27@cantab.net>
3 years agoDockerfile: Support socat use cases (#13208)
Begley Brothers (Development) [Thu, 22 Oct 2020 01:41:49 +0000 (12:41 +1100)]
Dockerfile: Support socat use cases (#13208)

* Dockerfile: Support socat use cases

In some contexts it is necessary to provide access to Gitea via TCP ports and unix sockets.
Gitea (`gitea web`) can be configured to listen for connections via unix-socket or TCP port, but not both.
When Gitea is installed to the host this limitation can be worked around by installing socat on the host.
When running Gitea from a container this limitation cannot be workaround.

Add socat to Gitea container.

* Removed version

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoEnhance release list (#6025)
Lanre Adelowo [Thu, 22 Oct 2020 00:55:25 +0000 (01:55 +0100)]
Enhance release list (#6025)

* show author for releases created outside Gitea UI.

Also show the number of commits behind the default branch for tags created outside the UI

don't show the tag date again for tags pushed to the repo. Since it is already on the sidebar and looks like duplication

* add migration for already existing tags

* update as per review

* fix build

* add space

* fix import statments

* Update models/migrations/v113.go

Co-Authored-By: zeripath <art27@cantab.net>
* Update models/migrations/v114.go

Co-authored-by: 6543 <6543@obermui.de>
* Update services/release/release.go

Co-authored-by: 6543 <6543@obermui.de>
* impruve

* remove dependency on models package

* Close the gitrepos in a defer to ensure that they are closed.

* gofmt

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoUpdate outdated label to use Fomantic UI style (#13181)
Iván Valdés [Wed, 21 Oct 2020 23:47:16 +0000 (16:47 -0700)]
Update outdated label to use Fomantic UI style (#13181)

* Update outdated label to use Fomantic UI style

* Use native labels rather than custom style

* Remove leading zero

Co-authored-by: zeripath <art27@cantab.net>
3 years agoFix initial commit page & binary munching problem (#13249)
zeripath [Wed, 21 Oct 2020 23:08:44 +0000 (00:08 +0100)]
Fix initial commit page & binary munching problem (#13249)

* Fix initial commit page

Unfortunately as a result of properly fixing ParsePatch the hack that
used git show <initial_commit_id> to get the diff for this failed.

This PR fixes this using the "super-secret" empty tree ref to make the
diff against.

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Also fix #13248

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Update services/gitdiff/gitdiff.go

Co-authored-by: 6543 <6543@obermui.de>
3 years agoAdd better error checking for inline html diff code (#13239)
mrsdizzie [Wed, 21 Oct 2020 22:14:44 +0000 (18:14 -0400)]
Add better error checking for inline html diff code (#13239)

* Add better error checking for inline html diff code

A better fix for #13191 which cleans up this code a bit and adds basic checking which should avoid writing broken HTML in future situations.

* Update gitdiff_test.go

* better regex

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoReplace footer and modal icons with SVG (#13245)
silverwind [Wed, 21 Oct 2020 21:07:33 +0000 (23:07 +0200)]
Replace footer and modal icons with SVG (#13245)

- Replace two font icons with SVG in the footer
- Replace icons in delete modals with SVG
- Horizontally center message text in modals

3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 21 Oct 2020 20:00:31 +0000 (20:00 +0000)]
[skip ci] Updated translations via Crowdin

3 years agofix message key (#13240)
Iwasa Kazmi [Wed, 21 Oct 2020 19:59:12 +0000 (04:59 +0900)]
fix message key (#13240)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 21 Oct 2020 15:43:44 +0000 (15:43 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoadd more clarification to the issue-template.md (#13235)
zeripath [Wed, 21 Oct 2020 15:42:47 +0000 (16:42 +0100)]
add more clarification to the issue-template.md (#13235)

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agogo-version constraints ignore pre-releases (#13234)
zeripath [Wed, 21 Oct 2020 15:42:08 +0000 (16:42 +0100)]
go-version constraints ignore pre-releases (#13234)

Go-version constraints ignore pre-releases.

Rather than change the library further this PR simply changes
the git version comparison to use simple version compare ignoring the
issue of pre-releases.

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Wed, 21 Oct 2020 11:03:31 +0000 (11:03 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoUpdate some JS dependencies (#13222)
silverwind [Wed, 21 Oct 2020 11:02:24 +0000 (13:02 +0200)]
Update some JS dependencies (#13222)

* Update some JS dependencies

- Update selective dependencies that are compatible with webpack 4. We
can not upgrade to webpack 5 yet because `license-webpack-plugin` is
incompatible.
- Enable a few new eslint rules and fix new issues

* fix comment

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
3 years agoReturn the full rejection message and errors in flash errors (#13221)
zeripath [Tue, 20 Oct 2020 23:50:10 +0000 (00:50 +0100)]
Return the full rejection message and errors in flash errors (#13221)

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years agoUpdate heatmap fixtures to restore tests (#13224)
6543 [Tue, 20 Oct 2020 22:39:25 +0000 (00:39 +0200)]
Update heatmap fixtures to restore tests (#13224)

* hotfix

* update ...

3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 20 Oct 2020 18:19:29 +0000 (18:19 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoAdd review request api (#11355)
a1012112796 [Tue, 20 Oct 2020 18:18:25 +0000 (02:18 +0800)]
Add review request api (#11355)

* Add review request api

* add : POST /repos/{owner}/{repo}/pulls/{index}/requested_reviewers
* Remove : DELET /repos/{owner}/{repo}/pulls/{index}/requested_reviewers
* fix some request review bug
* block delet request review by models/DeleteReview()

Signed-off-by: a1012112796 <1012112796@qq.com>
* make fmt

* fix bug

* fix test code

* fix typo

* Apply suggestion from code review @jonasfranz

* fix swagger ref

* fix typo

Co-authored-by: Lauris BH <lauris@nix.lv>
* fix comment

* Change response message

* chang response so some simplfy

* Add ErrIllLegalReviewRequest
fix some nits

* make fmt

* Apply suggestions from code review

Co-authored-by: silverwind <me@silverwind.io>
* * Add team support
* fix test
* fix an known bug

* fix nit

* fix test

* Apply suggestions from code review

Co-authored-by: zeripath <art27@cantab.net>
* update get api and add test

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: zeripath <art27@cantab.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Tue, 20 Oct 2020 12:54:03 +0000 (12:54 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoWhen the git ref is unable to be found return broken pr (#13218)
zeripath [Tue, 20 Oct 2020 12:52:54 +0000 (13:52 +0100)]
When the git ref is unable to be found return broken pr (#13218)

Fix #13216

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years agoVarious arc-green fixes (#13214)
silverwind [Tue, 20 Oct 2020 05:22:10 +0000 (07:22 +0200)]
Various arc-green fixes (#13214)

- Style search dropdown
- Fix radio buttons and tweak checkboxes
- Add styling for error form elements
- Make borders brighter and focus more apparent
- Adjust comment box border color to match

Fixes: https://github.com/go-gitea/gitea/pull/12491
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoShow stale label for stale code comment which is marked as resolved (#13213)
a1012112796 [Tue, 20 Oct 2020 04:48:04 +0000 (12:48 +0800)]
Show stale label for stale code comment which is marked as resolved (#13213)

Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
3 years agoMove install pages out of main macaron routes (#13195)
zeripath [Mon, 19 Oct 2020 21:03:08 +0000 (22:03 +0100)]
Move install pages out of main macaron routes (#13195)

* Move install pages out of main macaron loop

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Update templates/post-install.tmpl

Co-authored-by: Lauris BH <lauris@nix.lv>
* remove prefetch

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years agoUse CSS Variables for fonts, remove postcss-loader (#13204)
silverwind [Mon, 19 Oct 2020 20:01:06 +0000 (22:01 +0200)]
Use CSS Variables for fonts, remove postcss-loader (#13204)

* Use CSS Variables for fonts, remove postcss-loader

- Use CSS variables for fonts, making the fonts easier to customize
- Remove postcss-loader, it's not doing anything useful and is actually
  applying strange transforms on our CSS.

Fixes: https://github.com/go-gitea/gitea/issues/11045
* introduce helper variable, mark documented vars

* work around case issue by always quoting specific fonts

3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Mon, 19 Oct 2020 19:26:52 +0000 (19:26 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoAlign `SSH_AUTHORIZED_KEYS_BACKUP` var with the value in `app.ini` (#13212)
Patrick Schratz [Mon, 19 Oct 2020 19:25:32 +0000 (21:25 +0200)]
Align `SSH_AUTHORIZED_KEYS_BACKUP` var with the value in `app.ini` (#13212)

* Align `SSH_AUTHORIZED_KEYS_BACKUP` var with the value in `app.ini`

* Also fix the cheat sheet and move it to below - SSH_CREATE_AUTHORIZED_KEYS_FILE

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Andrew Thornton <art27@cantab.net>
3 years agoFix size and clickable area on file table back link (#13205)
silverwind [Sun, 18 Oct 2020 21:59:18 +0000 (23:59 +0200)]
Fix size and clickable area on file table back link (#13205)

Fixes: https://github.com/go-gitea/gitea/issues/13038
Should backport to 1.13.

3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sun, 18 Oct 2020 17:52:36 +0000 (17:52 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoFix error in diff html rendering (#13191)
mrsdizzie [Sun, 18 Oct 2020 17:51:38 +0000 (12:51 -0500)]
Fix error in diff html rendering (#13191)

* Fix error in diff html rendering

Was missing an optional whitespace check in regex. Also noticed a rare case where diff.Type == Equal would be empty and thus get a newline attached. Fixed that too.

Fixes #13177

* Update services/gitdiff/gitdiff.go

Co-authored-by: zeripath <art27@cantab.net>
* Update gitdiff_test.go

* fmt

Co-authored-by: zeripath <art27@cantab.net>
3 years agoApply to become a maintainer (#13201)
a1012112796 [Sun, 18 Oct 2020 16:12:51 +0000 (00:12 +0800)]
Apply to become a maintainer (#13201)

Dear gitea's managers and contributors, I apply to become a
maintainer of gitea. I'm interested in this project and has
sent prs to gitea also. I will do more things to make gitea
better and reviw other contributors's pr in my free time.
Thanks.

Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
3 years agoUpdate CHANGELOG.md (#13200)
a1012112796 [Sun, 18 Oct 2020 15:46:04 +0000 (23:46 +0800)]
Update CHANGELOG.md (#13200)

Co-authored-by: zeripath <art27@cantab.net>
3 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Sun, 18 Oct 2020 14:11:20 +0000 (14:11 +0000)]
[skip ci] Updated translations via Crowdin

3 years agoAdd git command error directory on log (#13194)
Lunny Xiao [Sun, 18 Oct 2020 14:10:11 +0000 (22:10 +0800)]
Add git command error directory on log (#13194)

3 years agoWhen handling errors in storageHandler check underlying error (#13178)
zeripath [Sun, 18 Oct 2020 01:29:06 +0000 (02:29 +0100)]
When handling errors in storageHandler check underlying error (#13178)

Unfortunately there was a mistake in #13164 which fails to handle
os.PathError wrapping an os.ErrNotExist

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
4 years agoRemove not relevant option from issue template (#13188)
mrsdizzie [Sat, 17 Oct 2020 15:46:59 +0000 (10:46 -0500)]
Remove not relevant option from issue template (#13188)

Almost every use of "Not relevant" I see is the opposite -- it is relevant to have an example on try.gitea.io and often we can't do anything until the user provides one. Remove the not-relevant option so people have to decide yes/no if they are going to attempt to reproduce it which will hopefully encourage them to do so in simple cases.

For actual not-relevant issues No should be a fine answer as well as it would be clear to us when you can't reproduce an example there.

Hopefully this will encourage more examples when people file issues which would lead to quicker fixes.

4 years ago[Refactor] Move APIFormat functions into convert package (#12856)
6543 [Sat, 17 Oct 2020 04:23:08 +0000 (06:23 +0200)]
[Refactor] Move APIFormat functions into convert package (#12856)

* USER APIFormat -> ToUser

* Migrate more and mark APIFormat deprecated

* models.Comment APIFormat() -> convert.ToComment

* models.Release APIFormat() -> convert.ToRelease

* models.Attachments APIFormat() -> convert.ToReleaseAttachments

* models.CommitStatus APIFormat() -> convert.ToCommitStatus

* finish migration to convert.ToUser

* Move Test

* Imprufe Test

* fix test

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
4 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Fri, 16 Oct 2020 17:14:34 +0000 (17:14 +0000)]
[skip ci] Updated translations via Crowdin

4 years agoFix diff skipping lines (#13154)
zeripath [Fri, 16 Oct 2020 17:13:18 +0000 (18:13 +0100)]
Fix diff skipping lines (#13154)

* Fix diff skipping lines

ParsePatch previously just skipped all lines that start with "+++ " or "--- "
and makes no attempt to see these lines in context.

This PR rewrites ParsePatch to pay attention to context and position
within a patch, ensuring that --- and +++ are only skipped if
appropriate.

This PR also fixes several issues with incomplete files.

Fix https://codeberg.org/Codeberg/Community/issues/308
Fix #13153

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Add testcase

Signed-off-by: Andrew Thornton <art27@cantab.net>
* fix comment

* simplify error handling

Signed-off-by: Andrew Thornton <art27@cantab.net>
* never return io.EOF

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
4 years agoUpdate go-version v1.2.3 -> v1.2.4 (#13169)
6543 [Fri, 16 Oct 2020 09:05:02 +0000 (11:05 +0200)]
Update go-version v1.2.3 -> v1.2.4 (#13169)

Co-authored-by: zeripath <art27@cantab.net>
4 years agoVendor Update Go Libs (#13166)
6543 [Fri, 16 Oct 2020 05:06:27 +0000 (07:06 +0200)]
Vendor Update Go Libs (#13166)

* update github.com/alecthomas/chroma v0.8.0 -> v0.8.1

* github.com/blevesearch/bleve v1.0.10 -> v1.0.12

* editorconfig-core-go v2.1.1 -> v2.3.7

* github.com/gliderlabs/ssh v0.2.2 -> v0.3.1

* migrate editorconfig.ParseBytes to Parse

* github.com/shurcooL/vfsgen to 0d455de96546

* github.com/go-git/go-git/v5 v5.1.0 -> v5.2.0

* github.com/google/uuid v1.1.1 -> v1.1.2

* github.com/huandu/xstrings v1.3.0 -> v1.3.2

* github.com/klauspost/compress v1.10.11 -> v1.11.1

* github.com/markbates/goth v1.61.2 -> v1.65.0

* github.com/mattn/go-sqlite3 v1.14.0 -> v1.14.4

* github.com/mholt/archiver v3.3.0 -> v3.3.2

* github.com/microcosm-cc/bluemonday 4f7140c49acb -> v1.0.4

* github.com/minio/minio-go v7.0.4 -> v7.0.5

* github.com/olivere/elastic v7.0.9 -> v7.0.20

* github.com/urfave/cli v1.20.0 -> v1.22.4

* github.com/prometheus/client_golang v1.1.0 -> v1.8.0

* github.com/xanzy/go-gitlab v0.37.0 -> v0.38.1

* mvdan.cc/xurls v2.1.0 -> v2.2.0

Co-authored-by: Lauris BH <lauris@nix.lv>
4 years agoPrevent panics with missing storage (#13164)
zeripath [Fri, 16 Oct 2020 03:51:06 +0000 (04:51 +0100)]
Prevent panics with missing storage (#13164)

* The `.Use` of storageHandler before setting up the template renderer
causes a panic if there is an error to log.
* The error passed to `ctx.Error` in that case may contain sensitive
information and should not be rendered to the end user. We should
instead log the error and render a simple error message.
* There is no handling of missing avatars and this needs a 404. Minio
errors need to be mapped to standard golang errors such as
os.ErrNotExist.
* There is no logging when storage is set up.

Related #13159

Signed-off-by: Andrew Thornton <art27@cantab.net>
4 years agoImprove users management through the CLI (#6001) (#10492)
ydelafollye [Fri, 16 Oct 2020 02:48:38 +0000 (22:48 -0400)]
Improve users management through the CLI (#6001) (#10492)

* Fix images in wiki edit preview (#11546)

Make sure wiki editor sets wiki to true so gitea renders it as a wiki page.

Also change the context data attr for edit form. This looks wrong but everywhere else in our code assumes the urlPrefix to be just the repo url when rendering and manually adds /wiki to the rendered url regardless.

Fixes #11540

4 years agoChange order of possible-owner organizations to alphabetical (#13160)
Elena Neuschild [Thu, 15 Oct 2020 22:15:55 +0000 (00:15 +0200)]
Change order of possible-owner organizations to alphabetical (#13160)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
4 years agoSlightly simplify the queue settings code to help reduce the risk of problems (#12976)
zeripath [Thu, 15 Oct 2020 21:40:03 +0000 (22:40 +0100)]
Slightly simplify the queue settings code to help reduce the risk of problems (#12976)

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
4 years ago[Vendor] Update go-ldap to v3.2.4 (#13163)
6543 [Thu, 15 Oct 2020 19:27:33 +0000 (21:27 +0200)]
[Vendor] Update go-ldap to v3.2.4 (#13163)

* [Vendor] update go-ldap to v3.0.3

* update go-ldap to v3.2.4

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
4 years ago[skip ci] Updated translations via Crowdin
GiteaBot [Thu, 15 Oct 2020 18:31:29 +0000 (18:31 +0000)]
[skip ci] Updated translations via Crowdin

4 years agoUpdate external-renderers.en-us.md (#13165)
Johan Van de Wauw [Thu, 15 Oct 2020 18:30:25 +0000 (20:30 +0200)]
Update external-renderers.en-us.md (#13165)

Alpine 3.12 (the version used by current master) no longer provides the python-dev package:
https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.12.0#python2_no_longer_provides_python_and_python-devel

As the next steps explicitely use python3 it is not needed anyway.