Make custom panel caption styles better looking (Valo)
If the background color of the caption is darker than the normal
background color, add a colored border around the whole caption.
Otherwise only draw the bottom border using the default background
color.
Fix caption bevel and “well” style box shadow handling as well.
Artur Signell [Fri, 8 Aug 2014 07:33:17 +0000 (10:33 +0300)]
Stop running TB2 tests on Safari 5 and Opera 12
While still supported, these browsers are completely outdated and the
tests no longer give us meaningful information. When TestBench 2 tests
are converted to TB4, they will no longer be run on either of these browser.
To improve the situation in the future, TB4 tests should be run on
Safari 7 and latest Opera
Notification delay is not set to 0 when the notification is clicked (#14368)
Reintroduce the delay timer which triggers the hiding of the
notification. When the notification is clicked, no timer is used, the
notification is hidden immediately.
The selected color hex value is no longer overlapping with the color
square.
But now when there’s no hex value as the button caption, there’s extra
white space on the right edge of the button, which is unavoidable. This
is a lesser evil.
Correctly display an item which is too long for the textfield. (#13477)
As setSelectionRange is not working correctly in IE the current approach
sets the direction before setting the text and resets it to the original
immediately after that.
Change-Id: I33f40f9ae436122092d995fa17c35a9cbe38aedb
Artur Signell [Mon, 4 Aug 2014 11:12:59 +0000 (14:12 +0300)]
Do not call requestStart/end multiple times when using push (#14228)
All HTTP request based push request invoke onRequestStart/End in the servlet.
We need to trigger start/end separately in push handler only for websocket messages
Markus Koivisto [Mon, 4 Aug 2014 11:25:16 +0000 (14:25 +0300)]
Reverting multiple commits that caused 100+ regression tests to fail.
Commits reverted:
* 392e8a0 - Minor refactor to #14147 patch
* 8d470c9 - Context menu is not shown in Table body on mobi... (#13694)
* f7dc719 - Fix Table stuck scroll position after setting ... (#14147)
Henri Sara [Mon, 4 Aug 2014 05:23:01 +0000 (08:23 +0300)]
Increase TB3 socket timeout to 30 min (#14352)
This increases the timeout from 15 to 30 minutes to avoid
occasional timeouts at times of test cluster congestion.
The timeout was originally reduced for #14298.
Fix inconsistent rendering between Valo’s bundled Open Sans vs. Google
Fonts provided Open Sans versions on Windows (DirectWrite).
The previous bundled font was generated with Font Squirrel Webfont
Generator with some additional optimizations on (the “Fix GASP Table”
option most likely), which caused the inconsistencies. The new version
is converted with the basic options (most straightforward conversion).
Artur Signell [Wed, 30 Jul 2014 07:53:28 +0000 (07:53 +0000)]
Allow changing theme on the fly (#2874, #14139, #14124)
* Updates UI and overlay container class names when the theme changes
* Initially verifies that the theme has actually been loaded (for the embed case)
and class names have been properly set
* Forces a state change to all components to re-translate theme:// URLs
* Runs a full layout after the new theme has been loaded and activated
Artur Signell [Mon, 28 Jul 2014 11:52:26 +0000 (14:52 +0300)]
Disable automatic removal of trailing whitespace and reformatted using Luna
Automatic removal of trailing whitespaces in Eclipse does not work even
in a nearly consistent way across platforms, versions or even on the same
maching within the same workspaces. Saving the same file multiple times
even alternates between adding and removing a whitespace on empty block
comment lines when saving.
Markus Koivisto [Wed, 30 Jul 2014 14:28:41 +0000 (17:28 +0300)]
Fix typo that caused spanned cells to be removed in Gridlayout (#14335)
Gridlayout removes columns and rows with no content. Gridlayout is
supposed to check for spanned cells and not remove otherwise empty rows
or columns if they are covered by a span.
TextArea size get reset when css resize is set (#14080)
Listen to MouseUp event on the <textarea> and notify the state with the width and height if changed.
Add com.vaadin.client.Util.Size to manipulates the css width/height.
Bottom component click scroll up the parent panel in a window (#12943)
Due to old fix for (#11994) the v-scrollable div of the window would
expand to 110% of its size then immediately back to the original size.
The first action, expanding the v-scrollable to 110% would decrease
the scrollTop value of our panel, while increasing its height. When
the revert back action would set the v-scrollable to its own size,
the panel's scrollTop would remain decreased, causing the scroll bar
to move up, hiding the ~10% at the bottom.
Fixed by calling Util.runWebkitOverflowAutoFix(); instead of changing
the height.
With this patch, the theme-and-default-widgetset target finishes in 50
seconds, whereas it takes about 80 seconds without the patch. This
happens at the cost of peak memory usage rising from ~750mb to ~850mb.
Export fetchRootConfig status so it can be read by TK (#14053)
Offline apps need to know when server errors are 500 or 400 in
order to switch appropriatelly to the offline mode.
Also we need exported the fetchRootConfig method and a
reliable way to get loaded apps.
Related with change I29635982514071e63221a9771d6729da14273ad3 [1]
see temporal workaround in TouchKitServlet
[1] https://dev.vaadin.com/review/#/c/4037/
Fabian Lange [Fri, 11 Jul 2014 22:00:41 +0000 (00:00 +0200)]
Improves performance of VaadinService.requestEnd(). (#14218)
Doing two times session.accessSynchronously is unnecessary effort in
multiple aspects:
* The session will be locked twice.
* CurrentInstances are set twice.
* CurrentInstances are restored twice.
* VaadinSession being checked for being the current via
VaadinService.verifyNoOtherSessionLocked(this);
When we leave requestEnd we unset all CurrentInstances. There is no need
to just restore them before doing so.
When we are in requestEnd, VaadinSession is set to "current" by
PushHandler.callWithUi() or VaadinService.handleRequest().
Also, the cleanupSession code does not need any of these thread locals,
so not having them set would also not hurt.
having an extra accessSynchronously call for just setting the duration
does not make a lot of sense. While it somehow wants to make the previous
accessSynchronously call to be counted completely into the duration it
invests an the same time that would have been left out additionally.
VaadinService removeClosedUIs is a cleanup which also locks and sets
CurrentInstances just to figure out that the UI it is checking is not
closing. This change moves that check out of ui.accessSynchronously.
In the end, the resulting code is a tiny bit less robust, however it
eliminates over 50% response time on trivial push request/responses.