source.dussan.org Git - redmine.git/log

Go MAEDA [Wed, 24 Jan 2024 02:49:38 +0000 (02:49 +0000)]

Remove unnecessary use of instance variables in CSV and Atom response handlers (#32985).

Contributed by Ko Nagase (@sanak).

git-svn-id: https://svn.redmine.org/redmine/trunk@22622 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 24 Jan 2024 02:32:44 +0000 (02:32 +0000)]

Fix RuboCop offense Layout/EmptyLinesAroundModuleBody (#38975).

git-svn-id: https://svn.redmine.org/redmine/trunk@22621 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 24 Jan 2024 02:29:55 +0000 (02:29 +0000)]

Fix RuboCop offense Layout/EmptyLineAfterMagicComment (#38975).

git-svn-id: https://svn.redmine.org/redmine/trunk@22620 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 23 Jan 2024 11:52:38 +0000 (11:52 +0000)]

Use ApplicationRecord instead of ActiveRecord::Base (#38975).

Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 23 Jan 2024 01:23:29 +0000 (01:23 +0000)]

Use @image_url@ for @favicon_url@ (#40087).

Patch by Go Maeda (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22618 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 23 Jan 2024 01:17:25 +0000 (01:17 +0000)]

Reverts r22439 (#35189).

git-svn-id: https://svn.redmine.org/redmine/trunk@22617 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 23 Jan 2024 01:05:38 +0000 (01:05 +0000)]

Reverts r22438 (#35189).

git-svn-id: https://svn.redmine.org/redmine/trunk@22616 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Sun, 21 Jan 2024 03:58:09 +0000 (03:58 +0000)]

Remove backported Rack::RewindableInput.size method due to Rack 3.0 migration (#36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22615 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 18 Jan 2024 01:43:51 +0000 (01:43 +0000)]

Update RuboCop to 1.60 (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22614 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 18 Jan 2024 01:36:46 +0000 (01:36 +0000)]

Regenerate .rubocop_todo.yml (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22613 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 18 Jan 2024 01:31:55 +0000 (01:31 +0000)]

Fix RuboCop offense Style/ArgumentsForwarding (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22612 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 17 Jan 2024 03:00:03 +0000 (03:00 +0000)]

Update csv, net-imap, and net-smtp gems to the same versions shipped with Ruby 3.3.0 (#39761).

git-svn-id: https://svn.redmine.org/redmine/trunk@22611 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Wed, 17 Jan 2024 00:50:02 +0000 (00:50 +0000)]

Fix query columns selection in custom query form (#39806).

Patch by Mizuki ISHIKAWA.

git-svn-id: https://svn.redmine.org/redmine/trunk@22610 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 17 Jan 2024 00:19:03 +0000 (00:19 +0000)]

Add Ruby 3.3 to supported Ruby versions (#39761).

git-svn-id: https://svn.redmine.org/redmine/trunk@22609 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 16 Jan 2024 16:48:39 +0000 (16:48 +0000)]

Fix query columns selection in time tracking settings page from admin (#39806).

Patch by Mizuki ISHIKAWA.

git-svn-id: https://svn.redmine.org/redmine/trunk@22608 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 16 Jan 2024 16:47:17 +0000 (16:47 +0000)]

Indentation fixes (#39806).

Patch by Jens Krämer.

git-svn-id: https://svn.redmine.org/redmine/trunk@22607 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 16 Jan 2024 16:35:00 +0000 (16:35 +0000)]

Fix query columns selection in admin and my page (#39806).

Patch by Jens Krämer.

git-svn-id: https://svn.redmine.org/redmine/trunk@22606 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 11 Jan 2024 11:27:25 +0000 (11:27 +0000)]

Replace regular expression matches with String#start_with? / end_with? (#40010).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22605 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 11 Jan 2024 08:13:17 +0000 (08:13 +0000)]

Remove copyright headers from tribute.css file (#37730).

git-svn-id: https://svn.redmine.org/redmine/trunk@22604 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 11 Jan 2024 06:37:49 +0000 (06:37 +0000)]

Shorten copyright headers for JS files (#37730).

git-svn-id: https://svn.redmine.org/redmine/trunk@22603 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 11 Jan 2024 06:36:47 +0000 (06:36 +0000)]

Shorten copyright headers for JS toolbar files (#37730).

git-svn-id: https://svn.redmine.org/redmine/trunk@22602 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 11 Jan 2024 06:32:08 +0000 (06:32 +0000)]

Shorten copyright headers for css files (#37730).

git-svn-id: https://svn.redmine.org/redmine/trunk@22601 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 11 Jan 2024 06:22:37 +0000 (06:22 +0000)]

Remove wrong copyright headers from acts_as_tree plugin (#37730).

git-svn-id: https://svn.redmine.org/redmine/trunk@22600 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 11 Jan 2024 06:16:17 +0000 (06:16 +0000)]

Switch default backend of ActiveSupport::XmlMini from rexml to Nokogiri (#37258).

git-svn-id: https://svn.redmine.org/redmine/trunk@22599 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Mon, 8 Jan 2024 01:39:27 +0000 (01:39 +0000)]

Refactor file extension removal in Theme#assets to use File.basename instead of delete_suffix (#40008).

git-svn-id: https://svn.redmine.org/redmine/trunk@22598 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Mon, 8 Jan 2024 01:14:31 +0000 (01:14 +0000)]

Refactor CustomFieldsControllerTest#custom_field_classes (#40008).

git-svn-id: https://svn.redmine.org/redmine/trunk@22597 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Mon, 8 Jan 2024 01:04:37 +0000 (01:04 +0000)]

Replace String#sub with delete_prefix / delete_suffix (#40008).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22596 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 4 Jan 2024 09:57:35 +0000 (09:57 +0000)]

Japanese translation update (#40003).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22595 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 4 Jan 2024 07:04:00 +0000 (07:04 +0000)]

Support localized decimal separators for float values in PDF export (#22024).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22594 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 4 Jan 2024 07:01:09 +0000 (07:01 +0000)]

Support localized decimal separators for hours in the web UI (#21677).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22593 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 4 Jan 2024 06:55:14 +0000 (06:55 +0000)]

Support localized decimal separators for float values (#22024).

Patch by Liane Hampe (@liane_hampe).

git-svn-id: https://svn.redmine.org/redmine/trunk@22592 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 4 Jan 2024 02:10:13 +0000 (02:10 +0000)]

Fix RuboCop offense Style/TrailingCommaInArguments introduced in r22584 (#39999).

git-svn-id: https://svn.redmine.org/redmine/trunk@22591 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 4 Jan 2024 01:23:25 +0000 (01:23 +0000)]

Optimize Project#notified_users to improve issue create/update speed (#23328).

Patch by Holger Just (@hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@22590 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 3 Jan 2024 12:14:04 +0000 (12:14 +0000)]

Optimize gantt chart rendering for issues without subtasks (#40000).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22589 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Wed, 3 Jan 2024 01:19:25 +0000 (01:19 +0000)]

Explicitly render a 404 on non-JS requests to messages#quote (#39999).

Patch by Holger Just (@hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@22584 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Tue, 2 Jan 2024 00:41:00 +0000 (00:41 +0000)]

Fix "any" operator for text filters to exclude empty text values (#39991).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22583 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Mon, 1 Jan 2024 11:28:48 +0000 (11:28 +0000)]

Optimize loading of journals, relations, and allowed_statuses in IssuesController#show for API requests (#39993).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22582 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Sun, 31 Dec 2023 02:02:31 +0000 (02:02 +0000)]

Cache the result of `Journal#attachments` (#39847).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22581 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Sat, 30 Dec 2023 04:47:38 +0000 (04:47 +0000)]

Optimize repository menu visibility check (#39835).

Patch by Holger Just (@hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@22580 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Sat, 30 Dec 2023 04:29:11 +0000 (04:29 +0000)]

Update SQLite3 gem to 1.7 (#39985).

git-svn-id: https://svn.redmine.org/redmine/trunk@22579 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Sat, 30 Dec 2023 04:13:36 +0000 (04:13 +0000)]

Remove specific platform constraints for database adapter gems (#39971).

git-svn-id: https://svn.redmine.org/redmine/trunk@22578 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Fri, 29 Dec 2023 08:24:43 +0000 (08:24 +0000)]

Extend "contains" operator in "Parent task" filter to support multiple issue IDs (#39805).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22577 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Fri, 29 Dec 2023 08:05:25 +0000 (08:05 +0000)]

Update Nokogiri to 1.16.0 (#39972).

git-svn-id: https://svn.redmine.org/redmine/trunk@22576 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Fri, 29 Dec 2023 08:00:23 +0000 (08:00 +0000)]

Optimize query models by replacing `map` with `pluck` (#39837).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22575 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 28 Dec 2023 04:16:49 +0000 (04:16 +0000)]

Improves filter rendering on narrow screens by replacing the layout tables with a flex layout.
(#39806).

Patch by Jens Krämer (@jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@22574 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Thu, 28 Dec 2023 00:10:34 +0000 (00:10 +0000)]

Optimize `Issue#relations` method to improve performance by fetching both `relations_from` and `relations_to` using a single database query (#39840).

Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22572 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Wed, 27 Dec 2023 15:40:08 +0000 (15:40 +0000)]

Fixes exception in @acts_as_attachable@ when running on Ruby 2.7 (#39862).

Patch by @maeda.

git-svn-id: https://svn.redmine.org/redmine/trunk@22569 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 27 Dec 2023 09:31:20 +0000 (09:31 +0000)]

Optimize IssueCategory SQL queries when showing an issue (#39849).

Patch by Go MAEDA.

git-svn-id: https://svn.redmine.org/redmine/trunk@22568 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 27 Dec 2023 08:07:22 +0000 (08:07 +0000)]

Optimize users visibility check (#39857).

Patch by Pavel Rosický.

git-svn-id: https://svn.redmine.org/redmine/trunk@22567 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 27 Dec 2023 06:07:22 +0000 (06:07 +0000)]

Fix RuboCop offense Style/HashSyntax (Don't mix styles in the same hash) introduced in r22551 (#39862).

git-svn-id: https://svn.redmine.org/redmine/trunk@22566 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 27 Dec 2023 06:02:22 +0000 (06:02 +0000)]

Fix RuboCop offense Style/HashSyntax (Don't mix styles in the same hash) introduced in r22563 (#39747, #36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22565 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 27 Dec 2023 01:17:28 +0000 (01:17 +0000)]

Fix RuboCop offense Layout/EmptyLinesAroundClassBody introduced in r22562 (#39747, #36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22564 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 26 Dec 2023 15:47:43 +0000 (15:47 +0000)]

Fixes that diff of a javascript file in repository module is not displayed with layout in Rails 7.1
(#39747, #36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22563 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 26 Dec 2023 15:43:25 +0000 (15:43 +0000)]

Add system test for #39747.

git-svn-id: https://svn.redmine.org/redmine/trunk@22562 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Tue, 26 Dec 2023 08:57:48 +0000 (08:57 +0000)]

Incorrect position of "Edited" mark in issue notes with h4 headings (#39932).

Contributed by Y. Saku.

git-svn-id: https://svn.redmine.org/redmine/trunk@22561 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Tue, 26 Dec 2023 08:33:20 +0000 (08:33 +0000)]

Traditional Chinese translation update (#39941).

Patch by ChunChang (Nagaharu) Lo.

git-svn-id: https://svn.redmine.org/redmine/trunk@22560 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Mon, 25 Dec 2023 01:57:24 +0000 (01:57 +0000)]

Updates number of subversion filechanges in @test_fetch_changesets_from_scratch@ (#39747, #36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22557 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Sun, 24 Dec 2023 16:44:56 +0000 (16:44 +0000)]

Updates number of subversion revisions in @test/unit/repository_subversion_test.rb@ (#39747, #36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22556 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Sun, 24 Dec 2023 16:39:17 +0000 (16:39 +0000)]

Updates subversion repository fixture with test data for #39747 (#39747, #36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22555 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Fri, 22 Dec 2023 02:08:53 +0000 (02:08 +0000)]

Fixes attachments functionality for (custom) plugins broken since fix for CVE-2022-44030 by adding a dynamic routing constraint which can be modified by plugins (#39862).

Patch by @jkraemer.

git-svn-id: https://svn.redmine.org/redmine/trunk@22551 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Fri, 22 Dec 2023 02:03:18 +0000 (02:03 +0000)]

Update locales (#39879).

git-svn-id: https://svn.redmine.org/redmine/trunk@22550 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Fri, 22 Dec 2023 01:58:28 +0000 (01:58 +0000)]

Fix hardcoded string "auto" on user preferences page (#39879).

Patch by @salmanmp.

git-svn-id: https://svn.redmine.org/redmine/trunk@22549 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Fri, 22 Dec 2023 01:44:02 +0000 (01:44 +0000)]

Allow consecutive footnote references inTextile (#39884).

Patch by @hjust.

git-svn-id: https://svn.redmine.org/redmine/trunk@22546 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Fri, 22 Dec 2023 00:33:13 +0000 (00:33 +0000)]

Fix improper error highlighting for description field in issue form (#39795).

Patch by Mizuki ISHIKAWA.

git-svn-id: https://svn.redmine.org/redmine/trunk@22545 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Fri, 22 Dec 2023 00:13:08 +0000 (00:13 +0000)]

Fix typo in Russian translation of text_status_no_workflow (#39801).

Patch by Evangeline Rome.

git-svn-id: https://svn.redmine.org/redmine/trunk@22544 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Fri, 22 Dec 2023 00:06:29 +0000 (00:06 +0000)]

Extends mysql8? test helper to handle more complex version strings (#39865).

Patch by Jens Krämer.

git-svn-id: https://svn.redmine.org/redmine/trunk@22542 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 21 Dec 2023 06:54:28 +0000 (06:54 +0000)]

Add test for #39894.

git-svn-id: https://svn.redmine.org/redmine/trunk@22539 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 21 Dec 2023 06:47:32 +0000 (06:47 +0000)]

Explicitly render a 404 on non-JS requests to @watchers#new@ (#39894).

Patch by @hjust.

git-svn-id: https://svn.redmine.org/redmine/trunk@22538 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 09:41:28 +0000 (09:41 +0000)]

Update RuboCop Rails to 2.23 (#39889).

git-svn-id: https://svn.redmine.org/redmine/trunk@22537 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 09:28:20 +0000 (09:28 +0000)]

Update RuboCop Performance to 1.20 (#39888).

git-svn-id: https://svn.redmine.org/redmine/trunk@22536 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 09:23:05 +0000 (09:23 +0000)]

Fix RuboCop offense Performance/StringIdentifierArgument (#39888).

git-svn-id: https://svn.redmine.org/redmine/trunk@22535 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 08:29:38 +0000 (08:29 +0000)]

Update RuboCop to 1.59 (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22534 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 08:22:54 +0000 (08:22 +0000)]

Regenerate .rubocop_todo.yml (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22533 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 08:13:48 +0000 (08:13 +0000)]

Fix RuboCop offense Style/HashEachMethods (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22532 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 07:16:35 +0000 (07:16 +0000)]

Fix RuboCop offense Lint/SymbolConversion (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22531 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 07:15:11 +0000 (07:15 +0000)]

Fix RuboCop offense Style/SuperWithArgsParentheses (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22530 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Wed, 20 Dec 2023 07:12:49 +0000 (07:12 +0000)]

Disable RuboCop Style/RedundantParentheses (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22529 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Wed, 20 Dec 2023 04:35:51 +0000 (04:35 +0000)]

Update Rails UJS to 7.1.2 (#36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22526 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Wed, 20 Dec 2023 03:30:04 +0000 (03:30 +0000)]

Run plugin tests only if test files exist (#39803, #36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22525 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Wed, 20 Dec 2023 03:19:10 +0000 (03:19 +0000)]

Fixes that @redmine:plugins:test@ should run plugins unit, functional, integration and system tests in one single test session instead of one session for each type of test. This behaviour was changed in Rails 7.1 because @rake test@ and @rails test@ are integrated (#39803, #36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22524 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Tue, 19 Dec 2023 09:43:27 +0000 (09:43 +0000)]

Fix RuboCop offense Layout/EmptyLineAfterMagicComment (#36320, #39834).

git-svn-id: https://svn.redmine.org/redmine/trunk@22523 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Sun, 17 Dec 2023 15:05:47 +0000 (15:05 +0000)]

Adds test for plugin autoload issue (#36320, #39834).

Patch by @tohosaku.

git-svn-id: https://svn.redmine.org/redmine/trunk@22522 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 14 Dec 2023 07:13:03 +0000 (07:13 +0000)]

Fixes random failing test by using @async_count@ in order to avoid query caching (#36320).

Patch by @maeda-m.

git-svn-id: https://svn.redmine.org/redmine/trunk@22520 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Thu, 14 Dec 2023 07:10:46 +0000 (07:10 +0000)]

Revert r22514 (#36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22519 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 12 Dec 2023 17:56:00 +0000 (17:56 +0000)]

Replaces @config.cache_classes@ which the new option @config.enable_reloading@ introduced in Rails 7.1 (#36320)

git-svn-id: https://svn.redmine.org/redmine/trunk@22518 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 12 Dec 2023 16:52:46 +0000 (16:52 +0000)]

Fix NoMethodError: undefined method `rake_run' for Rails::TestUnit::Runner:Class (NoMethodError) after updating to Rails 7.1 (#36320, #39803)

Patch by @tohosaku.

git-svn-id: https://svn.redmine.org/redmine/trunk@22517 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 12 Dec 2023 16:45:43 +0000 (16:45 +0000)]

Update integration test for plugin routes after r22515 (#36320, #39803).

git-svn-id: https://svn.redmine.org/redmine/trunk@22516 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Tue, 12 Dec 2023 16:26:34 +0000 (16:26 +0000)]

Reverts r22507, r22508 and r22510 (#36320, #39803).

git-svn-id: https://svn.redmine.org/redmine/trunk@22515 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Mon, 11 Dec 2023 10:57:40 +0000 (10:57 +0000)]

Block @rack-session@ gem version to 1 in order to stick with Rack 2 (#36320).

Patch by @maeda-m.

git-svn-id: https://svn.redmine.org/redmine/trunk@22514 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Mon, 11 Dec 2023 10:56:02 +0000 (10:56 +0000)]

Refactor integration test for plugins routing (added in r22328) in order to use the new plugins directory path for test environment (#36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22513 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Mon, 11 Dec 2023 09:20:06 +0000 (09:20 +0000)]

Change the default notification option from `only_my_events` to `only_assigned` (#39500).

Patch by Go MAEDA.

git-svn-id: https://svn.redmine.org/redmine/trunk@22512 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Mon, 11 Dec 2023 09:14:47 +0000 (09:14 +0000)]

Revert r22504 that missing a necessary file (#39500).

git-svn-id: https://svn.redmine.org/redmine/trunk@22511 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Mon, 11 Dec 2023 07:49:47 +0000 (07:49 +0000)]

Remove unnecessary line that changes the @PluginLoader@ directory inside @plugins_test.rb@ (#36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22510 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Sun, 10 Dec 2023 04:01:40 +0000 (04:01 +0000)]

Fix failing API tests on Ruby 2.7 after migration to Rails 7.1 (#36320, #39760).

Patch by @maeda-m.

git-svn-id: https://svn.redmine.org/redmine/trunk@22509 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Sun, 10 Dec 2023 03:41:09 +0000 (03:41 +0000)]

Adds test for plugin autoloading plugins issue (#36320).

Patch by @tohosaku.

git-svn-id: https://svn.redmine.org/redmine/trunk@22508 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Sun, 10 Dec 2023 03:34:16 +0000 (03:34 +0000)]

Allows configure plugins directory path in order to change the default location in test environment (#36320).

Patch by @tohosaku.

git-svn-id: https://svn.redmine.org/redmine/trunk@22507 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Sun, 10 Dec 2023 03:24:34 +0000 (03:24 +0000)]

Fix typo (#36320).

git-svn-id: https://svn.redmine.org/redmine/trunk@22506 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Marius Balteanu [Sun, 10 Dec 2023 03:10:39 +0000 (03:10 +0000)]

Fix autoloading of plugins fails in Rails 7.1.2 (#36320).

Patch by Mizuki ISHIKAWA.

git-svn-id: https://svn.redmine.org/redmine/trunk@22505 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Fri, 8 Dec 2023 08:29:17 +0000 (08:29 +0000)]

Change the default notification option from `only_my_events` to `only_assigned` (#39500).

Patch by Go MAEDA.

git-svn-id: https://svn.redmine.org/redmine/trunk@22504 e93f8b46-1217-0410-a6f0-8f06a7374b81

commit | commitdiff | tree

Go MAEDA [Fri, 8 Dec 2023 08:17:05 +0000 (08:17 +0000)]

Code cleanup: unnecessary use of instance variables in UserTest (#39500).

git-svn-id: https://svn.redmine.org/redmine/trunk@22503 e93f8b46-1217-0410-a6f0-8f06a7374b81