]> source.dussan.org Git - nextcloud-server.git/log
nextcloud-server.git
3 years agoUpdated CRL 25661/head
Roeland Jago Douma [Mon, 15 Feb 2021 19:32:48 +0000 (20:32 +0100)]
Updated CRL

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25657 from nextcloud/overwriteprotocol-codespace
Roeland Jago Douma [Mon, 15 Feb 2021 18:45:57 +0000 (19:45 +0100)]
Merge pull request #25657 from nextcloud/overwriteprotocol-codespace

Set overwriteprotocol to HTTPS in Codespace

3 years agoMerge pull request #25653 from nextcloud/fix/psalm/offlineuser
kesselb [Mon, 15 Feb 2021 16:04:16 +0000 (17:04 +0100)]
Merge pull request #25653 from nextcloud/fix/psalm/offlineuser

Some psalm OfflineUser fixes

3 years agoSet overwriteprotocol to HTTPS in Codespace 25657/head
Lukas Reschke [Mon, 15 Feb 2021 15:48:39 +0000 (16:48 +0100)]
Set overwriteprotocol to HTTPS in Codespace

Codespace is serving everything only as HTTPS. To keep the URLs valid, we also need to overwrite the protocol. (otherwise e.g. you can't develop the SAML app as the URLs are invalid)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
3 years agoMerge pull request #25595 from nextcloud/enh/caldavbackend/getChangesForCalendar_quer...
Roeland Jago Douma [Mon, 15 Feb 2021 15:39:46 +0000 (16:39 +0100)]
Merge pull request #25595 from nextcloud/enh/caldavbackend/getChangesForCalendar_querybuilder

Move getChangesForCalendar to QueryBuilder

3 years agoMerge pull request #25623 from nextcloud/dependabot/npm_and_yarn/eslint-plugin-promis...
Roeland Jago Douma [Mon, 15 Feb 2021 15:38:46 +0000 (16:38 +0100)]
Merge pull request #25623 from nextcloud/dependabot/npm_and_yarn/eslint-plugin-promise-4.3.1

Bump eslint-plugin-promise from 4.2.1 to 4.3.1

3 years agoSome psalm OfflineUser fixes 25653/head
Roeland Jago Douma [Mon, 15 Feb 2021 12:36:02 +0000 (13:36 +0100)]
Some psalm OfflineUser fixes

For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25594 from wankdanker/files_sharing_owner_display_name
Roeland Jago Douma [Mon, 15 Feb 2021 12:17:25 +0000 (13:17 +0100)]
Merge pull request #25594 from wankdanker/files_sharing_owner_display_name

Use ownerDisplayName for SharingEntry Tooltip

3 years agoMerge pull request #25578 from nextcloud/enh/simplify_weatherservice
Christoph Wurst [Mon, 15 Feb 2021 11:27:03 +0000 (12:27 +0100)]
Merge pull request #25578 from nextcloud/enh/simplify_weatherservice

Always use the cache

3 years agoMerge pull request #25575 from k00ni/pr/add-tests-for-LoginFlowV2Service
Christoph Wurst [Mon, 15 Feb 2021 11:22:39 +0000 (12:22 +0100)]
Merge pull request #25575 from k00ni/pr/add-tests-for-LoginFlowV2Service

Add tests for \OC\Core\Service\LoginFlowV2Service

3 years agoMerge pull request #25625 from nextcloud/enh/psalm/substr
Christoph Wurst [Mon, 15 Feb 2021 11:17:57 +0000 (12:17 +0100)]
Merge pull request #25625 from nextcloud/enh/psalm/substr

Check substr results

3 years agoMove getChangesForCalendar to QueryBuilder 25595/head
Roeland Jago Douma [Thu, 11 Feb 2021 20:42:23 +0000 (21:42 +0100)]
Move getChangesForCalendar to QueryBuilder

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25636 from nextcloud/fix/psalm/closure_return_types
Christoph Wurst [Mon, 15 Feb 2021 11:07:24 +0000 (12:07 +0100)]
Merge pull request #25636 from nextcloud/fix/psalm/closure_return_types

Add some closure return types

3 years agoMerge pull request #25646 from nextcloud/fix/psalm/markdown
Christoph Wurst [Mon, 15 Feb 2021 11:04:21 +0000 (12:04 +0100)]
Merge pull request #25646 from nextcloud/fix/psalm/markdown

Markdown: remove redundant int cast

3 years agoMerge pull request #25645 from nextcloud/enh/pslam/ocs_result
Christoph Wurst [Mon, 15 Feb 2021 10:42:00 +0000 (11:42 +0100)]
Merge pull request #25645 from nextcloud/enh/pslam/ocs_result

Some OCS result psalm fixes

3 years agoMerge pull request #25644 from nextcloud/fix/psalm/settings
Christoph Wurst [Mon, 15 Feb 2021 10:40:40 +0000 (11:40 +0100)]
Merge pull request #25644 from nextcloud/fix/psalm/settings

Some psalm fixes in the settings app

3 years agoMarkdown: remove redundant int cast 25646/head
Roeland Jago Douma [Mon, 15 Feb 2021 09:29:54 +0000 (10:29 +0100)]
Markdown: remove redundant int cast

For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoCheck substr results 25625/head
Roeland Jago Douma [Sat, 13 Feb 2021 14:27:11 +0000 (15:27 +0100)]
Check substr results

Else this might lead to unexpeted errors.
Found by psalm.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoSome OCS result psalm fixes 25645/head
Roeland Jago Douma [Mon, 15 Feb 2021 09:03:48 +0000 (10:03 +0100)]
Some OCS result psalm fixes

For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoSome psalm fixes in the settings app 25644/head
Roeland Jago Douma [Mon, 15 Feb 2021 09:00:35 +0000 (10:00 +0100)]
Some psalm fixes in the settings app

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25580 from nextcloud/enh/fix/psalm_pluginmanager
Roeland Jago Douma [Mon, 15 Feb 2021 08:11:16 +0000 (09:11 +0100)]
Merge pull request #25580 from nextcloud/enh/fix/psalm_pluginmanager

Enhancing the dav pluginmanager

3 years agoMerge pull request #25642 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
Roeland Jago Douma [Mon, 15 Feb 2021 07:59:36 +0000 (08:59 +0100)]
Merge pull request #25642 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

3 years agoUpdate psalm baseline 25642/head
Nextcloud-PR-Bot [Mon, 15 Feb 2021 04:31:27 +0000 (04:31 +0000)]
Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>
3 years ago[tx-robot] updated from transifex
Nextcloud bot [Mon, 15 Feb 2021 02:20:11 +0000 (02:20 +0000)]
[tx-robot] updated from transifex

3 years agoMerge pull request #25635 from nextcloud/fix/psalm/ProperNameSpace
kesselb [Sun, 14 Feb 2021 18:47:21 +0000 (19:47 +0100)]
Merge pull request #25635 from nextcloud/fix/psalm/ProperNameSpace

Use correct namespace (casing) in CalendarHome

3 years agoFix PluginManager annotation 25580/head
Roeland Jago Douma [Thu, 11 Feb 2021 11:37:21 +0000 (12:37 +0100)]
Fix PluginManager annotation

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoAdd some closure return types 25636/head
Roeland Jago Douma [Sun, 14 Feb 2021 11:43:31 +0000 (12:43 +0100)]
Add some closure return types

Found by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoUse correct namespace (casing) in CalendarHome 25635/head
Roeland Jago Douma [Sun, 14 Feb 2021 11:36:41 +0000 (12:36 +0100)]
Use correct namespace (casing) in CalendarHome

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25634 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
Roeland Jago Douma [Sun, 14 Feb 2021 08:55:49 +0000 (09:55 +0100)]
Merge pull request #25634 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

3 years agoUpdate psalm baseline 25634/head
Nextcloud-PR-Bot [Sun, 14 Feb 2021 04:31:01 +0000 (04:31 +0000)]
Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>
3 years ago[tx-robot] updated from transifex
Nextcloud bot [Sun, 14 Feb 2021 02:20:02 +0000 (02:20 +0000)]
[tx-robot] updated from transifex

3 years agoMerge pull request #25628 from nextcloud/revert-25608-trusted-proxy-check-correct...
Roeland Jago Douma [Sat, 13 Feb 2021 17:03:49 +0000 (18:03 +0100)]
Merge pull request #25628 from nextcloud/revert-25608-trusted-proxy-check-correct-header

Revert "use the configured forwarded headers for the setup check"

3 years agoRevert "use the configured forwarded headers for the setup check" 25628/head
Roeland Jago Douma [Sat, 13 Feb 2021 17:03:32 +0000 (18:03 +0100)]
Revert "use the configured forwarded headers for the setup check"

3 years agoMerge pull request #25577 from nextcloud/enhancement/app-code-checker-noop
Roeland Jago Douma [Sat, 13 Feb 2021 14:51:41 +0000 (15:51 +0100)]
Merge pull request #25577 from nextcloud/enhancement/app-code-checker-noop

Make the app code checker a NOOP

3 years agoMerge pull request #25619 from nextcloud/dependabot/npm_and_yarn/moment-timezone...
dependabot-preview[bot] [Sat, 13 Feb 2021 14:18:56 +0000 (14:18 +0000)]
Merge pull request #25619 from nextcloud/dependabot/npm_and_yarn/moment-timezone-0.5.33

3 years agoMerge pull request #25604 from nextcloud/bugfix/noid/fix-hover-background-for-dark...
Roeland Jago Douma [Sat, 13 Feb 2021 14:01:57 +0000 (15:01 +0100)]
Merge pull request #25604 from nextcloud/bugfix/noid/fix-hover-background-for-dark-mode

Fix hover background for dark mode

3 years agoMerge pull request #25608 from nextcloud/trusted-proxy-check-correct-header
Roeland Jago Douma [Sat, 13 Feb 2021 13:58:26 +0000 (14:58 +0100)]
Merge pull request #25608 from nextcloud/trusted-proxy-check-correct-header

use the configured forwarded headers for the setup check

3 years agoMerge pull request #25612 from nextcloud/bugfix/noid/make-new-result-parts-optional
Roeland Jago Douma [Sat, 13 Feb 2021 13:55:55 +0000 (14:55 +0100)]
Merge pull request #25612 from nextcloud/bugfix/noid/make-new-result-parts-optional

Make new result parts optional

3 years agoBump moment-timezone from 0.5.32 to 0.5.33 25619/head
dependabot-preview[bot] [Sat, 13 Feb 2021 02:17:14 +0000 (02:17 +0000)]
Bump moment-timezone from 0.5.32 to 0.5.33

Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.32 to 0.5.33.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](https://github.com/moment/moment-timezone/compare/0.5.32...0.5.33)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
3 years agoMerge pull request #25620 from nextcloud/dependabot/npm_and_yarn/babel-loader-exclude...
dependabot-preview[bot] [Sat, 13 Feb 2021 13:24:04 +0000 (13:24 +0000)]
Merge pull request #25620 from nextcloud/dependabot/npm_and_yarn/babel-loader-exclude-node-modules-except-1.1.2

3 years agoMerge pull request #25622 from nextcloud/dependabot/npm_and_yarn/babel/preset-env...
dependabot-preview[bot] [Sat, 13 Feb 2021 05:55:26 +0000 (05:55 +0000)]
Merge pull request #25622 from nextcloud/dependabot/npm_and_yarn/babel/preset-env-7.12.16

3 years agoBump @babel/preset-env from 7.12.13 to 7.12.16 25622/head
dependabot-preview[bot] [Sat, 13 Feb 2021 03:33:05 +0000 (03:33 +0000)]
Bump @babel/preset-env from 7.12.13 to 7.12.16

Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.13 to 7.12.16.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.16/packages/babel-preset-env)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
3 years agoMerge pull request #25621 from nextcloud/dependabot/npm_and_yarn/babel/core-7.12.16
dependabot-preview[bot] [Sat, 13 Feb 2021 03:30:25 +0000 (03:30 +0000)]
Merge pull request #25621 from nextcloud/dependabot/npm_and_yarn/babel/core-7.12.16

3 years agoBump eslint-plugin-promise from 4.2.1 to 4.3.1 25623/head
dependabot-preview[bot] [Sat, 13 Feb 2021 02:21:36 +0000 (02:21 +0000)]
Bump eslint-plugin-promise from 4.2.1 to 4.3.1

Bumps [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from 4.2.1 to 4.3.1.
- [Release notes](https://github.com/xjamundx/eslint-plugin-promise/releases)
- [Changelog](https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md)
- [Commits](https://github.com/xjamundx/eslint-plugin-promise/compare/v4.2.1...v4.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
3 years ago[tx-robot] updated from transifex
Nextcloud bot [Sat, 13 Feb 2021 02:20:27 +0000 (02:20 +0000)]
[tx-robot] updated from transifex

3 years agoBump @babel/core from 7.12.13 to 7.12.16 25621/head
dependabot-preview[bot] [Sat, 13 Feb 2021 02:18:45 +0000 (02:18 +0000)]
Bump @babel/core from 7.12.13 to 7.12.16

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.13 to 7.12.16.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.16/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
3 years agoBump babel-loader-exclude-node-modules-except from 1.0.3 to 1.1.2 25620/head
dependabot-preview[bot] [Sat, 13 Feb 2021 02:17:55 +0000 (02:17 +0000)]
Bump babel-loader-exclude-node-modules-except from 1.0.3 to 1.1.2

Bumps [babel-loader-exclude-node-modules-except](https://github.com/dutchenkoOleg/babel-loader-exclude-node-modules-except) from 1.0.3 to 1.1.2.
- [Release notes](https://github.com/dutchenkoOleg/babel-loader-exclude-node-modules-except/releases)
- [Commits](https://github.com/dutchenkoOleg/babel-loader-exclude-node-modules-except/compare/1.0.3...1.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
3 years agoMerge pull request #25563 from nextcloud/direct-download-event
Christoph Wurst [Fri, 12 Feb 2021 18:02:51 +0000 (19:02 +0100)]
Merge pull request #25563 from nextcloud/direct-download-event

add event for when a direct download is triggered

3 years agoadd event for when a direct download is triggered 25563/head
Robin Appelman [Wed, 10 Feb 2021 12:53:05 +0000 (13:53 +0100)]
add event for when a direct download is triggered

Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years agoMake new result parts optional 25612/head
Joas Schilling [Fri, 12 Feb 2021 15:21:47 +0000 (16:21 +0100)]
Make new result parts optional

Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years agouse the configured forwarded headers for the setup check 25608/head
Robin Appelman [Fri, 12 Feb 2021 13:22:27 +0000 (14:22 +0100)]
use the configured forwarded headers for the setup check

instead of always checking against the same header

Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years agoFix hover background for dark mode 25604/head
Joas Schilling [Fri, 12 Feb 2021 12:18:39 +0000 (13:18 +0100)]
Fix hover background for dark mode

Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years agorefined name of getOpenSSLEncryptedAndPrivateKey 25575/head
Konrad Abicht [Fri, 12 Feb 2021 12:01:37 +0000 (13:01 +0100)]
refined name of getOpenSSLEncryptedAndPrivateKey

Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years agoadded unit tests for LoginFlowV2Service::createTokens
Konrad Abicht [Thu, 11 Feb 2021 09:58:44 +0000 (10:58 +0100)]
added unit tests for LoginFlowV2Service::createTokens

Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years agoUse ownerDisplayName for SharingEntry Tooltip 25594/head
Dan VerWeire [Thu, 11 Feb 2021 20:36:33 +0000 (15:36 -0500)]
Use ownerDisplayName for SharingEntry Tooltip

Some NC installations may use a LDAP UUID for the username. If that
is the case, then the tooltip for who a file/folder was shared by may say something
like `Shared with Steve McQueen (smqueen@yada.com) by FKDJ39-38D794JG-4398GJODF9H3G-4534`.

This commit changes the value showed for the owner to the full display name.

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
3 years ago[tx-robot] updated from transifex
Nextcloud bot [Fri, 12 Feb 2021 02:20:18 +0000 (02:20 +0000)]
[tx-robot] updated from transifex

3 years agoMerge pull request #25582 from nextcloud/fix/no-imip-for-invalid-recpient
Roeland Jago Douma [Thu, 11 Feb 2021 18:57:58 +0000 (19:57 +0100)]
Merge pull request #25582 from nextcloud/fix/no-imip-for-invalid-recpient

Do not send imip email to invalid recipients

3 years agoMerge pull request #25585 from nextcloud/enhancement/empty-email-validation
Roeland Jago Douma [Thu, 11 Feb 2021 18:51:06 +0000 (19:51 +0100)]
Merge pull request #25585 from nextcloud/enhancement/empty-email-validation

Micro-optimize validation of empty email addresses

3 years agoMerge pull request #25576 from nextcloud/fix/webp_check 25590/head
Christoph Wurst [Thu, 11 Feb 2021 14:58:14 +0000 (15:58 +0100)]
Merge pull request #25576 from nextcloud/fix/webp_check

Fix WebP availability check

3 years agoMicro-optimize validation of empty email addresses 25585/head
Christoph Wurst [Thu, 11 Feb 2021 14:15:38 +0000 (15:15 +0100)]
Micro-optimize validation of empty email addresses

Then we don't have to construct any validators.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years agoDo not send imip email to invalid recipients 25582/head
Christoph Wurst [Thu, 11 Feb 2021 12:27:02 +0000 (13:27 +0100)]
Do not send imip email to invalid recipients

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years agoMerge pull request #25299 from elsiehupp/favicon-touch-corners
Jan C. Borchardt [Thu, 11 Feb 2021 11:28:02 +0000 (12:28 +0100)]
Merge pull request #25299 from elsiehupp/favicon-touch-corners

favicon-touch image corners

3 years agoAlways use the cache 25578/head
Roeland Jago Douma [Thu, 11 Feb 2021 10:48:52 +0000 (11:48 +0100)]
Always use the cache

If there is no cache available we will use the null cache. Which (you
guessed it) just doesn't do anything. This makes the code flow a bit
nicer and psalm a bit happier.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMake the app code checker a NOOP 25577/head
Christoph Wurst [Thu, 11 Feb 2021 10:32:01 +0000 (11:32 +0100)]
Make the app code checker a NOOP

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years agoFix WebP availability check 25576/head
Roeland Jago Douma [Thu, 11 Feb 2021 10:31:38 +0000 (11:31 +0100)]
Fix WebP availability check

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoadded unit tests for LoginFlowV2Service::flowDone
Konrad Abicht [Thu, 11 Feb 2021 09:45:47 +0000 (10:45 +0100)]
added unit tests for LoginFlowV2Service::flowDone

Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years agoMerge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
Roeland Jago Douma [Thu, 11 Feb 2021 09:33:15 +0000 (10:33 +0100)]
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements

Improve mention matches

3 years agoadded unit tests for LoginFlowV2Service::startLoginFlow
Konrad Abicht [Thu, 11 Feb 2021 08:56:09 +0000 (09:56 +0100)]
added unit tests for LoginFlowV2Service::startLoginFlow

Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years agoadded unit tests for LoginFlowV2Service::getByLoginToken
Konrad Abicht [Thu, 11 Feb 2021 08:49:39 +0000 (09:49 +0100)]
added unit tests for LoginFlowV2Service::getByLoginToken

Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years agoadded unit tests for LoginFlowV2Service::poll
Konrad Abicht [Thu, 11 Feb 2021 08:38:29 +0000 (09:38 +0100)]
added unit tests for LoginFlowV2Service::poll

Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago[tx-robot] updated from transifex
Nextcloud bot [Thu, 11 Feb 2021 02:20:37 +0000 (02:20 +0000)]
[tx-robot] updated from transifex

3 years agoMerge pull request #25570 from nextcloud/enh/dashboard/psalm_fixes
Christoph Wurst [Wed, 10 Feb 2021 20:37:18 +0000 (21:37 +0100)]
Merge pull request #25570 from nextcloud/enh/dashboard/psalm_fixes

Some psalm fixes for the DashboardController

3 years agoMerge pull request #25460 from nextcloud/fix/apppassword/always_renew
Roeland Jago Douma [Wed, 10 Feb 2021 20:09:20 +0000 (21:09 +0100)]
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew

Always renew apppasswords on login

3 years agoSome psalm fixes for the DashboardController 25570/head
Roeland Jago Douma [Wed, 10 Feb 2021 19:00:04 +0000 (20:00 +0100)]
Some psalm fixes for the DashboardController

* Use the AppFramework IInitialState
* Set return type

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #24904 from nextcloud/enh/github-psalm
Roeland Jago Douma [Wed, 10 Feb 2021 18:03:55 +0000 (19:03 +0100)]
Merge pull request #24904 from nextcloud/enh/github-psalm

Have psalm analysis directly on github

3 years agoAlways renew apppasswords on login 25460/head
Roeland Jago Douma [Wed, 3 Feb 2021 10:13:25 +0000 (11:13 +0100)]
Always renew apppasswords on login

Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25558 from nextcloud/deprecate/generic-event-wrapper
Roeland Jago Douma [Wed, 10 Feb 2021 17:57:07 +0000 (18:57 +0100)]
Merge pull request #25558 from nextcloud/deprecate/generic-event-wrapper

Deprecate the GenericEvent wrapper

3 years agoMerge pull request #25566 from nextcloud/fix/25359/followup
Roeland Jago Douma [Wed, 10 Feb 2021 17:02:24 +0000 (18:02 +0100)]
Merge pull request #25566 from nextcloud/fix/25359/followup

Fix remaining #25359

3 years agoMerge pull request #25560 from nextcloud/enhancement/pure-psr-event
Christoph Wurst [Wed, 10 Feb 2021 15:13:06 +0000 (16:13 +0100)]
Merge pull request #25560 from nextcloud/enhancement/pure-psr-event

Make our event base class independent of Symfony and follow PSR

3 years agoFix remaining #25359 25566/head
Roeland Jago Douma [Wed, 10 Feb 2021 14:41:25 +0000 (15:41 +0100)]
Fix remaining #25359

As a wise man once said:

"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25359 from nextcloud/enhancement/typed-service-registration
Christoph Wurst [Wed, 10 Feb 2021 14:31:42 +0000 (15:31 +0100)]
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration

Type the service registration

3 years agoMerge pull request #25435 from nextcloud/fix/favorite-icon
Roeland Jago Douma [Wed, 10 Feb 2021 14:19:04 +0000 (15:19 +0100)]
Merge pull request #25435 from nextcloud/fix/favorite-icon

Fix favorite dark icon

3 years agoMake our event base class independent of Symfony and follow PSR 25560/head
Christoph Wurst [Wed, 10 Feb 2021 08:13:02 +0000 (09:13 +0100)]
Make our event base class independent of Symfony and follow PSR

Symfony is migrating towards a pure PSR event dispatcher, hence their
event class is POPO that implements the PSR stoppable event interface.
Since we can do that ourself and this change doesn't come with any API
changes (breakage), it's easy for us to become independent of Symfony
but also stay PSR-compliant at the same step.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years agoMerge pull request #25557 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
Roeland Jago Douma [Wed, 10 Feb 2021 14:15:04 +0000 (15:15 +0100)]
Merge pull request #25557 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

3 years agoHave psalm analysis directly on github 24904/head
Roeland Jago Douma [Wed, 30 Dec 2020 10:17:18 +0000 (11:17 +0100)]
Have psalm analysis directly on github

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25554 from nextcloud/fix/pslam/tainted_cookie
Lukas Reschke [Wed, 10 Feb 2021 11:20:49 +0000 (12:20 +0100)]
Merge pull request #25554 from nextcloud/fix/pslam/tainted_cookie

tain-escape the cookie input

3 years agoType the service registration 25359/head
Christoph Wurst [Thu, 28 Jan 2021 13:08:38 +0000 (14:08 +0100)]
Type the service registration

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years agoDeprecate the GenericEvent wrapper 25558/head
Christoph Wurst [Wed, 10 Feb 2021 07:54:08 +0000 (08:54 +0100)]
Deprecate the GenericEvent wrapper

This class is a convenience type to replace the old Symfony GenericEvent
with our own type, to ease the transition from Symfony events to our
(PSR) events. Hence we can deprecate the class as precaution to smoothen
the next transition step in the future.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years agoUpdate psalm baseline 25557/head
Nextcloud-PR-Bot [Wed, 10 Feb 2021 04:31:13 +0000 (04:31 +0000)]
Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>
3 years ago[tx-robot] updated from transifex
Nextcloud bot [Wed, 10 Feb 2021 02:20:59 +0000 (02:20 +0000)]
[tx-robot] updated from transifex

3 years agotain-escape the cookie input 25554/head
Roeland Jago Douma [Tue, 9 Feb 2021 21:35:18 +0000 (22:35 +0100)]
tain-escape the cookie input

we only set the cookie if it is a proper <=32 char alphanum string.
Otherwise we just ignore the input.
Makes psalm also happier so that we can focus on other errors.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years agoMerge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials
Christoph Wurst [Tue, 9 Feb 2021 20:37:37 +0000 (21:37 +0100)]
Merge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials

Added tests for OC\Core\Data\LoginFlowV2Credentials

3 years agoMerge pull request #25545 from k00ni/fix/Dockerfile-wrong-package-name-php7.4-acpu
Lukas Reschke [Tue, 9 Feb 2021 20:26:30 +0000 (21:26 +0100)]
Merge pull request #25545 from k00ni/fix/Dockerfile-wrong-package-name-php7.4-acpu

Corrected package name used in .devcontainer/Dockerfile (php7.4-acpu => php7.4-apcu)

3 years agoMerge pull request #25546 from nextcloud/techdept/deprecate-event-constants
Christoph Wurst [Tue, 9 Feb 2021 19:19:04 +0000 (20:19 +0100)]
Merge pull request #25546 from nextcloud/techdept/deprecate-event-constants

Deprecate all remaining event constants

3 years agoMerge pull request #25543 from nextcloud/deprecate/idb-events
Christoph Wurst [Tue, 9 Feb 2021 17:50:55 +0000 (18:50 +0100)]
Merge pull request #25543 from nextcloud/deprecate/idb-events

Deprecate the internal IDBConnection event name constants

3 years agoMerge pull request #25549 from nextcloud/remove-reconnect-wrapper
Christoph Wurst [Tue, 9 Feb 2021 17:15:56 +0000 (18:15 +0100)]
Merge pull request #25549 from nextcloud/remove-reconnect-wrapper

remove ReconnectWrapper

3 years agoremove ReconnectWrapper 25549/head
Robin Appelman [Tue, 9 Feb 2021 15:12:15 +0000 (16:12 +0100)]
remove ReconnectWrapper

dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed

Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years agosimplified tests 25548/head
Konrad Abicht [Tue, 9 Feb 2021 14:48:37 +0000 (15:48 +0100)]
simplified tests

Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years agofixed coding style issue
Konrad Abicht [Tue, 9 Feb 2021 14:40:19 +0000 (15:40 +0100)]
fixed coding style issue

Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years agoadded tests for OC\Core\Data\LoginFlowV2Credentials
Konrad Abicht [Tue, 9 Feb 2021 14:25:37 +0000 (15:25 +0100)]
added tests for OC\Core\Data\LoginFlowV2Credentials

Signed-off-by: Konrad Abicht <hi@inspirito.de>