]> source.dussan.org Git - vaadin-framework.git/log
vaadin-framework.git
11 years agoAllow skipping TB2/TB3 tests using tests.tb2/tb3.skip
Artur Signell [Fri, 11 Oct 2013 17:31:48 +0000 (20:31 +0300)]
Allow skipping TB2/TB3 tests using tests.tb2/tb3.skip

Change-Id: If9f16657731fa5ea06e61bf9702abe385e4fc7a1

11 years agoDisable unit cache to avoid compilation issues when switching between branches
Artur Signell [Mon, 14 Oct 2013 18:57:08 +0000 (21:57 +0300)]
Disable unit cache to avoid compilation issues when switching between branches

Change-Id: Iac8a3cdc4b17c031108c08cf3e8cd8769bc14961

11 years agoUpdate to atmosphere javascript 2.0.3-vaadin1 (#12241, #12127)
Artur Signell [Fri, 11 Oct 2013 13:28:32 +0000 (16:28 +0300)]
Update to atmosphere javascript 2.0.3-vaadin1 (#12241, #12127)

Build vaadinPush.js from the released version instead of having a separate
javascript version in the project

Change-Id: I37aac284216c8ec6efd03c242e639e88854f11fd

11 years agoFix whitespace after including a mixin (#12715)
Mika Murtojarvi [Mon, 14 Oct 2013 12:16:40 +0000 (15:16 +0300)]
Fix whitespace after including a mixin (#12715)

Change-Id: I9b25968cc140a9443820a26eadb6b5a1507ad7ec

11 years agoAlso hide shim iframe of VOverlay on setVisible(false) (#12731)
Henri Sara [Wed, 9 Oct 2013 09:31:00 +0000 (12:31 +0300)]
Also hide shim iframe of VOverlay on setVisible(false) (#12731)

Change-Id: I48258a24bb14bbe79c1e11c9bda4a18b120b2a42

11 years agoHandle ClientMethodInvocation serialization with JSONArray as parameter
Pekka Hyvönen [Fri, 11 Oct 2013 09:38:53 +0000 (12:38 +0300)]
Handle ClientMethodInvocation serialization with JSONArray as parameter
(#12532)

Change-Id: I67306d2b9d151614f72455063b0d01423aeed4c1

11 years agoConverted broken test to TB3
Artur Signell [Fri, 27 Sep 2013 10:16:45 +0000 (13:16 +0300)]
Converted broken test to TB3

Change-Id: Ic30db7584a65c944eb45c576e12b7671399d1965

11 years agoMake the various Writers member fields instead of local variables (#12446)
Johannes Dahlström [Thu, 12 Sep 2013 13:07:59 +0000 (16:07 +0300)]
Make the various Writers member fields instead of local variables (#12446)

Change-Id: I9ca101edf6df41702b27635da9f749bdac5bf5f4

11 years agoOnly fetch rows if there are some (#11189)
Matti Tahvonen [Fri, 4 Oct 2013 12:41:06 +0000 (15:41 +0300)]
Only fetch rows if there are some (#11189)

IE hacks cause calls to onScroll in situations where the cache row fetch
logic is not working correctly (causes JS exception). This change has an
optimization to pass this logic if there are no rows available and this
way fixes the JS exception as well.

Change-Id: I3425f3d75cad8b65e605638343b167abf7b48067

11 years agoadded small pause to make test pass
Matti Tahvonen [Wed, 9 Oct 2013 11:37:57 +0000 (14:37 +0300)]
added small pause to make test pass

Change-Id: I2e58a7444e5a2740f81409e6f248e0acedcead54

11 years agoFocus selected row in Table #12540
John Ahlroos [Tue, 1 Oct 2013 13:55:39 +0000 (16:55 +0300)]
Focus selected row in Table #12540

Change-Id: Ic920f9cb11840a456a7c49746317eaccde1e1406

11 years agoFixed compilation error in TB3 test
John Ahlroos [Wed, 9 Oct 2013 06:59:03 +0000 (09:59 +0300)]
Fixed compilation error in TB3 test

Change-Id: I62e246995879733393af3275778e9201cd970adb

11 years agoAvoid obsolete calendar panel renderings to avoid various NPEs.
Matti Tahvonen [Fri, 27 Sep 2013 12:07:48 +0000 (15:07 +0300)]
Avoid obsolete calendar panel renderings to avoid various NPEs.
(#12504,#12667)

Change-Id: Ie0a9a8d9913116520b766062ebabdb771a76d1b6

11 years agoUpdatet servlet tests to follow the same *Test naming convention
Artur Signell [Mon, 7 Oct 2013 17:34:23 +0000 (20:34 +0300)]
Updatet servlet tests to follow the same *Test naming convention

Change-Id: I3c718232364f5ca7cce7131fa7685e4a2b833120

11 years agoAllow configuring deployment port for TB3 tests
John Ahlroos [Tue, 8 Oct 2013 12:54:55 +0000 (15:54 +0300)]
Allow configuring deployment port for TB3 tests

Change-Id: Iee0827d1e65dcbc1fc6c71701b80f355285b6902

11 years agoRecreate transient pendingAccessQueue in readObject() (#12456)
Johannes Dahlström [Tue, 24 Sep 2013 13:08:08 +0000 (16:08 +0300)]
Recreate transient pendingAccessQueue in readObject() (#12456)

This prevents a race condition in getPendingAccessQueue().

Change-Id: I1b8d013119e5963ed6083b7dd17afccd3a915e42

11 years agoUse class name and not enclosing class for screenshot name
Artur Signell [Mon, 7 Oct 2013 17:17:40 +0000 (20:17 +0300)]
Use class name and not enclosing class for screenshot name

Change-Id: I8e9e0487f4354ee0523b5d3c0c016a002c395107

11 years agoMakes test stable and adds helper comparison methods
Artur Signell [Mon, 7 Oct 2013 16:56:43 +0000 (19:56 +0300)]
Makes test stable and adds helper comparison methods

* Takes into account that the timer can be triggered multiple times before the initial request is done (especially if the server is slow)
* Adds assertLessThan, assertLessThanOrEqual, assertGreaterThan, assertGreaterThanOrEqual to ease test creation

Change-Id: I5ce1681e35d9c1de02a83b38528f17ee705331d7

11 years agoUpdate TB3+ convention to use a separate *Test file
Artur Signell [Mon, 7 Oct 2013 15:12:06 +0000 (18:12 +0300)]
Update TB3+ convention to use a separate *Test file

For any issue there should be a UI class, e.g. LabelSomething and a
Test class which has the name of the UI + Test, e.g. LabelSomethingTest.
The LabelSomethingTest contains ALL tests which depend on LabelSomething
and are named accordingly to what they test.

For special and legacy cases also LegacyApplication and UIProvider are
supported in addition to UI classes

Change-Id: Ifc0180b377284bbd029202494ad194d324f8213b

11 years agoMark as deprecated to discourage usage for new tests
Artur Signell [Mon, 7 Oct 2013 14:56:31 +0000 (17:56 +0300)]
Mark as deprecated to discourage usage for new tests

Change-Id: I87d417da5b6b8cf9753604944dff74f8f39c321a

11 years agoFixed incorrect logging (#12241)
Artur Signell [Mon, 7 Oct 2013 15:53:53 +0000 (18:53 +0300)]
Fixed incorrect logging (#12241)

Change-Id: Icfe32a26f9069b7c5ed8160dba93b806754acf58

11 years agoConverted push test to TB3 (#12226, #12522)
Artur Signell [Fri, 27 Sep 2013 10:44:00 +0000 (13:44 +0300)]
Converted push test to TB3 (#12226, #12522)

Change-Id: Ia12b35ef6beed0bf2f534f2c9505b22ce7b3c7c3

11 years agoRebuild OptionGroup on HtmlContentAllowed/Multiselect changes (#10451)
Artem Godin [Mon, 7 Oct 2013 14:19:57 +0000 (17:19 +0300)]
Rebuild OptionGroup on HtmlContentAllowed/Multiselect changes (#10451)

Fixes regression with HtmlContent in Safari 5 and changing of
Multiselect properties on the fly.

Change-Id: I4a3820eba8d1c06460777340ea36b1df31b38983

11 years agoActually open integration test.
Artur Signell [Mon, 7 Oct 2013 17:16:15 +0000 (20:16 +0300)]
Actually open integration test.

Regression since the change in test behavior (no longer automatically
opens test URL)

Change-Id: I1c4efc9b5b5c8a28818afa6f91af1a8b159354b4

11 years agoRun tests on Tomcat 8 (#12326)
Artur Signell [Mon, 7 Oct 2013 17:49:18 +0000 (20:49 +0300)]
Run tests on Tomcat 8 (#12326)

Change-Id: I99d91f16c5ad2dce6fb93f2862913b23518410d7

11 years agoFixed Table range selection IE regression #12407
John Ahlroos [Mon, 7 Oct 2013 09:37:50 +0000 (12:37 +0300)]
Fixed Table range selection IE regression #12407

After fixes for #12407 the range selection did not work in the case
where the selection start had previously been removed. This caused
MultiSelectWithRemovedRow test to fail on IE.

Change-Id: Iaa91cc6a3a310aedc80c4c2475fa8e94a30a5563

11 years agoFix NullPointerException in logger when message is null (#12588)
Artem Godin [Thu, 3 Oct 2013 12:47:08 +0000 (15:47 +0300)]
Fix NullPointerException in logger when message is null (#12588)

LogSection.publish and VConsole.log/VConsole.error methods now replace
null message with an empty string ("")

Change-Id: I735b51bce971ababe2557f1b6c317c01066bc03c

11 years agoPrepare for Atmosphere Javascript 2.0 (#12241)
Artur Signell [Thu, 12 Sep 2013 17:57:01 +0000 (20:57 +0300)]
Prepare for Atmosphere Javascript 2.0 (#12241)

* Atmosphere 2.0 has changed enableProtocol to default to true.
* Reopening a connection in Atmosphere 2.0 is signalled through an onReopen event (not present at all in Atmosphere 1.0.x)

Fix was backported from master

Change-Id: I6ed258087a0b3a06440ab9d19b621560fa4f998f
Merge: no

11 years agoFixes #12564 (HorizontalLayout breaks w/ alignment & error indicator)
Matti Tahvonen [Fri, 27 Sep 2013 16:00:53 +0000 (19:00 +0300)]
Fixes #12564 (HorizontalLayout breaks w/ alignment & error indicator)

Removed some obsolete (hopefully!?) code doing some odd things with caption height calculation  and some refactoring to make that part of code slightly more readable.

Change-Id: I960e4a9eba0388281868f18a182c8788cedf08f9

11 years agoFix OptionGroup elements losing focus on value change (#10451)
Artem Godin [Wed, 2 Oct 2013 14:07:14 +0000 (17:07 +0300)]
Fix OptionGroup elements losing focus on value change (#10451)

The misbehavior was caused by VOptionGroup.buildOptions recreating
associated panel on every change by removing and adding new elements.
With this fix applied it tries to update existing elements,
distinguishing them by assigned keys. It will recreate panel though if
elements are reordered or new elements were added/removed.

Change-Id: I1245b2ff30ce1932614c1eac37bd0131cbd29dd7

11 years agoPorted regression fixes in 6.8 for #12407 to 7.1 branch
John Ahlroos [Wed, 2 Oct 2013 13:33:41 +0000 (16:33 +0300)]
Ported regression fixes in 6.8 for #12407 to 7.1 branch

Change-Id: Ie46ab97fc1ff89dd241eec9182ed0f92164b754d

11 years agoOnly print testbench failure TeamCity messages when running in TC
John Ahlroos [Mon, 30 Sep 2013 11:45:43 +0000 (14:45 +0300)]
Only print testbench failure TeamCity messages when running in TC

Change-Id: Ifa04ce512743bc8ccddea0bdca7b82cceaff150e

11 years agoDo not try to focus invisible components which not present in UIDL #12654
Yuriy Artamonov [Thu, 26 Sep 2013 07:37:42 +0000 (11:37 +0400)]
Do not try to focus invisible components which not present in UIDL #12654

Change-Id: I365940e72d97426eceb408878bc8b24d7655de7c

11 years agoreduce reflow and calculation in VOverlay (#12566)
Fabian Lange [Thu, 12 Sep 2013 14:20:17 +0000 (16:20 +0200)]
reduce reflow and calculation in VOverlay (#12566)

the actual position of VOverlay is only required when a shim or shadow is used.
Otherwise the calculation of its position causes unnecessary reflows.

Change-Id: Id3915fe55c6b477f5d3ff01ee3a505014303d6d6

11 years agoOnly publish files actually produced by this test/browser
Artur Signell [Wed, 2 Oct 2013 06:39:34 +0000 (09:39 +0300)]
Only publish files actually produced by this test/browser

Change-Id: If4f66157791d642801c0100bb4bc0f293efe76cc

11 years agoUpdate slider client-side state object on value change (#12676)
Juho Nurminen [Tue, 1 Oct 2013 12:14:28 +0000 (15:14 +0300)]
Update slider client-side state object on value change (#12676)

Change-Id: Ief93d845e5498388072e05a0faff7ef2d29f1c77

11 years agoCheck modifiers when handling TabSheet hot keys. Fixes #12178
Juho Nurminen [Mon, 23 Sep 2013 10:17:41 +0000 (13:17 +0300)]
Check modifiers when handling TabSheet hot keys. Fixes #12178

Change-Id: I685dbf2c22e3b160632b811652bf3ab52d3ef6dc

11 years agoRefactor how TB3 tests are written (#12572)
Artur Signell [Fri, 27 Sep 2013 10:14:36 +0000 (13:14 +0300)]
Refactor how TB3 tests are written (#12572)

* openTestUrl() must be called in the beginning of each test. Before that setPush and setDebug can be used to determine whether /run-push or ?debug should be used in the URL

Change-Id: Ie70996fcbdb2769fcd4ec56cb878e20198e02bf6

11 years agoPrefixes GET parameters in Liferay with portlet namespace #12602
John Ahlroos [Mon, 23 Sep 2013 13:51:42 +0000 (16:51 +0300)]
Prefixes GET parameters in Liferay with portlet namespace #12602

Change-Id: I9939a7af83482e136ed0d146accdeec0cd9f10ea

11 years agoAdded user agent for IE 11 (#12631)
Artur Signell [Fri, 27 Sep 2013 10:12:35 +0000 (13:12 +0300)]
Added user agent for IE 11 (#12631)

Change-Id: I1ba1791c04a3d1685e1bc482d2b04a748e19f012

11 years agoPublish error artifacts immediatly in TeamCity
John Ahlroos [Wed, 25 Sep 2013 10:51:23 +0000 (13:51 +0300)]
Publish error artifacts immediatly in TeamCity

Change-Id: I69cb2208b7f6b3263ddb25fa26eebebcc6f9a7c3

11 years agoFixes normal drag and drop events (regression since 7.1) and html5 style
Matti Tahvonen [Thu, 26 Sep 2013 12:59:55 +0000 (15:59 +0300)]
Fixes normal drag and drop events (regression since 7.1) and html5 style
D&D in IE10 (#12339)

Change-Id: Ied4504406ebbeab6ff464fb239f7b3f5987fbbd9

11 years agoLimit the number of tests run concurrently (#12572)
Artur Signell [Tue, 24 Sep 2013 15:19:45 +0000 (18:19 +0300)]
Limit the number of tests run concurrently (#12572)

Change-Id: I015e92ccc9be963543032c14dd9d051bcba58e53

11 years agoFixes issue with Table not scrolling completely to the end #12651
John Ahlroos [Thu, 19 Sep 2013 13:42:50 +0000 (16:42 +0300)]
Fixes issue with Table not scrolling completely to the end #12651

Made the Table notice if the user is trying to scroll to an item on the
last "page" and in those cases actually scroll to that item, not just to
the page's first item as it did before.

Change-Id: I47df33c75aa9b7e4f9a5f4bd5daeb301028517e8

11 years agoConverted TB2 push tests to TB3 (#12580)
Artur Signell [Mon, 16 Sep 2013 11:44:43 +0000 (14:44 +0300)]
Converted TB2 push tests to TB3 (#12580)

Change-Id: Ifd6286aee75946eb47c39886c08473a5a0c10545

11 years agoRun TB3 tests also on IE11 (#12631)
Artur Signell [Wed, 25 Sep 2013 09:57:48 +0000 (12:57 +0300)]
Run TB3 tests also on IE11 (#12631)

Change-Id: I1ae0f8618e69ba61bb946cde18c2936b751f3a5f

11 years agoFixes browser detection for IE11 (#12638)
Artur Signell [Tue, 24 Sep 2013 08:36:18 +0000 (11:36 +0300)]
Fixes browser detection for IE11 (#12638)

Change-Id: I1f71477368ce42eac3679f7f2f9e87fe8e02e4de

11 years agoDo not add empty package javadoc for new classes
Artur Signell [Tue, 24 Sep 2013 10:36:03 +0000 (13:36 +0300)]
Do not add empty package javadoc for new classes

Change-Id: I5b040806acaae3e94d2eb8c7ea78f9414d964564

11 years agoTB3 test for browsers (#12572)
Artur Signell [Mon, 23 Sep 2013 16:57:08 +0000 (19:57 +0300)]
TB3 test for browsers (#12572)

Change-Id: I1011aed7b3a7f4a339199be4e598b02b27500307

11 years agoUpdated TB3 tests to use Firefox 24 (#12604)
Artur Signell [Mon, 23 Sep 2013 17:15:54 +0000 (20:15 +0300)]
Updated TB3 tests to use Firefox 24 (#12604)

Change-Id: I738e5e3aca7b5332ced2179593f304c6d375b0f1

11 years agoConverted servlet integration tests to TB3 (#12573)
Artur Signell [Mon, 16 Sep 2013 11:37:20 +0000 (14:37 +0300)]
Converted servlet integration tests to TB3 (#12573)

Change-Id: I964be2ef805875f36a2f0f8139feaa353c9aaee0

11 years agoRefactored build scripts to support TB2, TB3 + integration tests (#12572)
Artur Signell [Mon, 16 Sep 2013 11:31:37 +0000 (14:31 +0300)]
Refactored build scripts to support TB2, TB3 + integration tests (#12572)

* Main build configuration triggers unit tests for all modules and uitest/build.xml testbench tests in parallel
* uitest/build.xml triggers Jetty startup and integration (server) tests in parallel. After the server has started, TB2 and TB3 tests are run in parallel.
* Server integration tests for servlet containers are run using TB3 and the com.vaadin.tests.tb3.ServletIntegrationTests test suite.
* Portlet integration tests are still run using TB2 test scripts

Change-Id: Ie6bffd4e68b4889074e9c470faa3c65f923e55c4

11 years agoMake it possible to override web driver in tests (#12572)
Artur Signell [Mon, 23 Sep 2013 12:46:20 +0000 (15:46 +0300)]
Make it possible to override web driver in tests (#12572)

Change-Id: If696c8a57fc370d2851592d745ab8a2698631ed5

11 years agoBase files for TB3 tests (#12572)
Artur Signell [Mon, 16 Sep 2013 05:50:16 +0000 (08:50 +0300)]
Base files for TB3 tests (#12572)

* Converted LabelModes to TB3 for validation

Change-Id: Ic9e69d46623a16986961bdc8cc050b375622a91d

11 years agoDon't try to cast a connector to Widget. Fixes #12619
Jonatan Kronqvist [Fri, 20 Sep 2013 12:32:12 +0000 (15:32 +0300)]
Don't try to cast a connector to Widget. Fixes #12619

Change-Id: I0fe98ca90ed3969f1af1be60668b4c1c561675eb

11 years agoPostLayoutListener javadocs (#12562) 7.1.6
Leif Åstrand [Thu, 12 Sep 2013 07:13:12 +0000 (10:13 +0300)]
PostLayoutListener javadocs (#12562)

Change-Id: Icdc39630a8d48f87ca4765f4513c9871d49f5d76

11 years agoUpdate release notes to more closely be like 7.0.x (#12544)
Artur Signell [Wed, 18 Sep 2013 21:18:19 +0000 (00:18 +0300)]
Update release notes to more closely be like 7.0.x (#12544)

* Fixed ticket link and removed duplicate link
* Reordered sections to changes in this version comes before changes in old versions
* Updated browser versions

Change-Id: Ib3afc6257c93fe6481103fbb80aa5ebf9d2a5dd5

11 years agoAdd v-iosN classname for all iOS versions instead of just N=6 (#12324)
Johannes Dahlström [Thu, 19 Sep 2013 11:23:46 +0000 (14:23 +0300)]
Add v-iosN classname for all iOS versions instead of just N=6 (#12324)

Change-Id: Id06cfab1404facd612aa470d82757ae6dfe71641

11 years agoEnsure string converter is always set
Artur Signell [Mon, 16 Sep 2013 11:33:54 +0000 (14:33 +0300)]
Ensure string converter is always set

Change-Id: I8c9146975397356e92fded0d0207b56d057ac6c5

11 years agoEnable native scrolling in all iOS versions newer than 5, not just iOS 6 (#12324)
Johannes Dahlström [Tue, 10 Sep 2013 12:36:51 +0000 (15:36 +0300)]
Enable native scrolling in all iOS versions newer than 5, not just iOS 6 (#12324)

Change-Id: I8f9ec7f34aefa5b48fd23f3f000f9455475edefa

11 years agoInclude TestBench 3.1.1 in the project (#12572)
Artur Signell [Mon, 10 Jun 2013 18:32:57 +0000 (21:32 +0300)]
Include TestBench 3.1.1 in the project (#12572)

* Jetty is updated to 8.1.9.v20130131 to avoid conflicts with TestBench dependencies
* The new jetty dependens on servlet 3.0

Change-Id: Ibbbc8f5838feb4c132ee2b6f7d7f3f630e95dd68

11 years agoUse JUnit 4.11 in all modules (#12572)
Artur Signell [Wed, 4 Sep 2013 12:58:26 +0000 (15:58 +0300)]
Use JUnit 4.11 in all modules (#12572)

Change-Id: I244f4afdebe956166a9158d85dc69fd7746c5a47

11 years agoAdd async-supported to all servlets to enable push testing (#12573)
Artur Signell [Wed, 4 Sep 2013 17:07:54 +0000 (20:07 +0300)]
Add async-supported to all servlets to enable push testing (#12573)

Change-Id: I8025c7d032f1a76244dbf085e76cb231c1a4459c

11 years agoClarified error message (#12583)
Artur Signell [Mon, 16 Sep 2013 12:49:35 +0000 (15:49 +0300)]
Clarified error message (#12583)

Change-Id: I542046158f6e78c8bb26aaee110bd5b123ae13e6

11 years agoEnsure PushConnection is properly cleaned up on disconnect (#12226, #12522)
Johannes Dahlström [Thu, 12 Sep 2013 14:48:47 +0000 (17:48 +0300)]
Ensure PushConnection is properly cleaned up on disconnect (#12226, #12522)

Change-Id: I0bab199632554655ef92a624f5654852b4b157d1

11 years agoNullPointerException in DateToSqlDateConverter (#12284)
Edoardo Vacchi [Fri, 13 Sep 2013 08:25:29 +0000 (10:25 +0200)]
NullPointerException in DateToSqlDateConverter (#12284)

DateToSqlDateConverter throws a NullPointerException when the provided
value is null, thus violating the interface contract. If the provided
value is null, then the methods should return null.

Missing test case included

Change-Id: If08225c2a6ae7c3103e47d3817a5d45469c7bf4f

11 years agoTest for push with streaming based on Table
Artur Signell [Tue, 18 Jun 2013 19:26:23 +0000 (22:26 +0300)]
Test for push with streaming based on Table

Change-Id: I42146b8c0918a65c809bcb55e3930dad5bbb6e6f

11 years agofixed incorrect name for close-pressed.png for windows in black theme (#12563)
Fabian Lange [Thu, 12 Sep 2013 12:16:37 +0000 (14:16 +0200)]
fixed incorrect name for close-pressed.png for windows in black theme (#12563)

The scss file and the light and normal style suggest that the name should be
"-pressed". This is what this patch fixes. I have considered renaming all
"-pressed" to "-active", to be consistent with e.g. "maximize-active.png"
but decided against due to compatibility concerns.

Change-Id: I42f37b3311715fab04e5fe05fdf4bc3026e52ed1

11 years agoNullPointerException in TableQuery.fetchMetadata() (#11403)
Edoardo Vacchi [Fri, 13 Sep 2013 07:11:04 +0000 (09:11 +0200)]
NullPointerException in TableQuery.fetchMetadata() (#11403)

Trivial patch. The finally block lacks a check for null before
attempting to invoke table.close()

Change-Id: Ib32f1d75fef4bd442652ca60a2b7df6aa45d7fa7

11 years agoUse non-obfuscated version of vaadinPush.js when not in production (#12527)
Artur Signell [Mon, 9 Sep 2013 11:38:21 +0000 (14:38 +0300)]
Use non-obfuscated version of vaadinPush.js when not in production (#12527)

Change-Id: I8e0baec2391b140e6a72eedf6606fd2792c735bc

11 years agoAdded a comment that hopefully explains the NULL_OBJECT #12509
Jonatan Kronqvist [Mon, 9 Sep 2013 11:14:49 +0000 (14:14 +0300)]
Added a comment that hopefully explains the NULL_OBJECT #12509

Change-Id: I99ea86d8842324884dda3a5c392f37e8d4a7acf6

11 years agoAllow storing and restoring null instances in CurrentInstance #12509 7.1.5
Jonatan Kronqvist [Fri, 6 Sep 2013 13:07:33 +0000 (16:07 +0300)]
Allow storing and restoring null instances in CurrentInstance #12509

Change-Id: Icf82377b0d47166d59e8be5f2f8b450d654302d7

11 years agoProtect CurrentInstance instances from garbage collection (#12509)
Leif Åstrand [Thu, 5 Sep 2013 07:11:07 +0000 (10:11 +0300)]
Protect CurrentInstance instances from garbage collection (#12509)

Change-Id: I9ec103a1a42d8888d6f680f477393807223740cf

11 years agoFix keystore path to correspond to the Vaadin 7 directory structure (#12520)
Johannes Dahlström [Thu, 5 Sep 2013 11:58:00 +0000 (14:58 +0300)]
Fix keystore path to correspond to the Vaadin 7 directory structure (#12520)

Change-Id: I58d5633baabc03e4e7cda413aa5b9231c7fa3e57

11 years agoReduce Ivy resolver spam to a minimum (#12510)
Artur Signell [Wed, 4 Sep 2013 18:04:11 +0000 (21:04 +0300)]
Reduce Ivy resolver spam to a minimum (#12510)

Change-Id: Ie80f2bad49f38a2391a8a560825aceb19f82de0a

11 years agoUnified xml files to end with new line
Artur Signell [Wed, 4 Sep 2013 18:03:12 +0000 (21:03 +0300)]
Unified xml files to end with new line

Change-Id: Ifb1393e7e5c5c1002b924223957767b3e584d5ab

11 years agoInclude unobfuscated file used by test in the war (#12468)
Leif Åstrand [Tue, 3 Sep 2013 11:06:59 +0000 (14:06 +0300)]
Include unobfuscated file used by test in the war (#12468)

Change-Id: Id90faf1dde880bb1aa51f9c337dca594f4993884

11 years agoAllow creating TextBox or SuggestionPopup when extending VFilterSelect (#12491)
Fabian Lange [Mon, 2 Sep 2013 13:49:53 +0000 (15:49 +0200)]
Allow creating TextBox or SuggestionPopup when extending VFilterSelect (#12491)

This patch adds two methods, that one can override when extending VFilterSelect.
By doing so, the developer can for example change the behavior of setting text,
or performing clicks in the suggestion popup.
This change is backwards compatible, as it just offers two new methods to
override.

Change-Id: Icc8fd154ef1abaed96e6af742af77c3225db3fe4

11 years agoAdd <br> as empty representation for webkit (#12490) 7.1.4
Artur Signell [Tue, 3 Sep 2013 08:01:07 +0000 (11:01 +0300)]
Add <br> as empty representation for webkit (#12490)

Change-Id: Idfb1c770d411b0516046e40852b79da6f9c7916c

11 years agoFix for #12279 (caret jumps when formatting in RTA).
Marc Englund [Wed, 28 Aug 2013 12:47:02 +0000 (15:47 +0300)]
Fix for #12279  (caret jumps when formatting in RTA).

Change-Id: I09bd04cd0d687be636a7b4d718bccf271bdb9dd9

11 years agoExcludes WeakValueMap from the serializable test #12401
Jonatan Kronqvist [Tue, 3 Sep 2013 06:53:10 +0000 (09:53 +0300)]
Excludes WeakValueMap from the serializable test #12401

Also added a note to the WeakValueMap JavaDoc stating that it is
not serializable.

Change-Id: If342746ad7c7cac0db8bac4ba75236970cc4cd01

11 years agoSets the locale in the test case. #12460
Jonatan Kronqvist [Tue, 3 Sep 2013 06:37:26 +0000 (09:37 +0300)]
Sets the locale in the test case. #12460

TestHideTimeAndSeparator didn't specify a locale, which
caused it to fail if the locale on the system where it
ran was different from the one on the system where the
test was created.

Change-Id: I44de92c68954eac425308eeaf7e07e76c717f2bf

11 years agoAdd deprecation message to unused constant
Leif Åstrand [Tue, 9 Jul 2013 06:36:26 +0000 (09:36 +0300)]
Add deprecation message to unused constant

Change-Id: Ifcc4e021fa3843129f6501d6526e4d4f5c6930fb

11 years agoFix regression where empty RTA returns <br> (#12490)
Artur Signell [Mon, 2 Sep 2013 13:34:17 +0000 (16:34 +0300)]
Fix regression where empty RTA returns <br> (#12490)

Change-Id: I273037644ed1383af84898cf03360e2b08d2647b

11 years agoUpdated browser versions
Artur Signell [Mon, 2 Sep 2013 11:36:23 +0000 (14:36 +0300)]
Updated browser versions

Change-Id: If091d718fc45b226a60a4c69d3469b4b31919ac1

11 years agoChanged 'feature release' text to maintenance release (#12486)
Artur Signell [Mon, 2 Sep 2013 11:23:43 +0000 (14:23 +0300)]
Changed 'feature release' text to maintenance release (#12486)

Change-Id: I2896136065232d2704bb4807ff92e6ef384407e8

11 years agoCorrected typo in version variable (#12440)
Artur Signell [Mon, 2 Sep 2013 11:19:47 +0000 (14:19 +0300)]
Corrected typo in version variable (#12440)

Change-Id: Ib9a3efee02f4887072e7892d869911b78ec5e1d8

11 years agoThe colon in the calendar event caption is now also hideable. Fixes #12460
Jonatan Kronqvist [Wed, 28 Aug 2013 13:04:54 +0000 (16:04 +0300)]
The colon in the calendar event caption is now also hideable. Fixes #12460

Change-Id: Idc81c3cc614bc59c2a93615bd5ac5cac9b72f752

11 years agoTable ignores Container updates while painting (#12258)
Henrik Paul [Tue, 20 Aug 2013 12:47:54 +0000 (15:47 +0300)]
Table ignores Container updates while painting (#12258)

Vaadin threw an IllegalStateException if a Container was updated while
Table was being painted. SQLContainer was known to invalidate its cached
size during a Table repaint, resulting in an ItemSetChangeEvent. This fix
has been copied over from how ComboBox handles this situation.

Change-Id: I04af71a5ea3844da245cb9e31ada4a30ff704619

11 years agoUpdated _trackMessageSize based on latest upstream version (#12468)
Leif Åstrand [Fri, 30 Aug 2013 08:18:16 +0000 (11:18 +0300)]
Updated _trackMessageSize based on latest upstream version (#12468)

Change-Id: Ie7db27a026d52befe027ed2abb96e62947f8116d

11 years agoAvoid leaking memory from inherited ThreadLocales. Fixes #12401
Jonatan Kronqvist [Wed, 28 Aug 2013 10:53:45 +0000 (13:53 +0300)]
Avoid leaking memory from inherited ThreadLocales. Fixes #12401

The issue is fixed by changing the normal HashMap inside the inheritable
thread local to a map implementation holding only weak references to the
values (WeakValueMap).

Also included is a test UI that starts threads, which run until the JVM
is quit. This along with VisualVM was used to reproduce the issue and
verify the fix.

Change-Id: I116cc4e56e8a19c3b770abab6b18b9e262f4dafa

11 years agoAlways unlock the same session instance that was locked (#12481)
Leif Åstrand [Fri, 30 Aug 2013 11:38:48 +0000 (14:38 +0300)]
Always unlock the same session instance that was locked (#12481)

Change-Id: I15ff1177d827bc8fee9f8f723f9a288b0c3aea71

11 years agoAdds junit to the ide configuration for the theme-compiler module.
Jonatan Kronqvist [Fri, 30 Aug 2013 06:45:50 +0000 (09:45 +0300)]
Adds junit to the ide configuration for the theme-compiler module.

Change-Id: I7c777d8d427beab079c956248b23628a073563dc

11 years agoAllow creating session for Portlet UI init request (#12473)
Leif Åstrand [Fri, 30 Aug 2013 05:19:58 +0000 (08:19 +0300)]
Allow creating session for Portlet UI init request (#12473)

Change-Id: I4c62e246c026cec7c87c2bd5ee5435891f885882

11 years agoOnly consider caption tooltips for own slots (#12469)
Leif Åstrand [Thu, 29 Aug 2013 12:46:54 +0000 (15:46 +0300)]
Only consider caption tooltips for own slots (#12469)

Change-Id: I2d804b460fbca7cb7dbea01c88ae3dc7e63f344d

11 years agoUse the add() path of CssLayout only when appending to the end (#11284)
Henri Sara [Wed, 28 Aug 2013 09:34:53 +0000 (12:34 +0300)]
Use the add() path of CssLayout only when appending to the end (#11284)

This should get the benefits of the previous optimization on initial
rendering without negatively affecting the performance when modifying a
layout with complex non-leaf children.

Change-Id: Id6fcf3e54469454c6a998a50037c8a93bfb46cf6

11 years agoEnable use of profiler without debug window (#12465)
Henri Sara [Wed, 28 Aug 2013 07:43:39 +0000 (10:43 +0300)]
Enable use of profiler without debug window (#12465)

This change also corrects a typo in the name of the internal method
setProfilerResultConsumer()

Change-Id: I877858d992611512ee681022312de7a9bfa4cd39

11 years agoDisable slow sanity check when not in debug mode (#12463)
Henri Sara [Wed, 28 Aug 2013 07:12:15 +0000 (10:12 +0300)]
Disable slow sanity check when not in debug mode (#12463)

Change-Id: I98d0a3254a92bce728d56a591914e727f5ef3aa8

11 years agoAdded controlDirective to ifContentStatement. Fixes ticket #12105.
Juho Nurminen [Fri, 23 Aug 2013 07:03:53 +0000 (10:03 +0300)]
Added controlDirective to ifContentStatement. Fixes ticket #12105.

Change-Id: I48988c3f3451ff9fa86148f4bb923a2ebdb6c482

11 years agoOptimize CssLayout hierarchy update (#11284)
Henri Sara [Thu, 22 Aug 2013 08:28:39 +0000 (11:28 +0300)]
Optimize CssLayout hierarchy update (#11284)

This change also adds some profiling for CssLayoutConnector.

Change-Id: Ia567c2c0ed2cff2c73a9019cea0f9a0240955dc7