Merge pull request #35307 from nextcloud/release/23.0.12_rc1

23.0.12 RC1

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #35396 from nextcloud/stable23-update-some-libs

[stable23] Update some libs

Merge pull request #35410 from nextcloud/backport/35398/stable23

[stable23] Do not check quota for non Node

Do not check quota for non Node

Signed-off-by: Louis Chemineau <louis@chmn.me>

Update some libs

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #35361 from nextcloud/backport/stable23/35187

[stable23] Fix mentions rendering in comment editor

Merge pull request #35371 from nextcloud/backport/35250/stable23

[stable23] Properly compare quota against both float/int values

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #35369 from nextcloud/backport/35353/stable23

[stable23] Update cache when file size === 0

Merge pull request #35352 from nextcloud/backport/35327/stable23

[stable23] Handle badly named version files more gracefully and log information

Merge pull request #35329 from nextcloud/backport/35232/stable23

[stable23] Check quota on file copy

Merge pull request #35040 from nextcloud/backport/32211/stable23

[stable23] Add repair command to fix wrong share ownership

Properly compare quota against both float/int values

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #35357 from nextcloud/backport/35206/stable23

[stable23] Fix forwarding the object id when searching comments

Merge pull request #35020 from nextcloud/backport/34909/stable23

[stable23] Fix duplicate event email notifications

Update cache when file size === 0

The conditions were false when $result === 0.
$results here contains the number of written bits.
The correct way of checking for operation success is to check if $result === false

Signed-off-by: Louis Chemineau <louis@chmn.me>

Fix mentions rendering in comment editor

NcRichContentEditable needs an index of users to properly display them. This commit adds a caching logic and provides it to NcRichContentEditable.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #35102 from nextcloud/backport/35054/stable23-fix-html-entities-not-decoded-in-comment-just-added

[stable23] Fix HTML entities not decoded in comment just added

Fix forwarding the object id when searching comments

Signed-off-by: Joas Schilling <coding@schilljs.com>

Handle badly named version files more gracefully and log information

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #35339 from nextcloud/backport/35007/stable23

[stable23] Fix unsuccessful token login logged as error

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix unsuccessful token login logged as error

The condition of a non-existent login token can happen for concurrent
requests. Admins can not do anything about this. So this is to be
expected to happen occasionally. This event is only bad if none of the
requests is able to re-acquire a session. Luckily this happens rarely.

If a login loop persists an admin can still lower the log level to find
this info. But a default error log level will no longer write those
infos about the failed cookie login of one request.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Apply the same fix as on beforeCopy on beforeMove

Let’s be safe

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix dirname usage

Signed-off-by: Robin Appelman <robin@icewind.nl>

Fix psalm issues

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Check quota on file copy

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #35163 from nextcloud/backport/35157/stable23

[stable23] Make sure to not pass null to DateTime::createFromFormat

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #34967 from nextcloud/backport/34963/stable23

[stable23] Fix invalid date in security.txt

23.0.12 RC1

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #35144 from nextcloud/backport/34160/stable23

[stable23] Detect weird local ips

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #35267 from nextcloud/backport/35259/stable23

[stable23] Also cancel XHR when cancelling uploads

Also cancel XHR when cancelling uploads

Fixes issue when cancelling a long list of uploads.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Update 3rdparty to latest stable23

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #35202 from nextcloud/backport/35096/stable23

[stable23] Mark more config values as sensitive

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Mark more config values as sensitive

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #35051 from nextcloud/backport/28610/stable23

[stable23] Use storage filter when fetching previews to cleanup

Pass default values to idn_to_utf8 to fix behavior under PHP 7.3

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix duplicate event email notifications

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Make sure to not pass null to DateTime::createFromFormat

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #35050 from nextcloud/backport/34834/stable23

[stable23] Fix size calculation on copying the skeleton files

Add mlocati/ip-lib dependency

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix idn_to_utf8 stub signature

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix tests for nested v4 in v6

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Use new dependency to normalize IPs

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add missing urldecode and idn_to_utf8 calls to local address checker

The call to idn_to_utf8 call is actually to apply normalization

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Harden tests for local IP detection in URLs

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #35087 from nextcloud/backport/35074/stable23

[stable23] Make sure that path is normalized and then checked,

Compile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Fix HTML entities not decoded in comment just added

The XML data received from the comments endpoint has an inconsistent
encoding; some entities are encoded once and others are encoded twice.
When the comment list is loaded the comments are fetched using
GetComments, which handles all that, and therefore shows the messages
and author names as expected.

However, when a new comment is posted the list is not got again; instead
the new comment is loaded from the comment data returned after posting
it. This is done in NewComment, which did not decode the messages nor
the author names, and therefore showed, for example, "&amp;" instead of
"&".

To solve that now the same decoding logic used in GetComments is applied
too in NewComment.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Extract "decodeHtmlEntities" function to its own file

This will make possible to use it from files other than
"GetComments.js".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #35073 from nextcloud/backport/35063/stable23

[stable23] Fix top margin in empty versions list

Fix engines versions

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Make sure that path is normalized and then checked,

 and not the other way around

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix php 7.3 compat

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix concat usage

Signed-off-by: Robin Appelman <robin@icewind.nl>

Fix top margin in empty versions list

Manual backport of #35063

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #35062 from nextcloud/backport/35052/stable23

[stable23] Fix sidebar not automatically hidden in Files app

Fix sidebar not automatically hidden in Files app

Although the Files app creates the legacy sidebar (details view) it is
then replaced with the newer Vue app sidebar. Due to this ".detailsView"
no longer finds an element and therefore nothing was hidden when
"hideAppSidebar($('.detailsView'))" was called (for example, when
changing to another section).

However, "OC.Apps.hideAppSidebar()" does not properly work either with
the Vue sidebar used in the Files app (once hidden the sidebar is not
shown again). For simplicity, and to avoid any possible side effect in
other apps from changing "OC.Apps.hideAppSidebar", now
"OC.Files.Sidebar.close()" is used instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Use storage filter when fetching previews to cleanup

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Use proper storage method for writing skeleton files

otherwise the filecache will have a wrong size for skeleton files

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

update autoloader

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix repairing non user shares when repairing all shares

Signed-off-by: Robin Appelman <robin@icewind.nl>

remove no longer needed code

Signed-off-by: Robin Appelman <robin@icewind.nl>

split repairing into two stages to prevent long open transaction

Signed-off-by: Robin Appelman <robin@icewind.nl>

update shares directly in db

Signed-off-by: Robin Appelman <robin@icewind.nl>

More verbose output for repair share ownership cmd

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

move share owner repair to occ command

Signed-off-by: Robin Appelman <robin@icewind.nl>

Add repair step to fix wrong share ownership

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #34999 from nextcloud/backport/34937/stable23

[stable23] Avoid a crash when a PHP extension has no version

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Suppress false-positives from psalm, waiting for fix upstream

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Avoid a crash when a PHP extension has no version

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #34660 from nextcloud/backport/34632/stable23

[stable23] Add rate limiting on lost password emails

Merge pull request #34808 from nextcloud/backport/34802/stable23

[stable23] Add pre-commit configuration to stable24 as well

Merge pull request #34844 from nextcloud/backport/34302/stable23

 [stable23] Fix: Prevent deadlocks during mtime/size/etag propagation

Merge pull request #34948 from nextcloud/backport/34804/stable23

[stable23] Skip general login with email for non-valid addresses and LDAP

Merge pull request #34950 from nextcloud/backport/32663/stable23

[stable23] Cleanup tempfiles after each cron job run

Fix invalid date in security.txt

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Support PHP 7.3 for stable23

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix LostController test

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>