]> source.dussan.org Git - vaadin-framework.git/log
vaadin-framework.git
11 years agoUse the add() path of CssLayout only when appending to the end (#11284)
Henri Sara [Wed, 28 Aug 2013 09:34:53 +0000 (12:34 +0300)]
Use the add() path of CssLayout only when appending to the end (#11284)

This should get the benefits of the previous optimization on initial
rendering without negatively affecting the performance when modifying a
layout with complex non-leaf children.

Change-Id: Id6fcf3e54469454c6a998a50037c8a93bfb46cf6

11 years agoEnable use of profiler without debug window (#12465)
Henri Sara [Wed, 28 Aug 2013 07:43:39 +0000 (10:43 +0300)]
Enable use of profiler without debug window (#12465)

This change also corrects a typo in the name of the internal method
setProfilerResultConsumer()

Change-Id: I877858d992611512ee681022312de7a9bfa4cd39

11 years agoDisable slow sanity check when not in debug mode (#12463)
Henri Sara [Wed, 28 Aug 2013 07:12:15 +0000 (10:12 +0300)]
Disable slow sanity check when not in debug mode (#12463)

Change-Id: I98d0a3254a92bce728d56a591914e727f5ef3aa8

11 years agoAdded controlDirective to ifContentStatement. Fixes ticket #12105.
Juho Nurminen [Fri, 23 Aug 2013 07:03:53 +0000 (10:03 +0300)]
Added controlDirective to ifContentStatement. Fixes ticket #12105.

Change-Id: I48988c3f3451ff9fa86148f4bb923a2ebdb6c482

11 years agoOptimize CssLayout hierarchy update (#11284)
Henri Sara [Thu, 22 Aug 2013 08:28:39 +0000 (11:28 +0300)]
Optimize CssLayout hierarchy update (#11284)

This change also adds some profiling for CssLayoutConnector.

Change-Id: Ia567c2c0ed2cff2c73a9019cea0f9a0240955dc7

11 years agoFixed broken test due to changes in drop position by #12406
John Ahlroos [Mon, 26 Aug 2013 11:26:25 +0000 (14:26 +0300)]
Fixed broken test due to changes in drop position by #12406

Change-Id: Ia5c706a4315f8b8c618ca5c3e8681e656809dcec

11 years agoFix bug for spacing on first widget (#12420)
Henri Sara [Thu, 22 Aug 2013 12:26:35 +0000 (15:26 +0300)]
Fix bug for spacing on first widget (#12420)

Change-Id: I58db924446d5c4908f10b29f910cf2aa90ef7a2a

11 years agoOptimize large Vertical/HorizontalLayout client side (#12420, #10899)
Henri Sara [Thu, 22 Aug 2013 08:55:38 +0000 (11:55 +0300)]
Optimize large Vertical/HorizontalLayout client side (#12420, #10899)

Spacing is now only handled at the beginning and end of hierarchy
updates, not for every component separately.
Some more profiling data on potential hotspots is also generated when
Profiler is used.

Change-Id: Ief1138dfd9161b683f69513e3458b8174de592bc

11 years agoOptimize resetting of state when detaching components (#10899, #11284)
Henri Sara [Thu, 22 Aug 2013 08:03:47 +0000 (11:03 +0300)]
Optimize resetting of state when detaching components (#10899, #11284)

This has a significant impact on some older browsers, especially IE8.
This change also adds hierarchy update profiling statements to
help find hotspots.

Change-Id: Id7025776f8606794ba1d7aef99e2c37832b0c6bb

11 years agoFixed failing TabKeyboardNavigation test #12433
John Ahlroos [Thu, 22 Aug 2013 08:10:18 +0000 (11:10 +0300)]
Fixed failing TabKeyboardNavigation test #12433

The test fails on Opera 12 since the assertText is done before the
tabsheet has had time to change the tab content. Added a small waiting
period after the tab is changed before the assert is made to fix the
issue.

Change-Id: I89dfe040b577106f9f843c8b4013d20be1e02166

11 years agoFixed test broken by PopupDateField communication change #6252
John Ahlroos [Wed, 21 Aug 2013 11:51:50 +0000 (14:51 +0300)]
Fixed test broken by PopupDateField communication change #6252

After #6252 the value is no longer communicated to the server
immediatly but only once the popup is closed. Changed the test to assume
the new behaviour.

Change-Id: I74782971d47367a8a57a520d5f4ab736f9b37c2c

11 years agoFixed test broken by fixes to drag&drop #12406
John Ahlroos [Wed, 21 Aug 2013 10:34:37 +0000 (13:34 +0300)]
Fixed test broken by fixes to drag&drop #12406

Due to the fixes to the VDragAndDropManager the drop location became a
lot more accurate and so changed where the drops were made in the test.
To fix it I adjusted the pixel position within the drop target element to account for the
changed accuracy.

Change-Id: I60fec00a40c36fe0afcc7a4bacb2f7b101201b70

11 years agoAdd more detailed profiling for some client side hotspots (#12418)
Henri Sara [Wed, 21 Aug 2013 07:45:54 +0000 (10:45 +0300)]
Add more detailed profiling for some client side hotspots (#12418)

Change-Id: I27178a553571a99725ac4a75cae88d55398604ad

11 years agoOptimize ComputedStyle.getIntProperty() (#12411)
Henri Sara [Wed, 21 Aug 2013 06:59:40 +0000 (09:59 +0300)]
Optimize ComputedStyle.getIntProperty() (#12411)

Change-Id: I51b421e5b2c94d6b7e22a0c23bf1c8412061ef02

11 years agoEscape markup in CustomLayout's JavaDoc (#12410)
Henrik Paul [Tue, 20 Aug 2013 07:13:32 +0000 (07:13 +0000)]
Escape markup in CustomLayout's JavaDoc (#12410)

svn changeset:26111/svn branch:6.8

Change-Id: I8585c9022b78381a40d9008b0d489aecd741b011

11 years agoFixed DragAndDropWrapper using wrong drop target in IE8 #12406
John Ahlroos [Tue, 20 Aug 2013 10:30:47 +0000 (13:30 +0300)]
Fixed DragAndDropWrapper using wrong drop target in IE8 #12406

VDragAndDropManager was assuming that the target element will always be
inside the cloned "drag image" element while dragging. This assumption
is false since the "drag image" can be 0x0px or transparent effectivly
disabling dragging.

Since Testbench 2 is also very flaky in using the Vaadin locators with
the drag/drop commands I replaced the locators with shorter locators
using a debug id to make the test more readable and stable.

Change-Id: I2cc9683d11e982521e74418c74dd3e81ee617ac5

11 years agoReport min and max times from Profiler (#12409)
Henri Sara [Tue, 20 Aug 2013 09:21:18 +0000 (12:21 +0300)]
Report min and max times from Profiler (#12409)

Change-Id: Ifb88038baf9c1b9c872840030dcaefd7b8488f64

11 years agoSearch only remaining message for delimiter (#12404)
Artur Signell [Mon, 19 Aug 2013 15:27:35 +0000 (18:27 +0300)]
Search only remaining message for delimiter (#12404)

Change-Id: I0d61984aa795ec2b3bd384c2f93f6e3ee2a71be3

11 years agoFix scrollbar for Window under WebKit browsers (#11994)
Patrik Lindström [Thu, 15 Aug 2013 12:36:36 +0000 (15:36 +0300)]
Fix scrollbar for Window under WebKit browsers (#11994)

Change-Id: Ie39d521c2f299bca0e2175fd8bb59beaa4f66241

11 years agoMake sure that no fileIds are replayed to the client (#12330)
Henrik Paul [Thu, 15 Aug 2013 05:59:03 +0000 (08:59 +0300)]
Make sure that no fileIds are replayed to the client (#12330)

Due to how ProxyReceivers are constructed and serialized, we don't want
to resend the ProxyReceivers for files that already are in the queue.
Either we needed to change the way ProxyReceivers behave, or just make
sure that they aren't resent. I chose the double-check method.

Change-Id: I7c4e866ba4287afd3e80329be3640335d4ff00af

11 years agoTerminate JVM if server.close() has no effect (#12363)
Leif Åstrand [Tue, 13 Aug 2013 10:17:41 +0000 (13:17 +0300)]
Terminate JVM if server.close() has no effect (#12363)

Change-Id: If024d94d496a6cf2e6f0f342d368ac7bd746de38

11 years agoGWT requires max 1.6 compiler compliance level currently - #12345
Henrik Paul [Tue, 13 Aug 2013 06:41:25 +0000 (09:41 +0300)]
GWT requires max 1.6 compiler compliance level currently - #12345

Change-Id: I0e37e231b17afc365bf397ab601a1717d83a7459

11 years agoAdd a chapter on installing IvyDE (for #12359)
Henrik Paul [Tue, 13 Aug 2013 06:40:57 +0000 (09:40 +0300)]
Add a chapter on installing IvyDE (for #12359)

Change-Id: I996100bb702a4426726d5cb1d0826efedfde3f4f

11 years agoFixed a typo in FieldGroup.isModified() JavaDoc. (#12172)
Teemu Pöntelin [Mon, 12 Aug 2013 07:08:12 +0000 (10:08 +0300)]
Fixed a typo in FieldGroup.isModified() JavaDoc. (#12172)

Change-Id: I10d7ba7d0bc5c03e65206617c521d089fd4d0cfe

11 years agoReset waitingForFilteringResponse flag to false inside onBlur (#12325)
denisanisimov [Thu, 8 Aug 2013 10:43:00 +0000 (13:43 +0300)]
Reset waitingForFilteringResponse flag to false inside onBlur (#12325)

Change-Id: I09de808376c366cb52f055277671a59e6ae736b3

11 years agoDelay sending DateField popup value to server until popup is closed #6252
John Ahlroos [Fri, 9 Aug 2013 07:59:11 +0000 (10:59 +0300)]
Delay sending DateField popup value to server until popup is closed #6252

Change-Id: Ib6f4681ea38fe7a6cac8a44bc4ab4b23151844dd

11 years agoUse <code> instead of {@code} for sample containing { and } (#12311)
Leif Åstrand [Fri, 9 Aug 2013 06:42:25 +0000 (09:42 +0300)]
Use <code> instead of {@code} for sample containing { and } (#12311)

Change-Id: Ibbcc48e5557521bfe50e73e63ad723fe7da29c9b

11 years agoFixes Button icon alt text not being updated #12333
John Ahlroos [Thu, 8 Aug 2013 08:05:38 +0000 (11:05 +0300)]
Fixes Button icon alt text not being updated #12333

Change-Id: I23a26fbc5281e76792e257321d96f3d30a8bc2b2

11 years agoMake sure bean field validators are only added once (#11045)
Patrik Lindström [Wed, 31 Jul 2013 13:42:16 +0000 (16:42 +0300)]
Make sure bean field validators are only added once (#11045)

Change-Id: I67779fa5bfd4c850101c11c22091c988eb65b808

11 years agoSplit UiAccess test (#12332)
Leif Åstrand [Wed, 7 Aug 2013 08:22:09 +0000 (11:22 +0300)]
Split UiAccess test (#12332)

Change-Id: I231e84d84adca79549d00a88dd4ae613ff291dbc

11 years agoDisable failing calendar Actions Menu Test (#12181)
Patrik Lindström [Wed, 7 Aug 2013 08:08:13 +0000 (11:08 +0300)]
Disable failing calendar Actions Menu Test (#12181)

This test cannot be completed in a smart fashion until TestBench 3 is in
use, because of differences in the DOM structure created by GWT for IE
and Opera, versus Webkit and Gecko browsers. TB2 requires identical DOM
structure for assertion queries to work.

Change-Id: I6f5f9aac1c25e4e105459da215db080b031b2aab

11 years agoUpdate "lastRequestedFirstvisible" field value right away (#10666).
denisanisimov [Tue, 6 Aug 2013 13:19:40 +0000 (16:19 +0300)]
Update "lastRequestedFirstvisible" field value right away (#10666).

Change-Id: Idef31fa74f4720b5c55511de0545cd8ae1b77b26

11 years agoFix race in VaadinService.lockSession() (#12282) 7.1.2
Johannes Dahlström [Mon, 5 Aug 2013 12:47:16 +0000 (15:47 +0300)]
Fix race in VaadinService.lockSession() (#12282)

The session might be invalidated before lockSession() acquires the lock.
Check if the session is still valid after locking and ensure
SessionExpiredException is thrown if not.

Change-Id: Iad716332a65b7c198427fce5198f6808140c140c

11 years agoFix native scrolling regression in iOS 6 homescreen apps (#12295)
Johannes Dahlström [Tue, 6 Aug 2013 10:59:33 +0000 (13:59 +0300)]
Fix native scrolling regression in iOS 6 homescreen apps (#12295)

Change-Id: Ie225663ebc2a9ffe4b481a49e34e9dcf79b064b2

11 years agoAvoid infinite recursion when purging access queue (#12310)
Leif Åstrand [Fri, 2 Aug 2013 13:03:15 +0000 (16:03 +0300)]
Avoid infinite recursion when purging access queue (#12310)

Change-Id: Id5029f6606ce508c5746af4e0fa3078283f511bf

11 years agoShow tooltips for ordered layout captions (#10046)
denisanisimov [Fri, 2 Aug 2013 11:32:47 +0000 (14:32 +0300)]
Show tooltips for ordered layout captions (#10046)

Change-Id: I80cb1cbd573d7e0de8aa200a4513dc32984ba9f5

11 years agoRefine handling of null and empty URI fragments (#12207)
Leif Åstrand [Fri, 2 Aug 2013 07:20:40 +0000 (10:20 +0300)]
Refine handling of null and empty URI fragments (#12207)

Change-Id: Ie133694b010a586c6336e9b04be7bcd94d2525e9

11 years agoImprove URI fragment listener javadocs (#12296)
Leif Åstrand [Fri, 2 Aug 2013 05:32:45 +0000 (08:32 +0300)]
Improve URI fragment listener javadocs (#12296)

Change-Id: I7c91768f02d04c613f25e5984cb015067465815c

11 years agoEnsure StringToIntegerConverter rejects values outside range of int (#12230)
Johannes Dahlström [Thu, 1 Aug 2013 08:53:34 +0000 (11:53 +0300)]
Ensure StringToIntegerConverter rejects values outside range of int (#12230)

Change-Id: I150bee64144045355bfa75ac10ede663d3feb5ce

11 years agoFixes parsing of multiple push messages in streaming mode (#12197)
Fabian Lange [Wed, 17 Jul 2013 09:44:57 +0000 (11:44 +0200)]
Fixes parsing of multiple push messages in streaming mode (#12197)

The current atmosphere code can handle messages split up using the message
length header. But it does not handle the case where the header is actually
split up itself.
This patch solves it by making sure the length header stays intact.
Corresponding atmosphere ticket:
https://github.com/Atmosphere/atmosphere/issues/1199

Change-Id: If22c42ea63b0749c68df19c869b316f9b69f4317

11 years agoDisable all logging if production mode is enabled (#12299)
Leif Åstrand [Thu, 1 Aug 2013 09:18:05 +0000 (12:18 +0300)]
Disable all logging if production mode is enabled (#12299)

Change-Id: Ia6b05c0ebaf1f0bb4fb675392cc8f634cab8e494

11 years agoAdd optional OSGi Import-Package for javax.validation (#12301)
Johannes Dahlström [Wed, 31 Jul 2013 12:07:12 +0000 (15:07 +0300)]
Add optional OSGi Import-Package for javax.validation (#12301)

Change-Id: Iff9105537a2a8123b808be33f8cd390b0c23edd6

11 years agoDocument multiple load semantics in @StyleSheet and @JavaScript (#12200)
Leif Åstrand [Fri, 19 Jul 2013 12:25:40 +0000 (15:25 +0300)]
Document multiple load semantics in @StyleSheet and @JavaScript (#12200)

Change-Id: Id52f196ad6d14e8077482b19a8d0479aedc64db3

11 years agoFix calendar click events on context menu #12297
Patrik Lindström [Tue, 30 Jul 2013 11:10:01 +0000 (14:10 +0300)]
Fix calendar click events on context menu #12297

Change-Id: Ifb66253ef05677d80d2f1e8bb935e5e4789308de

11 years agoFix actions in action menu appearing in random order #12250
Patrik Lindström [Tue, 30 Jul 2013 11:14:07 +0000 (14:14 +0300)]
Fix actions in action menu appearing in random order #12250

Change-Id: I77186adb94392cd317d37b9d9250f28891e6f06e

11 years agoClarify Embedded javadoc (#12290)
Johannes Dahlström [Tue, 30 Jul 2013 11:58:14 +0000 (14:58 +0300)]
Clarify Embedded javadoc (#12290)

Change-Id: I3c15bf79236019056eeb501974a6a34799e8fd40

11 years agoFix invisible calendar actions menu #12181
Patrik Lindström [Mon, 29 Jul 2013 12:09:35 +0000 (15:09 +0300)]
Fix invisible calendar actions menu #12181

Change-Id: I4cdf3d1e584f1537f0f216ddd6f65c1ec4a2ee6b

11 years agoFix race condition that might leave access queue unpurged (#12277)
Leif Åstrand [Mon, 29 Jul 2013 12:51:33 +0000 (15:51 +0300)]
Fix race condition that might leave access queue unpurged (#12277)

Merge: no
Change-Id: Iee1012486906d8c2c46cef94cfcd6d2b399d7a6b

11 years agoFixed wrong classname in WindowThemes TB test #12171
John Ahlroos [Mon, 29 Jul 2013 10:16:40 +0000 (13:16 +0300)]
Fixed wrong classname in WindowThemes TB test #12171

Change-Id: I23ce7ba8a87c119ada78bba1d4735c4d8404b4f8

11 years agoFixes button :active state on firefox #12126
John Ahlroos [Fri, 26 Jul 2013 08:07:36 +0000 (11:07 +0300)]
Fixes button :active state on firefox #12126

When doing event.preventDefault() firefox will not trigger the :active
selector intentionally (see
https://bugzilla.mozilla.org/show_bug.cgi?id=771241).

Event.preventDefault() was added to prevent text selection in #10917
but it actually is not needed since the button also uses the
user-select:none css attribute which effectivly prevents the text selection.

Also now applying the previously browser specific (ie,opera) .v-pressed
classname to all browsers to make styling of the pressed state a bit easier
to do for all browsers and not reliant on the :active pseudo-class which is a
non-standard pseudo-class.

Change-Id: Ic67c0abb9d0bf8f47b817609f2928aa8fff3e82b

11 years agoFixes light theme window sprites #12171
John Ahlroos [Thu, 25 Jul 2013 06:53:50 +0000 (09:53 +0300)]
Fixes light theme window sprites #12171

The close buttons images for the Window black theme was mistakenly
added to the white theme sprite and ended up in the middle of the
light theme window. Moved the black theme button images to the
black theme sprite.

Change-Id: Ieaaaa1b404f1d623c61fe7cfecb4996d96904b27

11 years agoFix issue with hidden component cells in Table and TreeTable #12119
John Ahlroos [Wed, 24 Jul 2013 12:28:15 +0000 (15:28 +0300)]
Fix issue with hidden component cells in Table and TreeTable #12119

Change-Id: I2f491d04ff177f7f0ce104c96b1c4a84ee7a2bc0

11 years agoVerify the connector hierarchy if assertions are enabled (#12271)
Leif Åstrand [Tue, 23 Jul 2013 13:12:49 +0000 (16:12 +0300)]
Verify the connector hierarchy if assertions are enabled (#12271)

Change-Id: I87632abe9d86927b7ba4254724fedfdb04513205

11 years agoOnly add DateRangeValidator to DateField if start or end of range is set (#12193)
Johannes Dahlström [Fri, 19 Jul 2013 13:09:53 +0000 (16:09 +0300)]
Only add DateRangeValidator to DateField if start or end of range is set (#12193)

Change-Id: I9138a5607c1ff20f3aa7be49270f683e732ee195

11 years agoUpdate to Atmosphere 1.0.14.vaadin4 (#12242)
Leif Åstrand [Thu, 18 Jul 2013 14:11:17 +0000 (17:11 +0300)]
Update to Atmosphere 1.0.14.vaadin4 (#12242)

Change-Id: I76ccbf631f8ba169f11513b7d585f39b8ab570a4

11 years agoClose PushRequestHandler when VaadinServlet is destroyed (#11878)
Leif Åstrand [Fri, 19 Jul 2013 11:36:56 +0000 (14:36 +0300)]
Close PushRequestHandler when VaadinServlet is destroyed (#11878)

Should be implemented using ServiceDestoryListener in Vaadin 7.2

Merge: no

Change-Id: Ibb4d37f1f95c56b80111df3a3217076af18dd93d

11 years agoAdd Require-Bundle for our rebased atmosphere bundle (#12195)
Leif Åstrand [Thu, 18 Jul 2013 10:26:08 +0000 (13:26 +0300)]
Add Require-Bundle for our rebased atmosphere bundle (#12195)

Change-Id: Ibcc86cf874925096b3ac368cb0c6e3af00619f60

11 years agoMake VaadinService.closeInactiveUIs set UI threadlocals (#12186)
Leif Åstrand [Wed, 17 Jul 2013 12:15:21 +0000 (15:15 +0300)]
Make VaadinService.closeInactiveUIs set UI threadlocals (#12186)

Also update javadocs for methods called without UI threadlocals
Also make sure pending access tasks are run for a UI being closed

Change-Id: Ia600207b2d25fc195ee4254da371d420152bf100

11 years agoDon't close an unbound VaadinSession for GAEVaadinServlet (#12209)
Leif Åstrand [Fri, 12 Jul 2013 07:05:53 +0000 (10:05 +0300)]
Don't close an unbound VaadinSession for GAEVaadinServlet (#12209)

Change-Id: If3480eb6e21f5f19a43b8dc0d6279173ff3bec40

11 years agoFix lost focus in Table when refreshing row cache (#12231)
Tapio Aali [Tue, 16 Jul 2013 13:15:01 +0000 (16:15 +0300)]
Fix lost focus in Table when refreshing row cache (#12231)

svn changeset:25991/svn branch:6.8
svn changeset:26075/svn branch:6.8
svn changeset:26091/svn branch:6.8

Change-Id: Ia4a6ab4cc6ff98795a6d1f9b1701a345dc3f4dc4

11 years agoImproving performance of ConnectorTracker (#12218)
Fabian Lange [Sat, 13 Jul 2013 20:12:28 +0000 (22:12 +0200)]
Improving performance of ConnectorTracker (#12218)

Swapping the if check in cleanConnectorMap to prevent unnecessary calls to
isComponentVisible when the connector is in uninitializedConnectors set.

Change-Id: If6305a908364f8a7bb51fd7302449c6f54c274a3

11 years agoImproved AbstractClientConnector performance (#12219)
Fabian Lange [Sun, 14 Jul 2013 14:38:26 +0000 (16:38 +0200)]
Improved AbstractClientConnector performance (#12219)

Avoiding duplicate lookup of connector hierarchy when a component shall be
marked dirty. Optimized if statement to fail fast.

Change-Id: I3ac82d64b235ebfd1888a6076c595f351018d887

11 years agoAttempt to get GAE lock for UIDL requests (#12211)
Leif Åstrand [Fri, 12 Jul 2013 06:54:06 +0000 (09:54 +0300)]
Attempt to get GAE lock for UIDL requests (#12211)

Also removing the overhead of creating a Date object just for getting a
timestamp in the otherwise touched areas of code.

Change-Id: Ic712c0ae26d22995ad332593dbb8a14dbec7fcd6

11 years agoEnsure VaadinSession.service is set up by storeInSession (#12204)
Leif Åstrand [Fri, 12 Jul 2013 06:59:25 +0000 (09:59 +0300)]
Ensure VaadinSession.service is set up by storeInSession (#12204)

Change-Id: Ie707442f2625f3c9c07c75924c99299f07a4f3ec

11 years agoSet current instances when calling UI.push from VaadinSession.unlock (#12168)
Leif Åstrand [Mon, 8 Jul 2013 14:23:49 +0000 (17:23 +0300)]
Set current instances when calling UI.push from VaadinSession.unlock (#12168)

Change-Id: I27795ab9ae3e3692f508e847936ccaa5a1ebadd4

11 years agoWhen InputStream cannot be opened while writing static resource response, display...
Fabian Lange [Thu, 13 Jun 2013 13:11:39 +0000 (15:11 +0200)]
When InputStream cannot be opened while writing static resource response, display 404 instead of 500 (#10920)

A security audit revealed that it is possible to trigger an error 500 with
stack trace by just trying a directory traversal. An example of this can be
found in the sampler: http://demo.vaadin.com/sampler/VAADIN/widgetsets/
While there are other scenarios that can produce exceptions, in this place
Vaadin can handle it more graceful by just catching the exception and
returning 404.

Change-Id: Iec68d81d3bca365ec133737a9cd3e3b825d192b2

11 years agoSet heartbeat response Content-Type to text/plain (#12182)
Johannes Dahlström [Tue, 9 Jul 2013 09:03:30 +0000 (12:03 +0300)]
Set heartbeat response Content-Type to text/plain (#12182)

By default browsers assume text/html and may complain about an empty response body.

Change-Id: I66ed1aef3421a7f0a618bc441ffab1dc0efbdc71

11 years agoMake UploadInterruptedException visible (#12070)
Fabian Lange [Thu, 13 Jun 2013 12:51:08 +0000 (14:51 +0200)]
Make UploadInterruptedException visible (#12070)

When another threads interrupts the Upload, the UploadInterruptedException is
thrown. The respective StreamVariable will receive
streamingFailed(StreamingErrorEvent event) which contains the causing exception
via event.getException(). When the UploadInterruptedException is not public, it
is impossible to react on it in the StreamVariable (e.g. treating an
IOException differently from an UploadInterruptedException).

Change-Id: I9098e70e6750c420fcc0978340544e545e237b26

11 years agoAdd test case for testing ClickEvent after dragging button (#7690)
Patrik Lindström [Tue, 2 Jul 2013 12:26:35 +0000 (15:26 +0300)]
Add test case for testing ClickEvent after dragging button (#7690)

Change-Id: I9ecb796a9bcbc8415efe27873fdbd71745d0aa85

11 years agoEnable native scrolling in home screen apps on iOS 6+ (#12149)
Henri Sara [Thu, 4 Jul 2013 07:53:44 +0000 (10:53 +0300)]
Enable native scrolling in home screen apps on iOS 6+ (#12149)

This also fixes another iOS 6 detection issue for home screen apps.

Change-Id: Icbbb15d3f0d6668f11b2a796ae2c096d8c4dec0b

11 years agoFix bug in PopupDateField where locale was retained incorrectly if
Patrik Lindström [Tue, 2 Jul 2013 21:04:35 +0000 (00:04 +0300)]
Fix bug in PopupDateField where locale was retained incorrectly if
changed while popup was open (#12153)

Change-Id: Ib4bebab8c6e75e7f1af7cfc5198ab6516e94a45e

11 years agoAutomatic test for escape closing window from combobox (#12163)
Henri Sara [Thu, 4 Jul 2013 07:08:52 +0000 (10:08 +0300)]
Automatic test for escape closing window from combobox (#12163)

Change-Id: I38a143fb76ebf3a64cd416e5ba7d325aedc60ffe

11 years agoClose only combobox on escape, not the window (#12163)
Henri Sara [Wed, 3 Jul 2013 13:33:50 +0000 (16:33 +0300)]
Close only combobox on escape, not the window (#12163)

Change-Id: I356e115b5cd96ba0a598178a15215654f2fd16bb

11 years agoTest using Jetty 9 (#12124)
Artur Signell [Tue, 25 Jun 2013 07:54:08 +0000 (10:54 +0300)]
Test using Jetty 9 (#12124)

Change-Id: Ie765e542e2319dc1d94c61a986cab3720556e66a

11 years ago#11638: Ending an imported SCSS file with a comment causes an error in
Haijian Wang [Fri, 28 Jun 2013 13:18:13 +0000 (16:18 +0300)]
#11638: Ending an imported SCSS file with a comment causes an error in
the Sass

Change-Id: Ib498f68caa7e87e2d9a21b29c9bfb2f30f35c701

11 years agoEnsure table's cells aren't refreshed if table is detached. (#9138)
Anna Koskinen [Fri, 28 Jun 2013 13:47:10 +0000 (16:47 +0300)]
Ensure table's cells aren't refreshed if table is detached. (#9138)

Change-Id: I026cd70e9e518fa320f6ec3011194359385a3a4a

11 years agoFix NPE in Like.java (#10167)
Patrik Lindström [Fri, 28 Jun 2013 11:56:21 +0000 (14:56 +0300)]
Fix NPE in Like.java (#10167)

Change-Id: I041fbc5c3cda08d3cf3453cefc5f044c63dbe9bb

11 years agoFixed an error in CustomComponent JavaDoc (#10038), and some improvements.
Marko Gronroos [Fri, 28 Jun 2013 13:19:55 +0000 (16:19 +0300)]
Fixed an error in CustomComponent JavaDoc (#10038), and some improvements.

Change-Id: Ifbdae94dc94405eca967a95fe783a85d778f461a

11 years agoUpdated Javadoc for Table.getColumnAlignment fixing #6810
Sami Ekblad [Fri, 28 Jun 2013 13:23:14 +0000 (16:23 +0300)]
Updated Javadoc for Table.getColumnAlignment fixing #6810

Change-Id: I05004cb874f5c32c03d28119d0522d3184a82292

11 years agoReplace printStackTrace with getLogger().log() (#12147)
Artur Signell [Fri, 28 Jun 2013 13:31:48 +0000 (16:31 +0300)]
Replace printStackTrace with getLogger().log() (#12147)

Change-Id: I9ec61fdc7ddc06f129a9d69b99e6295a62c4b0d3

11 years ago32x32 favicons added, replacing the old favicons (#12143)
Jouni Koivuviita [Fri, 28 Jun 2013 13:19:24 +0000 (16:19 +0300)]
32x32 favicons added, replacing the old favicons (#12143)

Added new version for favicon.ico, which has 32x32 pixel version in
addition to 16x16 pixels. Adds support for high resolution/retina
displays.

Change-Id: I49bd84b9d23f1e26ceee28dab1e26d9cd4f6b6d2

11 years agoEnsure that Slider diffstate always contains "value" (#12133)
Risto Yrjänä [Fri, 28 Jun 2013 12:53:03 +0000 (15:53 +0300)]
Ensure that Slider diffstate always contains "value" (#12133)

Force diff state to contain "value", so that value changes from value
change listeners work.

Change-Id: I5b2c661f1297ec0272c150a5a9ff4ca26f19fefe

11 years agoFix VaadinService.findUI to throw Error if UIConstants.UI_ID_PARAMETER
mtzukanov [Fri, 28 Jun 2013 12:52:48 +0000 (15:52 +0300)]
Fix VaadinService.findUI to throw Error if UIConstants.UI_ID_PARAMETER
is not set (#11943)

Change-Id: I3cbb88e3fab4f39af8e4799d5a914ab9bd4733f5

11 years agoFixed slider value initialization on HSV and RGB tabs of ColorPicker. (#7863)
Teemu Pöntelin [Fri, 28 Jun 2013 12:13:45 +0000 (15:13 +0300)]
Fixed slider value initialization on HSV and RGB tabs of ColorPicker. (#7863)

Change-Id: I3776400d849d4ba9f76d6296603152c0a6464aaa

11 years agoFixed NPE in ApplicationRunnerServlet (#12145)
Jouni Koivuviita [Fri, 28 Jun 2013 13:00:59 +0000 (16:00 +0300)]
Fixed NPE in ApplicationRunnerServlet (#12145)

If the path for a test case file contained special characters (such as
space), they would get URL encoded which wouldn't work for File
constructors.

Fixed by using URI.getPath(), which does the decoding.

Change-Id: I2a7c13b785adbb2e486d3807b115540c0ba70fa6

11 years agoImplemented Focusable in MenuBar (#7674)
Jens Jansson [Fri, 28 Jun 2013 12:09:08 +0000 (15:09 +0300)]
Implemented Focusable in MenuBar (#7674)

Change-Id: I31cd6fafffacc16147e63d3878fcf025163deb5b

11 years agoRemove sub window references from Window javadocs (#9892)
Leif Åstrand [Fri, 28 Jun 2013 11:42:43 +0000 (14:42 +0300)]
Remove sub window references from Window javadocs (#9892)

Change-Id: I51f1f39a9730313e0150bff2fccdba67e69e9d95

11 years agoThe 'license.html' file has flaw in the HTML (unclosed span tag)
michaelvogt [Fri, 28 Jun 2013 11:16:56 +0000 (14:16 +0300)]
The 'license.html' file has flaw in the HTML (unclosed span tag)
(#11952)

Change-Id: Ib940b76df7d2507e8a8b7122e99c4542850f9ac9

11 years agoDebug window poll interval claims interval is in seconds and not
michaelvogt [Fri, 28 Jun 2013 11:00:25 +0000 (14:00 +0300)]
Debug window poll interval claims interval is in seconds and not
milliseconds (#12098)

Change-Id: I26f86fdeafbdf15d02d40b86abb3f23da4f38543

11 years agoUse varargs instead of array where appropriate (#4513)
Artur Signell [Wed, 26 Jun 2013 06:41:17 +0000 (09:41 +0300)]
Use varargs instead of array where appropriate (#4513)

Change-Id: Ide9349b6afa7e56ae04b7727134971ebf81c0b03

11 years agoActually show loading indicator during loading (#12128)
Artur Signell [Tue, 25 Jun 2013 19:40:48 +0000 (22:40 +0300)]
Actually show loading indicator during loading (#12128)

* Add theme name already during bootstrap

Change-Id: I78da3029b818ced51714d385cd77f5ba9bfce625

11 years agoThings now align better in SimpleTree, for #12058
Marc Englund [Fri, 14 Jun 2013 13:44:46 +0000 (16:44 +0300)]
Things now align better in SimpleTree, for #12058

Change-Id: Ie36f51b8b6e28aaf0055772a6cf4dcd35b716a3a

11 years agoInclude Atmosphere fix for Android 4.1 (#12101)
Artur Signell [Tue, 25 Jun 2013 15:49:39 +0000 (18:49 +0300)]
Include Atmosphere fix for Android 4.1 (#12101)

Change-Id: Ia17a9d8c6ece9861476be8861a735fe5d3e054bf

11 years agoUse atmosphere 1.0.14.vaadin3 which fixes Android 4.1 support (#12101)
Artur Signell [Tue, 25 Jun 2013 09:58:23 +0000 (12:58 +0300)]
Use atmosphere 1.0.14.vaadin3 which fixes Android 4.1 support (#12101)

Change-Id: I75cd1eebeeb5836b9205a9a1e28795be300d135a

11 years agoEnsure caption is used when child is set to required (#12077)
Artur Signell [Tue, 18 Jun 2013 19:59:01 +0000 (22:59 +0300)]
Ensure caption is used when child is set to required (#12077)

Change-Id: Id4a9674c1b2e1c41dbba1f6fde11502400591a52

11 years agoAdd version property to integration tests to servers know if it is a Vaadin 6 or...
Artur Signell [Tue, 18 Jun 2013 22:41:27 +0000 (01:41 +0300)]
Add version property to integration tests to servers know if it is a Vaadin 6 or 7 test

Change-Id: Id16238351289ce8df81bed3cd364cc4aa8bba95c

11 years agoUpdated Atmosphere dependency to 1.0.14.vaadin2 (#12017, #12033, #12115)
Artur Signell [Mon, 24 Jun 2013 10:15:17 +0000 (13:15 +0300)]
Updated Atmosphere dependency to 1.0.14.vaadin2 (#12017, #12033, #12115)

Change-Id: I068cca8ae2d3739b3a8ba7b01cd83b1b69509dd2

11 years agoEnable using @Stylesheet with vaadin:// (#9934)
Artur Signell [Tue, 18 Jun 2013 18:22:09 +0000 (21:22 +0300)]
Enable using @Stylesheet with vaadin:// (#9934)

Change-Id: I895fad31ef5b31a395cea95e64d6b183d718056f

11 years agoReinitialize pendingAccessQueue after deserialization (#12097)
Johannes Dahlström [Tue, 18 Jun 2013 15:54:31 +0000 (18:54 +0300)]
Reinitialize pendingAccessQueue after deserialization (#12097)

Change-Id: I5e6d192093f19df1a07e95dff643babd6f532426

11 years agoAdd 'transport' GET parameter to AbstractTestUI (#12094)
Johannes Dahlström [Tue, 18 Jun 2013 09:31:12 +0000 (12:31 +0300)]
Add 'transport' GET parameter to AbstractTestUI (#12094)

* Value can be 'xhr', 'websocket', or 'streaming'
* xhr disables push even if already enabled
* others set push to automatic if not already set to manual

Change-Id: Iaf929bbb78865fa7d832718841e781e76cdf7277