]> source.dussan.org Git - poi.git/log
poi.git
5 years agopulled *Cell.getCellTypeEnum() to common base
Vladislav Galas [Sat, 26 Jan 2019 23:19:47 +0000 (23:19 +0000)]
pulled *Cell.getCellTypeEnum() to common base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68

5 years agopulled *Cell.getAddress to common base
Vladislav Galas [Sat, 26 Jan 2019 23:19:41 +0000 (23:19 +0000)]
pulled *Cell.getAddress to common base

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68

5 years agopurged usages of Cell.setCellType (left only in tests, where conversions are tested)
Vladislav Galas [Sat, 26 Jan 2019 19:41:36 +0000 (19:41 +0000)]
purged usages of Cell.setCellType (left only in tests, where conversions are tested)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68

5 years agomade call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType...
Vladislav Galas [Sat, 26 Jan 2019 19:41:25 +0000 (19:41 +0000)]
made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68

5 years agopurged calls to cell.setCellType(CellType.BLANK) from the project, replaced with...
Vladislav Galas [Sat, 26 Jan 2019 19:41:10 +0000 (19:41 +0000)]
purged calls to cell.setCellType(CellType.BLANK) from the project, replaced with setBlank()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852245 13f79535-47bb-0310-9956-ffa450edef68

5 years agoadded Cell.setBlank() - as an alias, for now
Vladislav Galas [Sat, 26 Jan 2019 19:40:56 +0000 (19:40 +0000)]
added Cell.setBlank() - as an alias, for now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852244 13f79535-47bb-0310-9956-ffa450edef68

5 years agosetCellFormula: blank cell gets value 0, non-blank value is preserved
Vladislav Galas [Sat, 26 Jan 2019 10:09:13 +0000 (10:09 +0000)]
setCellFormula: blank cell gets value 0, non-blank value is preserved

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852212 13f79535-47bb-0310-9956-ffa450edef68

5 years agotry to fix missing modules error and move addOpens detection into ant build
Andreas Beeker [Thu, 24 Jan 2019 20:35:18 +0000 (20:35 +0000)]
try to fix missing modules error and move addOpens detection into ant build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852072 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd required --add-opens and other settings for JDK 12 on Windows
Dominik Stadler [Tue, 22 Jan 2019 10:45:26 +0000 (10:45 +0000)]
Add required --add-opens and other settings for JDK 12 on Windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851804 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins: Try to disable coverage for JDK 13 for now as it seems to cause issues
Dominik Stadler [Tue, 22 Jan 2019 10:23:58 +0000 (10:23 +0000)]
Jenkins: Try to disable coverage for JDK 13 for now as it seems to cause issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851803 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins: Add initial build for JDK 13, add build for JDK 12 on Windows
Dominik Stadler [Tue, 22 Jan 2019 10:07:02 +0000 (10:07 +0000)]
Jenkins: Add initial build for JDK 13, add build for JDK 12 on Windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851798 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix invalid comment in build.xml
Dominik Stadler [Tue, 22 Jan 2019 10:04:53 +0000 (10:04 +0000)]
Fix invalid comment in build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851797 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix passing in --add-opens for Java 9+ after the poiunit refactoring, this
Dominik Stadler [Tue, 22 Jan 2019 10:01:36 +0000 (10:01 +0000)]
Fix passing in --add-opens for Java 9+ after the poiunit refactoring, this
only caused problems with Java 9+ on Windows, which we do not run in CI (yet)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851796 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix some IDE warnings and JVM deprecations
Dominik Stadler [Tue, 22 Jan 2019 10:00:01 +0000 (10:00 +0000)]
Fix some IDE warnings and JVM deprecations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851795 13f79535-47bb-0310-9956-ffa450edef68

5 years agotry to fix xmlbeans build
PJ Fanning [Sat, 19 Jan 2019 11:50:14 +0000 (11:50 +0000)]
try to fix xmlbeans build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851667 13f79535-47bb-0310-9956-ffa450edef68

5 years agoupdate xmlbeans targets
Andreas Beeker [Fri, 18 Jan 2019 23:14:06 +0000 (23:14 +0000)]
update xmlbeans targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851657 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[github-140] add .travis.yml. Thanks to krichter722. This closes #140
PJ Fanning [Tue, 15 Jan 2019 00:49:16 +0000 (00:49 +0000)]
[github-140] add .travis.yml. Thanks to krichter722. This closes #140

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851312 13f79535-47bb-0310-9956-ffa450edef68

5 years agofollow-up to Bug 62904. More tests and improved evaluation of IF in array mode
Yegor Kozlov [Mon, 14 Jan 2019 14:48:21 +0000 (14:48 +0000)]
follow-up to Bug 62904. More tests and improved evaluation of IF in array mode

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851263 13f79535-47bb-0310-9956-ffa450edef68

5 years agoDon't fail on row-nums larger than Integer.MAX_VALUE, we had one sample
Dominik Stadler [Sun, 13 Jan 2019 17:14:31 +0000 (17:14 +0000)]
Don't fail on row-nums larger than Integer.MAX_VALUE, we had one sample
file which triggered this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851211 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix some Findbugs and IDE issues, refactor some duplicated code,
Dominik Stadler [Sun, 13 Jan 2019 17:14:24 +0000 (17:14 +0000)]
Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62810: AreaReference ctor looses sheet name if rows or columns swapped
Dominik Stadler [Sun, 13 Jan 2019 17:14:05 +0000 (17:14 +0000)]
Bug 62810: AreaReference ctor looses sheet name if rows or columns swapped

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851209 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd reproducer for bug 60355
Dominik Stadler [Sun, 13 Jan 2019 17:13:57 +0000 (17:13 +0000)]
Add reproducer for bug 60355

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851208 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRevert inadvertently commented lines
Dominik Stadler [Fri, 11 Jan 2019 19:31:18 +0000 (19:31 +0000)]
Revert inadvertently commented lines

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851092 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRemove obsolete settings from JDK 11/12 build
Dominik Stadler [Fri, 11 Jan 2019 19:31:14 +0000 (19:31 +0000)]
Remove obsolete settings from JDK 11/12 build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851091 13f79535-47bb-0310-9956-ffa450edef68

5 years agoEnable weekly run of Java 12 build
Dominik Stadler [Fri, 11 Jan 2019 19:31:09 +0000 (19:31 +0000)]
Enable weekly run of Java 12 build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851090 13f79535-47bb-0310-9956-ffa450edef68

5 years agoIDE and JavaDoc fixes, move/remove some unfixed tests
Dominik Stadler [Fri, 11 Jan 2019 19:31:05 +0000 (19:31 +0000)]
IDE and JavaDoc fixes, move/remove some unfixed tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851089 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd one more test for bug 62828 and fix some IDE warnings
Dominik Stadler [Fri, 11 Jan 2019 19:30:44 +0000 (19:30 +0000)]
Add one more test for bug 62828 and fix some IDE warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851088 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug #60977 writing XSSF with custom properties twice corrupts output
Greg Woolsey [Fri, 11 Jan 2019 18:20:03 +0000 (18:20 +0000)]
Bug #60977 writing XSSF with custom properties twice corrupts output

turns out the output XML data buffer for the custom properties document was appended to, not replaced, when writing in the presence of existing content.  Now clearing output buffer first in this case.  When first creating custom properties, i.e. first write after changes, there is no buffer yet, so nothing to clear.

Does not affect any read operations, or other writes beyond custom properties, as that was where the problem lay, not down in the Zip stuff.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851084 13f79535-47bb-0310-9956-ffa450edef68

5 years agouse spaces for indents
PJ Fanning [Thu, 10 Jan 2019 08:13:00 +0000 (08:13 +0000)]
use spaces for indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850926 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63054: updated formulas in test spreadsheet to keep build happy
Yegor Kozlov [Tue, 8 Jan 2019 16:36:34 +0000 (16:36 +0000)]
Bug 63054: updated formulas in test spreadsheet to keep build happy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850772 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63054: improved evaluation of array formulas with error in arguments
Yegor Kozlov [Tue, 8 Jan 2019 12:54:39 +0000 (12:54 +0000)]
Bug 63054: improved evaluation of array formulas with error in arguments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850742 13f79535-47bb-0310-9956-ffa450edef68

5 years agounified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc...
Vladislav Galas [Mon, 7 Jan 2019 19:10:19 +0000 (19:10 +0000)]
unified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc and tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62904: Support array arguments in IF and logical IS*** functions
Yegor Kozlov [Mon, 7 Jan 2019 14:34:19 +0000 (14:34 +0000)]
Bug 62904: Support array arguments in IF and logical IS*** functions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850646 13f79535-47bb-0310-9956-ffa450edef68

5 years agoupdated mockito to 2.23.4 to fix java 11 build
Vladislav Galas [Sun, 6 Jan 2019 18:56:29 +0000 (18:56 +0000)]
updated mockito to 2.23.4 to fix java 11 build

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850590 13f79535-47bb-0310-9956-ffa450edef68

5 years agothrow IllegalArgumnetException if null directory specified
PJ Fanning [Fri, 4 Jan 2019 16:07:53 +0000 (16:07 +0000)]
throw IllegalArgumnetException if null directory specified

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850394 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFixed build (explicitly specified charset for new String(byte[]))
Vladislav Galas [Fri, 4 Jan 2019 14:25:11 +0000 (14:25 +0000)]
Fixed build (explicitly specified charset for new String(byte[]))

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850366 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 63057: made SXSSFCell.setCellValue(String|RichTextString) exception-safe.
Vladislav Galas [Fri, 4 Jan 2019 10:10:30 +0000 (10:10 +0000)]
Bug 63057: made SXSSFCell.setCellValue(String|RichTextString) exception-safe.
Also removed unused code.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850342 13f79535-47bb-0310-9956-ffa450edef68

5 years agoImproved test coverage for *Cell classes
Vladislav Galas [Fri, 4 Jan 2019 09:17:48 +0000 (09:17 +0000)]
Improved test coverage for *Cell classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850338 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying...
Vladislav Galas [Thu, 3 Jan 2019 00:08:52 +0000 (00:08 +0000)]
Bug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying XSSFSheet. Thanks to Axel Howind.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62828: CellReference(Cell) now initializes sheet name.
Vladislav Galas [Wed, 2 Jan 2019 22:08:38 +0000 (22:08 +0000)]
Bug 62828: CellReference(Cell) now initializes sheet name.
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF...
Vladislav Galas [Wed, 2 Jan 2019 20:45:52 +0000 (20:45 +0000)]
Bug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF.\nAll three implementations throw ISE when trying to get numeric value from a boolean-valued cell, have it a formula set or not.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850207 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd missing revert() in OPCPackage to close Zip-streams always
Dominik Stadler [Tue, 1 Jan 2019 20:10:58 +0000 (20:10 +0000)]
Add missing revert() in OPCPackage to close Zip-streams always

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850115 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd missing file-close in ZipInputStreamZipEntrySource seen in some mass regression...
Dominik Stadler [Tue, 1 Jan 2019 20:10:51 +0000 (20:10 +0000)]
Add missing file-close in ZipInputStreamZipEntrySource seen in some mass regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850114 13f79535-47bb-0310-9956-ffa450edef68

5 years agofix since annotation
PJ Fanning [Mon, 31 Dec 2018 14:27:32 +0000 (14:27 +0000)]
fix since annotation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850048 13f79535-47bb-0310-9956-ffa450edef68

5 years agoexclude integrationtest/build from rat-check
Andreas Beeker [Mon, 31 Dec 2018 12:27:31 +0000 (12:27 +0000)]
exclude integrationtest/build from rat-check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850041 13f79535-47bb-0310-9956-ffa450edef68

5 years ago#63047 - Make POILogger subclassable
Andreas Beeker [Mon, 31 Dec 2018 12:07:37 +0000 (12:07 +0000)]
#63047 - Make POILogger subclassable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850040 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdjust test for bug 60460 to also run fine on Windows
Dominik Stadler [Mon, 31 Dec 2018 09:05:05 +0000 (09:05 +0000)]
Adjust test for bug 60460 to also run fine on Windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850022 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 60460: Handle null workbook or sheet names and emit #REF as Excel does
Dominik Stadler [Sun, 30 Dec 2018 22:44:40 +0000 (22:44 +0000)]
Bug 60460: Handle null workbook or sheet names and emit #REF as Excel does
instead of throwing NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850008 13f79535-47bb-0310-9956-ffa450edef68

5 years agoIDE and JavaDoc fixes
Dominik Stadler [Sun, 30 Dec 2018 22:44:29 +0000 (22:44 +0000)]
IDE and JavaDoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850007 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL: Disable XMLBeans-JDK-11 as it will not work yet
Dominik Stadler [Sun, 30 Dec 2018 10:07:56 +0000 (10:07 +0000)]
Jenkins DSL: Disable XMLBeans-JDK-11 as it will not work yet

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849970 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 60845: Apply patch and adjust tests
Dominik Stadler [Sun, 30 Dec 2018 10:07:52 +0000 (10:07 +0000)]
Bug 60845: Apply patch and adjust tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849969 13f79535-47bb-0310-9956-ffa450edef68

5 years agoIDE and JavaDoc fixes, make base test classes abstract
Dominik Stadler [Sun, 30 Dec 2018 10:07:42 +0000 (10:07 +0000)]
IDE and JavaDoc fixes, make base test classes abstract

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849968 13f79535-47bb-0310-9956-ffa450edef68

5 years ago #63028 - Provide font embedding for slideshows
Andreas Beeker [Fri, 28 Dec 2018 23:43:31 +0000 (23:43 +0000)]
 #63028 - Provide font embedding for slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849898 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd Enum method to help identifying unknown records with POI-Visualizer
Andreas Beeker [Fri, 28 Dec 2018 23:42:57 +0000 (23:42 +0000)]
Add Enum method to help identifying unknown records with POI-Visualizer

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849897 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix Javadocs
Andreas Beeker [Fri, 28 Dec 2018 23:42:44 +0000 (23:42 +0000)]
Fix Javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849896 13f79535-47bb-0310-9956-ffa450edef68

5 years agoZero out garbage bytes in FontEntityAtom
Andreas Beeker [Fri, 28 Dec 2018 23:42:31 +0000 (23:42 +0000)]
Zero out garbage bytes in FontEntityAtom

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849895 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL for Github PR build: Try to create the one file which is read from src...
Dominik Stadler [Fri, 28 Dec 2018 21:43:49 +0000 (21:43 +0000)]
Jenkins DSL for Github PR build: Try to create the one file which is read from src/documentation during target 'jenkins'

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849887 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL: enable Github PR builds, it seems to be functional now
Dominik Stadler [Fri, 28 Dec 2018 20:27:45 +0000 (20:27 +0000)]
Jenkins DSL: enable Github PR builds, it seems to be functional now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849885 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJenkins DSL: throttle Github PR builds to not run many at once
Dominik Stadler [Fri, 28 Dec 2018 20:19:58 +0000 (20:19 +0000)]
Jenkins DSL: throttle Github PR builds to not run many at once

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849884 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRun Cell-tests on HSSF as well and make handling of null-values consistent across...
Dominik Stadler [Fri, 28 Dec 2018 19:53:13 +0000 (19:53 +0000)]
Run Cell-tests on HSSF as well and make handling of null-values consistent across implementations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849881 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 61532: Fix setting values/types during formula evaluation for SXSSF
Dominik Stadler [Fri, 28 Dec 2018 19:53:03 +0000 (19:53 +0000)]
Bug 61532: Fix setting values/types during formula evaluation for SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849880 13f79535-47bb-0310-9956-ffa450edef68

5 years agoUse normal string parameter for now
Dominik Stadler [Fri, 28 Dec 2018 19:52:54 +0000 (19:52 +0000)]
Use normal string parameter for now

Plugin for gitParam is not installed in the Apache Jenkins instance

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849879 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd test which verifies that bug 61605 is already fixed
Dominik Stadler [Fri, 28 Dec 2018 19:52:46 +0000 (19:52 +0000)]
Add test which verifies that bug 61605 is already fixed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849878 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd XMLBeans jobs for JDK 8 and 11.
Dominik Stadler [Fri, 28 Dec 2018 11:17:57 +0000 (11:17 +0000)]
Add XMLBeans jobs for JDK 8 and 11.
Add initial version of Jenkins DSL for the Github-PullRequest build-job

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849838 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdjust test to not require src/documentation to be available
Dominik Stadler [Fri, 28 Dec 2018 11:17:52 +0000 (11:17 +0000)]
Adjust test to not require src/documentation to be available

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849837 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdjust/enhance tests for bug 62275 some more
Dominik Stadler [Fri, 28 Dec 2018 11:17:46 +0000 (11:17 +0000)]
Adjust/enhance tests for bug 62275 some more

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849836 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62629: Allow to handle files with invalid content types for pictures
Dominik Stadler [Thu, 27 Dec 2018 20:51:48 +0000 (20:51 +0000)]
Bug 62629: Allow to handle files with invalid content types for pictures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849814 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRe-instate two dev-tools that we lost in some refactoring,
Dominik Stadler [Thu, 27 Dec 2018 20:51:38 +0000 (20:51 +0000)]
Re-instate two dev-tools that we lost in some refactoring,

at least OOXMLPrettyPrint is still very useful for comparing ooxml-files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849813 13f79535-47bb-0310-9956-ffa450edef68

5 years agoIDE and JavaDoc fixes, close() in tests
Dominik Stadler [Thu, 27 Dec 2018 20:51:31 +0000 (20:51 +0000)]
IDE and JavaDoc fixes, close() in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849812 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd some simple coverage of HSLF-Dev-Tools
Dominik Stadler [Wed, 26 Dec 2018 13:28:32 +0000 (13:28 +0000)]
Add some simple coverage of HSLF-Dev-Tools

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849765 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62839: Adjust MathX.floor() to handle negative values the same
Dominik Stadler [Wed, 26 Dec 2018 13:28:17 +0000 (13:28 +0000)]
Bug 62839: Adjust MathX.floor() to handle negative values the same
way as Excel/LibreOffice

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849764 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix various IDE warnings and some JavaDoc adjustments
Dominik Stadler [Wed, 26 Dec 2018 13:28:10 +0000 (13:28 +0000)]
Fix various IDE warnings and some JavaDoc adjustments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849763 13f79535-47bb-0310-9956-ffa450edef68

5 years agoFix incorrect constant for pict-files
Dominik Stadler [Wed, 26 Dec 2018 13:27:56 +0000 (13:27 +0000)]
Fix incorrect constant for pict-files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849762 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRemove unnecesssary semicolons
Dominik Stadler [Wed, 26 Dec 2018 13:27:50 +0000 (13:27 +0000)]
Remove unnecesssary semicolons

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849761 13f79535-47bb-0310-9956-ffa450edef68

5 years agoSimplify some string operations
Dominik Stadler [Wed, 26 Dec 2018 13:27:35 +0000 (13:27 +0000)]
Simplify some string operations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68

5 years agoJavaDoc fixes/additions and some IDE warnings removed
Dominik Stadler [Tue, 25 Dec 2018 10:00:21 +0000 (10:00 +0000)]
JavaDoc fixes/additions and some IDE warnings removed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849718 13f79535-47bb-0310-9956-ffa450edef68

5 years agoBug 62884: sheetnum is not checked in InternalWorkbook.setSheetHidden()
Dominik Stadler [Tue, 25 Dec 2018 10:00:07 +0000 (10:00 +0000)]
Bug 62884: sheetnum is not checked in InternalWorkbook.setSheetHidden()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849717 13f79535-47bb-0310-9956-ffa450edef68

5 years agoCode-style: Unify how arrays are specified from C-style to normal Java-style
Dominik Stadler [Tue, 25 Dec 2018 09:59:58 +0000 (09:59 +0000)]
Code-style: Unify how arrays are specified from C-style to normal Java-style

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849716 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd more file-leak exlcudes for the mass regression testing
Dominik Stadler [Tue, 25 Dec 2018 09:58:42 +0000 (09:58 +0000)]
Add more file-leak exlcudes for the mass regression testing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849715 13f79535-47bb-0310-9956-ffa450edef68

5 years agofix old xerces errors because of not available disallow-doctype parser feature
Andreas Beeker [Wed, 19 Dec 2018 19:14:55 +0000 (19:14 +0000)]
fix old xerces errors because of not available disallow-doctype parser feature

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849336 13f79535-47bb-0310-9956-ffa450edef68

5 years agoRework test somewhat and enable logger to better indicate if the test is
Dominik Stadler [Wed, 19 Dec 2018 10:22:01 +0000 (10:22 +0000)]
Rework test somewhat and enable logger to better indicate if the test is
failing because JDK options are missing with JDK >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849287 13f79535-47bb-0310-9956-ffa450edef68

5 years agoOne more file-leak-detector exclude
Dominik Stadler [Wed, 19 Dec 2018 10:20:39 +0000 (10:20 +0000)]
One more file-leak-detector exclude

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849286 13f79535-47bb-0310-9956-ffa450edef68

5 years agoAdd missing jacoco-lib to test-scratchpad
Dominik Stadler [Wed, 19 Dec 2018 09:40:34 +0000 (09:40 +0000)]
Add missing jacoco-lib to test-scratchpad
Remove some xmlns that are not needed any more now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849280 13f79535-47bb-0310-9956-ffa450edef68

5 years ago#62886 - Regression extracting text from corrupted docx files
Andreas Beeker [Tue, 18 Dec 2018 23:55:58 +0000 (23:55 +0000)]
#62886 - Regression extracting text from corrupted docx files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849252 13f79535-47bb-0310-9956-ffa450edef68

5 years agofix index check in HemfDraw
PJ Fanning [Tue, 18 Dec 2018 23:26:49 +0000 (23:26 +0000)]
fix index check in HemfDraw

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849250 13f79535-47bb-0310-9956-ffa450edef68

5 years ago#63017 - Remove rows from a XSLFTable
Andreas Beeker [Tue, 18 Dec 2018 23:13:59 +0000 (23:13 +0000)]
#63017 - Remove rows from a XSLFTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849248 13f79535-47bb-0310-9956-ffa450edef68

5 years ago#63017 - Remove rows from a XSLFTable
Andreas Beeker [Tue, 18 Dec 2018 22:52:36 +0000 (22:52 +0000)]
#63017 - Remove rows from a XSLFTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849244 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[github-137] solves/unifies blank/missing value colection for PRODUCT/MDETERM/GEOMEAN...
PJ Fanning [Tue, 18 Dec 2018 21:16:25 +0000 (21:16 +0000)]
[github-137] solves/unifies blank/missing value colection for PRODUCT/MDETERM/GEOMEAN. Thanks to gallonfizik. This closes #137

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849237 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[bug-63013] add XWPFRun setLang method
PJ Fanning [Tue, 18 Dec 2018 08:12:42 +0000 (08:12 +0000)]
[bug-63013] add XWPFRun setLang method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849152 13f79535-47bb-0310-9956-ffa450edef68

5 years agoonly refactorings to break up the long method
Andreas Beeker [Mon, 17 Dec 2018 22:29:03 +0000 (22:29 +0000)]
only refactorings to break up the long method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849130 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[bug-63005] ignore openxml4j/ContentTypeHasEntities.ooxml
PJ Fanning [Mon, 17 Dec 2018 20:57:52 +0000 (20:57 +0000)]
[bug-63005] ignore openxml4j/ContentTypeHasEntities.ooxml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849128 13f79535-47bb-0310-9956-ffa450edef68

5 years agolgtm issues: potential index out of bounds exceptions
PJ Fanning [Mon, 17 Dec 2018 20:41:38 +0000 (20:41 +0000)]
lgtm issues: potential index out of bounds exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849127 13f79535-47bb-0310-9956-ffa450edef68

5 years ago[bug-63005] disable the reading of DTDs altogether
PJ Fanning [Mon, 17 Dec 2018 19:06:31 +0000 (19:06 +0000)]
[bug-63005] disable the reading of DTDs altogether

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849123 13f79535-47bb-0310-9956-ffa450edef68

5 years agochanged to bouncer pattern - to match also the rest of the code
Andreas Beeker [Mon, 17 Dec 2018 10:36:22 +0000 (10:36 +0000)]
changed to bouncer pattern - to match also the rest of the code
see https://softwareengineering.stackexchange.com/questions/18454/should-i-return-from-a-function-early-or-use-an-if-statement

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849074 13f79535-47bb-0310-9956-ffa450edef68

5 years agoadd null check in XLSFPictureShape
PJ Fanning [Mon, 17 Dec 2018 09:17:29 +0000 (09:17 +0000)]
add null check in XLSFPictureShape

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849069 13f79535-47bb-0310-9956-ffa450edef68

5 years agouse spaces for indents
PJ Fanning [Mon, 17 Dec 2018 09:11:06 +0000 (09:11 +0000)]
use spaces for indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849067 13f79535-47bb-0310-9956-ffa450edef68

5 years agofix junit tests
Andreas Beeker [Sun, 16 Dec 2018 21:25:57 +0000 (21:25 +0000)]
fix junit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849047 13f79535-47bb-0310-9956-ffa450edef68

5 years ago#62365 - SVG image support in XSLF
Andreas Beeker [Sun, 16 Dec 2018 21:02:01 +0000 (21:02 +0000)]
#62365 - SVG image support in XSLF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849046 13f79535-47bb-0310-9956-ffa450edef68

5 years agofix findbugs issue
PJ Fanning [Sun, 16 Dec 2018 20:07:23 +0000 (20:07 +0000)]
fix findbugs issue

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849044 13f79535-47bb-0310-9956-ffa450edef68

5 years agoadd missing license
PJ Fanning [Sun, 16 Dec 2018 19:50:59 +0000 (19:50 +0000)]
add missing license

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849043 13f79535-47bb-0310-9956-ffa450edef68