]> source.dussan.org Git - sonarqube.git/log
sonarqube.git
12 years agoRemove unused private method
Simon Brandhof [Thu, 2 Feb 2012 08:44:46 +0000 (09:44 +0100)]
Remove unused private method

12 years agoRemove executable flag from source files
Evgeny Mandrikov [Wed, 1 Feb 2012 22:49:06 +0000 (02:49 +0400)]
Remove executable flag from source files

12 years agoFix violations
Evgeny Mandrikov [Wed, 1 Feb 2012 22:08:05 +0000 (02:08 +0400)]
Fix violations

12 years agoFirst shot to improve documentation of Metric API
Fabrice Bellingard [Wed, 1 Feb 2012 18:15:08 +0000 (19:15 +0100)]
First shot to improve documentation of Metric API

=> Mostly, Metric.Builder had to be improved as it is the preferred
   way to create metric definitions.

12 years agoSONAR-3228 Set the wieghted_violations metric's best value to 0
Fabrice Bellingard [Tue, 31 Jan 2012 16:53:02 +0000 (17:53 +0100)]
SONAR-3228 Set the wieghted_violations metric's best value to 0

=> To optimize the number of entries persisted in the DB

12 years agoSONAR-3231 Allow to associate measure with committer
Evgeny Mandrikov [Wed, 1 Feb 2012 14:19:33 +0000 (18:19 +0400)]
SONAR-3231 Allow to associate measure with committer

12 years agoSONAR-3230 Stolen user session
Simon Brandhof [Wed, 1 Feb 2012 13:07:25 +0000 (14:07 +0100)]
SONAR-3230 Stolen user session

12 years agoFix documentation about migration scripts
Evgeny Mandrikov [Tue, 31 Jan 2012 21:33:33 +0000 (01:33 +0400)]
Fix documentation about migration scripts

12 years agoAdd column PROJECT_MEASURES.COMMITTER
Evgeny Mandrikov [Tue, 31 Jan 2012 19:16:27 +0000 (23:16 +0400)]
Add column PROJECT_MEASURES.COMMITTER

12 years agoFix mybatis integration tests on MsSQL
Simon Brandhof [Tue, 31 Jan 2012 17:06:43 +0000 (18:06 +0100)]
Fix mybatis integration tests on MsSQL

12 years agoFix DashboardDaoTest
Simon Brandhof [Tue, 31 Jan 2012 16:31:20 +0000 (17:31 +0100)]
Fix DashboardDaoTest

12 years agoFix compatibility of MyBatis integration tests with Oracle
Simon Brandhof [Tue, 31 Jan 2012 15:44:54 +0000 (16:44 +0100)]
Fix compatibility of MyBatis integration tests with Oracle

12 years agoSONAR-3228 Some metrics are not persisted if value 0
Fabrice Bellingard [Tue, 31 Jan 2012 15:06:20 +0000 (16:06 +0100)]
SONAR-3228 Some metrics are not persisted if value 0

=> whereas they can be used in Sonar Web UI

12 years agoRevert invalid comment
Simon Brandhof [Tue, 31 Jan 2012 07:38:57 +0000 (08:38 +0100)]
Revert invalid comment

12 years agoAdd javadoc to Violation#getCommitter
simonbrandhof [Mon, 30 Jan 2012 20:57:21 +0000 (21:57 +0100)]
Add javadoc to Violation#getCommitter

12 years agoSONAR-3104 Fix bug and improve element IDs to ease ITs
Fabrice Bellingard [Mon, 30 Jan 2012 17:52:50 +0000 (18:52 +0100)]
SONAR-3104 Fix bug and improve element IDs to ease ITs

12 years agoDo not delete snapshots with events
Simon Brandhof [Mon, 30 Jan 2012 16:39:03 +0000 (17:39 +0100)]
Do not delete snapshots with events

12 years agoSONAR-3091 Improve the "Events" widget
Fabrice Bellingard [Mon, 30 Jan 2012 16:17:16 +0000 (17:17 +0100)]
SONAR-3091 Improve the "Events" widget

=> The "Events" widget should not display events on snapshots which
   are about to be deleted

12 years agoSONAR-3104 Improve the usability of the project 'History' page
Fabrice Bellingard [Mon, 30 Jan 2012 14:38:17 +0000 (15:38 +0100)]
SONAR-3104 Improve the usability of the project 'History' page

- Display create/edit/delete action links only when mouse is over the
  line

12 years agoSONAR-3104 Improve the usability of the project 'History'
Fabrice Bellingard [Mon, 30 Jan 2012 14:14:53 +0000 (15:14 +0100)]
SONAR-3104 Improve the usability of the project 'History'

=> Remove the ability to add & edit event categories (admin page
removal)

12 years agoSONAR-3104 Improve the usability of the project 'History' page
Fabrice Bellingard [Mon, 30 Jan 2012 14:09:04 +0000 (15:09 +0100)]
SONAR-3104 Improve the usability of the project 'History' page

- Remove possibility to specify an event category
- And then simplify the UI consequently

12 years agoSONAR-3104 Improve the usability of the project 'History'
Fabrice Bellingard [Mon, 30 Jan 2012 10:57:47 +0000 (11:57 +0100)]
SONAR-3104 Improve the usability of the project 'History'

- Add row highlighting
- Reorder columns
- Remove date duplication

12 years agoSONAR-2807 fix support of period cleaner over multiple years
Simon Brandhof [Mon, 30 Jan 2012 12:01:19 +0000 (13:01 +0100)]
SONAR-2807 fix support of period cleaner over multiple years

12 years agoMerge remote branch 'upstream/master'
Fabrice Bellingard [Fri, 27 Jan 2012 16:02:25 +0000 (17:02 +0100)]
Merge remote branch 'upstream/master'

12 years agoSONAR-3206 Can not delete snapshot from history
Fabrice Bellingard [Fri, 27 Jan 2012 16:01:38 +0000 (17:01 +0100)]
SONAR-3206 Can not delete snapshot from history

Fix regression introduced in Sonar 2.13

12 years agoSONAR-2757 extract purge task into a dedicated component
Simon Brandhof [Fri, 27 Jan 2012 15:48:54 +0000 (16:48 +0100)]
SONAR-2757 extract purge task into a dedicated component

12 years agoSONAR-2757 purge errors should not fail the build
Simon Brandhof [Fri, 27 Jan 2012 10:22:45 +0000 (11:22 +0100)]
SONAR-2757 purge errors should not fail the build

12 years agoSONAR-2757 do not delete events on profile changes
Simon Brandhof [Fri, 27 Jan 2012 09:40:00 +0000 (10:40 +0100)]
SONAR-2757 do not delete events on profile changes

12 years agoSONAR-2757 improve reentrance of project deletion
simonbrandhof [Thu, 26 Jan 2012 22:13:09 +0000 (23:13 +0100)]
SONAR-2757 improve reentrance of project deletion

12 years agoSONAR-3139 Fix wrong refactoring
Evgeny Mandrikov [Thu, 26 Jan 2012 22:01:44 +0000 (02:01 +0400)]
SONAR-3139 Fix wrong refactoring

12 years agoSONAR-3139 Remove deprecated code, add some comments and tests
Evgeny Mandrikov [Thu, 26 Jan 2012 17:52:24 +0000 (21:52 +0400)]
SONAR-3139 Remove deprecated code, add some comments and tests

12 years agoDBCleaner : fix deletion of events + improve mybatis batch mode
Simon Brandhof [Thu, 26 Jan 2012 18:46:20 +0000 (19:46 +0100)]
DBCleaner : fix deletion of events + improve mybatis batch mode

12 years agoFix profile for mybatis integration tests
Simon Brandhof [Thu, 26 Jan 2012 18:16:00 +0000 (19:16 +0100)]
Fix profile for mybatis integration tests

12 years agoSONAR-3181 Fix NPE
Evgeny Mandrikov [Thu, 26 Jan 2012 17:00:32 +0000 (21:00 +0400)]
SONAR-3181 Fix NPE

12 years agoSONAR-1960 DBCleaner properties should be expressed in weeks instead of months
Simon Brandhof [Thu, 26 Jan 2012 17:14:17 +0000 (18:14 +0100)]
SONAR-1960 DBCleaner properties should be expressed in weeks instead of months

12 years agoSONAR-2807 + SONAR-3219 : improve the DBCleaner plugin
Simon Brandhof [Thu, 26 Jan 2012 16:16:49 +0000 (17:16 +0100)]
SONAR-2807 + SONAR-3219 : improve the DBCleaner plugin

* Delete all the wasted data. Some snapshots have been ignored
* Keep a single snapshot per day

12 years agoSONAR-2124 Show difference when rules in derived profiles are changed
Fabrice Bellingard [Thu, 26 Jan 2012 16:06:05 +0000 (17:06 +0100)]
SONAR-2124 Show difference when rules in derived profiles are changed

=> show when the severity has changed

12 years agoSONAR-1492 Remove parameter list in rule description popup window
Fabrice Bellingard [Thu, 26 Jan 2012 10:19:59 +0000 (11:19 +0100)]
SONAR-1492 Remove parameter list in rule description popup window

12 years agoSONAR-3181,SONAR-3139 Allow filtering by number of tokens
Evgeny Mandrikov [Wed, 25 Jan 2012 15:07:33 +0000 (19:07 +0400)]
SONAR-3181,SONAR-3139 Allow filtering by number of tokens

To do this each block stores two additional integers - index for first
and last token. So total size of in-memory storage has been increased.

12 years agoSONAR-2124 Fix some issues
Fabrice Bellingard [Thu, 26 Jan 2012 09:48:05 +0000 (10:48 +0100)]
SONAR-2124 Fix some issues

12 years agoAdd lines accidentally removed by Simon
Fabrice Bellingard [Thu, 26 Jan 2012 09:34:24 +0000 (10:34 +0100)]
Add lines accidentally removed by Simon

12 years agoSONAR-2061 add the flag Metric#deleteHistoricalData. Default value is false.
Simon Brandhof [Wed, 25 Jan 2012 18:26:18 +0000 (19:26 +0100)]
SONAR-2061 add the flag Metric#deleteHistoricalData. Default value is false.

* New column METRICS.DELETE_HISTORICAL_DATA (boolean, nullable)
* Hidden core metrics and some data metrics have this new field to true

12 years agoSONAR-2124 Show difference when rules in derived profiles are changed
Fabrice Bellingard [Wed, 25 Jan 2012 18:01:07 +0000 (19:01 +0100)]
SONAR-2124 Show difference when rules in derived profiles are changed

+ link to the rules that has been overriden
+ UI improvements

12 years agoSONAR-2757 close reviews when disabling resources + add unit tests
Simon Brandhof [Wed, 25 Jan 2012 17:15:52 +0000 (18:15 +0100)]
SONAR-2757 close reviews when disabling resources + add unit tests

12 years agoSONAR-2757 Refactor the purge mechanisms to prevent any fullscan SQL requests on...
Simon Brandhof [Wed, 25 Jan 2012 16:38:50 +0000 (17:38 +0100)]
SONAR-2757 Refactor the purge mechanisms to prevent any fullscan SQL requests on snapshots table

12 years agoSONAR-1492 Don't display edit/delete links if not admin
Fabrice Bellingard [Wed, 25 Jan 2012 15:14:05 +0000 (16:14 +0100)]
SONAR-1492 Don't display edit/delete links if not admin

12 years agoSONAR-1492 Improve rendering
Fabrice Bellingard [Wed, 25 Jan 2012 11:21:06 +0000 (12:21 +0100)]
SONAR-1492 Improve rendering

12 years agoSONAR-3081 Add cleared violations count on the "Rules" widget
Fabrice Bellingard [Wed, 25 Jan 2012 10:32:44 +0000 (11:32 +0100)]
SONAR-3081 Add cleared violations count on the "Rules" widget

12 years agoSONAR-3012 Improvements
Fabrice Bellingard [Wed, 25 Jan 2012 09:11:50 +0000 (10:11 +0100)]
SONAR-3012 Improvements

12 years agoSONAR-1492 Improve rule & active rule edition page
Fabrice Bellingard [Tue, 24 Jan 2012 18:19:20 +0000 (19:19 +0100)]
SONAR-1492 Improve rule & active rule edition page

+ use markdown instead of HTML
+ improve rule doc page

12 years agoSONAR-3181,SONAR-3139 Enable cross project CPD for all languages
Evgeny Mandrikov [Tue, 24 Jan 2012 13:17:59 +0000 (17:17 +0400)]
SONAR-3181,SONAR-3139 Enable cross project CPD for all languages

sonar.cpd.minimumTokens can't be used, because for index in database
tokens must be grouped by lines.

12 years agoSONAR-2754 rename the parameter to sonar.dbcleaner.cleanDirectory
simonbrandhof [Tue, 24 Jan 2012 13:44:53 +0000 (14:44 +0100)]
SONAR-2754 rename the parameter to sonar.dbcleaner.cleanDirectory

12 years agoMove some purge tasks to MyBatis
simonbrandhof [Tue, 24 Jan 2012 13:40:27 +0000 (14:40 +0100)]
Move some purge tasks to MyBatis

SONAR-2754 add the parameter sonar.dbcleaner.cleanDirectoryHistory
SONAR-2757 remove fullscan requests on the table SNAPSHOTS

12 years agoSONAR-3171 Space missing in drilldown description
Fabrice Bellingard [Tue, 24 Jan 2012 12:02:36 +0000 (13:02 +0100)]
SONAR-3171 Space missing in drilldown description

12 years agoSONAR-3198 Can't set the due date to the current day
Fabrice Bellingard [Tue, 24 Jan 2012 11:41:02 +0000 (12:41 +0100)]
SONAR-3198 Can't set the due date to the current day

12 years agoSONAR-3201 Display the icon on the first sorted column
Fabrice Bellingard [Tue, 24 Jan 2012 11:27:45 +0000 (12:27 +0100)]
SONAR-3201 Display the icon on the first sorted column

12 years agoSONAR-3200 Display the date of closure on the closed action plan list
Fabrice Bellingard [Tue, 24 Jan 2012 10:54:43 +0000 (11:54 +0100)]
SONAR-3200 Display the date of closure on the closed action plan list

12 years agoSONAR-1492 Allow notes per quality rule
Fabrice Bellingard [Tue, 24 Jan 2012 09:56:40 +0000 (10:56 +0100)]
SONAR-1492 Allow notes per quality rule

Fix some issues

12 years agoSONAR-3205 Upgrade to JaCoCo 0.5.6
Evgeny Mandrikov [Tue, 24 Jan 2012 05:54:11 +0000 (09:54 +0400)]
SONAR-3205 Upgrade to JaCoCo 0.5.6

12 years agoSONAR-3138 Prevent possible security flaws
Evgeny Mandrikov [Tue, 24 Jan 2012 05:21:30 +0000 (09:21 +0400)]
SONAR-3138 Prevent possible security flaws

* Save external password only if enabled "sonar.security.savePassword".
* Bypass restriction on password length (4), when external system enabled.
* Improve error handling.

12 years agoSONAR-1492 Allow notes per quality rule
Fabrice Bellingard [Mon, 23 Jan 2012 18:20:47 +0000 (19:20 +0100)]
SONAR-1492 Allow notes per quality rule

=> Improve the display of rules with notes and parameters

12 years agoSONAR-1492 Allow notes per quality rule
Fabrice Bellingard [Mon, 23 Jan 2012 17:03:19 +0000 (18:03 +0100)]
SONAR-1492 Allow notes per quality rule

Admin page implemented

12 years agoSONAR-1492 Allow notes per quality rule
Fabrice Bellingard [Fri, 20 Jan 2012 09:56:56 +0000 (10:56 +0100)]
SONAR-1492 Allow notes per quality rule

=> DB stuff & Ruby models implemented

12 years agoSONAR-3139 Enable Sonar CPD by default
Evgeny Mandrikov [Fri, 20 Jan 2012 12:46:47 +0000 (16:46 +0400)]
SONAR-3139 Enable Sonar CPD by default

12 years agoSONAR-3012 Fix bug on Derby in filters on violations resource tab
Fabrice Bellingard [Fri, 20 Jan 2012 14:08:28 +0000 (15:08 +0100)]
SONAR-3012 Fix bug on Derby in filters on violations resource tab

12 years agoSONAR-3081 "Violations" widget shows the number of "new violations"
Fabrice Bellingard [Fri, 20 Jan 2012 10:44:54 +0000 (11:44 +0100)]
SONAR-3081 "Violations" widget shows the number of "new violations"

And links it to the drilldown service using the correct metric to
easily find new violations.

12 years agoSONAR-3012 Improve widget rendering
Fabrice Bellingard [Fri, 20 Jan 2012 10:33:25 +0000 (11:33 +0100)]
SONAR-3012 Improve widget rendering

- 2 columns instead of 3
- "On new code" just below "unreviewed violations"

12 years agoSONAR-3179 Use naming convention for localization of qualifiers
Evgeny Mandrikov [Thu, 19 Jan 2012 15:15:43 +0000 (19:15 +0400)]
SONAR-3179 Use naming convention for localization of qualifiers

Change localization for "qualifier.BRK" from "Module" to "Sub-project".

12 years agoSONAR-2757 add the column SNAPSHOTS.PURGE_STATUS (INTEGER)
Simon Brandhof [Thu, 19 Jan 2012 14:52:52 +0000 (15:52 +0100)]
SONAR-2757 add the column SNAPSHOTS.PURGE_STATUS (INTEGER)

12 years agoRemove unused icons + fix 1 violation
Fabrice Bellingard [Thu, 19 Jan 2012 10:40:09 +0000 (11:40 +0100)]
Remove unused icons + fix 1 violation

12 years agoSONAR-3185 Set default value of 'sonar.authenticator.createUsers' to true
Evgeny Mandrikov [Thu, 19 Jan 2012 12:25:11 +0000 (16:25 +0400)]
SONAR-3185 Set default value of 'sonar.authenticator.createUsers' to true

12 years agoSONAR-3012 Fix regression on the filter of the violations viewer
Fabrice Bellingard [Thu, 19 Jan 2012 10:25:16 +0000 (11:25 +0100)]
SONAR-3012 Fix regression on the filter of the violations viewer

12 years agoFix some minor violations
Simon Brandhof [Thu, 19 Jan 2012 10:20:29 +0000 (11:20 +0100)]
Fix some minor violations

12 years agoFix compatibility of FieldUtilsTest with Jacoco
simonbrandhof [Wed, 18 Jan 2012 22:19:49 +0000 (23:19 +0100)]
Fix compatibility of FieldUtilsTest with Jacoco

12 years agoMerge branch 'SONAR-3129'
Evgeny Mandrikov [Wed, 18 Jan 2012 22:01:58 +0000 (02:01 +0400)]
Merge branch 'SONAR-3129'

12 years agoSONAR-3129 Fix selection of columns for filter, when language not english
Evgeny Mandrikov [Wed, 18 Jan 2012 21:24:41 +0000 (01:24 +0400)]
SONAR-3129 Fix selection of columns for filter, when language not english

12 years agoSONAR-1707 feed the column SNAPSHOTS.BUILD_DATE on files and directories
Simon Brandhof [Wed, 18 Jan 2012 17:07:21 +0000 (18:07 +0100)]
SONAR-1707 feed the column SNAPSHOTS.BUILD_DATE on files and directories

12 years agoSONAR-3180 Remove the support of AJP connector
Simon Brandhof [Wed, 18 Jan 2012 17:06:36 +0000 (18:06 +0100)]
SONAR-3180 Remove the support of AJP connector

12 years agoSONAR-3112 Metrics 'test_errors' and 'skipped_tests' should be qualitative
Evgeny Mandrikov [Wed, 18 Jan 2012 16:56:15 +0000 (20:56 +0400)]
SONAR-3112 Metrics 'test_errors' and 'skipped_tests' should be qualitative

12 years agoFix javascript on the timemachine page
Simon Brandhof [Wed, 18 Jan 2012 16:22:09 +0000 (17:22 +0100)]
Fix javascript on the timemachine page

12 years agoRemove some useless database migrations because upgrade from 1.x to 2.x is not supported
Simon Brandhof [Wed, 18 Jan 2012 16:16:35 +0000 (17:16 +0100)]
Remove some useless database migrations because upgrade from 1.x to 2.x is not supported

12 years agoAdd missing sonar versions to database scripts
Simon Brandhof [Wed, 18 Jan 2012 15:46:43 +0000 (16:46 +0100)]
Add missing sonar versions to database scripts

12 years agoSONAR-1707 Add the column SNAPSHOTS.BUILD_DATE
Simon Brandhof [Wed, 18 Jan 2012 15:45:45 +0000 (16:45 +0100)]
SONAR-1707 Add the column SNAPSHOTS.BUILD_DATE

12 years agoSONAR-3051 support POST, PUT and DELETE queries in GWT API.
Simon Brandhof [Tue, 17 Jan 2012 14:54:01 +0000 (15:54 +0100)]
SONAR-3051 support POST, PUT and DELETE queries in GWT API.

This patch is gracefully provided by Eugene Zadyra.

12 years agoSONAR-3179 Allow to declare resources which can be used for filters
Evgeny Mandrikov [Wed, 18 Jan 2012 12:23:16 +0000 (16:23 +0400)]
SONAR-3179 Allow to declare resources which can be used for filters

12 years agoSONAR-3012 Use the "Active" word in all widgets to be consistent
Fabrice Bellingard [Wed, 18 Jan 2012 15:42:13 +0000 (16:42 +0100)]
SONAR-3012 Use the "Active" word in all widgets to be consistent

12 years agoSONAR-3012 Add filters for reviews on the violations viewer
Fabrice Bellingard [Wed, 18 Jan 2012 15:09:53 +0000 (16:09 +0100)]
SONAR-3012 Add filters for reviews on the violations viewer

And make sure that when someone comes from the drilldown with a
review metric, then the filter is set to the correct value

12 years agoSONAR-3179 Fix mistake
Evgeny Mandrikov [Wed, 18 Jan 2012 13:48:57 +0000 (17:48 +0400)]
SONAR-3179 Fix mistake

12 years agoSONAR-3179 Add API to define resources
Evgeny Mandrikov [Wed, 18 Jan 2012 12:23:09 +0000 (16:23 +0400)]
SONAR-3179 Add API to define resources

12 years agoSONAR-2907 Fix loading of settings from database, when used property 'sonar.branch'
Evgeny Mandrikov [Tue, 17 Jan 2012 15:21:43 +0000 (19:21 +0400)]
SONAR-2907 Fix loading of settings from database, when used property 'sonar.branch'

12 years agoSONAR-3012 Remove local path to the Ruby template
Fabrice Bellingard [Wed, 18 Jan 2012 09:00:39 +0000 (10:00 +0100)]
SONAR-3012 Remove local path to the Ruby template

12 years agoRemove executable flag for files with images
Evgeny Mandrikov [Tue, 17 Jan 2012 20:48:58 +0000 (00:48 +0400)]
Remove executable flag for files with images

12 years agoRemove dependency that should have not been committed.
Fabrice Bellingard [Tue, 17 Jan 2012 16:49:31 +0000 (17:49 +0100)]
Remove dependency that should have not been committed.

12 years agoSONAR-3012 Shows the new unreviewed violations count in the widget
Fabrice Bellingard [Tue, 17 Jan 2012 16:45:30 +0000 (17:45 +0100)]
SONAR-3012 Shows the new unreviewed violations count in the widget

- Links this count to the drilldown service
- Open the right tab (Violations)

+ renaming of the metrics to be consistent with names

To be done: adding a filter in the "Violations" Tab

12 years agoSONAR-3176 Complete documentation of differential views properties
Simon Brandhof [Tue, 17 Jan 2012 13:04:57 +0000 (14:04 +0100)]
SONAR-3176 Complete documentation of differential views properties

12 years agoSONAR-3175 Document the constraint on number of JAR files in jdbc-driver directories
Simon Brandhof [Tue, 17 Jan 2012 11:55:04 +0000 (12:55 +0100)]
SONAR-3175 Document the constraint on number of JAR files in jdbc-driver directories

12 years agoSONAR-2994 Add missing localization for 'Sign Up' and 'Log In' pages
Evgeny Mandrikov [Tue, 17 Jan 2012 11:18:55 +0000 (15:18 +0400)]
SONAR-2994 Add missing localization for 'Sign Up' and 'Log In' pages

12 years agoSONAR-2940 Filters: Unable to sort the "language" column on both ways
Fabrice Bellingard [Tue, 17 Jan 2012 11:37:46 +0000 (12:37 +0100)]
SONAR-2940 Filters: Unable to sort the "language" column on both ways

12 years agoFix development mode of webapp + remove useless files
Simon Brandhof [Tue, 17 Jan 2012 11:28:48 +0000 (12:28 +0100)]
Fix development mode of webapp + remove useless files

12 years agoCalling Field.setAccessible(true) is accepted here -> not a quality flaw
Simon Brandhof [Mon, 16 Jan 2012 16:19:55 +0000 (17:19 +0100)]
Calling Field.setAccessible(true) is accepted here -> not a quality flaw