fix(tests): Fix most obvious errors in ObjectStore tests

Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

perf(ObjectStoreStorage): Improve (slow) move on same object bucket

This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>

Merge pull request #48980 from nextcloud/backport/48632/stable29

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48968 from nextcloud/backport/47847/stable29

Merge pull request #48973 from nextcloud/backport/48788/stable29

[stable29] fix: add PasswordConfirmationRequired to the external storages mentioned in review

fix(files): Do not jump to top when fileId is set to currentFolder

Fix https://github.com/nextcloud/server/issues/48545

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix: conflicts resolved by adding PasswordConfirmationRequired to update method

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: cs fix namespace

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: add PasswordConfirmationRequired to the eternal storages mentioned in review

Signed-off-by: yemkareems <yemkareems@gmail.com>

test: add test for nested jail cross-storage move

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix: Fix copying or moving from shared groupfolders

When copying or moving between two local storages the source path (on
disk) to copy or move from is got from the unjailed path of the source
storage. However, if the source storage has more than one jail getting
the unjailed path resolves the most external jail, but the source path
needs to be got from the most internal jail instead (the one closer to
the local storage).

This can happen, for example, with a shared groupfolder: in that case
there is an external jail for the shared storage, and one internal jail
for the groupfolder storage wrapped by the shared storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #48570 from nextcloud/backport/48532/stable29

Merge pull request #48958 from nextcloud/backport/48921/stable29

ci(psalm): Add missing imagick extension

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48889 from nextcloud/backport/48887/stable29

Merge pull request #48934 from nextcloud/backport/48625/stable29

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files_sharing): federated shares avatar

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore(assets): Recompile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

refactor(files): migrate to @nextcloud/sharing

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(files): handle empty view with error

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(files): migrate davUtils to TS

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Merge pull request #48949 from nextcloud/backport/48947/stable29

[stable29] fix(config): Mark more configs as sensitive

Merge pull request #48940 from nextcloud/backport/48915/stable29

[stable29] fix: encrypt and store password, decrypt and retrieve the same

fix(config): Mark more configs as sensitive

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #48944 from nextcloud/backport/48871/stable29

[stable29] fix(app-store): Update update count in navigation

Merge pull request #48936 from nextcloud/backport/48918/stable29

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix: readonly removed

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: crypto added manually as expected

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix(app-store): Update update count in navigation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48922 from nextcloud/backport/48898/stable29

[stable29] fix(files): add title for files list table header button

fix: crypto made inline for constructor and decrypt error handled in exception

Signed-off-by: yemkareems <yemkareems@gmail.com>
[skip ci]

fix: crypto made inline for constructor and decrypt error handled in exception

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: use Icrypto in place of Cypto

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: crypto type made not nullable and tests run using ICrypto

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: encrypt and store password, decrypt and retrieve the same

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix(files_sharing): Cleanup error messages

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48930 from nextcloud/backport/48917/stable29

fix(dav): Cleanup view-only check

Signed-off-by: provokateurin <kate@provokateurin.de>

chore(assets): Recompile assets

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

fix(files): add title for files list table header button

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48905 from nextcloud/dependabot/npm_and_yarn/stable29/jsdoc-4.0.4

chore(deps-dev): Bump jsdoc from 4.0.2 to 4.0.4

Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 4.0.2 to 4.0.4.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/4.0.4/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/4.0.2...4.0.4)

---
updated-dependencies:
- dependency-name: jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48750 from nextcloud/backport/48373/stable29

[stable29] fix: add PasswordConfirmationRequired to create user storages endpoint

fix: cs fix for namespace

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: add PasswordConfirmationRequired to user storages create, update and delete

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: Add frontend code for password confirmation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
[skip ci]

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48857 from nextcloud/backport/48839/stable29

[stable29] build: Print RTL limited characters in translation-checker

build: Show the actual string

Signed-off-by: Joas Schilling <coding@schilljs.com>

build: Print RTL limited characters in translation-checker

Signed-off-by: provokateurin <kate@provokateurin.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48831 from nextcloud/backport/48603/stable29

[stable29] fix(logger): Remove more parameters of other methods

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(logger): Remove more parameters of other methods

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #48825 from nextcloud/backport/48824/stable29

[stable29] ci: Update list of installed PHP extensions (as some are not default …

Merge pull request #48729 from nextcloud/backport/48696/stable29

[stable29] fix(files_sharing): Add proper user facing messages on success

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files_sharing): Add proper user facing messages on success

1. Use proper translated strings
2. Fix invalid use of translation message on API result
3. Log all errors

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48709 from nextcloud/backport/48682/stable29

ci: Update list of installed PHP extensions (as some are not default enabled in new images)

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48817 from nextcloud/backport/48812/stable29

[stable29] fix(activity): Fix download activity parameters

fix(activity): Fix download activity parameters

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48780 from nextcloud/automated/noid/stable29-update-code-signing-crl

[stable29] fix(security): Update code signing revocation list

fix(security): Update code signing revocation list

Signed-off-by: GitHub <noreply@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48755 from nextcloud/backport/48743/stable29

[stable29] fix(appstore): Hide last modified information for shipped apps

fix(appstore): Hide last modified information for shipped apps

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48764 from nextcloud/backport/48539/stable29

[stable29] fix(message): Fix logic of Mail test

Merge pull request #48588 from nextcloud/backport/47896/stable29

[stable29] fix: Make user removal more resilient

fix(message): Fix logic of Mail test

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #48752 from nextcloud/backport/48734/stable29

fix: do not duplicate existing entity

- this reverts 1e8048abee1745bab648dba5bf96f956c718e4e3

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit 6e7c35d77eb85836a35b6b0c8d8ba24829350066)

fix: dismiss notification only after transfer bg job created

- do not create 'denied' notification if bg job exists

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit 5be76411fa9cb9b883ae6c0405b44b3b6bc855e7)

fix: add notification icon for transfer ownership

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit 73b34bba7b70d3296ce8eba633a4d9c61cf01904)

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48239 from nextcloud/backport/47905/stable29

[stable29] fix(files): Ensure children are removed from folder and not duplicated

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): Adjust Typescript issues

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

test(files): Add tests for path handling

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Ensure children are removed from folder and not duplicated

* Resolves https://github.com/nextcloud/server/issues/47904

We need to make sure that we only add one source (unique!) once as a child,
this is ensured by simply use a native `Set`.
Also we need to remove children on from folders when the `files:node:deleted`
event is emitted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48704 from nextcloud/backport/48673/stable29

[stable29] fix(share): Return empty string if no label is set

fix(share): Return empty string if no label is set

* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(UserTrait): Fix backend initialization

Signed-off-by: provokateurin <kate@provokateurin.de>

fix: Skip users that still exist in backend

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix: Make user removal more resilient

Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48617 from nextcloud/backport/48597/stable29

[stable29] Fix email share transfer accross storages