Fabian Lange [Thu, 22 May 2014 22:36:56 +0000 (00:36 +0200)]
Allow inlining of JsonCodec#encode (#13814)
JsonCodec#encode() is a frequently called (hot) method. However in its
current form it is too long to be inlined.
This review reduces the length of the method from 454 bytes instructions
to 311 and optimises flow of common calls.
It however has a behaviour change for esoteric edge cases where the
order would matter. Like a custom collection which extends JSONArray and
implements collection. Previously it would have been handled by the
collection case, now its the JSONArray case. However it can be assumed
that the result: serialized to valid JSON is the same.
Leif Åstrand [Fri, 16 May 2014 08:31:14 +0000 (11:31 +0300)]
Replace use of deprecated DOM.setStyleAttribute method (#13781)
This change is only a brain dead replacement of one specific method. In
some cases, there were some oddities in the surrounding code as well,
but these were left unresolved on purpose.
It should also be noted that DOM.setStyleAttribute just delegates to
element.getStyle().setProperty(), so any null references would have
caused problems already in the existing code.
The UI.pushConnection field is transient no longer; instead PushConnection
implementations must take care of serialization internally. When a session
is serialized, the client should notice that push was disconnected and
try to reconnect. A deserialized PushConnection should be in a "disconnected"
state so the eventual client reconnection works correctly.
cleanConnectorMap is a hot method.
This change improves multiple code paths:
1) The global resource handler is no longer get()ed from the session for
each connector (was in two loops).
2) The ConnectorTracker is no longer get()ed from the UI for each
connector (was in one loop).
3) values() iterator for ClientConnectors replaces
keySet() iterator + get(key) call
4) use getUI() from ClientConnector instead manual method.
5) moved removeUnregisteredConnectors to ease inlining and readability.
getAllChildrenIterable() is invoked frequently, its used by
attach/detach and markAsDirty.
Because of the implementation detail in CombinedIterator, on every call
all iterators are checked. This means that on every component which has
multiple childs, each next() call will first check the extension
iterator, before advancing in the child iterator.
By having the childs first, this overhead is reduced. If no extensions
are existing (which is quite common) the iterator is not added at all.
(creating an iterator on an empty UnmodifiableCollection is waste of
time and memory)
John Ahlroos [Thu, 24 Apr 2014 18:12:15 +0000 (21:12 +0300)]
Allow editing colorpicker values in colorpicker in textfield #13469
This fix adds support for typing in color values according to
http://www.w3schools.com/cssref/css_colors_legal.asp into the
colorpicker popup input textfield.
Manolo Carrasco [Wed, 14 May 2014 10:55:47 +0000 (12:55 +0200)]
Make Hearbeat available to other modules (#13250)
- When a mobile app goes online/offline we need to change
Heartbeat interval and restart the schedule.
- We also need to be notified about response status in
order to show the appropriate offline UI, etc.
Related with Issue #13250 and review https://dev.vaadin.com/review/#/c/3376/
* 77a08ca - (origin/master, origin/HEAD, master) Add missing @sinces to JavaDoc
* 82033e8 - Support long in state again (#13692)
* 2b60bbb - Fix SelectedItemIcon rendering on IE (#13731)
* ee16285 - Support passing multiple versions
* 45226d5 - Mention dnd on IE touch devices in known issues (#13612)
* deeb645 - Added link to ticket for the Firefox reconnect issue (#13612)
* e975af7 - List authors in release notes (#13612)
* 20f5633 - Make SuperDevMode work again (#13682)
* e8f0fe7 - Show badges in release notes (#13612)
* 466883b - Convert test to TB4 to be compatible with Tomcat proxy test
* cd20de5 - Make touch actions disabled on some CSS classes (#13368)
* aab62be - Update sass-compiler to 0.9.2 (#13651)
* 43c1a36 - Update the release-notes (#13612)
* 35c174c - Re-apply old change which was excluded from master
* 67dd382 - Ignore PointerEvents in VDragAndDropManager (#13720)
* 5a4c888 - Rename base on API review (#13557)
* 4bd8314 - Remove ComponentLocator which conflicts with package name (#13729)
* 0970487 - Update ErrorIndicator test from TB2 to TB4
* 1cf11f8 - Resize PopupView's overlay on content resize (#13666)
* 2ecdf7e - Fix table focusing when scrolled from the server (#10522)
The fix to #9379 broke the support for long type fields in state classes. This
patch bypasses the unboxing of long values and adds the @UnsafeNativeLong annotation
to the methods which may fetch and return (without modifying) long values.
SerializerTest is extended to test the different data types in States.
Artur Signell [Sun, 11 May 2014 16:55:27 +0000 (19:55 +0300)]
Make SuperDevMode work again (#13682)
VNotification now works without ApplicationConnection again.
Dependencies needed by codeserver are now dependencies for client-compiler
Error message now takes into account that devModeRedirect is enabled by default
* Removed the "Tools have been updated for Vaadin 7.2 with the following changes:"
* Removed the security fix notice for 7.1.11
* Removed the text about using the experimental Eclipse plug-in
* Specify that 7.2 is a minor release
* Clarified the known issues section
* Listed Windows Phone 8 in supported devices
* Replaced vaadin.com/pro-account with vaadin.com/pro-tools and vaadin.com/support
Artur Signell [Fri, 9 May 2014 10:29:25 +0000 (13:29 +0300)]
Re-apply old change which was excluded from master
The merge script was faulty between May and June 2013 and merged changes
individually from both 7.0 and 7.1 to master. In the case that a commit from
7.0 was merged right before there was a "Merge: no" commit in 7.1, the changes
between the "Merge: no" commit and the previous merge point from 7.1 to master was
potentially never merged (the whole chain was merged as a no-op).
The only affected change seems to be
0a437a5 Revert "Replaced css inject hack in TestUtils with Page.Styles.add() #11798" b008768 Implement parenthesis-handling fixes for Sass in Vaadin 7.1 (#12834)
The former one is re-applied in this commit, the latter one has been verified to be in
the master branch
* 9b3df56 - (origin/master, origin/HEAD, master) Actually close push connection in disconnect() (#13716)
* f21c108 - Fix improper merge of 3d0ff32b from 7.1 to master (#13620)
* 3184af5 - Convert the ComboBoxClosePopupRetainText test to TB4 to avoid false failures.
* b136dd5 - Convert the AccordionClipsContent test to TB4 to avoid false failures.
* 50ea89e - Update Atmosphere client. (#13727)
* 78981f1 - Fix occasionally misplaced error indicators in Buttons (#13723)
* 8fb9121 - Fix misleading message. Close does not always mean reconnect
* 3d42856 - Removed irrelevant readme file
projects / vaadin-framework.git / log