Add unit tests for "OC.Notification.hide()"

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix default timeouts in OC.Notification

When no timeout was given "show()" used the default timeout of
"OCP.Toast", which is 7 seconds instead of indefinitely as stated in the
documentation of "show()". "showHtml()" should also indefinitely show
the notification if no timeout is given, but due to the strict
comparison the notification was indefinitely shown only when a timeout
of 0 was explicitly given. Now both methods show the notification
indefinitely (or until it is explicitly hidden) when no timeout is
given.

The unit tests did not catch this error because "showHtml()" had no
tests (as before the move to Toastify it was called from "show()" and
thus implicitly tested), and because "show()" verified that "hide()" was
not called after some time; "hide()" is no longer called from "show()"
since "OCP.Toast" is used internally, so the test always passed even if
the notification was indeed hidden. Now the test is based on whether the
element is found or not, and explicit tests were added too for
"showHtml()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Fix mixed test for "show" and "showTemporary"

"showTemporary()" when a timeout was given was being tested along with
the "show()" tests; now there are two separate tests when a timeout is
given, one for "showTemporary()" and one for "show()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Check number of elements instead of if the jQuery object is defined

Tje jQuery object created through "$('#testArea .toastify')" will be
always defined even if no elements were found, so the check does not
really work; instead, it should be checked the number of elements found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #16461 from nextcloud/fix/noid/pgsql-version

fixes the check for postgresql

Merge pull request #16542 from nextcloud/dependabot/npm_and_yarn/build/fstream-1.0.12

[Security] Bump fstream from 1.0.11 to 1.0.12 in /build

[tx-robot] updated from transifex

Merge pull request #16532 from nextcloud/bugfix/14776/maxcontrast-fix

Fix max contrast retrieval to limit minimum color for relative time

[Security] Bump fstream from 1.0.11 to 1.0.12 in /build

Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12. **This update includes a security fix.**
- [Release notes](https://github.com/npm/fstream/releases)
- [Commits](https://github.com/npm/fstream/compare/v1.0.11...v1.0.12)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #16503 from nextcloud/bugfix/5504/create_new_birthday_calendars_with_VEVENT_only

allow to provide supported calendar component set internally as a string

Trigger fallback code to get max contrast value and use integer there

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

[tx-robot] updated from transifex

Fix max contrast retrieval to limit minimum color for relative time

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #16528 from nextcloud/shipped-texteditor

Remove files_texteditor from shipped apps

Remove files_texteditor from shipped apps

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #15637 from nextcloud/bugfix/15567/ignore-hidden-share

Allow hidden smb shares

Merge pull request #16523 from nextcloud/bugfix/noid/nested-recursion-breaking-max-nested-level-for-parent-comment

Nested recursion breaking max nested level for parent comment calculation

PHPStorm code cleanup

Signed-off-by: Joas Schilling <coding@schilljs.com>

Get the topmost parent for the parent instead of doing endless recursion

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #16493 from nextcloud/enh/remove-curly-braces

The array and string offset access syntax using curly braces is depre…

[tx-robot] updated from transifex

Merge pull request #16505 from nextcloud/enh/nitpicks-14954

Dont assign $options to $options and cleanup doc

Merge pull request #16514 from nextcloud/dependabot/npm_and_yarn/babel/preset-env-7.5.5

Bump @babel/preset-env from 7.5.4 to 7.5.5

Merge pull request #16492 from nextcloud/enh/exclude-rnd-files

Exclude .rnd files from integrity check

Merge pull request #16497 from nextcloud/dependabot/npm_and_yarn/babel/core-7.5.5

Bump @babel/core from 7.5.4 to 7.5.5

[tx-robot] updated from transifex

Dont assign $options to $options and cleanup doc

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

allow to provide supported calendar component set internally as a string

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Merge pull request #16450 from nextcloud/tech-debt/noid/cleanup-unused-OC_API-methods

Removes unused OC_API::register

Merge pull request #16495 from nextcloud/fix/16378-cannot-get-key-from-parameter

Pass $configargs to openssl_pkey_export

Fix wrong indentation

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix 1px jump when selecting multi table entries (#16475)

Fix 1px jump when selecting multi table entries

Adjust deprecation tests

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Bump @babel/core from 7.5.4 to 7.5.5

Bumps [@babel/core](https://github.com/babel/babel) from 7.5.4 to 7.5.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.5.4...v7.5.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #16483 from nextcloud/dependabot/npm_and_yarn/css-loader-3.1.0

Bump css-loader from 3.0.0 to 3.1.0

Merge pull request #16482 from nextcloud/dependabot/npm_and_yarn/url-loader-2.1.0

Bump url-loader from 2.0.1 to 2.1.0

Merge pull request #16489 from nextcloud/dependabot/npm_and_yarn/lodash-4.17.15

Bump lodash from 4.17.14 to 4.17.15

Merge pull request #16487 from nextcloud/dependabot/npm_and_yarn/blueimp-md5-2.11.0

Bump blueimp-md5 from 2.10.0 to 2.11.0

[tx-robot] updated from transifex

Fix invalid recursion

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Pass $configargs to openssl_pkey_export

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Bump css-loader from 3.0.0 to 3.1.0

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.0.0...v3.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #16488 from nextcloud/dependabot/npm_and_yarn/file-loader-4.1.0

Bump file-loader from 4.0.0 to 4.1.0

The array and string offset access syntax using curly braces is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Bump lodash from 4.17.14 to 4.17.15

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.15.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.15)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Bump blueimp-md5 from 2.10.0 to 2.11.0

Bumps [blueimp-md5](https://github.com/blueimp/JavaScript-MD5) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/blueimp/JavaScript-MD5/releases)
- [Commits](https://github.com/blueimp/JavaScript-MD5/compare/v2.10.0...v2.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Bump url-loader from 2.0.1 to 2.1.0

Bumps [url-loader](https://github.com/webpack-contrib/url-loader) from 2.0.1 to 2.1.0.
- [Release notes](https://github.com/webpack-contrib/url-loader/releases)
- [Changelog](https://github.com/webpack-contrib/url-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/url-loader/compare/v2.0.1...v2.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #16485 from nextcloud/dependabot/npm_and_yarn/webpack-4.36.1

Bump webpack from 4.35.3 to 4.36.1

Exclude .rnd files from integrity check

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Bump webpack from 4.35.3 to 4.36.1

Bumps [webpack](https://github.com/webpack/webpack) from 4.35.3 to 4.36.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.35.3...v4.36.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #16486 from nextcloud/dependabot/npm_and_yarn/vue-loader-15.7.1

Bump vue-loader from 15.7.0 to 15.7.1

Merge pull request #16480 from nextcloud/dependabot/npm_and_yarn/build/jsdoc-3.6.3

Bump jsdoc from 3.6.2 to 3.6.3 in /build

Bump vue-loader from 15.7.0 to 15.7.1

Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.7.0 to 15.7.1.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.7.0...v15.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #16490 from nextcloud/dependabot/npm_and_yarn/webpack-cli-3.3.6

Bump webpack-cli from 3.3.5 to 3.3.6

[tx-robot] updated from transifex

Bump webpack-cli from 3.3.5 to 3.3.6

Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.3.5 to 3.3.6.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/v3.3.6/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/v3.3.5...v3.3.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump file-loader from 4.0.0 to 4.1.0

Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/webpack-contrib/file-loader/releases)
- [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/file-loader/compare/v4.0.0...v4.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @babel/preset-env from 7.5.4 to 7.5.5

Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.5.4 to 7.5.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.5.4...v7.5.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump jsdoc from 3.6.2 to 3.6.3 in /build

Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.2 to 3.6.3.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.2...3.6.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #16470 from nextcloud/bugfix/noid/settings-menu-border-top_new

Add border-top to settings menu when its open

Fix 1px jump when selecting multi table entries

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>

[tx-robot] updated from transifex

Merge pull request #14954 from tacruc/searchPatterns

Allow to search for real pattern in contacts

Merge pull request #14540 from army1349/master

LDAP Password Modify Extended Operation support

Add border-top to settings menu when its open

Signed-off-by: Greta Doci <gretadoci@gmail.com>

[tx-robot] updated from transifex

Merge pull request #16366 from nextcloud/bugfix/noid/filelist-overlap

Fix filelist overlap with header ref #16076

Merge pull request #16452 from nextcloud/bug/noid/error-with-exception-on-ssl-error

Error with exception on SSL error

Merge pull request #16455 from nextcloud/enh/noid/ldap-update-user-cmd

adds an --update flag to check-user for manual sync of the ldap record

Merge pull request #10842 from nextcloud/bugfix/9339/initial_collection_sync_caldav_carddav

LIMIT is no column but a SQL keyword, allow limit on initial sync

Error with exception on SSL error

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

fixes the check for postgresql

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #16420 from nextcloud/bugfix/noid/settings-menu-border-top

 Add border-top to settings menu when its open ref #16076

Fix filelist overlap with header ref #16076

Signed-off-by: Greta Doci <gretadoci@gmail.com>

Merge pull request #16380 from Dreamsorcerer/patch-1

Allow use of server var for CSP nonce

adds an --update flag to check-user for manual sync of the ldap record

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #15143 from nextcloud/bugfix/noid/lookup-server-connector-background-jobs-problem

Fix lookup server connector background jobs problem

Merge pull request #16451 from nextcloud/tech-debt/noid/reduce-indirection

Reduce indirection in AppManager

LIMIT is no column but a SQL feature, allow limit on initial sync

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Add support for CSP_NONCE server variable

Allow passing a nonce from the web server, allowing the possibility to enforce a strict CSP from the web server.

Signed-off-by: Sam Bull <git@sambull.org>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Reduce indirection in AppManager

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Removes unused OC_API::register

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Make the RetryJob work on the userId only

To ensure there is only 1 background job per user

Signed-off-by: Joas Schilling <coding@schilljs.com>

Yay for null coalescing operator

Signed-off-by: Joas Schilling <coding@schilljs.com>

Use public interfaces

Signed-off-by: Joas Schilling <coding@schilljs.com>

Always use a background job for the update

Signed-off-by: Joas Schilling <coding@schilljs.com>

Also send a delete like on the syncronous action

Signed-off-by: Joas Schilling <coding@schilljs.com>

Use an application class

Signed-off-by: Joas Schilling <coding@schilljs.com>

[tx-robot] updated from transifex

Merge pull request #16440 from marcelklehr/fix/objectstorage-put-contents

Fix File#putContents(string) on ObjectStorage

Merge pull request #15040 from nextcloud/feature/13980/push-for-deleted-notifications

Notifications overhaul

Merge pull request #16075 from nextcloud/bugfix/15823/app-restricted-groups

Remove deleted groups from app restrictions fixes #15823

Add border-top to settings menu when its open ref #16076

Signed-off-by: Greta Doci <gretadoci@gmail.com>

Fix File#putContents(string) on ObjectStorage

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Merge pull request #16416 from nextcloud/enh/log-details

Move log detail aggregation and reuse it in syslog/systemd logger

Move log detail aggregation to separate class and reuse it in syslog/systemd logger

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #16424 from nextcloud/fix/do_not_keep_searching

Do not keep searching for recent

[tx-robot] updated from transifex

Properly inject the logger

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #16422 from nextcloud/feature/noid/complement-search-string-inrequest-

set and complete the searched string