]>
source.dussan.org Git - poi.git/log
Javen O'Neal [Sat, 2 Jul 2016 18:28:43 +0000 (18:28 +0000)]
bug 59773: move loop invariants outside of loop or change for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751086 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 16:29:05 +0000 (16:29 +0000)]
bug 59781: ignore duplicate HSSF PaneInformation, which now shadows the Common SS version. The HSSF version has been deprecated and will be deleted after 2 releases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751081 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 09:00:13 +0000 (09:00 +0000)]
bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751044 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 08:40:50 +0000 (08:40 +0000)]
don't shadow drawing field from XSSFShape in XSSFGraphicFrame
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751038 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 08:30:34 +0000 (08:30 +0000)]
findbugs: remove implements Cloneable declaration from classes that don't implement a clone method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751035 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 08:20:14 +0000 (08:20 +0000)]
findbugs: remove switch statement fall-through and move default switch to bottom
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751034 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 05:12:19 +0000 (05:12 +0000)]
enable @Ignored unit test that is passing now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751024 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 05:11:01 +0000 (05:11 +0000)]
findbugs REC_CATCH_EXCEPTION: catch specific exception types and include more helpful reason rather than catching all Exceptions with one misleading reason
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751023 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 05:01:43 +0000 (05:01 +0000)]
+svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751022 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 04:43:21 +0000 (04:43 +0000)]
deprecate o.a.p.hssf.util.AreaReference as it shadows o.a.p.ss.util.AreaReference (findbugs) and provides no additional functionality
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751021 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 04:39:53 +0000 (04:39 +0000)]
findbugs: DocumentInputStream.skip(long) result not checked; close DocumentInputStream even if exception is thrown
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751020 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 2 Jul 2016 04:28:41 +0000 (04:28 +0000)]
whitespace and +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751019 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Fri, 1 Jul 2016 21:10:40 +0000 (21:10 +0000)]
sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1751007 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 1 Jul 2016 09:14:41 +0000 (09:14 +0000)]
bug 59776: don't swallow cause of exception in ZipPackagePropertiesMashaller exception handling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750893 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Thu, 30 Jun 2016 23:03:17 +0000 (23:03 +0000)]
forbidden-apis-fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750868 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Thu, 30 Jun 2016 22:59:46 +0000 (22:59 +0000)]
a few performance fixes to speed-up the tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750867 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Thu, 30 Jun 2016 21:20:23 +0000 (21:20 +0000)]
#59739 When testing for a valid NFIB in a FileInformationBlock, accept common "nearby" values as found from CommonCrawl
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750866 13f79535 -47bb-0310-9956-
ffa450edef68
Dominik Stadler [Thu, 30 Jun 2016 21:06:04 +0000 (21:06 +0000)]
Bug 59739: For now fix the regression in FileInformationBlock which was introduced after 3.15-beta1 so that the documents can be loaded again pending a full fix as discussed in the bug.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750864 13f79535 -47bb-0310-9956-
ffa450edef68
Dominik Stadler [Thu, 30 Jun 2016 21:05:52 +0000 (21:05 +0000)]
Update to apache-rat-12
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750863 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Mon, 27 Jun 2016 19:57:33 +0000 (19:57 +0000)]
#59766 Need to catch Errors as well when trying to tweak SAX stuff
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750408 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sat, 25 Jun 2016 16:53:05 +0000 (16:53 +0000)]
prepare for 3.15-beta3
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750213 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sat, 25 Jun 2016 16:50:21 +0000 (16:50 +0000)]
release prepare for 3.15-beta2 - pin documentation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750211 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 25 Jun 2016 05:22:05 +0000 (05:22 +0000)]
bug 59748: replace remaining Hashtable usages in contrib/poi-ruby and hssf examples
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750182 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 25 Jun 2016 05:10:22 +0000 (05:10 +0000)]
add @Override annotation for updateOtherRecordReferences on PositionDependentRecordAtom descendents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750181 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Fri, 24 Jun 2016 23:31:12 +0000 (23:31 +0000)]
deprecated constants pointing to MissingCellPolicy - use enum instead
javadocs fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750172 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Fri, 24 Jun 2016 22:04:12 +0000 (22:04 +0000)]
Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750171 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 24 Jun 2016 21:39:44 +0000 (21:39 +0000)]
bug 59748: replace Hashtable with HashMap; contributed by Axel Howind
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750168 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Fri, 24 Jun 2016 20:26:08 +0000 (20:26 +0000)]
sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750162 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Fri, 24 Jun 2016 00:12:25 +0000 (00:12 +0000)]
common-crawl-regression-fix: fallback to higher template level for default font, in case the style reference can't be determined
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750034 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Thu, 23 Jun 2016 23:13:59 +0000 (23:13 +0000)]
Fix for test-data of #59746
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1750033 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Thu, 23 Jun 2016 18:59:48 +0000 (18:59 +0000)]
#59746 XSSF support for files from certain alternate tools where the row XML is missing the row number
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749971 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Thu, 23 Jun 2016 18:44:34 +0000 (18:44 +0000)]
Disabled unit test for bug #59746, test file from Rob Owen
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749963 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Thu, 23 Jun 2016 00:23:51 +0000 (00:23 +0000)]
#59743 - ZipSecureFile throwing "zip bomb detected" exception when writing SXSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749799 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Wed, 22 Jun 2016 22:51:14 +0000 (22:51 +0000)]
Ignore Tiff files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749797 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Wed, 22 Jun 2016 22:27:53 +0000 (22:27 +0000)]
sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749795 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Wed, 22 Jun 2016 22:26:08 +0000 (22:26 +0000)]
javadoc fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749794 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Wed, 22 Jun 2016 16:18:36 +0000 (16:18 +0000)]
XSLFPictureData support for TIFF images - patch and tests from bug #59742 from Jens Popp
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749732 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Tue, 21 Jun 2016 14:34:12 +0000 (14:34 +0000)]
Fix inconsistent whitespace and indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749530 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Tue, 21 Jun 2016 14:27:41 +0000 (14:27 +0000)]
#59717 POIXMLProperties helper methods for reading and changing OOXML document thumbnails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749528 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Tue, 21 Jun 2016 14:26:28 +0000 (14:26 +0000)]
Provide an alternate method to get the OLE2 thumbnail that decodes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749526 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 11:27:40 +0000 (11:27 +0000)]
bug 56781: make Name#validateName compatible on Java 6 (no Regex \p{IsAlphabetic} metaclasses
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749305 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 10:52:50 +0000 (10:52 +0000)]
remove an unnecessary row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749300 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 10:49:05 +0000 (10:49 +0000)]
bug 59733: cells do not need to be created for the XmlValueDisconnectedException to occur
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749298 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 10:41:22 +0000 (10:41 +0000)]
bug 59733: add disabled unit test from Dattathreya
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749295 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 10:32:21 +0000 (10:32 +0000)]
remove commented out @Ignore
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749294 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 10:27:52 +0000 (10:27 +0000)]
bug 56781: disallow names with symbols, except underscore, period, and backslash
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749293 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 08:50:36 +0000 (08:50 +0000)]
add comments, adjust whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749276 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 08:15:56 +0000 (08:15 +0000)]
whitespace (tabs to spaces); +svnprop svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749274 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 07:15:09 +0000 (07:15 +0000)]
bug 57929: add disabled unit test, adapted from nova
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749270 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 06:49:13 +0000 (06:49 +0000)]
bug 57523: off by one error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749269 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 06:27:12 +0000 (06:27 +0000)]
bug 57523: add unit test written by Dominik Stadler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749267 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 05:01:21 +0000 (05:01 +0000)]
bug 59719: add unit test and comments/javadocs from Greg Woolsey for XSSFDataVAlidationConstraint
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749265 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 04:21:26 +0000 (04:21 +0000)]
whitespace (tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749264 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 04:16:32 +0000 (04:16 +0000)]
bug 59731: start migrating methods relating to row-shifting in HSSFSheet to HSSFRowShifter; consolidate with XSSFRowShifter into RowShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749262 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 03:50:30 +0000 (03:50 +0000)]
parameterize raw generics
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749260 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 03:40:32 +0000 (03:40 +0000)]
bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749258 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 02:02:08 +0000 (02:02 +0000)]
bug 56454: keep XSSFRowShifter#shiftMerged in sync with HSSFSheet: when shifting rows, shift merged regions (even when the merged region does not include column 0)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749248 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 01:49:46 +0000 (01:49 +0000)]
bug 56454: deprecate shiftMerged with unused parameter, move loop-invariant out of for-loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749247 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 01:44:44 +0000 (01:44 +0000)]
bug 56454: add disabled unit test based on Jörg Selbach's test case showing shiftRows incorrectly handles merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749246 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 01:25:23 +0000 (01:25 +0000)]
object-oriented methods are preferred over utility classes for discoverability
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749245 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 00:55:51 +0000 (00:55 +0000)]
bug 59729: update CellRangeUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749243 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 00:28:19 +0000 (00:28 +0000)]
whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749241 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 00:25:29 +0000 (00:25 +0000)]
mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749240 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 00:16:41 +0000 (00:16 +0000)]
bug 56454: add CellRangeAddress#containsRow and containsColumn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749239 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Mon, 20 Jun 2016 00:08:11 +0000 (00:08 +0000)]
findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749238 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Mon, 20 Jun 2016 00:00:41 +0000 (00:00 +0000)]
convert TestCellRangeAddress from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749237 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 23:02:43 +0000 (23:02 +0000)]
bug 56958: replace java.awt.Rectangle#intersects with native implementation to determine if CellRangeAddresses intersect; patch from Yaniv Kunda
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749226 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 22:51:01 +0000 (22:51 +0000)]
bug 59728: add disabled unit test: should not be able to add an array formula to merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749225 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 19 Jun 2016 22:43:24 +0000 (22:43 +0000)]
Regression fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749224 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 22:24:17 +0000 (22:24 +0000)]
bug 56958: slightly improve performance when checking array formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749219 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Sun, 19 Jun 2016 22:13:41 +0000 (22:13 +0000)]
#59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749214 13f79535 -47bb-0310-9956-
ffa450edef68
Nick Burch [Sun, 19 Jun 2016 22:12:55 +0000 (22:12 +0000)]
#59724 Provide Closeable on all OLE2-based POIDocument types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749213 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 22:00:44 +0000 (22:00 +0000)]
bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749210 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 18:20:23 +0000 (18:20 +0000)]
bug 59645: add Page Setup Print row and column headings support for Common SS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749191 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 06:23:57 +0000 (06:23 +0000)]
update javadoc for clarification about non-literal lists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749133 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 06:16:23 +0000 (06:16 +0000)]
use fully qualified name for Javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749132 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 06:10:50 +0000 (06:10 +0000)]
add unit test for bug 59719
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749131 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sun, 19 Jun 2016 04:43:53 +0000 (04:43 +0000)]
bug 59719: parse static list text properly; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749129 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sun, 19 Jun 2016 01:06:55 +0000 (01:06 +0000)]
findbugs fixes - ME_MUTABLE_ENUM_FIELD
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749116 13f79535 -47bb-0310-9956-
ffa450edef68
Andreas Beeker [Sat, 18 Jun 2016 23:48:00 +0000 (23:48 +0000)]
#59702 - Setting background color in slide master
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1749108 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 18 Jun 2016 02:37:24 +0000 (02:37 +0000)]
add unit test for HSSFWorkbook.getSelectedTabs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748899 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 18 Jun 2016 01:21:08 +0000 (01:21 +0000)]
bug 59718: deprecate get/setBoldweight. Use get/setBold
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748898 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Sat, 18 Jun 2016 01:06:53 +0000 (01:06 +0000)]
bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748897 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 11:06:58 +0000 (11:06 +0000)]
bug 59432: move loop invariants outside the loop to marginally improve code execution speed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748832 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 10:47:13 +0000 (10:47 +0000)]
FunctionEval is a utility class. It should not have a public default constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748830 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 10:22:09 +0000 (10:22 +0000)]
bug 56958: validate array formulas wasn't correctly checking for overlap with a merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748829 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 10:17:47 +0000 (10:17 +0000)]
bug 59279: add unit test for CellComment.equals and CellComment.hashCode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748827 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 08:56:10 +0000 (08:56 +0000)]
bug 59279: add Comment.equals and hashCode methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748814 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 08:54:08 +0000 (08:54 +0000)]
add unit test for Cell.getCellComment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748813 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 07:59:01 +0000 (07:59 +0000)]
move loop invariant outside of loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748809 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 07:32:38 +0000 (07:32 +0000)]
findbugs: remove uncalled private methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748804 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 07:21:48 +0000 (07:21 +0000)]
bug 58575: add 'svn:auto-props = *.java = svn:eol-style=native'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748802 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 02:35:44 +0000 (02:35 +0000)]
bug 59170: add version when deprecated
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748793 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 02:31:27 +0000 (02:31 +0000)]
bug 59170: deprecate o.a.p.hssf.model.PictureShape
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748792 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 02:16:40 +0000 (02:16 +0000)]
bug 59170: remove deprecated constructors in o.a.p.hwpf.usermodel.Paragraph
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748791 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 02:12:05 +0000 (02:12 +0000)]
bug 59170: remove deprecated o.a.p.hwpf.usermodel.Pictures methods; add version when deprecated to javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748790 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 01:48:46 +0000 (01:48 +0000)]
bug 59170: remove or privatize deprecated methods in o.a.p.hwpf.usermodel.Range from POI 3.8 beta 4/5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748789 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 01:34:00 +0000 (01:34 +0000)]
remove deprecated o.a.p.hwpf.usermodel.Shapes (replaced by OfficeDrawing in POI 3.8 beta 4)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748788 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 01:24:38 +0000 (01:24 +0000)]
bug 59170: remove deprecated o.a.p.hwpf.usermodel.ListEntry constructor and method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748787 13f79535 -47bb-0310-9956-
ffa450edef68
Javen O'Neal [Fri, 17 Jun 2016 01:19:36 +0000 (01:19 +0000)]
bug 59170: remove deprecated WordExtractor constructor; add version when deprecated to HWPF HeaderStories
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@
1748786 13f79535 -47bb-0310-9956-
ffa450edef68