Merge pull request #27880 from nextcloud/bugfix/noid/make-integrity-check-verbose

Make integrity commands verbose

Merge pull request #27631 from yan12125/php8-fix-error-reporting

Merge pull request #26481 from ghost/fdroid

Merge pull request #27852 from nextcloud/bugfix/noid/allow-casting-query-functions

Merge pull request #26728 from doc75/http-warning

Correctly skip suppressed errors in PHP 8.0

Applies the suggested transformation mentioned in
https://www.php.net/manual/en/migration80.incompatible.php,

> The @ operator will no longer silence fatal errors (E_ERROR,
> E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR,
> E_PARSE). Error handlers that expect error_reporting to be 0 when
> @ is used, should be adjusted to use a mask check instead

The new code still works on PHP 7, as error_reporting() already
returns 0 when diagnostics are suppressed.

This fixes https://github.com/nextcloud/server/issues/25807 in PHP 8.0.
For PHP 7.x, https://github.com/nextcloud/server/pull/22243 suppresses
the E_NOTICE message from the second session_start() call with the error
suppression operator @, and thus those E_NOTICE messages are still
logged in PHP 8.0.

See also https://github.com/nextcloud/server/issues/25806

Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>

[tx-robot] updated from transifex

Merge pull request #27264 from nextcloud/dependabot/npm_and_yarn/nextcloud/paths-2.0.0

Bump @nextcloud/paths from 1.1.2 to 2.0.0

Bump @nextcloud/paths from 1.1.2 to 2.0.0

Bumps @nextcloud/paths from 1.1.2 to 2.0.0.

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #27272 from nextcloud/dependabot/npm_and_yarn/nextcloud/logger-2.0.0

Bump @nextcloud/logger from 1.1.2 to 2.0.0

Bump @nextcloud/logger from 1.1.2 to 2.0.0

Bumps [@nextcloud/logger](https://github.com/nextcloud/nextcloud-logger) from 1.1.2 to 2.0.0.
- [Release notes](https://github.com/nextcloud/nextcloud-logger/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-logger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-logger/compare/v1.1.2...v2.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #27915 from nextcloud/fix/plasm-code-alerts

Fix Psalm code scanning alerts

Fix Psalm code scanning alerts

InvalidScalarArgument (apps/theming/lib/IconBuilder.php#L213): https://github.com/nextcloud/server/security/code-scanning/6691
InvalidScalarArgument (apps/theming/lib/IconBuilder.php#L213): https://github.com/nextcloud/server/security/code-scanning/6692
MissingReturnType (apps/theming/lib/IconBuilder.php#L226): https://github.com/nextcloud/server/security/code-scanning/6693
MissingParamType (apps/theming/lib/IconBuilder.php#L226): https://github.com/nextcloud/server/security/code-scanning/6694
MissingParamType (apps/theming/lib/IconBuilder.php#L226): https://github.com/nextcloud/server/security/code-scanning/6695
PossiblyFalseArgument (apps/theming/lib/IconBuilder.php#L232): https://github.com/nextcloud/server/security/code-scanning/6696

Signed-off-by: MichaIng <micha@dietpi.com>

Merge pull request #27922 from nextcloud/check-if-dnsresponse-is-false

Check if dns_get_record returns non-false

Check for !== false instead

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Check if dns_get_record returns non-false

`dns_get_record` can return false which results in exceptions such as
the ones shown in https://github.com/nextcloud/server/issues/27870.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Merge pull request #27887 from nextcloud/enh/noid/fix-userstatus-mobile

make user status usable on mobile

make user status usable on mobile

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #27854 from nextcloud/fix/27371/fix-dark-theme-public-pages

Fix dark theme on public link shares

Fix accessibility theme for guests

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix filepicker bug in dark mode

Signed-off-by: szaimen <szaimen@e.mail.de>

[tx-robot] updated from transifex

Make integrity commands verbose

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #27847 from nextcloud/enh/26973/talk-password-failed

Update "Sending password by Nextcloud Talk failed" sentence

Merge pull request #27864 from nextcloud/bug/27435/add-group-button

Fix add group button

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #27774 from nextcloud/feat/workflow-auto-update

Updating dependabot-approve-merge.yml workflow from template

Merge pull request #27845 from nextcloud/update-diaspora-url

Use proper "Share to Diaspora" URL

[tx-robot] updated from transifex

Merge pull request #27835 from nextcloud/htaccess-cache

Cache images on browser

Merge pull request #27844 from nextcloud/fix/25037/mobile-search-popup

Make search popup usable on mobile, too

Merge pull request #27851 from nextcloud/backport/27848/master

[master] Fixes recursion count incrementation

Allow casting query functions as well

Signed-off-by: Joas Schilling <coding@schilljs.com>

Add a unit test to check for casting a IQueryFunction

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fixes recursion count incrementation

Signed-off-by: Sanpi <sanpi@homecomputing.fr>

Update "Sending password by Nextcloud Talk failed" sentence

Signed-off-by: szaimen <szaimen@e.mail.de>

Merge pull request #27842 from nextcloud/enh/27206/everyone-active-users

Admin user settings - change Everyone to Active users

Use proper "Share to Diaspora" URL

The previous URL leads to an outdated GitHub page that links to websites
which are already available to sale.

This uses the somewhat more official https://share.diasporafoundation.org/

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

Merge pull request #27830 from J0WI/simple-load-enc-module

Refactor getEncryptionModule routine

Admin user settings - change Everyone to Active users

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Make search popup usable on mobile, too

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #27838 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Merge pull request #27827 from nextcloud/enh/27292/singular-plural

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Cache images on browser

Fix #26851

Refactor getEncryptionModule routine

add singular and plural in for days in admin sharing settings

Signed-off-by: szaimen <szaimen@e.mail.de>

Merge pull request #27801 from nextcloud/enh/noid/hardening-dns-pin-middleware

Ignore subdomain for soa queries

Merge pull request #27818 from nextcloud/fix/locking-cache-check

Fix in locking cache check

[tx-robot] updated from transifex

Fix in locking cache check

The intention obviously was to check whether $lockingCacheClass is defined, and existing class, and available. It was however checked whether the $distributedCacheClass is an existing class, which would have caused an exception already in the previous distributed cache check.

Signed-off-by: MichaIng <micha@dietpi.com>

Merge pull request #27794 from nextcloud/fix/clarify-lazy-event-listener-container

Clarify that lazy event listeners are built from the server container

Ignore subdomain for soa queries

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #27767 from nextcloud/enh/20515/maintenance-mode-info

Improve maintenance mode info

Merge pull request #27799 from nextcloud/bug/26425/check-return-encrypt

Throw exception if encrypting the data failed.

Merge pull request #27758 from nullspoon/fix-dns-pinning

Merge pull request #27796 from nextcloud/bug/26839/check-pdo

Check that pdo is installed

Merge pull request #27810 from nextcloud/Valdnet-patch-1

Add a text string to l10n

Add a text string to l10n

Add a text string to l10n

Clarify that lazy event listeners are built from the server container

Ref https://github.com/nextcloud/server/issues/27793

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #27198 from nextcloud/tests/run-s3-tests

Run s3 tests again

Throw exception if encrypting the data failed.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Check that pdo is installed

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

[tx-robot] updated from transifex

Add F-Droid

Signed-off-by: HouraisanNEET <HouraisanNEET@users.noreply.github.com>

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Fix DnsPinMiddleware resolve pinning bug

Libcurl expects the value of the CURLOPT_RESOLVE configurations to be an
array of strings, those strings containing a comma delimited list of
resolved IPs for each host:port combination.

The original code here does create that array with the host:port:ip
combination, but multiple ips for a single host:port result in
additional array entries, rather than adding them to the end of the
string with a comma. Per the libcurl docs, the `CURLOPT_RESOLVE` array
entries should match the syntax `host:port:address[,address]`.

This creates a function-scoped associative array which uses `host:port`
as the key (which are supposed to be unique and this ensures that), and
the value is an array containing IP strings (ipv4 or ipv6). Once the
associative array is populated, it is then set to the CURLOPT_RESOLVE
array, imploding the ip arrays using a comma delimiter so the array
syntax matches the expected by libcurl.

Note that this reorders the "foreach ip" and "foreach port" loops.
Rather than looping over ips then ports, we now loop over ports then
ips, since ports are part of the unique host:port map, and multiple ips
can exist therein.

Signed-off-by: Aaron Ball <nullspoon@oper.io>

Merge pull request #27750 from nextcloud/folder-search-filter-self

dont include folder being search in in the results

Updating dependabot-approve-merge.yml workflow from template

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #27771 from nextcloud/bugfix/noid/autotest-wait-pgsql-docker

Add connection check in autotest.sh for pgsql docker

dont include folder being search in in the results

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #17148 from nextcloud/always-provide-color-to-default-personal-calendar

Always provide theme color for default personal calendar

Add connection check in autotest.sh for pgsql docker

When using pgsql docker for testing locally with autotest, make sure to
properly wait for the port to be available.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Improve maintenance mode info

Signed-off-by: szaimen <szaimen@e.mail.de>

[tx-robot] updated from transifex

Merge pull request #27533 from Rid/master

Fix scanner mistaking socket files for directories

Merge pull request #27586 from nextcloud/bugfi/noid/objectstore-checksum

Reset checksum when writing files to object store

Merge pull request #27737 from nextcloud/enh/19906/contactsmenu

make contactsmenu icon bigger

Merge pull request #27742 from nextcloud/enh/explicit-hint-federation-local

Clarify that federated sharing settings may also affect shares between users on the current instanc

Clarify that federated sharing settings may also affect shares between users on the current instance

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #27739 from nextcloud/enh/noid/app-settings-button

design fixes to app-settings button

Merge pull request #26681 from nextcloud/techdebt/hint-exception-ocp

Move HintException to OCP

Use minio for s3 tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

design fixes to app-settings button

Signed-off-by: szaimen <szaimen@e.mail.de>

Migrate HintException to OCP

Signed-off-by: Gary Kim <gary@garykim.dev>

make contactsmenu icon bigger

Signed-off-by: szaimen <szaimen@e.mail.de>

Merge pull request #27732 from nextcloud/fix/27576/LDAPProviderFactory-not-found

Fix LDAPProviderFactory not found

unset ldap provider when disabling user_ldap

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

ensure that factoryClass exisits before instantiation

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Run s3 tests again

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #27638 from nextcloud/enh/noid/fix-encrypted-version

Merge pull request #27723 from nextcloud/fix/noid/typo-regex

fix incredible off-by-one-typo-error

Merge pull request #27700 from nextcloud/deprecate-remote

Deprecate OCP\Remote