source.dussan.org Git

]> source.dussan.org Git - poi.git/log

Javen O'Neal [Sun, 19 Jun 2016 23:02:43 +0000 (23:02 +0000)]

bug 56958: replace java.awt.Rectangle#intersects with native implementation to determine if CellRangeAddresses intersect; patch from Yaniv Kunda

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749226 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 19 Jun 2016 22:51:01 +0000 (22:51 +0000)]

bug 59728: add disabled unit test: should not be able to add an array formula to merged region

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749225 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 19 Jun 2016 22:43:24 +0000 (22:43 +0000)]

Regression fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749224 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 19 Jun 2016 22:24:17 +0000 (22:24 +0000)]

bug 56958: slightly improve performance when checking array formulas

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749219 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 19 Jun 2016 22:13:41 +0000 (22:13 +0000)]

#59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749214 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 19 Jun 2016 22:12:55 +0000 (22:12 +0000)]

#59724 Provide Closeable on all OLE2-based POIDocument types

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749213 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 19 Jun 2016 22:00:44 +0000 (22:00 +0000)]

bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749210 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 19 Jun 2016 18:20:23 +0000 (18:20 +0000)]

bug 59645: add Page Setup Print row and column headings support for Common SS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 19 Jun 2016 06:23:57 +0000 (06:23 +0000)]

update javadoc for clarification about non-literal lists

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749133 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 19 Jun 2016 06:16:23 +0000 (06:16 +0000)]

use fully qualified name for Javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749132 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 19 Jun 2016 06:10:50 +0000 (06:10 +0000)]

add unit test for bug 59719

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749131 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 19 Jun 2016 04:43:53 +0000 (04:43 +0000)]

bug 59719: parse static list text properly; patch from Greg Woolsey

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749129 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 19 Jun 2016 01:06:55 +0000 (01:06 +0000)]

findbugs fixes - ME_MUTABLE_ENUM_FIELD

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749116 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 18 Jun 2016 23:48:00 +0000 (23:48 +0000)]

#59702 - Setting background color in slide master

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749108 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 18 Jun 2016 02:37:24 +0000 (02:37 +0000)]

add unit test for HSSFWorkbook.getSelectedTabs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748899 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 18 Jun 2016 01:21:08 +0000 (01:21 +0000)]

bug 59718: deprecate get/setBoldweight. Use get/setBold

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748898 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 18 Jun 2016 01:06:53 +0000 (01:06 +0000)]

bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 11:06:58 +0000 (11:06 +0000)]

bug 59432: move loop invariants outside the loop to marginally improve code execution speed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748832 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 10:47:13 +0000 (10:47 +0000)]

FunctionEval is a utility class. It should not have a public default constructor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748830 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 10:22:09 +0000 (10:22 +0000)]

bug 56958: validate array formulas wasn't correctly checking for overlap with a merged region

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748829 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 10:17:47 +0000 (10:17 +0000)]

bug 59279: add unit test for CellComment.equals and CellComment.hashCode

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748827 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 08:56:10 +0000 (08:56 +0000)]

bug 59279: add Comment.equals and hashCode methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748814 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 08:54:08 +0000 (08:54 +0000)]

add unit test for Cell.getCellComment

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748813 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 07:59:01 +0000 (07:59 +0000)]

move loop invariant outside of loop

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748809 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 07:32:38 +0000 (07:32 +0000)]

findbugs: remove uncalled private methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748804 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 07:21:48 +0000 (07:21 +0000)]

bug 58575: add 'svn:auto-props = *.java = svn:eol-style=native'

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748802 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 02:35:44 +0000 (02:35 +0000)]

bug 59170: add version when deprecated

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748793 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 02:31:27 +0000 (02:31 +0000)]

bug 59170: deprecate o.a.p.hssf.model.PictureShape

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748792 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 02:16:40 +0000 (02:16 +0000)]

bug 59170: remove deprecated constructors in o.a.p.hwpf.usermodel.Paragraph

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748791 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 02:12:05 +0000 (02:12 +0000)]

bug 59170: remove deprecated o.a.p.hwpf.usermodel.Pictures methods; add version when deprecated to javadoc

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748790 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 01:48:46 +0000 (01:48 +0000)]

bug 59170: remove or privatize deprecated methods in o.a.p.hwpf.usermodel.Range from POI 3.8 beta 4/5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748789 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 01:34:00 +0000 (01:34 +0000)]

remove deprecated o.a.p.hwpf.usermodel.Shapes (replaced by OfficeDrawing in POI 3.8 beta 4)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748788 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 01:24:38 +0000 (01:24 +0000)]

bug 59170: remove deprecated o.a.p.hwpf.usermodel.ListEntry constructor and method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748787 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 01:19:36 +0000 (01:19 +0000)]

bug 59170: remove deprecated WordExtractor constructor; add version when deprecated to HWPF HeaderStories

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748786 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 01:09:05 +0000 (01:09 +0000)]

bug 59170: remove deprecated o.a.p.hwpf.usermodel.CharacterRun#cloneProperties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748785 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 01:00:38 +0000 (01:00 +0000)]

bug 59170: add version when deprecated

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748784 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 00:55:22 +0000 (00:55 +0000)]

bug 59170: remove deprecated HSLF and HWPF methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748783 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 00:36:19 +0000 (00:36 +0000)]

bug 59170: remove deprecated o.a.p.hdgf.HDGFDiagram constructor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748782 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 00:35:29 +0000 (00:35 +0000)]

whitespace (3 spaces to tab)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748781 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 17 Jun 2016 00:20:48 +0000 (00:20 +0000)]

bug 59170: remove deprecated o.a.p.xwpf.model.XWPFHyperlinkDecorator class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748780 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 16 Jun 2016 23:52:54 +0000 (23:52 +0000)]

bug 59170: remove deprecated o.a.p.openxml4j.opc.internal.CnotentType#getParameters

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748778 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 16 Jun 2016 06:51:53 +0000 (06:51 +0000)]

bug 55385: deprecate Font.getBoldweight and Font.setBoldweight

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748658 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 16:36:31 +0000 (16:36 +0000)]

add disabled unit test for bug 55273: contributed by Martin Studer

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748606 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 04:32:17 +0000 (04:32 +0000)]

fix javadocs @link error for removed o.a.p.hssf.util.CellRangeAddress

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748496 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 04:26:14 +0000 (04:26 +0000)]

bug 59170: remove deprecated XSSFExcelExtractor(String)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748495 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 04:22:49 +0000 (04:22 +0000)]

bug 59170: remove deprecated o.a.p.openxml4j.opc.Package

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748494 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 04:22:26 +0000 (04:22 +0000)]

bug 59170: remove deprecated XSSFFontFormatting#getXSSFColor that was deprecated in 3.13 beta 1

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748493 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 04:08:56 +0000 (04:08 +0000)]

add @Override annotations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748491 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 03:55:45 +0000 (03:55 +0000)]

whitespace (2 spaces or tabs to 4 spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748489 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 03:42:18 +0000 (03:42 +0000)]

bug 59170: remove deprecated writeTo method in @Internal PAPBinTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748488 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 03:34:56 +0000 (03:34 +0000)]

whitespace (2 spaces to 4 spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748487 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 03:31:41 +0000 (03:31 +0000)]

remove deprecated constructor for @Internal PAPBinTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748486 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 03:29:31 +0000 (03:29 +0000)]

update WriteAuthorAntTitle example to Java 1.6+

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748485 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 03:28:11 +0000 (03:28 +0000)]

revert accidental commit

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748484 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 03:26:58 +0000 (03:26 +0000)]

bug 59170: remove deprecated methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748483 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 02:56:56 +0000 (02:56 +0000)]

bug 57840: make it easier to replace _rows implementation (HashMap?) by making it final

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748482 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 02:48:23 +0000 (02:48 +0000)]

bug 59170: remove deprecated methods in o.a.p.hpsf.wellknown.SectionIDMap

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748481 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 02:47:04 +0000 (02:47 +0000)]

bug 59170: remove deprecated hpsf.Constants class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748480 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 15 Jun 2016 01:42:11 +0000 (01:42 +0000)]

bug 57840: add comments for explicit boxing performance optimization

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748479 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 14 Jun 2016 21:57:38 +0000 (21:57 +0000)]

remove RegionUtil reference

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748473 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 13 Jun 2016 23:08:13 +0000 (23:08 +0000)]

javadoc fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748328 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 13 Jun 2016 21:18:50 +0000 (21:18 +0000)]

reverted changes of r1747942 and deprecated instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748313 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 18:14:26 +0000 (18:14 +0000)]

back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748294 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 18:12:29 +0000 (18:12 +0000)]

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 10:55:49 +0000 (10:55 +0000)]

Sonar: 'static modifier out of order with the JLS suggestions.remove No need to check for null before an instanceof; the instanceof keyword returns false when given a null argument.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748175 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 10:53:03 +0000 (10:53 +0000)]

add HSSFCell.setCachedErrorResult(FormulaError)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748174 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 10:29:38 +0000 (10:29 +0000)]

type check error code when setting cell error value on HSSFCell

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748172 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 10:14:44 +0000 (10:14 +0000)]

add useless unit test for o.a.p.ss.util.RegionUtil

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748170 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 09:51:01 +0000 (09:51 +0000)]

add periods for complete sentences

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748166 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 13 Jun 2016 09:39:36 +0000 (09:39 +0000)]

Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748158 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 13 Jun 2016 09:38:12 +0000 (09:38 +0000)]

Javadoc fixes - @see and @link can't be combined together, at least not in Java 6

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748157 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 08:58:55 +0000 (08:58 +0000)]

improve unit test coverage on CellReference.
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748144 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 08:55:41 +0000 (08:55 +0000)]

fix accidental infinite recursion

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748143 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 07:44:29 +0000 (07:44 +0000)]

bug 58787: add an advertisement to BorderPropertyTemplate.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748110 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 07:40:20 +0000 (07:40 +0000)]

bug 58787 follow-on: update javadocs; remove unused Workbook parameter from set(Top|Bottom|Left|Right)Border and BorderColor methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748107 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 07:27:18 +0000 (07:27 +0000)]

whitespace (tabs to spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748105 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 07:15:47 +0000 (07:15 +0000)]

add description to gump and jenkins build targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748100 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 07:02:33 +0000 (07:02 +0000)]

findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 06:38:53 +0000 (06:38 +0000)]

findbugs: fix SF_SWITCH_NO_DEFAULT warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 06:12:35 +0000 (06:12 +0000)]

findbugs: fix SF_SWITCH_FALLTHROUGH warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 05:41:32 +0000 (05:41 +0000)]

findbugs depends on the poi, poi-scratchpad, and poi-ooxml jars being copied to build/maven

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748087 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 05:34:02 +0000 (05:34 +0000)]

findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 05:06:47 +0000 (05:06 +0000)]

findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748085 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 04:42:59 +0000 (04:42 +0000)]

findbugs: fix URF_UNREAD_FIELD warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 04:34:37 +0000 (04:34 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748083 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 04:09:41 +0000 (04:09 +0000)]

consolidate findbugs filters using Or logic

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748081 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 03:48:30 +0000 (03:48 +0000)]

fix findbugs issues

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 01:25:50 +0000 (01:25 +0000)]

bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 01:00:51 +0000 (01:00 +0000)]

rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 00:50:52 +0000 (00:50 +0000)]

test copy constructor: make changes to same range: this is a better test for deepcopy

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 00:43:34 +0000 (00:43 +0000)]

add copy constructor

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 13 Jun 2016 00:40:46 +0000 (00:40 +0000)]

move colors in TestBorderPropertyTemplate to testclass constants

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748071 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 12 Jun 2016 23:43:16 +0000 (23:43 +0000)]

rewrite switch statements to not re-check the switch'd variable

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748070 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 12 Jun 2016 23:03:23 +0000 (23:03 +0000)]

rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748068 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 12 Jun 2016 22:59:47 +0000 (22:59 +0000)]

commit | commitdiff | tree

Javen O'Neal [Sun, 12 Jun 2016 22:57:37 +0000 (22:57 +0000)]

move check if border line style is blank before setting the border color to a helper function for readability

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 12 Jun 2016 22:33:24 +0000 (22:33 +0000)]

remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key.

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 12 Jun 2016 22:02:38 +0000 (22:02 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 12 Jun 2016 22:01:30 +0000 (22:01 +0000)]

use CellAddress in unit tests where possible to improve readability

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 12 Jun 2016 22:00:45 +0000 (22:00 +0000)]

javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68

Mirror of Apache POI: https://github.com/apache/poi

RSS Atom