]> source.dussan.org Git - poi.git/log
poi.git
8 years agoFix a NullPointerException that occurs with some PPTs now but did not in POI 3.13
Dominik Stadler [Wed, 13 Jan 2016 19:45:49 +0000 (19:45 +0000)]
Fix a NullPointerException that occurs with some PPTs now but did not in POI 3.13

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724487 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEclipse warnings, helper unit-test, improve information provided in Exceptions, do...
Dominik Stadler [Wed, 13 Jan 2016 19:45:05 +0000 (19:45 +0000)]
Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68

8 years agoGeneralised API for adding ignored errors, e.g. number stored as text.
David North [Wed, 13 Jan 2016 17:54:24 +0000 (17:54 +0000)]
Generalised API for adding ignored errors, e.g. number stored as text.

https://bz.apache.org/bugzilla/show_bug.cgi?id=56892

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724469 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 58829: Remove some useages of printStackTrace() and some other minor cleanups
Dominik Stadler [Wed, 13 Jan 2016 15:59:38 +0000 (15:59 +0000)]
Bug 58829: Remove some useages of printStackTrace() and some other minor cleanups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724445 13f79535-47bb-0310-9956-ffa450edef68

8 years agoRework test to not catch exception, junit does a good job of handling unexpected...
Dominik Stadler [Wed, 13 Jan 2016 08:16:15 +0000 (08:16 +0000)]
Rework test to not catch exception, junit does a good job of handling unexpected exceptions itself, StringBuffer replacing, code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724368 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJavadoc fix
Nick Burch [Wed, 13 Jan 2016 07:33:03 +0000 (07:33 +0000)]
Javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724364 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#58847 Getters/setters/removers for the additional well-known document summary inform...
Nick Burch [Wed, 13 Jan 2016 07:26:26 +0000 (07:26 +0000)]
#58847 Getters/setters/removers for the additional well-known document summary information properties from Office 12

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724363 13f79535-47bb-0310-9956-ffa450edef68

8 years agoJavadocs fixes
Andreas Beeker [Wed, 13 Jan 2016 01:09:43 +0000 (01:09 +0000)]
Javadocs fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724343 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#57796 - Support hyperlink extraction when rendering slides
Andreas Beeker [Tue, 12 Jan 2016 23:20:48 +0000 (23:20 +0000)]
#57796 - Support hyperlink extraction when rendering slides

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724338 13f79535-47bb-0310-9956-ffa450edef68

8 years agoMore Office 12 DSI property IDs, getters/setters to follow
Nick Burch [Mon, 11 Jan 2016 18:43:33 +0000 (18:43 +0000)]
More Office 12 DSI property IDs, getters/setters to follow

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724110 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBump up the max DSI property ID, and list a few Office 12 well known IDs
Nick Burch [Mon, 11 Jan 2016 18:26:24 +0000 (18:26 +0000)]
Bump up the max DSI property ID, and list a few Office 12 well known IDs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724104 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#54916 - POI does not always read all the slides in pptx files
Andreas Beeker [Sun, 10 Jan 2016 20:44:17 +0000 (20:44 +0000)]
#54916 - POI does not always read all the slides in pptx files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723966 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd other printStackTrace methods to forbidden-apis-check
Andreas Beeker [Sun, 10 Jan 2016 19:52:16 +0000 (19:52 +0000)]
add other printStackTrace methods to forbidden-apis-check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68

8 years agoreplace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTra...
Andreas Beeker [Sun, 10 Jan 2016 02:20:35 +0000 (02:20 +0000)]
replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68

8 years agoWMF fixes
Andreas Beeker [Sun, 10 Jan 2016 01:12:16 +0000 (01:12 +0000)]
WMF fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723898 13f79535-47bb-0310-9956-ffa450edef68

8 years agoPOI-58822 switch printStackTrace for actual log msg. Should probably open separate...
Tim Allison [Fri, 8 Jan 2016 17:06:39 +0000 (17:06 +0000)]
POI-58822 switch printStackTrace for actual log msg.  Should probably open separate ticket to handle handful of other instances

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723765 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58815: javadoc spelling
Javen O'Neal [Thu, 7 Jan 2016 01:53:05 +0000 (01:53 +0000)]
bug 58815: javadoc spelling

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723445 13f79535-47bb-0310-9956-ffa450edef68

8 years agoWMF fixes
Andreas Beeker [Tue, 5 Jan 2016 23:40:47 +0000 (23:40 +0000)]
WMF fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723198 13f79535-47bb-0310-9956-ffa450edef68

8 years agoDummy commit to try if we can close some old github PRs via commit-comments: closes...
Dominik Stadler [Mon, 4 Jan 2016 20:43:16 +0000 (20:43 +0000)]
Dummy commit to try if we can close some old github PRs via commit-comments: closes #2, closes #3, closes #4, closes #19

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722963 13f79535-47bb-0310-9956-ffa450edef68

8 years agoWMF fixes
Andreas Beeker [Sun, 3 Jan 2016 22:46:57 +0000 (22:46 +0000)]
WMF fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722771 13f79535-47bb-0310-9956-ffa450edef68

8 years agoUndo changes to file in assertCloseDoesNotModifyFile to not have dirty files after...
Dominik Stadler [Sun, 3 Jan 2016 21:37:52 +0000 (21:37 +0000)]
Undo changes to file in assertCloseDoesNotModifyFile to not have dirty files after running tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722756 13f79535-47bb-0310-9956-ffa450edef68

8 years agoTry to reproduce bug 52258 and add more checks to integration tests
Dominik Stadler [Sun, 3 Jan 2016 21:23:09 +0000 (21:23 +0000)]
Try to reproduce bug 52258 and add more checks to integration tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722755 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58043: provide some compatibility between HSSF and XSSF in regards to values...
Dominik Stadler [Sun, 3 Jan 2016 13:28:17 +0000 (13:28 +0000)]
bug 58043: provide some compatibility between HSSF and XSSF in regards to values for CellStyle.setRotation(). Also adjust JavaDoc to mention the remaining things to note

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722716 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix bug 58067: XWPF: don't return deleted text when document is in review-mode
Dominik Stadler [Sun, 3 Jan 2016 13:28:01 +0000 (13:28 +0000)]
Fix bug 58067: XWPF: don't return deleted text when document is in review-mode

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722715 13f79535-47bb-0310-9956-ffa450edef68

8 years agore-throw errors we aren't looking for
Javen O'Neal [Sun, 3 Jan 2016 09:48:05 +0000 (09:48 +0000)]
re-throw errors we aren't looking for

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722708 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58779: check if SlideShowFactory.create() modifies the file being read when the...
Javen O'Neal [Sun, 3 Jan 2016 09:16:59 +0000 (09:16 +0000)]
bug 58779: check if SlideShowFactory.create() modifies the file being read when the slideshow is closed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722707 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace
Javen O'Neal [Sun, 3 Jan 2016 01:34:33 +0000 (01:34 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722696 13f79535-47bb-0310-9956-ffa450edef68

8 years agotest XSLF SlideShowFactory creation methods individually for more granular unit test...
Javen O'Neal [Sun, 3 Jan 2016 01:26:29 +0000 (01:26 +0000)]
test XSLF SlideShowFactory creation methods individually for more granular unit test results

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722695 13f79535-47bb-0310-9956-ffa450edef68

8 years agorearrange unit tests into more, smaller functions
Javen O'Neal [Sat, 2 Jan 2016 21:20:43 +0000 (21:20 +0000)]
rearrange unit tests into more, smaller functions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722667 13f79535-47bb-0310-9956-ffa450edef68

8 years agoMove test for bug 57236 as it seems to be fixed since some time
Dominik Stadler [Sat, 2 Jan 2016 21:11:41 +0000 (21:11 +0000)]
Move test for bug 57236 as it seems to be fixed since some time

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722666 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd test which reproduces bug 58325, seems the file uses AlternateContent which POI...
Dominik Stadler [Sat, 2 Jan 2016 21:11:28 +0000 (21:11 +0000)]
Add test which reproduces bug 58325, seems the file uses AlternateContent which POI does not support (yet)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722665 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw...
Javen O'Neal [Sat, 2 Jan 2016 11:11:33 +0000 (11:11 +0000)]
bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68

8 years agofix javadocs
Javen O'Neal [Sat, 2 Jan 2016 06:23:05 +0000 (06:23 +0000)]
fix javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722609 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy.
Javen O'Neal [Sat, 2 Jan 2016 04:29:30 +0000 (04:29 +0000)]
bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68

8 years agojavadocs
Javen O'Neal [Sat, 2 Jan 2016 03:40:22 +0000 (03:40 +0000)]
javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722605 13f79535-47bb-0310-9956-ffa450edef68

8 years agoremove test debug stuff
Andreas Beeker [Fri, 1 Jan 2016 19:45:30 +0000 (19:45 +0000)]
remove test debug stuff

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722556 13f79535-47bb-0310-9956-ffa450edef68

8 years agopreparation for #54916 - commit unrelated changes
Andreas Beeker [Fri, 1 Jan 2016 19:05:50 +0000 (19:05 +0000)]
preparation for #54916 - commit unrelated changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722538 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58618: XWPFParagraph insertNewRun and removeRun work incorrectly for
Dominik Stadler [Fri, 1 Jan 2016 16:28:01 +0000 (16:28 +0000)]
bug 58618: XWPFParagraph insertNewRun and removeRun work incorrectly for
runs after hyperlink/field runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722503 13f79535-47bb-0310-9956-ffa450edef68

8 years agoInclude full nested exception, not just localized message
Dominik Stadler [Fri, 1 Jan 2016 16:27:50 +0000 (16:27 +0000)]
Include full nested exception, not just localized message

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722502 13f79535-47bb-0310-9956-ffa450edef68

8 years agoSome more unit tests
Dominik Stadler [Fri, 1 Jan 2016 16:27:35 +0000 (16:27 +0000)]
Some more unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722501 13f79535-47bb-0310-9956-ffa450edef68

8 years agoCombine common functionality in POIXMLTypeLoader into helper method
Dominik Stadler [Fri, 1 Jan 2016 16:27:27 +0000 (16:27 +0000)]
Combine common functionality in POIXMLTypeLoader into helper method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722500 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd ignored testcase for multiple signatures
Andreas Beeker [Fri, 1 Jan 2016 15:04:06 +0000 (15:04 +0000)]
add ignored testcase for multiple signatures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722497 13f79535-47bb-0310-9956-ffa450edef68

8 years agoremove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml...
Andreas Beeker [Fri, 1 Jan 2016 02:22:31 +0000 (02:22 +0000)]
remove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml schemas)
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722482 13f79535-47bb-0310-9956-ffa450edef68

8 years agoremove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml...
Andreas Beeker [Fri, 1 Jan 2016 00:45:05 +0000 (00:45 +0000)]
remove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml schemas)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722480 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#55030 - RichTextRun getFontName can not get Chinese font name
Andreas Beeker [Thu, 31 Dec 2015 23:49:34 +0000 (23:49 +0000)]
#55030 - RichTextRun getFontName can not get Chinese font name

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722479 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#56570 - RecordType has repeat by code type 3009
Andreas Beeker [Thu, 31 Dec 2015 22:10:40 +0000 (22:10 +0000)]
#56570 - RecordType has repeat by code type 3009
#58159 - getHeaderText() and getFooterText() duplicate text in sheet.getTextRuns()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722477 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#56570 - RecordType has repeat by code type 3009
Andreas Beeker [Thu, 31 Dec 2015 22:10:17 +0000 (22:10 +0000)]
#56570 - RecordType has repeat by code type 3009
#58159 - getHeaderText() and getFooterText() duplicate text in sheet.getTextRuns()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722476 13f79535-47bb-0310-9956-ffa450edef68

8 years agoWMF fixes
Andreas Beeker [Thu, 31 Dec 2015 20:23:20 +0000 (20:23 +0000)]
WMF fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722465 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix example. If you don't call super for the non-ignored sheets, everything breaks...
David North [Thu, 31 Dec 2015 18:15:35 +0000 (18:15 +0000)]
Fix example. If you don't call super for the non-ignored sheets, everything breaks because you end up with an empty workbook.

https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722457 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix bug 58760: non-standard namespace-key breaks parsing XLSX files
Dominik Stadler [Thu, 31 Dec 2015 09:56:33 +0000 (09:56 +0000)]
Fix bug 58760: non-standard namespace-key breaks parsing XLSX files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722433 13f79535-47bb-0310-9956-ffa450edef68

8 years agoRevert changes to integration-test-framework to not make tests fail with strange...
Dominik Stadler [Thu, 31 Dec 2015 08:23:04 +0000 (08:23 +0000)]
Revert changes to integration-test-framework to not make tests fail with strange errors about entity expansion limits

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722425 13f79535-47bb-0310-9956-ffa450edef68

8 years agoUse parameter in unit test
Dominik Stadler [Wed, 30 Dec 2015 20:31:56 +0000 (20:31 +0000)]
Use parameter in unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722412 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdjust test for extracting some more
Dominik Stadler [Wed, 30 Dec 2015 20:31:50 +0000 (20:31 +0000)]
Adjust test for extracting some more

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722411 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 58746: Fix missing adjustment of formulas when sheet-ordering is changed.
Dominik Stadler [Wed, 30 Dec 2015 20:31:44 +0000 (20:31 +0000)]
Bug 58746: Fix missing adjustment of formulas when sheet-ordering is changed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722410 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdjust doap to list dev-list as maintainer and adjust license information
Dominik Stadler [Wed, 30 Dec 2015 20:31:35 +0000 (20:31 +0000)]
Adjust doap to list dev-list as maintainer and adjust license information

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722409 13f79535-47bb-0310-9956-ffa450edef68

8 years agoAdd null-handler in integration-tests for two Visio files which are not handled ...
Dominik Stadler [Wed, 30 Dec 2015 20:31:30 +0000 (20:31 +0000)]
Add null-handler in integration-tests for two Visio files which are not handled (yet) and adjust memory handling somewhat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722408 13f79535-47bb-0310-9956-ffa450edef68

8 years agoBug 58616: Try to initialize with empty password if not done before
Dominik Stadler [Wed, 30 Dec 2015 20:31:23 +0000 (20:31 +0000)]
Bug 58616: Try to initialize with empty password if not done before

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722407 13f79535-47bb-0310-9956-ffa450edef68

8 years agoEclipse warnings
Dominik Stadler [Wed, 30 Dec 2015 20:31:13 +0000 (20:31 +0000)]
Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722406 13f79535-47bb-0310-9956-ffa450edef68

8 years agoExclude file from integration-tests until bug 58760 is fixed
Dominik Stadler [Wed, 30 Dec 2015 20:31:04 +0000 (20:31 +0000)]
Exclude file from integration-tests until bug 58760 is fixed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722405 13f79535-47bb-0310-9956-ffa450edef68

8 years agoWMF - remove test output
Andreas Beeker [Tue, 29 Dec 2015 23:53:52 +0000 (23:53 +0000)]
WMF - remove test output

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722249 13f79535-47bb-0310-9956-ffa450edef68

8 years agoDisabled unit test for #58760 (problem remains)
Nick Burch [Tue, 29 Dec 2015 22:42:17 +0000 (22:42 +0000)]
Disabled unit test for #58760 (problem remains)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722244 13f79535-47bb-0310-9956-ffa450edef68

8 years agoremove unused import
Javen O'Neal [Tue, 29 Dec 2015 10:44:41 +0000 (10:44 +0000)]
remove unused import

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722095 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd comment
Javen O'Neal [Tue, 29 Dec 2015 10:44:57 +0000 (10:44 +0000)]
add comment

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722094 13f79535-47bb-0310-9956-ffa450edef68

8 years agomove comment
Javen O'Neal [Tue, 29 Dec 2015 10:43:40 +0000 (10:43 +0000)]
move comment

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722093 13f79535-47bb-0310-9956-ffa450edef68

8 years agojavadocs
Javen O'Neal [Tue, 29 Dec 2015 10:41:50 +0000 (10:41 +0000)]
javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722092 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd unit test for bug 58779 when the problem gets fixed
Javen O'Neal [Tue, 29 Dec 2015 10:40:20 +0000 (10:40 +0000)]
add unit test for bug 58779 when the problem gets fixed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722091 13f79535-47bb-0310-9956-ffa450edef68

8 years agojunit3 -> junit4
Javen O'Neal [Tue, 29 Dec 2015 09:54:59 +0000 (09:54 +0000)]
junit3 -> junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722081 13f79535-47bb-0310-9956-ffa450edef68

8 years agorevert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifyi...
Javen O'Neal [Tue, 29 Dec 2015 09:28:32 +0000 (09:28 +0000)]
revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722079 13f79535-47bb-0310-9956-ffa450edef68

8 years agorevert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifyi...
Javen O'Neal [Tue, 29 Dec 2015 09:21:17 +0000 (09:21 +0000)]
revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722078 13f79535-47bb-0310-9956-ffa450edef68

8 years agomake spreadsheet file names static final rather than initializing them with setUp()
Javen O'Neal [Tue, 29 Dec 2015 08:53:46 +0000 (08:53 +0000)]
make spreadsheet file names static final rather than initializing them with setUp()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722073 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace
Javen O'Neal [Tue, 29 Dec 2015 07:38:31 +0000 (07:38 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722070 13f79535-47bb-0310-9956-ffa450edef68

8 years agojavadoc fix
Javen O'Neal [Tue, 29 Dec 2015 06:55:22 +0000 (06:55 +0000)]
javadoc fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722057 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58775: set an upper limit on number of data formats, default 250.
Javen O'Neal [Tue, 29 Dec 2015 05:46:20 +0000 (05:46 +0000)]
bug 58775: set an upper limit on number of data formats, default 250.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722054 13f79535-47bb-0310-9956-ffa450edef68

8 years agofix javadocs warnings for r1721930 (bug 58775)
Javen O'Neal [Tue, 29 Dec 2015 02:57:58 +0000 (02:57 +0000)]
fix javadocs warnings for r1721930 (bug 58775)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68

8 years agoconvert junit3 to junit4
Javen O'Neal [Tue, 29 Dec 2015 01:26:55 +0000 (01:26 +0000)]
convert junit3 to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722048 13f79535-47bb-0310-9956-ffa450edef68

8 years agowhitespace
Javen O'Neal [Tue, 29 Dec 2015 01:18:16 +0000 (01:18 +0000)]
whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722047 13f79535-47bb-0310-9956-ffa450edef68

8 years agoWMF fixes
Andreas Beeker [Tue, 29 Dec 2015 00:45:59 +0000 (00:45 +0000)]
WMF fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722046 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58778: override a built-in number format, such as using £ instead of $ for currency
Javen O'Neal [Tue, 29 Dec 2015 00:12:04 +0000 (00:12 +0000)]
bug 58778: override a built-in number format, such as using £ instead of $ for currency

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722043 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58740: javadocs
Javen O'Neal [Mon, 28 Dec 2015 16:04:47 +0000 (16:04 +0000)]
bug 58740: javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721942 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58775: use short for data format index, int for cell style index
Javen O'Neal [Mon, 28 Dec 2015 14:50:54 +0000 (14:50 +0000)]
bug 58775: use short for data format index, int for cell style index

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58775: consolidate HashMap and array numberFormats data structures to one SortedM...
Javen O'Neal [Mon, 28 Dec 2015 14:37:23 +0000 (14:37 +0000)]
bug 58775: consolidate HashMap and array numberFormats data structures to one SortedMap data structure

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721928 13f79535-47bb-0310-9956-ffa450edef68

8 years agowrite for loop for performance and readability
Javen O'Neal [Mon, 28 Dec 2015 14:20:30 +0000 (14:20 +0000)]
write for loop for performance and readability

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721924 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58775: fix a>b which should be a>=b; use shorts instead of ints to hold number...
Javen O'Neal [Mon, 28 Dec 2015 14:19:50 +0000 (14:19 +0000)]
bug 58775: fix a>b which should be a>=b; use shorts instead of ints to hold number format index

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721923 13f79535-47bb-0310-9956-ffa450edef68

8 years agosimplify bug 57880 test case:
Javen O'Neal [Mon, 28 Dec 2015 14:03:52 +0000 (14:03 +0000)]
simplify bug 57880 test case:
remove unrelated DataFormat code (not worried about wrap-around here since Excel supports up to 250 data formats and we're using the short data type)
replace complex write-out, close, read-back, delete code with new better test apparatus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721922 13f79535-47bb-0310-9956-ffa450edef68

8 years agoadd convenience methods for writing and reading back XSSFWorkbooks
Javen O'Neal [Mon, 28 Dec 2015 13:44:08 +0000 (13:44 +0000)]
add convenience methods for writing and reading back XSSFWorkbooks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721920 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58775: use assertNotBuiltInFormat
Javen O'Neal [Mon, 28 Dec 2015 12:13:17 +0000 (12:13 +0000)]
bug 58775: use assertNotBuiltInFormat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721902 13f79535-47bb-0310-9956-ffa450edef68

8 years agojava docs
Javen O'Neal [Mon, 28 Dec 2015 12:11:13 +0000 (12:11 +0000)]
java docs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721901 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58775: add unit test to test for non-built-in data formats
Javen O'Neal [Mon, 28 Dec 2015 12:10:12 +0000 (12:10 +0000)]
bug 58775: add unit test to test for non-built-in data formats

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721900 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58775: add Override annotations, Javadocs, and comments
Javen O'Neal [Mon, 28 Dec 2015 07:56:54 +0000 (07:56 +0000)]
bug 58775: add Override annotations, Javadocs, and comments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721880 13f79535-47bb-0310-9956-ffa450edef68

8 years agomake HSSFCellStyle attributes final, add Override decorators on all methods
Javen O'Neal [Mon, 28 Dec 2015 05:43:11 +0000 (05:43 +0000)]
make HSSFCellStyle attributes final, add Override decorators on all methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721876 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58740: add @Internal annotations and decrease access level to methods that only...
Javen O'Neal [Mon, 28 Dec 2015 00:52:47 +0000 (00:52 +0000)]
bug 58740: add @Internal annotations and decrease access level to methods that only exist for unit testing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721864 13f79535-47bb-0310-9956-ffa450edef68

8 years agobug 58740: return unmodifiable list/map when exposing internal data structures
Javen O'Neal [Sun, 27 Dec 2015 23:17:33 +0000 (23:17 +0000)]
bug 58740: return unmodifiable list/map when exposing internal data structures
patch from Archie Cobbs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721857 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix compiling unit-test after previous changes
Dominik Stadler [Tue, 22 Dec 2015 22:48:31 +0000 (22:48 +0000)]
Fix compiling unit-test after previous changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721471 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix some cases where file resources were not closed correctly, mostly when Exceptions...
Dominik Stadler [Tue, 22 Dec 2015 22:36:43 +0000 (22:36 +0000)]
Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68

8 years agofix commandline option in PPTX2PNG from quite to quiet
Dominik Stadler [Tue, 22 Dec 2015 22:36:33 +0000 (22:36 +0000)]
fix commandline option in PPTX2PNG from quite to quiet

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721469 13f79535-47bb-0310-9956-ffa450edef68

8 years agoFix freeing resources in some tests and dev-tools so we can run unit-tests with enabl...
Dominik Stadler [Tue, 22 Dec 2015 22:35:59 +0000 (22:35 +0000)]
Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68

8 years ago#56004 - Support for WMF rendering (parsing the WMF records)
Andreas Beeker [Mon, 21 Dec 2015 01:26:39 +0000 (01:26 +0000)]
#56004 - Support for WMF rendering (parsing the WMF records)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721078 13f79535-47bb-0310-9956-ffa450edef68

8 years agoHandle some cases better where file handles were left open by the ExtractorFactory...
Dominik Stadler [Sun, 20 Dec 2015 20:39:01 +0000 (20:39 +0000)]
Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68

8 years agorat-check - remove clutter to compact build output
Andreas Beeker [Sun, 20 Dec 2015 17:01:46 +0000 (17:01 +0000)]
rat-check - remove clutter to compact build output

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721043 13f79535-47bb-0310-9956-ffa450edef68

8 years agoUnit test for non-reproducable #58747
Nick Burch [Thu, 17 Dec 2015 15:05:06 +0000 (15:05 +0000)]
Unit test for non-reproducable #58747

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720588 13f79535-47bb-0310-9956-ffa450edef68